44421 2010-08-23 07:12:09 -0700 Remove obsolete public/API methods in chromium port 2010-08-23 09:37:47 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 39485 0 satish webkit-unassigned commit-queue fishd jorlow oldest_to_newest 267888 0 satish 2010-08-23 07:12:09 -0700 In https://bugs.webkit.org/show_bug.cgi?id=43922 the speech input API was changed to include additional parameters. Now that chromium has picked up this change we no longer need the old style wrappers which were left in place for a clean transition. 267889 1 65113 satish 2010-08-23 07:16:05 -0700 Created attachment 65113 Patch 267892 2 jorlow 2010-08-23 07:27:19 -0700 Please cc Darin on all WebKit changes. 267893 3 65113 jorlow 2010-08-23 07:27:49 -0700 Comment on attachment 65113 Patch r=me 267957 4 65113 commit-queue 2010-08-23 09:37:43 -0700 Comment on attachment 65113 Patch Clearing flags on attachment: 65113 Committed r65815: <http://trac.webkit.org/changeset/65815> 267958 5 commit-queue 2010-08-23 09:37:47 -0700 All reviewed patches have been landed. Closing bug. 65113 2010-08-23 07:16:05 -0700 2010-08-23 09:37:43 -0700 Patch bug-44421-20100823151603.patch text/plain 4565 satish ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGZiMjU5OWY3ODliZDFkOGRkMTJhZWNjYzYwOGJiN2UyNzI5ODg1ZWUu LjkyZDBkNTYzZjdmY2I4ZTBlMzAxZjM3Y2RjMTE1ZmM5ZjlhZGZlYTYgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDEwLTA4LTIzICBTYXRpc2ggU2FtcGF0aCAgPHNhdGlzaEBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgUmVtb3ZlIG9ic29sZXRlIHB1YmxpYy9BUEkgbWV0aG9kcyBpbiBjaHJvbWl1bSBwb3J0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDQyMQorCisg ICAgICAgICogcHVibGljL1dlYlNwZWVjaElucHV0Q29udHJvbGxlci5oOgorICAgICAgICAoV2Vi S2l0OjpXZWJTcGVlY2hJbnB1dENvbnRyb2xsZXI6OnN0YXJ0UmVjb2duaXRpb24pOgorICAgICAg ICAoV2ViS2l0OjpXZWJTcGVlY2hJbnB1dENvbnRyb2xsZXI6OmNhbmNlbFJlY29nbml0aW9uKToK KyAgICAgICAgKFdlYktpdDo6V2ViU3BlZWNoSW5wdXRDb250cm9sbGVyOjpzdG9wUmVjb3JkaW5n KToKKyAgICAgICAgKiBwdWJsaWMvV2ViU3BlZWNoSW5wdXRMaXN0ZW5lci5oOgorCiAyMDEwLTA4 LTIyICBEYW5pZWwgQmF0ZXMgIDxkYmF0ZXNAcmltLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBFcmljIFNlaWRlbC4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU3Bl ZWNoSW5wdXRDb250cm9sbGVyLmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlNwZWVjaElu cHV0Q29udHJvbGxlci5oCmluZGV4IGI4NWZkZTY3ZmNiZmI3NDU2NTY1NTNmMGFjMjFkYjk5YmRj ZmYyMGMuLjlhZWRiNmY0ZWMwM2UxMTk3MTUzOGJiYTE4MzI3M2NmNThhMmRjNzAgMTAwNjQ0Ci0t LSBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViU3BlZWNoSW5wdXRDb250cm9sbGVyLmgKKysr IGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTcGVlY2hJbnB1dENvbnRyb2xsZXIuaApAQCAt NDMsMjkgKzQzLDIwIEBAIHB1YmxpYzoKICAgICAvLyB0ZXh0IGFyZSByZXR1cm5lZCB2aWEgdGhl IGxpc3RlbmVyIGludGVyZmFjZS4KICAgICB2aXJ0dWFsIGJvb2wgc3RhcnRSZWNvZ25pdGlvbihp bnQpCiAgICAgewotICAgICAgICByZXR1cm4gc3RhcnRSZWNvZ25pdGlvbigpOwotICAgIH0KLSAg ICAvLyBGSVhNRTogUmVtb3ZlIHRoaXMgb25jZSBjaHJvbWl1bSBoYXMgcGlja2VkIHVwIHRoaXMg Y2hhbmdlLgotICAgIHZpcnR1YWwgYm9vbCBzdGFydFJlY29nbml0aW9uKCkKLSAgICB7CiAgICAg ICAgIFdFQktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwog ICAgIH0KIAogICAgIC8vIENhbmNlbHMgYW4gb25nb2luZyByZWNvZ25pdGlvbiBhbmQgZGlzY2Fy ZHMgYW55IGF1ZGlvIHJlY29yZGVkIHNvIGZhci4gTm8gcGFydGlhbAogICAgIC8vIHJlY29nbml0 aW9uIHJlc3VsdHMgYXJlIHJldHVybmVkIHRvIHRoZSBsaXN0ZW5lci4KLSAgICB2aXJ0dWFsIHZv aWQgY2FuY2VsUmVjb2duaXRpb24oaW50KSB7IGNhbmNlbFJlY29nbml0aW9uKCk7IH0KLSAgICAv LyBGSVhNRTogUmVtb3ZlIHRoaXMgb25jZSBjaHJvbWl1bSBoYXMgcGlja2VkIHVwIHRoaXMgY2hh bmdlLgotICAgIHZpcnR1YWwgdm9pZCBjYW5jZWxSZWNvZ25pdGlvbigpIHsgV0VCS0lUX0FTU0VS VF9OT1RfUkVBQ0hFRCgpOyB9CisgICAgdmlydHVhbCB2b2lkIGNhbmNlbFJlY29nbml0aW9uKGlu dCkgeyBXRUJLSVRfQVNTRVJUX05PVF9SRUFDSEVEKCk7IH0KIAogICAgIC8vIFN0b3BzIGF1ZGlv IHJlY29yZGluZyBhbmQgcGVyZm9ybXMgcmVjb2duaXRpb24gd2l0aCB0aGUgYXVkaW8gcmVjb3Jk ZWQgdW50aWwgbm93CiAgICAgLy8gKGRvZXMgbm90IGRpc2NhcmQgYXVkaW8pLiBUaGlzIGlzIGFu IG9wdGlvbmFsIGNhbGwgYW5kIGlzIHR5cGljYWxseSBpbnZva2VkIGlmIHRoZSB1c2VyCiAgICAg Ly8gd2FudHMgdG8gc3RvcCByZWNvcmRpbmcgYXVkaW8gYXMgc29vbiBhcyB0aGV5IGZpbmlzaGVk IHNwZWFraW5nLiBPdGhlcndpc2UsIHRoZSBzcGVlY2gKICAgICAvLyByZWNvcmRpbmcgJ2VuZHBv aW50ZXInIHNob3VsZCBkZXRlY3Qgc2lsZW5jZSBpbiB0aGUgaW5wdXQgYW5kIHN0b3AgcmVjb3Jk aW5nIGF1dG9tYXRpY2FsbHkuCiAgICAgLy8gQ2FsbCBzdGFydFJlY29nbml0aW9uKCkgdG8gcmVj b3JkIGF1ZGlvIGFuZCByZWNvZ25pemUgc3BlZWNoIGFnYWluLgotICAgIHZpcnR1YWwgdm9pZCBz dG9wUmVjb3JkaW5nKGludCkgeyBzdG9wUmVjb3JkaW5nKCk7IH0KLSAgICAvLyBGSVhNRTogUmVt b3ZlIHRoaXMgb25jZSBjaHJvbWl1bSBoYXMgcGlja2VkIHVwIHRoaXMgY2hhbmdlLgotICAgIHZp cnR1YWwgdm9pZCBzdG9wUmVjb3JkaW5nKCkgeyBXRUJLSVRfQVNTRVJUX05PVF9SRUFDSEVEKCk7 IH0KKyAgICB2aXJ0dWFsIHZvaWQgc3RvcFJlY29yZGluZyhpbnQpIHsgV0VCS0lUX0FTU0VSVF9O T1RfUkVBQ0hFRCgpOyB9CiAKIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIH5XZWJTcGVlY2hJbnB1 dENvbnRyb2xsZXIoKSB7IH0KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi U3BlZWNoSW5wdXRMaXN0ZW5lci5oIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTcGVlY2hJ bnB1dExpc3RlbmVyLmgKaW5kZXggZTc3OWMzYTc5ZDMxYWJlMDFkYjAwMDMwMjMwN2RmZTM1OGQx NTgxNS4uNmRjM2Q0OTYzNTQ5NjQ0ZjZiZWEzNjYxNGVhZWNlMjViN2VlNjRhMyAxMDA2NDQKLS0t IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTcGVlY2hJbnB1dExpc3RlbmVyLmgKKysrIGIv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJTcGVlY2hJbnB1dExpc3RlbmVyLmgKQEAgLTQ4LDMz ICs0OCwxOCBAQCBwdWJsaWM6CiAgICAgLy8gVHlwaWNhbGx5IGFmdGVyIHRoaXMgY2FsbCB0aGUg bGlzdGVuZXIgd291bGQgdXBkYXRlIHRoZSBVSSB0byByZWZsZWN0IHRoYXQgcmVjb2duaXRpb24g aXMKICAgICAvLyBpbiBwcm9ncmVzcy4KICAgICB2aXJ0dWFsIHZvaWQgZGlkQ29tcGxldGVSZWNv cmRpbmcoaW50KSA9IDA7Ci0gICAgLy8gRklYTUU6IFJlbW92ZSB0aGlzIG9uY2UgY2hyb21pdW0g aGFzIHBpY2tlZCB1cCB0aGlzIGNoYW5nZS4KLSAgICB2aXJ0dWFsIHZvaWQgZGlkQ29tcGxldGVS ZWNvcmRpbmcoKQotICAgIHsKLSAgICAgICAgZGlkQ29tcGxldGVSZWNvcmRpbmcoMSk7Ci0gICAg fQogCiAgICAgLy8gR2l2ZXMgcmVzdWx0cyBmcm9tIHNwZWVjaCByZWNvZ25pdGlvbiwgZWl0aGVy IHBhcnRpYWwgb3IgdGhlIGZpbmFsIHJlc3VsdHMuCiAgICAgLy8gVGhpcyBtZXRob2QgY2FuIHBv dGVudGlhbGx5IGdldCBjYWxsZWQgbXVsdGlwbGUgdGltZXMgaWYgdGhlcmUgYXJlIHBhcnRpYWwg cmVzdWx0cwogICAgIC8vIGF2YWlsYWJsZSBhcyB0aGUgdXNlciBrZWVwcyBzcGVha2luZy4gSWYg dGhlIHNwZWVjaCBjb3VsZCBub3QgYmUgcmVjb2duaXplZCBwcm9wZXJseQogICAgIC8vIG9yIGlm IHRoZXJlIHdhcyBhbnkgb3RoZXIgZXJyb3JzIGluIHRoZSBwcm9jZXNzLCB0aGlzIG1ldGhvZCBt YXkgbmV2ZXIgYmUgY2FsbGVkLgogICAgIHZpcnR1YWwgdm9pZCBzZXRSZWNvZ25pdGlvblJlc3Vs dChpbnQsIGNvbnN0IFdlYlN0cmluZyYpID0gMDsKLSAgICAvLyBGSVhNRTogUmVtb3ZlIHRoaXMg b25jZSBjaHJvbWl1bSBoYXMgcGlja2VkIHVwIHRoaXMgY2hhbmdlLgotICAgIHZpcnR1YWwgdm9p ZCBzZXRSZWNvZ25pdGlvblJlc3VsdChjb25zdCBXZWJTdHJpbmcmIHJlc3VsdCkKLSAgICB7Ci0g ICAgICAgIHNldFJlY29nbml0aW9uUmVzdWx0KDEsIHJlc3VsdCk7Ci0gICAgfQogCiAgICAgLy8g SW5mb3JtcyB0aGF0IHNwZWVjaCByZWNvZ25pdGlvbiBoYXMgY29tcGxldGVkLiBUaGlzIGdldHMg aW52b2tlZCBpcnJlc3BlY3RpdmUgb2Ygd2hldGhlcgogICAgIC8vIHJlY29nbml0aW9uIHdhcyBz dWNjZXNmdWwgb3Igbm90LCB3aGV0aGVyIHNldFJlY29nbml0aW9uUmVzdWx0KCkgd2FzIGludm9r ZWQgb3Igbm90LiBUaGUKICAgICAvLyBoYW5kbGVyIHR5cGljYWxseSBmcmVlcyB1cCBhbnkgdGVt cG9yYXJ5IHJlc291cmNlcyBhbGxvY2F0ZWQgYW5kIHdhaXRzIGZvciB0aGUgbmV4dCBzcGVlY2gK ICAgICAvLyByZWNvZ25pdGlvbiByZXF1ZXN0LgogICAgIHZpcnR1YWwgdm9pZCBkaWRDb21wbGV0 ZVJlY29nbml0aW9uKGludCkgPSAwOwotICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhpcyBvbmNlIGNo cm9taXVtIGhhcyBwaWNrZWQgdXAgdGhpcyBjaGFuZ2UuCi0gICAgdmlydHVhbCB2b2lkIGRpZENv bXBsZXRlUmVjb2duaXRpb24oKQotICAgIHsKLSAgICAgICAgZGlkQ29tcGxldGVSZWNvZ25pdGlv bigxKTsKLSAgICB9CiAKIHByb3RlY3RlZDoKICAgICB+V2ViU3BlZWNoSW5wdXRMaXN0ZW5lcigp IHsgfQo=