<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>44405</bug_id>
          
          <creation_ts>2010-08-22 22:55:56 -0700</creation_ts>
          <short_desc>[Qt] Proper workaround for missing Gtk initialization in Adobe&apos;s flash plugins...</short_desc>
          <delta_ts>2010-11-29 09:49:51 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Plug-ins</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, QtTriaged</keywords>
          <priority>P1</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dawit A.">adawit</reporter>
          <assigned_to name="QtWebKit Unassigned">webkit-qt-unassigned</assigned_to>
          <cc>ademar</cc>
    
    <cc>girish</cc>
    
    <cc>kling</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>267760</commentid>
    <comment_count>0</comment_count>
      <attachid>65076</attachid>
    <who name="Dawit A.">adawit</who>
    <bug_when>2010-08-22 22:55:56 -0700</bug_when>
    <thetext>Created attachment 65076
Initialize Gtk if the loaded plugin is Adobe&apos;s flash player...

This bug report is intended to supercede bug# 44324 and bug# 40567 as the proper fix for the Gtk initialization problems that is prevelant in some releases of Adobe&apos;s flash player plugins. Specifically, the patch attached ensures that the workaround in applied ONLY to Adobe&apos;s plugin and nothing else.

I tested this change with both Adobe&apos;s proprietary plugin as well as Gnu&apos;s gnash and everything seems to work fine. For those using the nspluginwrapper, the Adobe workaround needs to be implemented inside of the wrapper itself since it is responsible for loading the flash player plugin.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267761</commentid>
    <comment_count>1</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2010-08-22 22:57:28 -0700</bug_when>
    <thetext>Attachment 65076 did not pass style-queue:

Failed to run &quot;[&apos;WebKitTools/Scripts/check-webkit-style&apos;]&quot; exit_code: 1
WebCore/plugins/qt/PluginPackageQt.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267763</commentid>
    <comment_count>2</comment_count>
      <attachid>65076</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-08-22 23:02:25 -0700</bug_when>
    <thetext>Comment on attachment 65076
Initialize Gtk if the loaded plugin is Adobe&apos;s flash player...

&gt;WebCore/ChangeLog:5
&gt; +          Need a short description and bug URL (OOPS!)
ChangeLog needs to be filled out.

&gt;WebCore/plugins/qt/PluginPackageQt.cpp:154
&gt; +      qDebug() &lt;&lt; &quot;**** PATH:&quot; &lt;&lt; m_path;
Please remove this, or if you really think it should stay in, clean up the message and put it within a preprocessor conditional.

r- for those two things.

You say the wrapper needs to be fixed, how do we make sure that happens?
Is there no other workaround possible for that case?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267764</commentid>
    <comment_count>3</comment_count>
      <attachid>65077</attachid>
    <who name="Dawit A.">adawit</who>
    <bug_when>2010-08-22 23:03:29 -0700</bug_when>
    <thetext>Created attachment 65077
Initialize Gtk if the loaded plugin is Adobe&apos;s flash player [Update I]...

Removed debuging statement and corrected changelog entry...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267774</commentid>
    <comment_count>4</comment_count>
    <who name="Dawit A.">adawit</who>
    <bug_when>2010-08-22 23:43:30 -0700</bug_when>
    <thetext>(In reply to comment #2)

&gt; You say the wrapper needs to be fixed, how do we make sure that happens?

Not entirely sure the plugin needs to be fixed. For all I know it might already contain this workaround since this is not the first time this particular bug is seen in the history of adobe&apos;s flash player plugin releases. Unfortunately, someone else would need to test it because it is not supported by my distro (no ready made packages available). And looking at its website, I can see why. For all intense and purposes it seems to be unmaintained No new releases since Jan 02, 2009. 

I personally tell people to uninstall it when they send crash reports to kwebkitpart&apos;s database and sof far almost all of them have reported that doing so have fixed their problems.

&gt; Is there no other workaround possible for that case?

There is... Always initialize gtk (not only gdk) like you guys did before when the plugin being loaded is the nspluginwrapper. It should however be noted that there is no way  to know which flash player is actually going to be used ; so the workaround would be applied regardless.

Personally I think this is not the place to solve the problem for a library the nspluginwrapper loads itself. If the workaround was for the wrapper itself, it would be completely understandable.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267777</commentid>
    <comment_count>5</comment_count>
      <attachid>65077</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-08-23 00:20:14 -0700</bug_when>
    <thetext>Comment on attachment 65077
Initialize Gtk if the loaded plugin is Adobe&apos;s flash player [Update I]...

Can you please verify if this is an issue on maemo5? Also shouldn&apos;t we use a quirk for flash instead?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267783</commentid>
    <comment_count>6</comment_count>
      <attachid>65085</attachid>
    <who name="Dawit A.">adawit</who>
    <bug_when>2010-08-23 00:43:21 -0700</bug_when>
    <thetext>Created attachment 65085
Alternate patch that also attempts to provide the workaround for the nspluginwrapper...

This is an alternate patch to 65077 that provides a blind workaround for nspluginwrapper as well. The nspluginwrapper portion is untested by me and since there is no way to know which flash player the wrapper will load and use, the initialization workaround for the wrapper will load and initialize the gtk toolkit regardless of the need!

NOTE: I am only providing this patch as an alternate based on per prior discussions. I personally believe the proper approach for the wrapper is to implement the workaround there, specially since the wrapper itself is open source...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267786</commentid>
    <comment_count>7</comment_count>
    <who name="Dawit A.">adawit</who>
    <bug_when>2010-08-23 00:51:02 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; (From update of attachment 65077 [details])
&gt; Can you please verify if this is an issue on maemo5? 

Unfortunately, I personally cannot. Very little time to do that, but unless Andreas updated qtwebkit 2.0 with his recent fix, the original version of this patch is what made it into qtwebkit 2.0 and hence Qt 4.7 ; so perhaps someone with maemo5 can test that and report ?

&gt; Also shouldn&apos;t we use a quirk for flash instead?

Don&apos;t follow... What do you mean ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267789</commentid>
    <comment_count>8</comment_count>
    <who name="Girish Ramakrishnan">girish</who>
    <bug_when>2010-08-23 01:08:44 -0700</bug_when>
    <thetext>The suggested patches shouldn&apos;t break Maemo5.

Some comments:
1. Can&apos;t we use gtk_init_check for both the cases and thus combine the code for both cases?
2. We already have a &quot;if (m_path.contains(&quot;npwrapper.&quot;)) {&quot;, can we combine all the hacks in one place?
3. Adam, I think Kenneth is suggesting adding a Quirk enumeration - PluginQuirkInitializeGtk. Maybe a new quirk is not necessary and we can just combine with the existing PluginQuirkRequiresGtkToolKit (I prefer reusing this enum but for some reason it is special cased for Flash 10).

To summarize,
1. in determineQuriks, we add a new quirk or reuse PluginQuirkRequiresGtkToolKit. If we reuse, we move the quirk for all versions of Flash (for Qt only).
2. in load(), we check the above quirk and call gtk_init_check. in addition, if module name contains npwrapper, we override getvalue to staticPluginQuirkRequiresGtkToolKit_NPN_GetValue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>268031</commentid>
    <comment_count>9</comment_count>
    <who name="Dawit A.">adawit</who>
    <bug_when>2010-08-23 11:46:25 -0700</bug_when>
    <thetext>(In reply to comment #8)
&gt; The suggested patches shouldn&apos;t break Maemo5.
&gt; 
&gt; Some comments:
&gt; 1. Can&apos;t we use gtk_init_check for both the cases and thus combine the code for both cases?

Thought Gtk is already loaded and will be reused at this point, why go through all the stuff QLibrary does to load a library again when the symbol we need is already available ? It is there so why not use it ? However, you are right the code for the workaround could definitely be improved.

The main question I have is whether or not the non-optimal Gtk workaround for nspluginwrapper is acceptable to do here in QtWebKit instead of getting the plugin wrapper itself fixed ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>268095</commentid>
    <comment_count>10</comment_count>
      <attachid>65160</attachid>
    <who name="Dawit A.">adawit</who>
    <bug_when>2010-08-23 14:08:58 -0700</bug_when>
    <thetext>Created attachment 65160
Initialize Gtk plugin to prevent some versions of Adobe&apos;s flash player plugin from causing crash...

Combines the two workaround patches into one. Still not sure whether or not the workaround for nspluginwrapper belongs here. However, with this version of the patch it is simply a matter or removing a single line to get rid of the nspluginwrapper workaround if it is not needed...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>268297</commentid>
    <comment_count>11</comment_count>
      <attachid>65160</attachid>
    <who name="Andreas Kling">kling</who>
    <bug_when>2010-08-23 21:55:35 -0700</bug_when>
    <thetext>Comment on attachment 65160
Initialize Gtk plugin to prevent some versions of Adobe&apos;s flash player plugin from causing crash...

This looks quite reasonable to me.

The nspluginwrapper issue will certainly be revisited but we should do our best to avoid crashes in the meantime.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>268299</commentid>
    <comment_count>12</comment_count>
      <attachid>65160</attachid>
    <who name="Ariya Hidayat">ariya.hidayat</who>
    <bug_when>2010-08-23 22:01:45 -0700</bug_when>
    <thetext>Comment on attachment 65160
Initialize Gtk plugin to prevent some versions of Adobe&apos;s flash player plugin from causing crash...

I think we can have this fix, it&apos;s a good compromise. Nice job :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269222</commentid>
    <comment_count>13</comment_count>
    <who name="Girish Ramakrishnan">girish</who>
    <bug_when>2010-08-25 07:03:35 -0700</bug_when>
    <thetext>+1 thanks Adam. I will land it with staticPluginRequiresGtkInit renamed to initializeGtk (as agreed with kling)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>269285</commentid>
    <comment_count>14</comment_count>
    <who name="Girish Ramakrishnan">girish</who>
    <bug_when>2010-08-25 09:34:48 -0700</bug_when>
    <thetext>Landed in 66017</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>314117</commentid>
    <comment_count>15</comment_count>
    <who name="Dawit A.">adawit</who>
    <bug_when>2010-11-26 23:53:29 -0800</bug_when>
    <thetext>This needs to be cherry picked into qtwebkit 2.1 as replacement for the patch that was cherry picked from bug# 44324:

http://gitorious.org/webkit/qtwebkit/commit/a74784a. 

That patch has two issues:

#1.) It does not provide proper support for flash plugin wrappers such as the nspluginwrapper. 

#2.) Its use of a static flag to avoid multiple initializations breaks sites that embed multiple flash content in a single page. If you get improperly rendered flash content in qtwebkit-2.1 this is most likely the culprit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>314472</commentid>
    <comment_count>16</comment_count>
    <who name="Ademar Reis">ademar</who>
    <bug_when>2010-11-29 09:49:27 -0800</bug_when>
    <thetext>Revision r66017 cherry-picked into qtwebkit-2.1 with commit 64a2028 &lt;http://gitorious.org/webkit/qtwebkit/commit/64a2028&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>65076</attachid>
            <date>2010-08-22 22:55:56 -0700</date>
            <delta_ts>2010-08-22 23:03:29 -0700</delta_ts>
            <desc>Initialize Gtk if the loaded plugin is Adobe&apos;s flash player...</desc>
            <filename>adobe_flash_player_workaround.patch</filename>
            <type>text/plain</type>
            <size>3402</size>
            <attacher name="Dawit A.">adawit</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
OWFkNjc0OS4uMWU1MGM5ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wOC0yMiAgRGF3aXQgQWxlbWF5
ZWh1ICA8YWRhd2l0QGtkZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgTmVlZCBhIHNob3J0IGRlc2NyaXB0aW9uIGFuZCBidWcgVVJMIChPT1BT
ISkKKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIHBsdWdpbnMv
cXQvUGx1Z2luUGFja2FnZVF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnBsdWdpbkd0a0luaXRX
b3JrYXJvdW5kKToKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblBhY2thZ2U6OmxvYWQpOgorCiAy
MDEwLTA4LTIyICBBbmRyZWFzIEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+CiAKICAg
ICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYgLS1naXQg
YS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luUGFja2FnZVF0LmNwcCBiL1dlYkNvcmUvcGx1Z2lu
cy9xdC9QbHVnaW5QYWNrYWdlUXQuY3BwCmluZGV4IGI0MjFiMWUuLjBkODI3NDQgMTAwNjQ0Ci0t
LSBhL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5QYWNrYWdlUXQuY3BwCisrKyBiL1dlYkNvcmUv
cGx1Z2lucy9xdC9QbHVnaW5QYWNrYWdlUXQuY3BwCkBAIC0zMyw2ICszMyw4IEBACiAjaW5jbHVk
ZSAiUGx1Z2luRGVidWcuaCIKICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKKyNpbmNs
dWRlIDxRRGVidWc+CisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogYm9vbCBQbHVnaW5QYWNrYWdl
OjpmZXRjaEluZm8oKQpAQCAtOTAsMjYgKzkyLDMyIEBAIHN0YXRpYyBOUEVycm9yIHN0YXRpY1Bs
dWdpblF1aXJrUmVxdWlyZXNHdGtUb29sS2l0X05QTl9HZXRWYWx1ZShOUFAgaW5zdGFuY2UsIE5Q
CiAgICAgcmV0dXJuIE5QTl9HZXRWYWx1ZShpbnN0YW5jZSwgdmFyaWFibGUsIHZhbHVlKTsKIH0K
IAotc3RhdGljIHZvaWQgaW5pdGlhbGl6ZUdka0lmUG9zc2libGUoKQorLyoKKyAgV09SS0FST1VO
RDogVGhpcyB3b3JrYXJvdW5kIGZ1bmN0aW9uIGlzIE9OTFkgaW50ZW5kZWQgdG8gcHJldmVudCBh
IGNyYXNoCisgIGNhdXNlZCBieSBtaXNzaW5nIEd0ayBpbml0aWFsaXphdGlvbiBpbiBzb21lIHZl
cnNpb25zIG9mIEFkb2JlJ3MgZmxhc2ggcGxheWVyCisgIHBsdWdpbi4gU2VlIGh0dHA6Ly93ZWJr
aXQub3JnL2IvNDA1NjcgJiBodHRwOi8vd2Via2l0Lm9yZy9iLzQ0MzI0IGZvciBkZXRhaWxzLgor
Ki8KK3N0YXRpYyB2b2lkIHBsdWdpbkd0a0luaXRXb3JrYXJvdW5kKFFMaWJyYXJ5KiBtb2R1bGUp
CiB7Ci0gICAgc3RhdGljIGJvb2wgYXR0ZW1wdE1hZGUgPSBmYWxzZTsKLQotICAgIGlmIChhdHRl
bXB0TWFkZSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgYXR0ZW1wdE1hZGUgPSB0cnVlOwotCi0g
ICAgUUxpYnJhcnkgbGlicmFyeSgibGliZ2RrLXgxMS0yLjAuc28uMCIpOwotICAgIGlmICghbGli
cmFyeS5sb2FkKCkpCisgICAgLy8gT25seSBmb3IgQWRvYmUncyBmbGFzaCBwbGF5ZXIgYXQgdGhp
cyBwb2ludC4uLgorICAgIGlmICghbW9kdWxlLT5maWxlTmFtZSgpLmNvbnRhaW5zKCJmbGFzaHBs
YXllciIpKQogICAgICAgICByZXR1cm47CiAKLSAgICB0eXBlZGVmIHZvaWQgKigqZ2RrX2luaXRf
Y2hlY2tfcHRyKShpbnQqLCBjaGFyKioqKTsKLSAgICBnZGtfaW5pdF9jaGVja19wdHIgZ2RrX2lu
aXRfY2hlY2sgPSAoZ2RrX2luaXRfY2hlY2tfcHRyKWxpYnJhcnkucmVzb2x2ZSgiZ2RrX2luaXRf
Y2hlY2siKTsKLSAgICBpZiAoIWdka19pbml0X2NoZWNrKQotICAgICAgICByZXR1cm47Ci0KLSAg
ICAvLyBOT1RFOiBXZSdyZSB1c2luZyBnZGtfaW5pdF9jaGVjaygpIHNpbmNlIGdka19pbml0KCkg
bWF5IGV4aXQoKSBvbiBmYWlsdXJlLgotICAgICh2b2lkKSBnZGtfaW5pdF9jaGVjaygwLCAwKTsK
KyAgICB0eXBlZGVmIHZvaWQgKigqZ3RrX2luaXRfcHRyKShpbnQqLCBjaGFyKioqKTsKKyAgICBn
dGtfaW5pdF9wdHIgZ3RrSW5pdCA9IChndGtfaW5pdF9wdHIpbW9kdWxlLT5yZXNvbHZlKCJndGtf
aW5pdCIpOworICAgIGlmIChndGtJbml0KSB7CisgICAgICAgIC8vIFByZXZlbnQgZ3RrX2luaXQo
KSBmcm9tIHJlcGxhY2luZyB0aGUgWCBlcnJvciBoYW5kbGVycywgc2luY2UgdGhlIEd0aworICAg
ICAgICAvLyBoYW5kbGVycyBhYm9ydCB3aGVuIHRoZXkgcmVjZWl2ZSBhbiBYIGVycm9yLCB0aHVz
IGtpbGxpbmcgdGhlIHZpZXdlci4KKyNpZmRlZiBRX1dTX1gxMQorICAgICAgICBpbnQgKCpvbGRf
ZXJyb3JfaGFuZGxlcikoRGlzcGxheSosIFhFcnJvckV2ZW50KikgPSBYU2V0RXJyb3JIYW5kbGVy
KDApOworICAgICAgICBpbnQgKCpvbGRfaW9fZXJyb3JfaGFuZGxlcikoRGlzcGxheSopID0gWFNl
dElPRXJyb3JIYW5kbGVyKDApOworI2VuZGlmCisgICAgICAgIGd0a0luaXQoMCwgMCk7CisjaWZk
ZWYgUV9XU19YMTEKKyAgICAgICAgWFNldEVycm9ySGFuZGxlcihvbGRfZXJyb3JfaGFuZGxlcik7
CisgICAgICAgIFhTZXRJT0Vycm9ySGFuZGxlcihvbGRfaW9fZXJyb3JfaGFuZGxlcik7CisjZW5k
aWYKKyAgICB9CiB9CiAKIGJvb2wgUGx1Z2luUGFja2FnZTo6bG9hZCgpCkBAIC0xNDMsMTQgKzE1
MSwxNSBAQCBib29sIFBsdWdpblBhY2thZ2U6OmxvYWQoKQogCiAgICAgaW5pdGlhbGl6ZUJyb3dz
ZXJGdW5jcygpOwogCisgICAgcURlYnVnKCkgPDwgIioqKiogUEFUSDoiIDw8IG1fcGF0aDsKKwog
ICAgIGlmIChtX3BhdGguY29udGFpbnMoIm5wd3JhcHBlci4iKSkgewogICAgICAgICAvLyBuc3Bs
dWdpbndyYXBwZXIgcmVsaWVzIG9uIHRoZSB0b29sa2l0IHZhbHVlIHRvIGtub3cgaWYgZ2xpYiBp
cyBhdmFpbGFibGUKICAgICAgICAgLy8gSXQgZG9lcyBzbyBpbiBOUF9Jbml0aWFsaXplIHdpdGgg
YSBudWxsIGluc3RhbmNlLCB0aGVyZWZvcmUgaXQgaXMgZG9uZSB0aGlzIHdheToKICAgICAgICAg
bV9icm93c2VyRnVuY3MuZ2V0dmFsdWUgPSBzdGF0aWNQbHVnaW5RdWlya1JlcXVpcmVzR3RrVG9v
bEtpdF9OUE5fR2V0VmFsdWU7CiAgICAgfQogCi0gICAgLy8gVHJ5IHRvIGluaXRpYWxpemUgR0RL
IC0gc29tZSB2ZXJzaW9ucyBvZiB0aGUgRmxhc2ggcGx1Z2luIGRlcGVuZCBvbiB0aGlzLgotICAg
IGluaXRpYWxpemVHZGtJZlBvc3NpYmxlKCk7CisgICAgcGx1Z2luR3RrSW5pdFdvcmthcm91bmQo
bV9tb2R1bGUpOwogCiAjaWYgZGVmaW5lZChYUF9VTklYKQogICAgIG5wRXJyID0gTlBfSW5pdGlh
bGl6ZSgmbV9icm93c2VyRnVuY3MsICZtX3BsdWdpbkZ1bmNzKTsK
</data>
<flag name="review"
          id="53754"
          type_id="1"
          status="-"
          setter="kling"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>65077</attachid>
            <date>2010-08-22 23:03:29 -0700</date>
            <delta_ts>2010-08-23 14:08:58 -0700</delta_ts>
            <desc>Initialize Gtk if the loaded plugin is Adobe&apos;s flash player [Update I]...</desc>
            <filename>adobe_flash_player_workaround.patch</filename>
            <type>text/plain</type>
            <size>2987</size>
            <attacher name="Dawit A.">adawit</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
OWFkNjc0OS4uYjk0YmQ4YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOC0yMiAgRGF3aXQgQWxlbWF5
ZWh1ICA8YWRhd2l0QGtkZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgUHJvcGVyIHdvcmthcm91bmQgZm9yIG1pc3NpbmcgR3RrIGluaXRpYWxp
emF0aW9uIGluIEFkb2JlJ3MgZmxhc2ggcGx1Z2lucy4gICAgICAgIAorICAgICAgICBodHRwLy93
ZWJraXQub3JnL2IvNDQ0MDUKKworICAgICAgICAqIHBsdWdpbnMvcXQvUGx1Z2luUGFja2FnZVF0
LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnBsdWdpbkd0a0luaXRXb3JrYXJvdW5kKToKKyAgICAg
ICAgKFdlYkNvcmU6OlBsdWdpblBhY2thZ2U6OmxvYWQpOgorCiAyMDEwLTA4LTIyICBBbmRyZWFz
IEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg
S2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsdWdpbnMv
cXQvUGx1Z2luUGFja2FnZVF0LmNwcCBiL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5QYWNrYWdl
UXQuY3BwCmluZGV4IGI0MjFiMWUuLmNlZWFlYmMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lu
cy9xdC9QbHVnaW5QYWNrYWdlUXQuY3BwCisrKyBiL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5Q
YWNrYWdlUXQuY3BwCkBAIC05MCwyNiArOTAsMzIgQEAgc3RhdGljIE5QRXJyb3Igc3RhdGljUGx1
Z2luUXVpcmtSZXF1aXJlc0d0a1Rvb2xLaXRfTlBOX0dldFZhbHVlKE5QUCBpbnN0YW5jZSwgTlAK
ICAgICByZXR1cm4gTlBOX0dldFZhbHVlKGluc3RhbmNlLCB2YXJpYWJsZSwgdmFsdWUpOwogfQog
Ci1zdGF0aWMgdm9pZCBpbml0aWFsaXplR2RrSWZQb3NzaWJsZSgpCisvKgorICBXT1JLQVJPVU5E
OiBUaGlzIHdvcmthcm91bmQgZnVuY3Rpb24gaXMgT05MWSBpbnRlbmRlZCB0byBwcmV2ZW50IGEg
Y3Jhc2gKKyAgY2F1c2VkIGJ5IG1pc3NpbmcgR3RrIGluaXRpYWxpemF0aW9uIGluIHNvbWUgdmVy
c2lvbnMgb2YgQWRvYmUncyBmbGFzaCBwbGF5ZXIKKyAgcGx1Z2luLiBTZWUgaHR0cDovL3dlYmtp
dC5vcmcvYi80MDU2NyAmIGh0dHA6Ly93ZWJraXQub3JnL2IvNDQzMjQgZm9yIGRldGFpbHMuCisq
Lworc3RhdGljIHZvaWQgcGx1Z2luR3RrSW5pdFdvcmthcm91bmQoUUxpYnJhcnkqIG1vZHVsZSkK
IHsKLSAgICBzdGF0aWMgYm9vbCBhdHRlbXB0TWFkZSA9IGZhbHNlOwotCi0gICAgaWYgKGF0dGVt
cHRNYWRlKQotICAgICAgICByZXR1cm47Ci0KLSAgICBhdHRlbXB0TWFkZSA9IHRydWU7Ci0KLSAg
ICBRTGlicmFyeSBsaWJyYXJ5KCJsaWJnZGsteDExLTIuMC5zby4wIik7Ci0gICAgaWYgKCFsaWJy
YXJ5LmxvYWQoKSkKKyAgICAvLyBPbmx5IGZvciBBZG9iZSdzIGZsYXNoIHBsYXllciBhdCB0aGlz
IHBvaW50Li4uCisgICAgaWYgKCFtb2R1bGUtPmZpbGVOYW1lKCkuY29udGFpbnMoImZsYXNocGxh
eWVyIikpCiAgICAgICAgIHJldHVybjsKIAotICAgIHR5cGVkZWYgdm9pZCAqKCpnZGtfaW5pdF9j
aGVja19wdHIpKGludCosIGNoYXIqKiopOwotICAgIGdka19pbml0X2NoZWNrX3B0ciBnZGtfaW5p
dF9jaGVjayA9IChnZGtfaW5pdF9jaGVja19wdHIpbGlicmFyeS5yZXNvbHZlKCJnZGtfaW5pdF9j
aGVjayIpOwotICAgIGlmICghZ2RrX2luaXRfY2hlY2spCi0gICAgICAgIHJldHVybjsKLQotICAg
IC8vIE5PVEU6IFdlJ3JlIHVzaW5nIGdka19pbml0X2NoZWNrKCkgc2luY2UgZ2RrX2luaXQoKSBt
YXkgZXhpdCgpIG9uIGZhaWx1cmUuCi0gICAgKHZvaWQpIGdka19pbml0X2NoZWNrKDAsIDApOwor
ICAgIHR5cGVkZWYgdm9pZCAqKCpndGtfaW5pdF9wdHIpKGludCosIGNoYXIqKiopOworICAgIGd0
a19pbml0X3B0ciBndGtJbml0ID0gKGd0a19pbml0X3B0ciltb2R1bGUtPnJlc29sdmUoImd0a19p
bml0Iik7CisgICAgaWYgKGd0a0luaXQpIHsKKyAgICAgICAgLy8gUHJldmVudCBndGtfaW5pdCgp
IGZyb20gcmVwbGFjaW5nIHRoZSBYIGVycm9yIGhhbmRsZXJzLCBzaW5jZSB0aGUgR3RrCisgICAg
ICAgIC8vIGhhbmRsZXJzIGFib3J0IHdoZW4gdGhleSByZWNlaXZlIGFuIFggZXJyb3IsIHRodXMg
a2lsbGluZyB0aGUgdmlld2VyLgorI2lmZGVmIFFfV1NfWDExCisgICAgICAgIGludCAoKm9sZF9l
cnJvcl9oYW5kbGVyKShEaXNwbGF5KiwgWEVycm9yRXZlbnQqKSA9IFhTZXRFcnJvckhhbmRsZXIo
MCk7CisgICAgICAgIGludCAoKm9sZF9pb19lcnJvcl9oYW5kbGVyKShEaXNwbGF5KikgPSBYU2V0
SU9FcnJvckhhbmRsZXIoMCk7CisjZW5kaWYKKyAgICAgICAgZ3RrSW5pdCgwLCAwKTsKKyNpZmRl
ZiBRX1dTX1gxMQorICAgICAgICBYU2V0RXJyb3JIYW5kbGVyKG9sZF9lcnJvcl9oYW5kbGVyKTsK
KyAgICAgICAgWFNldElPRXJyb3JIYW5kbGVyKG9sZF9pb19lcnJvcl9oYW5kbGVyKTsKKyNlbmRp
ZgorICAgIH0KIH0KIAogYm9vbCBQbHVnaW5QYWNrYWdlOjpsb2FkKCkKQEAgLTE0OSw4ICsxNTUs
NyBAQCBib29sIFBsdWdpblBhY2thZ2U6OmxvYWQoKQogICAgICAgICBtX2Jyb3dzZXJGdW5jcy5n
ZXR2YWx1ZSA9IHN0YXRpY1BsdWdpblF1aXJrUmVxdWlyZXNHdGtUb29sS2l0X05QTl9HZXRWYWx1
ZTsKICAgICB9CiAKLSAgICAvLyBUcnkgdG8gaW5pdGlhbGl6ZSBHREsgLSBzb21lIHZlcnNpb25z
IG9mIHRoZSBGbGFzaCBwbHVnaW4gZGVwZW5kIG9uIHRoaXMuCi0gICAgaW5pdGlhbGl6ZUdka0lm
UG9zc2libGUoKTsKKyAgICBwbHVnaW5HdGtJbml0V29ya2Fyb3VuZChtX21vZHVsZSk7CiAKICNp
ZiBkZWZpbmVkKFhQX1VOSVgpCiAgICAgbnBFcnIgPSBOUF9Jbml0aWFsaXplKCZtX2Jyb3dzZXJG
dW5jcywgJm1fcGx1Z2luRnVuY3MpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>65085</attachid>
            <date>2010-08-23 00:43:21 -0700</date>
            <delta_ts>2010-08-23 14:08:58 -0700</delta_ts>
            <desc>Alternate patch that also attempts to provide the workaround for the nspluginwrapper...</desc>
            <filename>adobe_flash_player_and_nspluginwrapper_workaround.patch</filename>
            <type>text/plain</type>
            <size>3653</size>
            <attacher name="Dawit A.">adawit</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
OWFkNjc0OS4uYjk0YmQ4YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOC0yMiAgRGF3aXQgQWxlbWF5
ZWh1ICA8YWRhd2l0QGtkZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgUHJvcGVyIHdvcmthcm91bmQgZm9yIG1pc3NpbmcgR3RrIGluaXRpYWxp
emF0aW9uIGluIEFkb2JlJ3MgZmxhc2ggcGx1Z2lucy4gICAgICAgIAorICAgICAgICBodHRwLy93
ZWJraXQub3JnL2IvNDQ0MDUKKworICAgICAgICAqIHBsdWdpbnMvcXQvUGx1Z2luUGFja2FnZVF0
LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnBsdWdpbkd0a0luaXRXb3JrYXJvdW5kKToKKyAgICAg
ICAgKFdlYkNvcmU6OlBsdWdpblBhY2thZ2U6OmxvYWQpOgorCiAyMDEwLTA4LTIyICBBbmRyZWFz
IEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg
S2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsdWdpbnMv
cXQvUGx1Z2luUGFja2FnZVF0LmNwcCBiL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5QYWNrYWdl
UXQuY3BwCmluZGV4IGI0MjFiMWUuLjAyZmRiNzIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lu
cy9xdC9QbHVnaW5QYWNrYWdlUXQuY3BwCisrKyBiL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5Q
YWNrYWdlUXQuY3BwCkBAIC05MCwyNiArOTAsNDQgQEAgc3RhdGljIE5QRXJyb3Igc3RhdGljUGx1
Z2luUXVpcmtSZXF1aXJlc0d0a1Rvb2xLaXRfTlBOX0dldFZhbHVlKE5QUCBpbnN0YW5jZSwgTlAK
ICAgICByZXR1cm4gTlBOX0dldFZhbHVlKGluc3RhbmNlLCB2YXJpYWJsZSwgdmFsdWUpOwogfQog
Ci1zdGF0aWMgdm9pZCBpbml0aWFsaXplR2RrSWZQb3NzaWJsZSgpCisvKgorICBXT1JLQVJPVU5E
OiBUaGlzIHdvcmthcm91bmQgZnVuY3Rpb24gaXMgT05MWSBpbnRlbmRlZCB0byBwcmV2ZW50IGEg
Y3Jhc2gKKyAgY2F1c2VkIGJ5IG1pc3NpbmcgR3RrIGluaXRpYWxpemF0aW9uIGluIHNvbWUgdmVy
c2lvbnMgb2YgQWRvYmUncyBmbGFzaCBwbGF5ZXIKKyAgcGx1Z2luLiBTZWUgaHR0cDovL3dlYmtp
dC5vcmcvYi80MDU2NyAmIGh0dHA6Ly93ZWJraXQub3JnL2IvNDQzMjQgZm9yIGRldGFpbHMuCisq
Lworc3RhdGljIHZvaWQgcGx1Z2luR3RrSW5pdFdvcmthcm91bmQoUUxpYnJhcnkqIG1vZHVsZSkK
IHsKLSAgICBzdGF0aWMgYm9vbCBhdHRlbXB0TWFkZSA9IGZhbHNlOwotCi0gICAgaWYgKGF0dGVt
cHRNYWRlKQotICAgICAgICByZXR1cm47Ci0KLSAgICBhdHRlbXB0TWFkZSA9IHRydWU7Ci0KLSAg
ICBRTGlicmFyeSBsaWJyYXJ5KCJsaWJnZGsteDExLTIuMC5zby4wIik7Ci0gICAgaWYgKCFsaWJy
YXJ5LmxvYWQoKSkKLSAgICAgICAgcmV0dXJuOwotCi0gICAgdHlwZWRlZiB2b2lkICooKmdka19p
bml0X2NoZWNrX3B0cikoaW50KiwgY2hhcioqKik7Ci0gICAgZ2RrX2luaXRfY2hlY2tfcHRyIGdk
a19pbml0X2NoZWNrID0gKGdka19pbml0X2NoZWNrX3B0cilsaWJyYXJ5LnJlc29sdmUoImdka19p
bml0X2NoZWNrIik7Ci0gICAgaWYgKCFnZGtfaW5pdF9jaGVjaykKLSAgICAgICAgcmV0dXJuOwot
Ci0gICAgLy8gTk9URTogV2UncmUgdXNpbmcgZ2RrX2luaXRfY2hlY2soKSBzaW5jZSBnZGtfaW5p
dCgpIG1heSBleGl0KCkgb24gZmFpbHVyZS4KLSAgICAodm9pZCkgZ2RrX2luaXRfY2hlY2soMCwg
MCk7CisgICAgY29uc3QgUVN0cmluZyBtb2R1bGVOYW1lID0gbW9kdWxlLT5maWxlTmFtZSgpOwor
ICAgIGlmIChtb2R1bGVOYW1lLmNvbnRhaW5zKCJmbGFzaHBsYXllciIpKSB7CisgICAgICAgIHR5
cGVkZWYgdm9pZCAqKCpndGtfaW5pdF9wdHIpKGludCosIGNoYXIqKiopOworICAgICAgICBndGtf
aW5pdF9wdHIgZ3RrSW5pdCA9IChndGtfaW5pdF9wdHIpbW9kdWxlLT5yZXNvbHZlKCJndGtfaW5p
dCIpOworICAgICAgICBpZiAoZ3RrSW5pdCkgeworICAgICAgICAgICAgLy8gUHJldmVudCBndGtf
aW5pdCgpIGZyb20gcmVwbGFjaW5nIHRoZSBYIGVycm9yIGhhbmRsZXJzLCBzaW5jZSB0aGUgR3Rr
CisgICAgICAgICAgICAvLyBoYW5kbGVycyBhYm9ydCB3aGVuIHRoZXkgcmVjZWl2ZSBhbiBYIGVy
cm9yLCB0aHVzIGtpbGxpbmcgdGhlIHZpZXdlci4KKyNpZmRlZiBRX1dTX1gxMQorICAgICAgICAg
ICAgaW50ICgqb2xkX2Vycm9yX2hhbmRsZXIpKERpc3BsYXkqLCBYRXJyb3JFdmVudCopID0gWFNl
dEVycm9ySGFuZGxlcigwKTsKKyAgICAgICAgICAgIGludCAoKm9sZF9pb19lcnJvcl9oYW5kbGVy
KShEaXNwbGF5KikgPSBYU2V0SU9FcnJvckhhbmRsZXIoMCk7CisjZW5kaWYKKyAgICAgICAgICAg
IGd0a0luaXQoMCwgMCk7CisjaWZkZWYgUV9XU19YMTEKKyAgICAgICAgICAgIFhTZXRFcnJvckhh
bmRsZXIob2xkX2Vycm9yX2hhbmRsZXIpOworICAgICAgICAgICAgWFNldElPRXJyb3JIYW5kbGVy
KG9sZF9pb19lcnJvcl9oYW5kbGVyKTsKKyNlbmRpZgorICAgICAgICB9CisgICAgfSBlbHNlIGlm
IChtb2R1bGVOYW1lLmNvbnRhaW5zKCJucHdyYXBwZXIuIikpIHsKKyAgICAgICAgc3RhdGljIGJv
b2wgYXR0ZW1wdE1hZGUgPSBmYWxzZTsKKyAgICAgICAgaWYgKCFhdHRlbXB0TWFkZSkgeworICAg
ICAgICAgICAgYXR0ZW1wdE1hZGUgPSB0cnVlOworICAgICAgICAgICAgUUxpYnJhcnkgbGlicmFy
eSgibGliZ3RrLXgxMS0yLjAuc28uMCIpOworICAgICAgICAgICAgaWYgKGxpYnJhcnkubG9hZCgp
KSB7CisgICAgICAgICAgICAgICAgdHlwZWRlZiB2b2lkICooKmd0a19pbml0X2NoZWNrX3B0ciko
aW50KiwgY2hhcioqKik7CisgICAgICAgICAgICAgICAgZ3RrX2luaXRfY2hlY2tfcHRyIGd0a0lu
aXRDaGVjayA9IChndGtfaW5pdF9jaGVja19wdHIpbGlicmFyeS5yZXNvbHZlKCJndGtfaW5pdF9j
aGVjayIpOworICAgICAgICAgICAgICAgIC8vIE5PVEU6IFdlJ3JlIHVzaW5nIGd0a19pbml0X2No
ZWNrKCkgc2luY2UgZ3RrX2luaXQoKSBtYXkgZXhpdCgpIG9uIGZhaWx1cmUuCisgICAgICAgICAg
ICAgICAgaWYgKGd0a0luaXRDaGVjaykKKyAgICAgICAgICAgICAgICAgICAgKHZvaWQpIGd0a0lu
aXRDaGVjaygwLCAwKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorICAgIH0KIH0KIAogYm9v
bCBQbHVnaW5QYWNrYWdlOjpsb2FkKCkKQEAgLTE0OSw4ICsxNjcsNyBAQCBib29sIFBsdWdpblBh
Y2thZ2U6OmxvYWQoKQogICAgICAgICBtX2Jyb3dzZXJGdW5jcy5nZXR2YWx1ZSA9IHN0YXRpY1Bs
dWdpblF1aXJrUmVxdWlyZXNHdGtUb29sS2l0X05QTl9HZXRWYWx1ZTsKICAgICB9CiAKLSAgICAv
LyBUcnkgdG8gaW5pdGlhbGl6ZSBHREsgLSBzb21lIHZlcnNpb25zIG9mIHRoZSBGbGFzaCBwbHVn
aW4gZGVwZW5kIG9uIHRoaXMuCi0gICAgaW5pdGlhbGl6ZUdka0lmUG9zc2libGUoKTsKKyAgICBw
bHVnaW5HdGtJbml0V29ya2Fyb3VuZChtX21vZHVsZSk7CiAKICNpZiBkZWZpbmVkKFhQX1VOSVgp
CiAgICAgbnBFcnIgPSBOUF9Jbml0aWFsaXplKCZtX2Jyb3dzZXJGdW5jcywgJm1fcGx1Z2luRnVu
Y3MpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>65160</attachid>
            <date>2010-08-23 14:08:58 -0700</date>
            <delta_ts>2010-08-23 22:01:45 -0700</delta_ts>
            <desc>Initialize Gtk plugin to prevent some versions of Adobe&apos;s flash player plugin from causing crash...</desc>
            <filename>adobe_flash_player_and_nspluginwrapper_workaround.patch</filename>
            <type>text/plain</type>
            <size>3813</size>
            <attacher name="Dawit A.">adawit</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
ZTNlYzM5ZC4uM2Y2NDY1YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOC0yMiAgRGF3aXQgQWxlbWF5
ZWh1ICA8YWRhd2l0QGtkZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT
ISkuCisKKyAgICAgICAgUHJvcGVyIHdvcmthcm91bmQgZm9yIG1pc3NpbmcgR3RrIGluaXRpYWxp
emF0aW9uIGluIEFkb2JlJ3MgZmxhc2ggcGx1Z2lucy4KKyAgICAgICAgaHR0cC8vd2Via2l0Lm9y
Zy9iLzQ0NDA1CisKKyAgICAgICAgKiBwbHVnaW5zL3F0L1BsdWdpblBhY2thZ2VRdC5jcHA6Cisg
ICAgICAgIChXZWJDb3JlOjpwbHVnaW5HdGtJbml0V29ya2Fyb3VuZCk6CisgICAgICAgIChXZWJD
b3JlOjpQbHVnaW5QYWNrYWdlOjpsb2FkKToKKwogMjAxMC0wOC0yMyAgQXJpeWEgSGlkYXlhdCAg
PGFyaXlhQHNlbmNoYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBD
aHJpc3RpYW5zZW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luUGFja2Fn
ZVF0LmNwcCBiL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5QYWNrYWdlUXQuY3BwCmluZGV4IGI0
MjFiMWUuLjVkZTkxZDkgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5QYWNr
YWdlUXQuY3BwCisrKyBiL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5QYWNrYWdlUXQuY3BwCkBA
IC05MCwyNiArOTAsMzcgQEAgc3RhdGljIE5QRXJyb3Igc3RhdGljUGx1Z2luUXVpcmtSZXF1aXJl
c0d0a1Rvb2xLaXRfTlBOX0dldFZhbHVlKE5QUCBpbnN0YW5jZSwgTlAKICAgICByZXR1cm4gTlBO
X0dldFZhbHVlKGluc3RhbmNlLCB2YXJpYWJsZSwgdmFsdWUpOwogfQogCi1zdGF0aWMgdm9pZCBp
bml0aWFsaXplR2RrSWZQb3NzaWJsZSgpCitzdGF0aWMgdm9pZCBzdGF0aWNQbHVnaW5SZXF1aXJl
c0d0a0luaXQoUUxpYnJhcnkqIG1vZHVsZSA9IDApCiB7Ci0gICAgc3RhdGljIGJvb2wgYXR0ZW1w
dE1hZGUgPSBmYWxzZTsKLQotICAgIGlmIChhdHRlbXB0TWFkZSkKLSAgICAgICAgcmV0dXJuOwot
Ci0gICAgYXR0ZW1wdE1hZGUgPSB0cnVlOwotCi0gICAgUUxpYnJhcnkgbGlicmFyeSgibGliZ2Rr
LXgxMS0yLjAuc28uMCIpOwotICAgIGlmICghbGlicmFyeS5sb2FkKCkpCi0gICAgICAgIHJldHVy
bjsKLQotICAgIHR5cGVkZWYgdm9pZCAqKCpnZGtfaW5pdF9jaGVja19wdHIpKGludCosIGNoYXIq
KiopOwotICAgIGdka19pbml0X2NoZWNrX3B0ciBnZGtfaW5pdF9jaGVjayA9IChnZGtfaW5pdF9j
aGVja19wdHIpbGlicmFyeS5yZXNvbHZlKCJnZGtfaW5pdF9jaGVjayIpOwotICAgIGlmICghZ2Rr
X2luaXRfY2hlY2spCi0gICAgICAgIHJldHVybjsKKyAgICAvLyBFbnN1cmVzIG1pc3NpbmcgR3Rr
IGluaXRpYWxpemF0aW9uIGluIHNvbWUgdmVyc2lvbnMgb2YgQWRvYmUncyBmbGFzaCBwbGF5ZXIK
KyAgICAvLyBwbHVnaW4gZG8gbm90IGNhdXNlIGNyYXNoZXMuIFNlZSBCUiMgNDA1NjcsIDQ0MzI0
LCBhbmQgNDQ0MDUgZm9yIGRldGFpbHMuICAKKyAgICBpZiAobW9kdWxlKSB7CisgICAgICAgIHR5
cGVkZWYgdm9pZCAqKCpndGtfaW5pdF9wdHIpKGludCosIGNoYXIqKiopOworICAgICAgICBndGtf
aW5pdF9wdHIgZ3RrSW5pdCA9IChndGtfaW5pdF9wdHIpbW9kdWxlLT5yZXNvbHZlKCJndGtfaW5p
dCIpOworICAgICAgICBpZiAoZ3RrSW5pdCkgeworICAgICAgICAgICAgLy8gUHJldmVudCBndGtf
aW5pdCgpIGZyb20gcmVwbGFjaW5nIHRoZSBYIGVycm9yIGhhbmRsZXJzLCBzaW5jZSB0aGUgR3Rr
CisgICAgICAgICAgICAvLyBoYW5kbGVycyBhYm9ydCB3aGVuIHRoZXkgcmVjZWl2ZSBhbiBYIGVy
cm9yLCB0aHVzIGtpbGxpbmcgdGhlIHZpZXdlci4KKyNpZmRlZiBRX1dTX1gxMQorICAgICAgICAg
ICAgaW50ICgqb2xkX2Vycm9yX2hhbmRsZXIpKERpc3BsYXkqLCBYRXJyb3JFdmVudCopID0gWFNl
dEVycm9ySGFuZGxlcigwKTsKKyAgICAgICAgICAgIGludCAoKm9sZF9pb19lcnJvcl9oYW5kbGVy
KShEaXNwbGF5KikgPSBYU2V0SU9FcnJvckhhbmRsZXIoMCk7CisjZW5kaWYKKyAgICAgICAgICAg
IGd0a0luaXQoMCwgMCk7CisjaWZkZWYgUV9XU19YMTEKKyAgICAgICAgICAgIFhTZXRFcnJvckhh
bmRsZXIob2xkX2Vycm9yX2hhbmRsZXIpOworICAgICAgICAgICAgWFNldElPRXJyb3JIYW5kbGVy
KG9sZF9pb19lcnJvcl9oYW5kbGVyKTsKKyNlbmRpZgorICAgICAgICAgICAgcmV0dXJuOworICAg
ICAgICB9CisgICAgfQogCi0gICAgLy8gTk9URTogV2UncmUgdXNpbmcgZ2RrX2luaXRfY2hlY2so
KSBzaW5jZSBnZGtfaW5pdCgpIG1heSBleGl0KCkgb24gZmFpbHVyZS4KLSAgICAodm9pZCkgZ2Rr
X2luaXRfY2hlY2soMCwgMCk7CisgICAgUUxpYnJhcnkgbGlicmFyeSgibGliZ3RrLXgxMS0yLjAu
c28uMCIpOworICAgIGlmIChsaWJyYXJ5LmxvYWQoKSkgeworICAgICAgICB0eXBlZGVmIHZvaWQg
KigqZ3RrX2luaXRfY2hlY2tfcHRyKShpbnQqLCBjaGFyKioqKTsKKyAgICAgICAgZ3RrX2luaXRf
Y2hlY2tfcHRyIGd0a0luaXRDaGVjayA9IChndGtfaW5pdF9jaGVja19wdHIpbGlicmFyeS5yZXNv
bHZlKCJndGtfaW5pdF9jaGVjayIpOworICAgICAgICAvLyBOT1RFOiBXZSdyZSB1c2luZyBndGtf
aW5pdF9jaGVjaygpIHNpbmNlIGd0a19pbml0KCkgY2FsbHMgZXhpdCgpIG9uIGZhaWx1cmUuCisg
ICAgICAgIGlmIChndGtJbml0Q2hlY2spCisgICAgICAgICAgICAodm9pZCkgZ3RrSW5pdENoZWNr
KDAsIDApOworICAgIH0KIH0KIAogYm9vbCBQbHVnaW5QYWNrYWdlOjpsb2FkKCkKQEAgLTE0Nywx
MSArMTU4LDE1IEBAIGJvb2wgUGx1Z2luUGFja2FnZTo6bG9hZCgpCiAgICAgICAgIC8vIG5zcGx1
Z2lud3JhcHBlciByZWxpZXMgb24gdGhlIHRvb2xraXQgdmFsdWUgdG8ga25vdyBpZiBnbGliIGlz
IGF2YWlsYWJsZQogICAgICAgICAvLyBJdCBkb2VzIHNvIGluIE5QX0luaXRpYWxpemUgd2l0aCBh
IG51bGwgaW5zdGFuY2UsIHRoZXJlZm9yZSBpdCBpcyBkb25lIHRoaXMgd2F5OgogICAgICAgICBt
X2Jyb3dzZXJGdW5jcy5nZXR2YWx1ZSA9IHN0YXRpY1BsdWdpblF1aXJrUmVxdWlyZXNHdGtUb29s
S2l0X05QTl9HZXRWYWx1ZTsKKyAgICAgICAgLy8gV29ya2Fyb3VuZCBBZG9iZSdzIGZhaWx1cmUg
dG8gcHJvcGVybHkgaW5pdGlhbGl6ZSBHdGsgaW4gc29tZSB2ZXJzaW9ucworICAgICAgICAvLyBv
ZiB0aGVpciBmbGFzaCBwbGF5ZXIgcGx1Z2luLgorICAgICAgICBzdGF0aWNQbHVnaW5SZXF1aXJl
c0d0a0luaXQoKTsKKyAgICB9IGVsc2UgaWYgKG1fcGF0aC5jb250YWlucygiZmxhc2hwbGF5ZXIi
KSkgeworICAgICAgICAvLyBXb3JrYXJvdW5kIEFkb2JlJ3MgZmFpbHVyZSB0byBwcm9wZXJseSBp
bml0aWFsaXplIEd0ayBpbiBzb21lIHZlcnNpb25zCisgICAgICAgIC8vIG9mIHRoZWlyIGZsYXNo
IHBsYXllciBwbHVnaW4uCisgICAgICAgIHN0YXRpY1BsdWdpblJlcXVpcmVzR3RrSW5pdChtX21v
ZHVsZSk7CiAgICAgfQogCi0gICAgLy8gVHJ5IHRvIGluaXRpYWxpemUgR0RLIC0gc29tZSB2ZXJz
aW9ucyBvZiB0aGUgRmxhc2ggcGx1Z2luIGRlcGVuZCBvbiB0aGlzLgotICAgIGluaXRpYWxpemVH
ZGtJZlBvc3NpYmxlKCk7Ci0KICNpZiBkZWZpbmVkKFhQX1VOSVgpCiAgICAgbnBFcnIgPSBOUF9J
bml0aWFsaXplKCZtX2Jyb3dzZXJGdW5jcywgJm1fcGx1Z2luRnVuY3MpOwogI2Vsc2UK
</data>
<flag name="review"
          id="53852"
          type_id="1"
          status="+"
          setter="ariya.hidayat"
    />
          </attachment>
      

    </bug>

</bugzilla>