44392 2010-08-21 22:09:08 -0700 [Qt] Gradient: Support inner radius larger than outer radius 2010-08-22 01:39:32 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED HTML5, Qt, QtTriaged P2 Normal --- 1 kling webkit-qt-unassigned oldest_to_newest 267642 0 kling 2010-08-21 22:09:08 -0700 We should reverse the gradient if the inner radius is larger than the outer one. This is relevant both for CSS and the CanvasGradient API. Example pages with apparent missing support: - http://www.kaleidoscopeapp.com/ - http://graphicpeel.com/cssiosicons Fixing this will also cause us to pass the following tests: - canvas/philip/tests/2d.gradient.radial.outside2.html - canvas/philip/tests/2d.gradient.radial.outside3.html 267643 1 65047 kling 2010-08-21 22:14:57 -0700 Created attachment 65047 Proposed patch 267652 2 65049 kling 2010-08-22 00:07:58 -0700 Created attachment 65049 Proposed patch v2 Updated patch addressing comments from Ariya on IRC. 267655 3 65049 ariya.hidayat 2010-08-22 00:15:10 -0700 Comment on attachment 65049 Proposed patch v2 LGTM.re=me. Minor issue: WebCore/platform/graphics/qt/GradientQt.cpp:76 + if (m_radial && !qFuzzyCompare(outerRadius, qreal(0))) { Should be qFuzzyCompare(1 + outerRadius, qreal(1)). 267662 4 kling 2010-08-22 01:39:32 -0700 Committed r65783: <http://trac.webkit.org/changeset/65783> 65047 2010-08-21 22:14:57 -0700 2010-08-22 00:07:58 -0700 Proposed patch bug-44392.diff text/plain 3683 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2ZjBlMTQ2Li44YzEzOTQ1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDgt MjEgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEdyYWRpZW50OiBTdXBw b3J0IGlubmVyIHJhZGl1cyBsYXJnZXIgdGhhbiBvdXRlciByYWRpdXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0MzkyCisKKyAgICAgICAgVW5za2lw IHR3byB0ZXN0cyB0aGF0IG5vdyBwYXNzOgorICAgICAgICAtIGNhbnZhcy9waGlsaXAvdGVzdHMv MmQuZ3JhZGllbnQucmFkaWFsLm91dHNpZGUyLmh0bWwKKyAgICAgICAgLSBjYW52YXMvcGhpbGlw L3Rlc3RzLzJkLmdyYWRpZW50LnJhZGlhbC5vdXRzaWRlMy5odG1sCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDEwLTA4LTIxICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxz b25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vcXQvU2tpcHBlZAppbmRleCA5YzlhNjUyLi5lZTIwNTI3IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0 L1NraXBwZWQKQEAgLTUyMzAsOCArNTIzMCw2IEBAIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZ3Jh ZGllbnQucmFkaWFsLmNvbmUuY3lsaW5kZXIuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5n cmFkaWVudC5yYWRpYWwuY29uZS5zaGFwZTIuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5n cmFkaWVudC5yYWRpYWwuY29uZS50b3AuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5ncmFk aWVudC5yYWRpYWwubmVnYXRpdmUuaHRtbAotY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5ncmFkaWVu dC5yYWRpYWwub3V0c2lkZTIuaHRtbAotY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5ncmFkaWVudC5y YWRpYWwub3V0c2lkZTMuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5ncmFkaWVudC5yYWRp YWwudG91Y2gxLmh0bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQucmFkaWFsLnRv dWNoMi5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmdyYWRpZW50LnJhZGlhbC50b3VjaDMu aHRtbApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCBlMjhhZDg3Li4wNzgzYWMxIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA4LTIxICBBbmRyZWFz IEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBHcmFkaWVudDogU3VwcG9ydCBpbm5lciBy YWRpdXMgbGFyZ2VyIHRoYW4gb3V0ZXIgcmFkaXVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDM5MgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvcXQvR3JhZGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFkaWVudDo6cGxhdGZv cm1HcmFkaWVudCk6IFJldmVyc2UgdGhlIChyYWRpYWwpIGdyYWRpZW50IGlmIHIwID4gcjEuCisK IDIwMTAtMDgtMjEgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvcXQvR3JhZGllbnRRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3F0L0dyYWRpZW50UXQuY3BwCmluZGV4IDFmMDVhMTUuLjg4YTExYWUgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhZGllbnRRdC5jcHAKKysrIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFkaWVudFF0LmNwcApAQCAtNDYsOCArNDYsMTMgQEAg UUdyYWRpZW50KiBHcmFkaWVudDo6cGxhdGZvcm1HcmFkaWVudCgpCiAgICAgaWYgKG1fZ3JhZGll bnQpCiAgICAgICAgIHJldHVybiBtX2dyYWRpZW50OwogCisgICAgYm9vbCByZXZlcnNlZCA9IG1f cjAgPiBtX3IxOworCisgICAgcXJlYWwgaW5uZXJSYWRpdXMgPSByZXZlcnNlZCA/IG1fcjEgOiBt X3IwOworICAgIHFyZWFsIG91dGVyUmFkaXVzID0gcmV2ZXJzZWQgPyBtX3IwIDogbV9yMTsKKwog ICAgIGlmIChtX3JhZGlhbCkKLSAgICAgICAgbV9ncmFkaWVudCA9IG5ldyBRUmFkaWFsR3JhZGll bnQobV9wMS54KCksIG1fcDEueSgpLCBtX3IxLCBtX3AwLngoKSwgbV9wMC55KCkpOworICAgICAg ICBtX2dyYWRpZW50ID0gbmV3IFFSYWRpYWxHcmFkaWVudChyZXZlcnNlZCA/IG1fcDAgOiBtX3Ax LCBvdXRlclJhZGl1cywgcmV2ZXJzZWQgPyBtX3AxIDogbV9wMCk7CiAgICAgZWxzZQogICAgICAg ICBtX2dyYWRpZW50ID0gbmV3IFFMaW5lYXJHcmFkaWVudChtX3AwLngoKSwgbV9wMC55KCksIG1f cDEueCgpLCBtX3AxLnkoKSk7CiAKQEAgLTY1LDkgKzcwLDE5IEBAIFFHcmFkaWVudCogR3JhZGll bnQ6OnBsYXRmb3JtR3JhZGllbnQoKQogICAgICAgICAgICAgbGFzdFN0b3AgPSBzdG9wSXRlcmF0 b3ItPnN0b3AgKyBsYXN0U3RvcERpZmY7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIGxhc3RT dG9wID0gc3RvcEl0ZXJhdG9yLT5zdG9wOwotICAgICAgICBpZiAobV9yYWRpYWwgJiYgbV9yMCkK LSAgICAgICAgICAgIGxhc3RTdG9wID0gbV9yMCAvIG1fcjEgKyBsYXN0U3RvcCAqICgxLjBmIC0g bV9yMCAvIG1fcjEpOwotICAgICAgICBtX2dyYWRpZW50LT5zZXRDb2xvckF0KHFNaW4obGFzdFN0 b3AsIHFyZWFsKDEuMGYpKSwgc3RvcENvbG9yKTsKKworICAgICAgICBpZiAobV9yYWRpYWwgJiYg b3V0ZXJSYWRpdXMpIHsKKyAgICAgICAgICAgIGxhc3RTdG9wID0gbGFzdFN0b3AgKiAoMS4wZiAt IGlubmVyUmFkaXVzIC8gb3V0ZXJSYWRpdXMpOworICAgICAgICAgICAgaWYgKCFyZXZlcnNlZCkK KyAgICAgICAgICAgICAgICBsYXN0U3RvcCArPSBpbm5lclJhZGl1cyAvIG91dGVyUmFkaXVzOwor ICAgICAgICB9CisKKyAgICAgICAgcXJlYWwgc3RvcFBvc2l0aW9uID0gcU1pbihsYXN0U3RvcCwg cXJlYWwoMS4wZikpOworCisgICAgICAgIGlmIChtX3JhZGlhbCAmJiByZXZlcnNlZCkKKyAgICAg ICAgICAgIHN0b3BQb3NpdGlvbiA9IHFyZWFsKDEuMGYpIC0gc3RvcFBvc2l0aW9uOworCisgICAg ICAgIG1fZ3JhZGllbnQtPnNldENvbG9yQXQoc3RvcFBvc2l0aW9uLCBzdG9wQ29sb3IpOwogICAg ICAgICAvLyBLZWVwIHRoZSBsYXN0U3RvcCBhcyBvcmdpbmFsIHZhbHVlLCBzaW5jZSB0aGUgZm9s bG93aW5nIHN0b3BDb2xvciBkZXBlbmQgaXQKICAgICAgICAgbGFzdFN0b3AgPSBzdG9wSXRlcmF0 b3ItPnN0b3A7CiAgICAgICAgICsrc3RvcEl0ZXJhdG9yOwo= 65049 2010-08-22 00:07:58 -0700 2010-08-22 00:15:10 -0700 Proposed patch v2 bug-44392-v2.diff text/plain 3767 kling ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2ZjBlMTQ2Li44YzEzOTQ1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDgt MjEgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEdyYWRpZW50OiBTdXBw b3J0IGlubmVyIHJhZGl1cyBsYXJnZXIgdGhhbiBvdXRlciByYWRpdXMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0MzkyCisKKyAgICAgICAgVW5za2lw IHR3byB0ZXN0cyB0aGF0IG5vdyBwYXNzOgorICAgICAgICAtIGNhbnZhcy9waGlsaXAvdGVzdHMv MmQuZ3JhZGllbnQucmFkaWFsLm91dHNpZGUyLmh0bWwKKyAgICAgICAgLSBjYW52YXMvcGhpbGlw L3Rlc3RzLzJkLmdyYWRpZW50LnJhZGlhbC5vdXRzaWRlMy5odG1sCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDEwLTA4LTIxICBFcmljIENhcmxzb24gIDxlcmljLmNhcmxz b25AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxh dGZvcm0vcXQvU2tpcHBlZAppbmRleCA5YzlhNjUyLi5lZTIwNTI3IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0 L1NraXBwZWQKQEAgLTUyMzAsOCArNTIzMCw2IEBAIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZ3Jh ZGllbnQucmFkaWFsLmNvbmUuY3lsaW5kZXIuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5n cmFkaWVudC5yYWRpYWwuY29uZS5zaGFwZTIuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5n cmFkaWVudC5yYWRpYWwuY29uZS50b3AuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5ncmFk aWVudC5yYWRpYWwubmVnYXRpdmUuaHRtbAotY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5ncmFkaWVu dC5yYWRpYWwub3V0c2lkZTIuaHRtbAotY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5ncmFkaWVudC5y YWRpYWwub3V0c2lkZTMuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5ncmFkaWVudC5yYWRp YWwudG91Y2gxLmh0bWwKIGNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQucmFkaWFsLnRv dWNoMi5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmdyYWRpZW50LnJhZGlhbC50b3VjaDMu aHRtbApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwpp bmRleCBlMjhhZDg3Li4wOTIzOWZlIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA4LTIyICBBbmRyZWFz IEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBHcmFkaWVudDogU3VwcG9ydCBpbm5lciBy YWRpdXMgbGFyZ2VyIHRoYW4gb3V0ZXIgcmFkaXVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDM5MgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvcXQvR3JhZGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpHcmFkaWVudDo6cGxhdGZv cm1HcmFkaWVudCk6IFJldmVyc2UgdGhlIChyYWRpYWwpIGdyYWRpZW50IGlmIHIwID4gcjEuCisK IDIwMTAtMDgtMjEgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvcXQvR3JhZGllbnRRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL3F0L0dyYWRpZW50UXQuY3BwCmluZGV4IDFmMDVhMTUuLjQ2NGQxYTcgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhZGllbnRRdC5jcHAKKysrIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFkaWVudFF0LmNwcApAQCAtNDYsOCArNDYsMTUgQEAg UUdyYWRpZW50KiBHcmFkaWVudDo6cGxhdGZvcm1HcmFkaWVudCgpCiAgICAgaWYgKG1fZ3JhZGll bnQpCiAgICAgICAgIHJldHVybiBtX2dyYWRpZW50OwogCisgICAgYm9vbCByZXZlcnNlZCA9IG1f cjAgPiBtX3IxOworCisgICAgcXJlYWwgaW5uZXJSYWRpdXMgPSByZXZlcnNlZCA/IG1fcjEgOiBt X3IwOworICAgIHFyZWFsIG91dGVyUmFkaXVzID0gcmV2ZXJzZWQgPyBtX3IwIDogbV9yMTsKKyAg ICBRUG9pbnRGIGNlbnRlciA9IHJldmVyc2VkID8gbV9wMCA6IG1fcDE7CisgICAgUVBvaW50RiBm b2NhbFBvaW50ID0gcmV2ZXJzZWQgPyBtX3AxIDogbV9wMDsKKwogICAgIGlmIChtX3JhZGlhbCkK LSAgICAgICAgbV9ncmFkaWVudCA9IG5ldyBRUmFkaWFsR3JhZGllbnQobV9wMS54KCksIG1fcDEu eSgpLCBtX3IxLCBtX3AwLngoKSwgbV9wMC55KCkpOworICAgICAgICBtX2dyYWRpZW50ID0gbmV3 IFFSYWRpYWxHcmFkaWVudChjZW50ZXIsIG91dGVyUmFkaXVzLCBmb2NhbFBvaW50KTsKICAgICBl bHNlCiAgICAgICAgIG1fZ3JhZGllbnQgPSBuZXcgUUxpbmVhckdyYWRpZW50KG1fcDAueCgpLCBt X3AwLnkoKSwgbV9wMS54KCksIG1fcDEueSgpKTsKIApAQCAtNjUsOSArNzIsMTkgQEAgUUdyYWRp ZW50KiBHcmFkaWVudDo6cGxhdGZvcm1HcmFkaWVudCgpCiAgICAgICAgICAgICBsYXN0U3RvcCA9 IHN0b3BJdGVyYXRvci0+c3RvcCArIGxhc3RTdG9wRGlmZjsKICAgICAgICAgZWxzZQogICAgICAg ICAgICAgbGFzdFN0b3AgPSBzdG9wSXRlcmF0b3ItPnN0b3A7Ci0gICAgICAgIGlmIChtX3JhZGlh bCAmJiBtX3IwKQotICAgICAgICAgICAgbGFzdFN0b3AgPSBtX3IwIC8gbV9yMSArIGxhc3RTdG9w ICogKDEuMGYgLSBtX3IwIC8gbV9yMSk7Ci0gICAgICAgIG1fZ3JhZGllbnQtPnNldENvbG9yQXQo cU1pbihsYXN0U3RvcCwgcXJlYWwoMS4wZikpLCBzdG9wQ29sb3IpOworCisgICAgICAgIGlmICht X3JhZGlhbCAmJiAhcUZ1enp5Q29tcGFyZShvdXRlclJhZGl1cywgcXJlYWwoMCkpKSB7CisgICAg ICAgICAgICBsYXN0U3RvcCA9IGxhc3RTdG9wICogKDEuMGYgLSBpbm5lclJhZGl1cyAvIG91dGVy UmFkaXVzKTsKKyAgICAgICAgICAgIGlmICghcmV2ZXJzZWQpCisgICAgICAgICAgICAgICAgbGFz dFN0b3AgKz0gaW5uZXJSYWRpdXMgLyBvdXRlclJhZGl1czsKKyAgICAgICAgfQorCisgICAgICAg IHFyZWFsIHN0b3BQb3NpdGlvbiA9IHFNaW4obGFzdFN0b3AsIHFyZWFsKDEuMGYpKTsKKworICAg ICAgICBpZiAobV9yYWRpYWwgJiYgcmV2ZXJzZWQpCisgICAgICAgICAgICBzdG9wUG9zaXRpb24g PSAxIC0gc3RvcFBvc2l0aW9uOworCisgICAgICAgIG1fZ3JhZGllbnQtPnNldENvbG9yQXQoc3Rv cFBvc2l0aW9uLCBzdG9wQ29sb3IpOwogICAgICAgICAvLyBLZWVwIHRoZSBsYXN0U3RvcCBhcyBv cmdpbmFsIHZhbHVlLCBzaW5jZSB0aGUgZm9sbG93aW5nIHN0b3BDb2xvciBkZXBlbmQgaXQKICAg ICAgICAgbGFzdFN0b3AgPSBzdG9wSXRlcmF0b3ItPnN0b3A7CiAgICAgICAgICsrc3RvcEl0ZXJh dG9yOwo=