44388 2010-08-21 18:47:34 -0700 [GTK] The Mozilla theme drawing code incorrectly renders scrollbar backgrounds 2010-08-23 19:13:28 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 mrobinson webkit-unassigned abarth eric webkit.review.bot oldest_to_newest 267622 0 mrobinson 2010-08-21 18:47:34 -0700 Instead of painting a scrolled window behind scrollbars, the theme drawing code simply paints the theme background color behind scrollbar troughs. This bug tracks both disabling that behavior and exposing a function to paint a scrolled window. This is necessary to correctly render certain GTK+ themes. 267624 1 65041 mrobinson 2010-08-21 18:52:34 -0700 Created attachment 65041 Patch for this issue 268241 2 65041 mrobinson 2010-08-23 18:25:45 -0700 Comment on attachment 65041 Patch for this issue Clearing flags on attachment: 65041 Committed r65851: <http://trac.webkit.org/changeset/65851> 268242 3 mrobinson 2010-08-23 18:25:49 -0700 All reviewed patches have been landed. Closing bug. 268270 4 webkit.review.bot 2010-08-23 19:13:28 -0700 http://trac.webkit.org/changeset/65851 might have broken Chromium Mac Release The following changes are on the blame list: http://trac.webkit.org/changeset/65851 http://trac.webkit.org/changeset/65852 65041 2010-08-21 18:52:34 -0700 2010-08-23 18:25:45 -0700 Patch for this issue bug-44388-20100821185232.patch text/plain 4454 mrobinson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjQ3NDM1NzhmODU1OGMwYjk1ZTM0Nzc0N2RlNTUwNzVjOGZjYTRmZS4uNzc3MmFlOTdkMWY3Nzcy YzI5ZGJkNDllNGU1YzEwYjFjNjk0YmI3ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wOC0yMSAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gVGhlIE1vemlsbGEgdGhlbWUgZHJh d2luZyBjb2RlIGluY29ycmVjdGx5IHJlbmRlcnMgc2Nyb2xsYmFyIGJhY2tncm91bmRzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDM4OAorCisgICAg ICAgIE5vIG5ldyB0ZXN0cyBhcyB0aGlzIGZ1bmN0aW9uYWxpdHkgaXMgY3VycmVudGx5IHVudXNl ZC4gV2hlbiB0aGUKKyAgICAgICAgdGhlIG5ldyBzY3JvbGxiYXIgdGhlbWUgY29kZSBsYW5kcyBm b3IgR1RLKywgdGhpcyB3aWxsIGJlIHRlc3RlZAorICAgICAgICBieSBzY3JvbGxiYXIgcGl4ZWwg dGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvZ3RrMmRyYXdpbmcuYzogRXhwb3NlIGEg bWV0aG9kIHRvIHBhaW50IHNjcm9sbGVkIHdpbmRvdworICAgICAgICBiYWNrZ3JvdW5kcyBhbmQg ZGlzYWJsZSBpbmNvcnJlY3QgcmVuZGVyaW5nIG9mIHNjcm9sbGJhciB0cm91Z2ggYmFja2dyb3Vu ZHMuCisgICAgICAgIChtb3pfZ3RrX3Njcm9sbGVkX3dpbmRvd19wYWludCk6IEFkZGVkLgorICAg ICAgICAobW96X2d0a19zY3JvbGxiYXJfdHJvdWdoX3BhaW50KTogRGlzYWJsZSBpbmNvcnJlY3Qg YmFja2dyb3VuZCByZW5kZXIuCisgICAgICAgICogcGxhdGZvcm0vZ3RrL2d0a2RyYXdpbmcuaDog QWRkIHNjcm9sbGVkIHdpbmRvdyB3aWRnZXQgdHlwZSBpbiB0aGUgZW51bS4KKwogMjAxMC0wOC0x NCAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjY1Mzc0LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0 Zm9ybS9ndGsvZ3RrMmRyYXdpbmcuYyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL2d0azJkcmF3aW5n LmMKaW5kZXggODBlMmMyYWU2NWQxZWEzOGMxZjljZjNkYzA4MjJlMjhmZGI1M2QxOS4uYmViZGM5 NTdhNDI1NDhkNjgzNWI1YTMyZDMxMzlmMzU0NjM1NjdjZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9w bGF0Zm9ybS9ndGsvZ3RrMmRyYXdpbmcuYworKysgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9ndGsy ZHJhd2luZy5jCkBAIC0xMDk0LDYgKzEwOTQsMzQgQEAgY2FsY3VsYXRlX2Fycm93X3JlY3QoR3Rr V2lkZ2V0KiBhcnJvdywgR2RrUmVjdGFuZ2xlKiByZWN0LAogfQogCiBzdGF0aWMgZ2ludAorbW96 X2d0a19zY3JvbGxlZF93aW5kb3dfcGFpbnQoR2RrRHJhd2FibGUqIGRyYXdhYmxlLCBHZGtSZWN0 YW5nbGUqIHJlY3QsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHZGtSZWN0YW5nbGUq IGNsaXByZWN0LCBHdGtXaWRnZXRTdGF0ZSogc3RhdGUpCit7CisgICAgR3RrU3RhdGVUeXBlIHN0 YXRlX3R5cGUgPSBDb252ZXJ0R3RrU3RhdGUoc3RhdGUpOworICAgIEd0a1NoYWRvd1R5cGUgc2hh ZG93X3R5cGUgPSAoc3RhdGUtPmFjdGl2ZSkgPyAgR1RLX1NIQURPV19JTiA6IEdUS19TSEFET1df T1VUOworICAgIEd0a1N0eWxlKiBzdHlsZTsKKyAgICBHdGtBbGxvY2F0aW9uIGFsbG9jYXRpb247 CisgICAgR3RrV2lkZ2V0KiB3aWRnZXQ7CisKKyAgICBlbnN1cmVfc2Nyb2xsZWRfd2luZG93X3dp ZGdldCgpOworICAgIHdpZGdldCA9IGdQYXJ0cy0+c2Nyb2xsZWRXaW5kb3dXaWRnZXQ7CisKKyAg ICBndGtfd2lkZ2V0X2dldF9hbGxvY2F0aW9uKHdpZGdldCwgJmFsbG9jYXRpb24pOworICAgIGFs bG9jYXRpb24ueCA9IHJlY3QtPng7CisgICAgYWxsb2NhdGlvbi55ID0gcmVjdC0+eTsKKyAgICBh bGxvY2F0aW9uLndpZHRoID0gcmVjdC0+d2lkdGg7CisgICAgYWxsb2NhdGlvbi5oZWlnaHQgPSBy ZWN0LT5oZWlnaHQ7CisgICAgZ3RrX3dpZGdldF9zZXRfYWxsb2NhdGlvbih3aWRnZXQsICZhbGxv Y2F0aW9uKTsKKworICAgIHN0eWxlID0gZ3RrX3dpZGdldF9nZXRfc3R5bGUod2lkZ2V0KTsKKyAg ICBUU09mZnNldFN0eWxlR0NzKHN0eWxlLCByZWN0LT54IC0gMSwgcmVjdC0+eSAtIDEpOworICAg IGd0a19wYWludF9ib3goc3R5bGUsIGRyYXdhYmxlLCBzdGF0ZV90eXBlLCBzaGFkb3dfdHlwZSwg Y2xpcHJlY3QsCisgICAgICAgICAgICAgICAgICB3aWRnZXQsICJzY3JvbGxlZF93aW5kb3ciLCBy ZWN0LT54IC0gMSwgcmVjdC0+eSAtIDEsCisgICAgICAgICAgICAgICAgICByZWN0LT53aWR0aCAr IDIsIHJlY3QtPmhlaWdodCArIDIpOworICAgIHJldHVybiBNT1pfR1RLX1NVQ0NFU1M7Cit9CisK K3N0YXRpYyBnaW50CiBtb3pfZ3RrX3Njcm9sbGJhcl9idXR0b25fcGFpbnQoR2RrRHJhd2FibGUq IGRyYXdhYmxlLCBHZGtSZWN0YW5nbGUqIHJlY3QsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgR2RrUmVjdGFuZ2xlKiBjbGlwcmVjdCwgR3RrV2lkZ2V0U3RhdGUqIHN0YXRlLAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIEd0a1Njcm9sbGJhckJ1dHRvbkZsYWdzIGZsYWdz LApAQCAtMTIxNCwxMCArMTI0Miw2IEBAIG1vel9ndGtfc2Nyb2xsYmFyX3Ryb3VnaF9wYWludChH dGtUaGVtZVdpZGdldFR5cGUgd2lkZ2V0LAogICAgIHN0eWxlID0gZ3RrX3dpZGdldF9nZXRfc3R5 bGUoR1RLX1dJREdFVChzY3JvbGxiYXIpKTsKIAogICAgIFRTT2Zmc2V0U3R5bGVHQ3Moc3R5bGUs IHJlY3QtPngsIHJlY3QtPnkpOwotICAgIGd0a19zdHlsZV9hcHBseV9kZWZhdWx0X2JhY2tncm91 bmQoc3R5bGUsIGRyYXdhYmxlLCBUUlVFLCBHVEtfU1RBVEVfQUNUSVZFLAotICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgY2xpcHJlY3QsIHJlY3QtPngsIHJlY3QtPnksCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWN0LT53aWR0aCwgcmVjdC0+ aGVpZ2h0KTsKLQogICAgIGd0a19wYWludF9ib3goc3R5bGUsIGRyYXdhYmxlLCBHVEtfU1RBVEVf QUNUSVZFLCBHVEtfU0hBRE9XX0lOLCBjbGlwcmVjdCwKICAgICAgICAgICAgICAgICAgIEdUS19X SURHRVQoc2Nyb2xsYmFyKSwgInRyb3VnaCIsIHJlY3QtPngsIHJlY3QtPnksCiAgICAgICAgICAg ICAgICAgICByZWN0LT53aWR0aCwgcmVjdC0+aGVpZ2h0KTsKQEAgLTMxMDksNiArMzEzMyw5IEBA IG1vel9ndGtfd2lkZ2V0X3BhaW50KEd0a1RoZW1lV2lkZ2V0VHlwZSB3aWRnZXQsIEdka0RyYXdh YmxlKiBkcmF3YWJsZSwKICAgICAgICAgcmV0dXJuIG1vel9ndGtfc2Nyb2xsYmFyX3RodW1iX3Bh aW50KHdpZGdldCwgZHJhd2FibGUsIHJlY3QsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBjbGlwcmVjdCwgc3RhdGUsIGRpcmVjdGlvbik7CiAgICAgICAgIGJy ZWFrOworICAgIGNhc2UgTU9aX0dUS19TQ1JPTExFRF9XSU5ET1c6CisgICAgICAgIHJldHVybiBt b3pfZ3RrX3Njcm9sbGVkX3dpbmRvd19wYWludChkcmF3YWJsZSwgcmVjdCwgY2xpcHJlY3QsIHN0 YXRlKTsKKyAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBNT1pfR1RLX1NDQUxFX0hPUklaT05UQUw6 CiAgICAgY2FzZSBNT1pfR1RLX1NDQUxFX1ZFUlRJQ0FMOgogICAgICAgICByZXR1cm4gbW96X2d0 a19zY2FsZV9wYWludChkcmF3YWJsZSwgcmVjdCwgY2xpcHJlY3QsIHN0YXRlLApkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvZ3RrZHJhd2luZy5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvZ3RrZHJhd2luZy5oCmluZGV4IGI1YTdmZWIyNGE2NDZmNGQ2MDE0OGZkNjQ0YjA1MGIwMjdk ZTVjYzguLmIyYTgzNTM4MjI4Yjk1ZTk2YzI2NDNkYTcxN2JkN2NhNTM3NzFkOGYgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL2d0a2RyYXdpbmcuaAorKysgYi9XZWJDb3JlL3BsYXRm b3JtL2d0ay9ndGtkcmF3aW5nLmgKQEAgLTE4MCw2ICsxODAsOCBAQCB0eXBlZGVmIGVudW0gewog ICAvKiBQYWludHMgdGhlIHNsaWRlciAodGh1bWIpIG9mIGEgR3RrU2Nyb2xsYmFyLiAqLwogICBN T1pfR1RLX1NDUk9MTEJBUl9USFVNQl9IT1JJWk9OVEFMLAogICBNT1pfR1RLX1NDUk9MTEJBUl9U SFVNQl9WRVJUSUNBTCwKKyAgLyogUGFpbnRzIHRoZSBiYWNrZ3JvdW5kIG9mIGEgc2Nyb2xsZWQg d2luZG93ICovCisgIE1PWl9HVEtfU0NST0xMRURfV0lORE9XLAogICAvKiBQYWludHMgYSBHdGtT Y2FsZS4gKi8KICAgTU9aX0dUS19TQ0FMRV9IT1JJWk9OVEFMLAogICBNT1pfR1RLX1NDQUxFX1ZF UlRJQ0FMLAo=