44384 2010-08-21 15:21:13 -0700 [Qt] Crash when purging the scratch buffer for the shadow 2010-08-23 01:16:21 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 ariya.hidayat ariya.hidayat hausmann kling oldest_to_newest 267608 0 ariya.hidayat 2010-08-21 15:21:13 -0700 The purge timer might stop or fire after the application is destroyed, and thus causes a crash. 267612 1 65036 ariya.hidayat 2010-08-21 16:11:29 -0700 Created attachment 65036 Patch 267616 2 65036 ariya.hidayat 2010-08-21 17:04:33 -0700 Comment on attachment 65036 Patch Andreas kindly suggested on IRC that the problem is solved easier by making ShadowBuffer a child of QCoreApplication::instance(). This leads me into thinking, maybe we should fix our shared timer instead so that application destruction stops and closes pending timers. Clearing the review flag while thinking about this. 267746 3 ariya.hidayat 2010-08-22 21:20:37 -0700 Apparently the problem is because TimerBase/Timer relies on thread global data, which is gone already after the application instance is destroyed. Thus, any static object can't use TimerBase/Timer with a risk of crashing. 267748 4 65073 ariya.hidayat 2010-08-22 21:41:56 -0700 Created attachment 65073 Patch 267749 5 65073 kling 2010-08-22 21:45:50 -0700 Comment on attachment 65073 Patch LGTM, feels like the best approach to this problem. 267780 6 65073 kenneth 2010-08-23 00:26:01 -0700 Comment on attachment 65073 Patch Oh that is a bit sad... 267791 7 ariya.hidayat 2010-08-23 01:16:21 -0700 Committed r65795: <http://trac.webkit.org/changeset/65795> 65036 2010-08-21 16:11:29 -0700 2010-08-22 21:41:52 -0700 Patch bug-44384-20100821161128.patch text/plain 2782 ariya.hidayat ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDcxNmYyN2FhNmQwYjE4ZTExMjc4YTgyNGY5ODMzZjczMWQwYjljYi4uZjU1N2JiZWY5YWNhMzdl NmVhNWNlZTNiNjJlNmRhMDFiNzkwNDAyNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMSBAQAogMjAxMC0wOC0yMSAgQXJp eWEgSGlkYXlhdCAgPGFyaXlhQHNlbmNoYS5jb20+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBDcmFzaCB3aGVuIHB1cmdpbmcgdGhlIHNjcmF0 Y2ggYnVmZmVyIGZvciB0aGUgc2hhZG93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00NDM4NAorCisgICAgICAgIFN0b3AgdGhlIHRpbWVyIHdoZW4gdGhl IGFwcGxpY2F0aW9uIGlzIGFib3V0IHRvIGJlIGRlc3Ryb3llZAorICAgICAgICBzbyB0aGF0IGl0 IHdpbGwgbmV2ZXIgZmlyZSB3aGVuIHRoZXJlIGlzIG5vIHZhbGlkIGFwcGxpY2F0aW9uCisgICAg ICAgIGluc3RhbmNlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvcXQvQ29udGV4dFNo YWRvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjopOgorICAgICAgICAoV2ViQ29yZTo6U2hhZG93 QnVmZmVyOjpTaGFkb3dCdWZmZXIpOgorICAgICAgICAoV2ViQ29yZTo6U2hhZG93QnVmZmVyOjpz aHV0ZG93bik6CisKKzIwMTAtMDgtMjEgIEFyaXlhIEhpZGF5YXQgIDxhcml5YUBzZW5jaGEuY29t PgorCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgogCiAg ICAgICAgIFtRdF0gRmFzdGVyIGJvdW5kaW5nIHJlY3QgZm9yIHRoZSBzaGFkb3cgY2xpcCByZWdp b24KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvQ29udGV4dFNoYWRv dy5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0NvbnRleHRTaGFkb3cuY3BwCmlu ZGV4IDdmOWI0MjdmOGQ0YzU0OTg2YTA0Y2U3YzZjNTg0ZDlhNDNmNjgyYWEuLmM0OGQ0N2Q0ZjEy MWQ2MTRkZTJhZjhlZGFkN2M2YTI4YzBhM2YxMGMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvcXQvQ29udGV4dFNoYWRvdy5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9xdC9Db250ZXh0U2hhZG93LmNwcApAQCAtMjgsNiArMjgsNyBAQAogI2luY2x1ZGUg ImNvbmZpZy5oIgogI2luY2x1ZGUgIkNvbnRleHRTaGFkb3cuaCIKIAorI2luY2x1ZGUgPFFDb3Jl QXBwbGljYXRpb24+CiAjaW5jbHVkZSAiVGltZXIuaCIKICNpbmNsdWRlIDx3dGYvTm9uY29weWFi bGUuaD4KIApAQCAtMzcsNyArMzgsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAvLyBJbnN0ZWFk IG9mIGNyZWF0aW5nIGFuZCBkZXN0cm95aW5nIHRoZSBidWZmZXIgZm9yIGV2ZXJ5IG9wZXJhdGlv biwKIC8vIHdlIGNyZWF0ZSBhIGJ1ZmZlciB3aGljaCB3aWxsIGJlIGF1dG9tYXRpY2FsbHkgcHVy Z2VkIHZpYSBhIHRpbWVyLgogCi1jbGFzcyBTaGFkb3dCdWZmZXI6IHB1YmxpYyBOb25jb3B5YWJs ZSB7CitjbGFzcyBTaGFkb3dCdWZmZXI6IHB1YmxpYyBRT2JqZWN0IHsKKyAgICBRX09CSkVDVAog cHVibGljOgogICAgIFNoYWRvd0J1ZmZlcigpOwogCkBAIC00NSw2ICs0Nyw5IEBAIHB1YmxpYzoK IAogICAgIHZvaWQgc2NoZWR1bGVQdXJnZSgpOwogCitwcml2YXRlIHNsb3RzOgorICAgIHZvaWQg c2h1dGRvd24oKTsKKwogcHJpdmF0ZToKICAgICBRSW1hZ2UgaW1hZ2U7CiAgICAgdm9pZCBwdXJn ZUJ1ZmZlcihUaW1lcjxTaGFkb3dCdWZmZXI+Kik7CkBAIC01Miw4ICs1NywxMyBAQCBwcml2YXRl OgogfTsKIAogU2hhZG93QnVmZmVyOjpTaGFkb3dCdWZmZXIoKQotICAgIDogcHVyZ2VUaW1lcih0 aGlzLCAmU2hhZG93QnVmZmVyOjpwdXJnZUJ1ZmZlcikKKyAgICA6IFFPYmplY3QoMCkKKyAgICAs IHB1cmdlVGltZXIodGhpcywgJlNoYWRvd0J1ZmZlcjo6cHVyZ2VCdWZmZXIpCiB7CisgICAgLy8g SWYgdGhlIHB1cmdlIHRpbWVyIHN0b3BzIG9yIGZpcmVzIGFmdGVyIHRoZSBhcHBsaWNhdGlvbiBp cyBkZXN0cm95ZWQsCisgICAgLy8gd2Ugd2lsbCBjcmFzaC4gVG8gcHJldmVudCB0aGlzLCB3ZSBz dG9wIHRoZSB0aW1lciBiZWZvcmVoYW5kLgorICAgIGNvbm5lY3QoUUNvcmVBcHBsaWNhdGlvbjo6 aW5zdGFuY2UoKSwgU0lHTkFMKGRlc3Ryb3llZCgpKSwKKyAgICAgICAgICAgIHRoaXMsIFNMT1Qo c2h1dGRvd24oKSkpOwogfQogCiBRSW1hZ2UqIFNoYWRvd0J1ZmZlcjo6c2NyYXRjaEltYWdlKGNv bnN0IFFTaXplJiBzaXplKQpAQCAtOTIsNiArMTAyLDExIEBAIHZvaWQgU2hhZG93QnVmZmVyOjpw dXJnZUJ1ZmZlcihUaW1lcjxTaGFkb3dCdWZmZXI+KikKICAgICBpbWFnZSA9IFFJbWFnZSgpOwog fQogCit2b2lkIFNoYWRvd0J1ZmZlcjo6c2h1dGRvd24oKQoreworICAgIHB1cmdlVGltZXIuc3Rv cCgpOworfQorCiBRX0dMT0JBTF9TVEFUSUMoU2hhZG93QnVmZmVyLCBzY3JhdGNoU2hhZG93QnVm ZmVyKQogCiBDb250ZXh0U2hhZG93OjpDb250ZXh0U2hhZG93KCkKQEAgLTMyMiw1ICszMzcsNiBA QCB2b2lkIENvbnRleHRTaGFkb3c6OmRyYXdTaGFkb3dSZWN0KFFQYWludGVyKiBwLCBjb25zdCBR UmVjdEYmIHJlY3QpCiAgICAgcC0+ZmlsbFJlY3QocmVjdC50cmFuc2xhdGVkKG9mZnNldCksIGNv bG9yKTsKIH0KIAorI2luY2x1ZGUgIkNvbnRleHRTaGFkb3cubW9jIgogCiB9Cg== 65073 2010-08-22 21:41:56 -0700 2010-08-23 00:26:01 -0700 Patch bug-44384-20100822214154.patch text/plain 2884 ariya.hidayat ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODI1ZTcyYWQzZTY3YjA4ZmEyMmQ0YTMyYTk0ZjA3OWY2NjliZmVjMC4uNGQxMTBmZDNhZWM0NDYy NTNmMjc0M2NhMmYzYTljMTY2Yjc4Mzg5NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0wOC0yMiAgQXJp eWEgSGlkYXlhdCAgPGFyaXlhQHNlbmNoYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBDcmFzaCB3aGVuIHB1cmdpbmcgdGhlIHNjcmF0 Y2ggYnVmZmVyIGZvciB0aGUgc2hhZG93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00NDM4NAorCisgICAgICAgIFdlYkNvcmU6OlRpbWVyIGNhbid0IGJl IHVzZWQgaW4gYSBzdGF0aWMgb2JqZWN0IGJjYXVzZSBpdCByZWxpZXMgb24KKyAgICAgICAgdGhy ZWFkIGdsb2JhbCBkYXRhLCB3aGljaCBpcyBpbnZhbGlkIG9uY2UgdGhlIGFwcGxpY2F0aW9uIGlu c3RhbmNlIGlzCisgICAgICAgIGRlc3Ryb3llZC4gVG8gb3ZlcmNvbWUgdGhlIHByb2JsZW0sIHVz ZSBRT2JqZWN0J3MgdGltZXIgc3VwcG9ydCBmb3IKKyAgICAgICAgdGhlIFNoYWRvd0J1ZmZlciBj bGFzcy4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0NvbnRleHRTaGFkb3cuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6KToKKyAgICAgICAgKFdlYkNvcmU6OlNoYWRvd0J1ZmZlcjo6 U2hhZG93QnVmZmVyKToKKyAgICAgICAgKFdlYkNvcmU6OlNoYWRvd0J1ZmZlcjo6c2NoZWR1bGVQ dXJnZSk6CisgICAgICAgIChXZWJDb3JlOjpTaGFkb3dCdWZmZXI6OnRpbWVyRXZlbnQpOgorCiAy MDEwLTA4LTIyICBBbmRyZWFzIEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgQXJpeWEgSGlkYXlhdC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvcXQvQ29udGV4dFNoYWRvdy5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3F0L0NvbnRleHRTaGFkb3cuY3BwCmluZGV4IDgzZTI5MWRkYjg5MzM5NGUxMWFlMjNj MDY3NzI2YWQxYTg5MTg4ZjMuLjk2ZDEzZmMwYWY2YTVkZWMyZWE1ZTMxZjk2YmQwM2MxZDdiMDE5 NDAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvQ29udGV4dFNoYWRv dy5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Db250ZXh0U2hhZG93LmNw cApAQCAtMjgsNyArMjgsNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkNvbnRl eHRTaGFkb3cuaCIKIAotI2luY2x1ZGUgIlRpbWVyLmgiCisjaW5jbHVkZSA8UVRpbWVyRXZlbnQ+ CiAjaW5jbHVkZSA8d3RmL05vbmNvcHlhYmxlLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKQEAg LTM3LDIyICszNywyNSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAvLyBJbnN0ZWFkIG9mIGNyZWF0 aW5nIGFuZCBkZXN0cm95aW5nIHRoZSBidWZmZXIgZm9yIGV2ZXJ5IG9wZXJhdGlvbiwKIC8vIHdl IGNyZWF0ZSBhIGJ1ZmZlciB3aGljaCB3aWxsIGJlIGF1dG9tYXRpY2FsbHkgcHVyZ2VkIHZpYSBh IHRpbWVyLgogCi1jbGFzcyBTaGFkb3dCdWZmZXI6IHB1YmxpYyBOb25jb3B5YWJsZSB7CitjbGFz cyBTaGFkb3dCdWZmZXI6IHB1YmxpYyBRT2JqZWN0IHsKIHB1YmxpYzoKLSAgICBTaGFkb3dCdWZm ZXIoKTsKKyAgICBTaGFkb3dCdWZmZXIoUU9iamVjdCogcGFyZW50ID0gMCk7CiAKICAgICBRSW1h Z2UqIHNjcmF0Y2hJbWFnZShjb25zdCBRU2l6ZSYgc2l6ZSk7CiAKICAgICB2b2lkIHNjaGVkdWxl UHVyZ2UoKTsKIAorcHJvdGVjdGVkOgorICAgIHZvaWQgdGltZXJFdmVudChRVGltZXJFdmVudCog ZXZlbnQpOworCiBwcml2YXRlOgogICAgIFFJbWFnZSBpbWFnZTsKLSAgICB2b2lkIHB1cmdlQnVm ZmVyKFRpbWVyPFNoYWRvd0J1ZmZlcj4qKTsKLSAgICBUaW1lcjxTaGFkb3dCdWZmZXI+IHB1cmdl VGltZXI7CisgICAgaW50IHRpbWVySWQ7CiB9OwogCi1TaGFkb3dCdWZmZXI6OlNoYWRvd0J1ZmZl cigpCi0gICAgOiBwdXJnZVRpbWVyKHRoaXMsICZTaGFkb3dCdWZmZXI6OnB1cmdlQnVmZmVyKQor U2hhZG93QnVmZmVyOjpTaGFkb3dCdWZmZXIoUU9iamVjdCogcGFyZW50KQorICAgIDogUU9iamVj dChwYXJlbnQpCisgICAgLCB0aW1lcklkKDApCiB7CiB9CiAKQEAgLTg0LDEyICs4NywxNyBAQCBR SW1hZ2UqIFNoYWRvd0J1ZmZlcjo6c2NyYXRjaEltYWdlKGNvbnN0IFFTaXplJiBzaXplKQogdm9p ZCBTaGFkb3dCdWZmZXI6OnNjaGVkdWxlUHVyZ2UoKQogewogICAgIHN0YXRpYyBjb25zdCBkb3Vi bGUgQnVmZmVyUHVyZ2VEZWxheSA9IDI7IC8vIHNlY29uZHMKLSAgICBwdXJnZVRpbWVyLnN0YXJ0 T25lU2hvdChCdWZmZXJQdXJnZURlbGF5KTsKKyAgICBraWxsVGltZXIodGltZXJJZCk7CisgICAg dGltZXJJZCA9IHN0YXJ0VGltZXIoQnVmZmVyUHVyZ2VEZWxheSAqIDEwMDApOwogfQogCi12b2lk IFNoYWRvd0J1ZmZlcjo6cHVyZ2VCdWZmZXIoVGltZXI8U2hhZG93QnVmZmVyPiopCit2b2lkIFNo YWRvd0J1ZmZlcjo6dGltZXJFdmVudChRVGltZXJFdmVudCogZXZlbnQpCiB7Ci0gICAgaW1hZ2Ug PSBRSW1hZ2UoKTsKKyAgICBpZiAoZXZlbnQtPnRpbWVySWQoKSA9PSB0aW1lcklkKSB7CisgICAg ICAgIGtpbGxUaW1lcih0aW1lcklkKTsKKyAgICAgICAgaW1hZ2UgPSBRSW1hZ2UoKTsKKyAgICB9 CisgICAgUU9iamVjdDo6dGltZXJFdmVudChldmVudCk7CiB9CiAKIFFfR0xPQkFMX1NUQVRJQyhT aGFkb3dCdWZmZXIsIHNjcmF0Y2hTaGFkb3dCdWZmZXIpCg==