44373 2010-08-20 19:45:35 -0700 WebKit does not build with Python 2.3 2010-08-21 10:23:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 benjamin webkit-unassigned abarth commit-queue eric kling oldest_to_newest 267509 0 benjamin 2010-08-20 19:45:35 -0700 The patch of https://bugs.webkit.org/show_bug.cgi?id=43949 introduce a python script in the build system to create html entities. This script requires Python 2.4 because of the function sorted(). This is quite annoying since Scratchbox (for Maemo for example) and older Macs have Python 2.3. 267515 1 65017 benjamin 2010-08-20 19:50:57 -0700 Created attachment 65017 Replace the call to sorted() by List::sort() This simple change makes it possible to compile for Maemo 5 again. 267524 2 65017 commit-queue 2010-08-20 20:35:14 -0700 Comment on attachment 65017 Replace the call to sorted() by List::sort() Rejecting patch 65017 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20893 test cases. animations/suspend-resume-animation.html -> failed Exiting early after 1 failures. 127 tests run. 32.78s total testing time 126 test cases (99%) succeeded 1 test case (<1%) had incorrect layout Full output: http://queues.webkit.org/results/3723404 267526 3 65017 kling 2010-08-20 20:39:19 -0700 Comment on attachment 65017 Replace the call to sorted() by List::sort() Clearing flags on attachment: 65017 Committed r65773: <http://trac.webkit.org/changeset/65773> 267527 4 kling 2010-08-20 20:39:29 -0700 All reviewed patches have been landed. Closing bug. 267569 5 eric 2010-08-21 07:38:05 -0700 Thanks. It's kinda sad, since we require python 2.5 to run the tests. However we made a special exception for Apple's Tiger bot to support 2.3 for building. What platform do you have which still uses Python 2.3? It's ancient! (Also, it's generally polite/helpful to CC the authors of the code your'e seeking review on. I just happened to see this since I get the commit-bot email, but Adam wrote this code.) Thanks for the fix. :) 267584 6 abarth 2010-08-21 10:11:14 -0700 Without a way to test this on the buildbot, we're going to keep regressing this whenever we touch this script. 267587 7 benjamin 2010-08-21 10:23:15 -0700 (In reply to comment #5) > What platform do you have which still uses Python 2.3? It's ancient! Yep. Maemo itself uses Python 2.5+, but the build system still uses Python 2.3. We also support Mac OS X Tiger in the Tier 2 platforms of Qt 4.6. > (Also, it's generally polite/helpful to CC the authors of the code your'e seeking review on. I just happened to see this since I get the commit-bot email, but Adam wrote this code.) Sorry. I thought that was not necessary given how trivial the fix is. 65017 2010-08-20 19:50:57 -0700 2010-08-20 20:39:19 -0700 Replace the call to sorted() by List::sort() 44373.patch text/plain 1317 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAwYjJkMzI0Li45MDhlN2IzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDgt MjAgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lhLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWJLaXQgZG9lcyBu b3QgYnVpbGQgd2l0aCBQeXRob24gMi4zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00NDM3MworCisgICAgICAgIFJlcGxhY2VkIHRoZSBmdW5jdGlvbiBz b3J0ZWQoKSBieSBhIGNhbGwgdG8gc29ydCgpCisgICAgICAgIG9uIHRoZSBlbnRyeSBsaXN0Lgor ICAgICAgICBUaGUgZnVuY3Rpb24gc29ydGVkKCkgaGFzIGJlZW4gYWRkZWQgdG8gUHl0aG9uIDIu NC4KKyAgICAgICAgVGhlIGZ1bmN0aW9uIG1ldGhvZCBzb3J0KCkgb2YgTGlzdCB3b3JrcyB3aXRo IG9sZGVyCisgICAgICAgIHZlcnNpb25zIG9mIFB5dGhvbi4KKworICAgICAgICAqIFNjcmlwdHMv Y3JlYXRlLWh0bWwtZW50aXR5LXRhYmxlOgorCiAyMDEwLTA4LTIwICBNYXJ0aW4gUm9iaW5zb24g IDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxk bWFuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9jcmVhdGUtaHRtbC1lbnRpdHkt dGFibGUgYi9XZWJLaXRUb29scy9TY3JpcHRzL2NyZWF0ZS1odG1sLWVudGl0eS10YWJsZQppbmRl eCA0NmM4YzUyLi5jNDA4MjA3IDEwMDc1NQotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL2NyZWF0 ZS1odG1sLWVudGl0eS10YWJsZQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL2NyZWF0ZS1odG1s LWVudGl0eS10YWJsZQpAQCAtNzMsNyArNzMsNyBAQCBodG1sX2VudGl0eV9uYW1lc19maWxlID0g b3BlbihpbnB1dF9wYXRoKQogZW50cmllcyA9IHNpbXBsZWpzb24ubG9hZChodG1sX2VudGl0eV9u YW1lc19maWxlKQogaHRtbF9lbnRpdHlfbmFtZXNfZmlsZS5jbG9zZSgpCiAKLWVudHJpZXMgPSBz b3J0ZWQoZW50cmllcywga2V5PWxhbWJkYSBlbnRyeTogZW50cnlbJ2VudGl0eSddKQorZW50cmll cy5zb3J0KGxhbWJkYSBhLCBiOiBjbXAoYVsnZW50aXR5J10sIGJbJ2VudGl0eSddKSkKIGVudGl0 eV9jb3VudCA9IGxlbihlbnRyaWVzKQogCiBvdXRwdXRfZmlsZSA9IG9wZW4ob3V0cHV0X3BhdGgs ICJ3IikK