<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>44353</bug_id>
          
          <creation_ts>2010-08-20 13:57:25 -0700</creation_ts>
          <short_desc>Do Not Copy Subversion Related Files in Inspector Build Phase</short_desc>
          <delta_ts>2010-08-20 14:17:44 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector (Deprecated)</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Joseph Pecoraro">joepeck</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ddkilzer</cc>
    
    <cc>joepeck</cc>
    
    <cc>mrowe</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>267396</commentid>
    <comment_count>0</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2010-08-20 13:57:25 -0700</bug_when>
    <thetext>`ditto` does a dumb copy in the &quot;Copy Inspector Resources&quot; build phase.
Let me know if you think I should switch over to an `rsync --exclude`
implementation like the &quot;Copy Forwarding and ICU Headers&quot; build phase.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267397</commentid>
    <comment_count>1</comment_count>
      <attachid>64990</attachid>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2010-08-20 13:59:32 -0700</bug_when>
    <thetext>Created attachment 64990
[PATCH] Remove .svn directories

Adds the following:

    # Remove any .svn directories that may have been copied over.
    find &quot;${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector&quot; -name &quot;.svn&quot; -type d | xargs rm -r</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267399</commentid>
    <comment_count>2</comment_count>
      <attachid>64991</attachid>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2010-08-20 14:00:22 -0700</bug_when>
    <thetext>Created attachment 64991
[SCRIPT] Build Phase - Not One Line

This is what the Build Phase looks like, not in one line.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267401</commentid>
    <comment_count>3</comment_count>
      <attachid>64990</attachid>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2010-08-20 14:06:52 -0700</bug_when>
    <thetext>Comment on attachment 64990
[PATCH] Remove .svn directories

WebCore/WebCore.xcodeproj/project.pbxproj:20491
+ [...]find \&quot;${TARGET_BUILD_DIR}/${UNLOCALIZED_RESOURCES_FOLDER_PATH}/inspector\&quot; -name \&quot;.svn\&quot; -type d | xargs rm -r\n&quot;;

I would actually use &quot;rm -rf&quot; here to force the deletion (unless you want the script to complain if rm doesn&apos;t work).

r=me either way.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>267404</commentid>
    <comment_count>4</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2010-08-20 14:17:44 -0700</bug_when>
    <thetext>&gt; I would actually use &quot;rm -rf&quot; here [...]

Done. Each of the other `rm -rf`

Committed r65753
	M	WebCore/ChangeLog
	M	WebCore/WebCore.xcodeproj/project.pbxproj
r65753 = 75779b62fce9cf44123d6ace17d73db0d307f98a (refs/remotes/trunk)
http://trac.webkit.org/changeset/65753</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>64990</attachid>
            <date>2010-08-20 13:59:32 -0700</date>
            <delta_ts>2010-08-20 14:06:52 -0700</delta_ts>
            <desc>[PATCH] Remove .svn directories</desc>
            <filename>no-svn.patch</filename>
            <type>text/plain</type>
            <size>2580</size>
            <attacher name="Joseph Pecoraro">joepeck</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
NjZkZmE1OS4uYTg5MTQ4NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wOC0yMCAgSm9zZXBoIFBlY29y
YXJvICA8am9lcGVja0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgIERvIE5vdCBDb3B5IFN1YnZlcnNpb24gUmVsYXRlZCBGaWxlcyBp
biBJbnNwZWN0b3IgQnVpbGQgUGhhc2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv
c2hvd19idWcuY2dpP2lkPTQ0MzUzCisKKyAgICAgICAgKiBXZWJDb3JlLnhjb2RlcHJvai9wcm9q
ZWN0LnBieHByb2o6IHJlbW92ZSAuc3ZuIGRpcmVjdG9yaWVzIGluIHRoZSAiQ29weSBJbnNwZWN0
b3IgUmVzb3VyY2VzIiBidWlsZCBwaGFzZS4KKwogMjAxMC0wOC0xOSAgRGF2aWQgS2lsemVyICA8
ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIDxodHRwOi8vd2Via2l0Lm9yZy9iLzQ0Mjg1
PiBGaXggY29tcGlsYXRpb24gd2l0aCBORVRTQ0FQRV9QTFVHSU5fQVBJIGRpc2FibGVkCmRpZmYg
LS1naXQgYS9XZWJDb3JlL1dlYkNvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvaiBiL1dlYkNv
cmUvV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IDI0MzVjNjEuLjkxNWRk
ZjcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9q
CisrKyBiL1dlYkNvcmUvV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCkBAIC0yMDQ4
OCw3ICsyMDQ4OCw3IEBACiAJCQkpOwogCQkJcnVuT25seUZvckRlcGxveW1lbnRQb3N0cHJvY2Vz
c2luZyA9IDA7CiAJCQlzaGVsbFBhdGggPSAvYmluL3NoOwotCQkJc2hlbGxTY3JpcHQgPSAiIyBD
b3B5IGFsbCB0aGUgSW5zcGVjdG9yIGZyb250LWVuZCByZXNvdXJjZXMuXG5kaXR0byBcIiR7U1JD
Uk9PVH0vaW5zcGVjdG9yL2Zyb250LWVuZFwiIFwiJHtUQVJHRVRfQlVJTERfRElSfS8ke1VOTE9D
QUxJWkVEX1JFU09VUkNFU19GT0xERVJfUEFUSH0vaW5zcGVjdG9yXCJcbmRpdHRvIFwiJHtCVUlM
VF9QUk9EVUNUU19ESVJ9L0Rlcml2ZWRTb3VyY2VzL1dlYkNvcmUvSW5zcGVjdG9yQmFja2VuZFN0
dWIuanNcIiBcIiR7VEFSR0VUX0JVSUxEX0RJUn0vJHtVTkxPQ0FMSVpFRF9SRVNPVVJDRVNfRk9M
REVSX1BBVEh9L2luc3BlY3RvclwiXG5cbiMgUmVtb3ZlIHRoZSBXZWJLaXQucXJjIGZpbGUgc2lu
Y2UgaXQgaXMgbm90IHVzZWQgb24gdGhlIE1hYyAodGhpcyBmaWxlIGlzIGZvciBRdClcbnJtIC1m
IFwiJHtUQVJHRVRfQlVJTERfRElSfS8ke1VOTE9DQUxJWkVEX1JFU09VUkNFU19GT0xERVJfUEFU
SH0vaW5zcGVjdG9yL1dlYktpdC5xcmNcIlxuXG4jIFJlbW92ZSAqLnJlMmpzIGZpbGVzLCB0aGV5
IGFyZSBvbmx5IHVzZWQgdG8gZ2VuZXJhdGUgc29tZSAuanMgZmlsZXMuXG5ybSAtZiBcIiR7VEFS
R0VUX0JVSUxEX0RJUn0vJHtVTkxPQ0FMSVpFRF9SRVNPVVJDRVNfRk9MREVSX1BBVEh9L2luc3Bl
Y3Rvci9cIioucmUyanNcbiI7CisJCQlzaGVsbFNjcmlwdCA9ICIjIENvcHkgYWxsIHRoZSBJbnNw
ZWN0b3IgZnJvbnQtZW5kIHJlc291cmNlcy5cbmRpdHRvIFwiJHtTUkNST09UfS9pbnNwZWN0b3Iv
ZnJvbnQtZW5kXCIgXCIke1RBUkdFVF9CVUlMRF9ESVJ9LyR7VU5MT0NBTElaRURfUkVTT1VSQ0VT
X0ZPTERFUl9QQVRIfS9pbnNwZWN0b3JcIlxuZGl0dG8gXCIke0JVSUxUX1BST0RVQ1RTX0RJUn0v
RGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9JbnNwZWN0b3JCYWNrZW5kU3R1Yi5qc1wiIFwiJHtUQVJH
RVRfQlVJTERfRElSfS8ke1VOTE9DQUxJWkVEX1JFU09VUkNFU19GT0xERVJfUEFUSH0vaW5zcGVj
dG9yXCJcblxuIyBSZW1vdmUgdGhlIFdlYktpdC5xcmMgZmlsZSBzaW5jZSBpdCBpcyBub3QgdXNl
ZCBvbiB0aGUgTWFjICh0aGlzIGZpbGUgaXMgZm9yIFF0KS5cbnJtIC1mIFwiJHtUQVJHRVRfQlVJ
TERfRElSfS8ke1VOTE9DQUxJWkVEX1JFU09VUkNFU19GT0xERVJfUEFUSH0vaW5zcGVjdG9yL1dl
YktpdC5xcmNcIlxuXG4jIFJlbW92ZSAqLnJlMmpzIGZpbGVzLCB0aGV5IGFyZSBvbmx5IHVzZWQg
dG8gZ2VuZXJhdGUgc29tZSAuanMgZmlsZXMuXG5ybSAtZiBcIiR7VEFSR0VUX0JVSUxEX0RJUn0v
JHtVTkxPQ0FMSVpFRF9SRVNPVVJDRVNfRk9MREVSX1BBVEh9L2luc3BlY3Rvci9cIioucmUyanNc
blxuIyBSZW1vdmUgYW55IC5zdm4gZGlyZWN0b3JpZXMgdGhhdCBtYXkgaGF2ZSBiZWVuIGNvcGll
ZCBvdmVyLlxuZmluZCBcIiR7VEFSR0VUX0JVSUxEX0RJUn0vJHtVTkxPQ0FMSVpFRF9SRVNPVVJD
RVNfRk9MREVSX1BBVEh9L2luc3BlY3RvclwiIC1uYW1lIFwiLnN2blwiIC10eXBlIGQgfCB4YXJn
cyBybSAtclxuIjsKIAkJfTsKIAkJNUQwRDU0MEQwRTk4NjJGNjAwMjlFMjIzIC8qIENoZWNrIEZv
ciBXZWFrIFZUYWJsZXMgYW5kIEV4dGVybmFscyAqLyA9IHsKIAkJCWlzYSA9IFBCWFNoZWxsU2Ny
aXB0QnVpbGRQaGFzZTsK
</data>
<flag name="review"
          id="53672"
          type_id="1"
          status="+"
          setter="ddkilzer"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>64991</attachid>
            <date>2010-08-20 14:00:22 -0700</date>
            <delta_ts>2010-08-20 14:00:49 -0700</delta_ts>
            <desc>[SCRIPT] Build Phase - Not One Line</desc>
            <filename>build-phase.sh</filename>
            <type>text/plain</type>
            <size>798</size>
            <attacher name="Joseph Pecoraro">joepeck</attacher>
            
              <data encoding="base64">IyBDb3B5IGFsbCB0aGUgSW5zcGVjdG9yIGZyb250LWVuZCByZXNvdXJjZXMuCmRpdHRvICIke1NS
Q1JPT1R9L2luc3BlY3Rvci9mcm9udC1lbmQiICIke1RBUkdFVF9CVUlMRF9ESVJ9LyR7VU5MT0NB
TElaRURfUkVTT1VSQ0VTX0ZPTERFUl9QQVRIfS9pbnNwZWN0b3IiCmRpdHRvICIke0JVSUxUX1BS
T0RVQ1RTX0RJUn0vRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9JbnNwZWN0b3JCYWNrZW5kU3R1Yi5q
cyIgIiR7VEFSR0VUX0JVSUxEX0RJUn0vJHtVTkxPQ0FMSVpFRF9SRVNPVVJDRVNfRk9MREVSX1BB
VEh9L2luc3BlY3RvciIKCiMgUmVtb3ZlIHRoZSBXZWJLaXQucXJjIGZpbGUgc2luY2UgaXQgaXMg
bm90IHVzZWQgb24gdGhlIE1hYyAodGhpcyBmaWxlIGlzIGZvciBRdCkuCnJtIC1mICIke1RBUkdF
VF9CVUlMRF9ESVJ9LyR7VU5MT0NBTElaRURfUkVTT1VSQ0VTX0ZPTERFUl9QQVRIfS9pbnNwZWN0
b3IvV2ViS2l0LnFyYyIKCiMgUmVtb3ZlICoucmUyanMgZmlsZXMsIHRoZXkgYXJlIG9ubHkgdXNl
ZCB0byBnZW5lcmF0ZSBzb21lIC5qcyBmaWxlcy4Kcm0gLWYgIiR7VEFSR0VUX0JVSUxEX0RJUn0v
JHtVTkxPQ0FMSVpFRF9SRVNPVVJDRVNfRk9MREVSX1BBVEh9L2luc3BlY3Rvci8iKi5yZTJqcwoK
IyBSZW1vdmUgYW55IC5zdm4gZGlyZWN0b3JpZXMgdGhhdCBtYXkgaGF2ZSBiZWVuIGNvcGllZCBv
dmVyLgpmaW5kICIke1RBUkdFVF9CVUlMRF9ESVJ9LyR7VU5MT0NBTElaRURfUkVTT1VSQ0VTX0ZP
TERFUl9QQVRIfS9pbnNwZWN0b3IiIC1uYW1lICIuc3ZuIiAtdHlwZSBkIHwgeGFyZ3Mgcm0gLXIK
</data>

          </attachment>
      

    </bug>

</bugzilla>