44347 2010-08-20 12:38:19 -0700 [Qt] constify core() and kit() parameters 2010-08-20 18:02:36 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 ademar webkit-unassigned commit-queue oldest_to_newest 267350 0 ademar 2010-08-20 12:38:19 -0700 The parameters to the private methods core() and kit() should be constified. Essencial if we need to call "core(this)" from inside a const method (a getter, for example). Patch is on the way 267353 1 64974 ademar 2010-08-20 12:47:43 -0700 Created attachment 64974 constify core() and kit() parameters from the private classes 267468 2 64974 ariya.hidayat 2010-08-20 16:24:11 -0700 Comment on attachment 64974 constify core() and kit() parameters from the private classes LGTM, re=me 267500 3 64974 commit-queue 2010-08-20 18:02:30 -0700 Comment on attachment 64974 constify core() and kit() parameters from the private classes Clearing flags on attachment: 64974 Committed r65771: <http://trac.webkit.org/changeset/65771> 267501 4 commit-queue 2010-08-20 18:02:36 -0700 All reviewed patches have been landed. Closing bug. 64974 2010-08-20 12:47:43 -0700 2010-08-20 18:02:30 -0700 constify core() and kit() parameters from the private classes 0001-Qt-API-constify-core-and-kit-parameters.patch text/plain 4437 ademar RnJvbSA0MDEzNTNjNjQwNTA1Nzc2MWQ2MzIyOWU2OWU1MTcyZGVmYTMxYjAzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVtYXIgZGUgU291emEgUmVpcyBKciA8YWRlbWFyLnJlaXNA b3BlbmJvc3NhLm9yZz4KRGF0ZTogRnJpLCAyMCBBdWcgMjAxMCAxNjoxODoyNyAtMDMwMApTdWJq ZWN0OiBbUEFUQ0hdIFF0IEFQSTogY29uc3RpZnkgY29yZSgpIGFuZCBraXQoKSBwYXJhbWV0ZXJz CgotLS0KIFdlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcCAgIHwgICAgNCArKy0tCiBXZWJLaXQv cXQvQXBpL3F3ZWJmcmFtZV9wLmggICB8ICAgIDQgKystLQogV2ViS2l0L3F0L0FwaS9xd2ViaGlz dG9yeS5jcHAgfCAgICAyICstCiBXZWJLaXQvcXQvQXBpL3F3ZWJoaXN0b3J5X3AuaCB8ICAgIDIg Ky0KIFdlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwICAgIHwgICAgMiArLQogV2ViS2l0L3F0L0Fw aS9xd2VicGFnZV9wLmggICAgfCAgICAyICstCiBXZWJLaXQvcXQvQ2hhbmdlTG9nICAgICAgICAg ICB8ICAgMTcgKysrKysrKysrKysrKysrKysKIDcgZmlsZXMgY2hhbmdlZCwgMjUgaW5zZXJ0aW9u cygrKSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFt ZS5jcHAgYi9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAKaW5kZXggMmM2NjU4Mi4uOGZhMzBm NiAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWUuY3BwCisrKyBiL1dlYktpdC9x dC9BcGkvcXdlYmZyYW1lLmNwcApAQCAtMTQyMSwxMiArMTQyMSwxMiBAQCBRV2ViU2VjdXJpdHlP cmlnaW4gUVdlYkZyYW1lOjpzZWN1cml0eU9yaWdpbigpIGNvbnN0CiAgICAgcmV0dXJuIFFXZWJT ZWN1cml0eU9yaWdpbihwcml2KTsKIH0KIAotV2ViQ29yZTo6RnJhbWUqIFFXZWJGcmFtZVByaXZh dGU6OmNvcmUoUVdlYkZyYW1lKiB3ZWJGcmFtZSkKK1dlYkNvcmU6OkZyYW1lKiBRV2ViRnJhbWVQ cml2YXRlOjpjb3JlKGNvbnN0IFFXZWJGcmFtZSogd2ViRnJhbWUpCiB7CiAgICAgcmV0dXJuIHdl YkZyYW1lLT5kLT5mcmFtZTsKIH0KIAotUVdlYkZyYW1lKiBRV2ViRnJhbWVQcml2YXRlOjpraXQo V2ViQ29yZTo6RnJhbWUqIGNvcmVGcmFtZSkKK1FXZWJGcmFtZSogUVdlYkZyYW1lUHJpdmF0ZTo6 a2l0KGNvbnN0IFdlYkNvcmU6OkZyYW1lKiBjb3JlRnJhbWUpCiB7CiAgICAgcmV0dXJuIHN0YXRp Y19jYXN0PEZyYW1lTG9hZGVyQ2xpZW50UXQqPihjb3JlRnJhbWUtPmxvYWRlcigpLT5jbGllbnQo KSktPndlYkZyYW1lKCk7CiB9CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZV9w LmggYi9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZV9wLmgKaW5kZXggMTViMDU0OS4uYjVkZGE2MiAx MDA2NDQKLS0tIGEvV2ViS2l0L3F0L0FwaS9xd2ViZnJhbWVfcC5oCisrKyBiL1dlYktpdC9xdC9B cGkvcXdlYmZyYW1lX3AuaApAQCAtODEsOCArODEsOCBAQCBwdWJsaWM6CiAgICAgV2ViQ29yZTo6 U2Nyb2xsYmFyKiBob3Jpem9udGFsU2Nyb2xsQmFyKCkgY29uc3Q7CiAgICAgV2ViQ29yZTo6U2Ny b2xsYmFyKiB2ZXJ0aWNhbFNjcm9sbEJhcigpIGNvbnN0OwogCi0gICAgc3RhdGljIFdlYkNvcmU6 OkZyYW1lKiBjb3JlKFFXZWJGcmFtZSopOwotICAgIHN0YXRpYyBRV2ViRnJhbWUqIGtpdChXZWJD b3JlOjpGcmFtZSopOworICAgIHN0YXRpYyBXZWJDb3JlOjpGcmFtZSogY29yZShjb25zdCBRV2Vi RnJhbWUqKTsKKyAgICBzdGF0aWMgUVdlYkZyYW1lKiBraXQoY29uc3QgV2ViQ29yZTo6RnJhbWUq KTsKIAogICAgIHZvaWQgcmVuZGVyUmVsYXRpdmVDb29yZHMoV2ViQ29yZTo6R3JhcGhpY3NDb250 ZXh0KiwgUVdlYkZyYW1lOjpSZW5kZXJMYXllciwgY29uc3QgUVJlZ2lvbiYgY2xpcCk7CiAjaWYg RU5BQkxFKFRJTEVEX0JBQ0tJTkdfU1RPUkUpCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3 ZWJoaXN0b3J5LmNwcCBiL1dlYktpdC9xdC9BcGkvcXdlYmhpc3RvcnkuY3BwCmluZGV4IDU1MzA1 YzkuLjFkOTkzNWQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9BcGkvcXdlYmhpc3RvcnkuY3BwCisr KyBiL1dlYktpdC9xdC9BcGkvcXdlYmhpc3RvcnkuY3BwCkBAIC01NTQsNyArNTU0LDcgQEAgUVdl YlBhZ2VQcml2YXRlKiBRV2ViSGlzdG9yeVByaXZhdGU6OnBhZ2UoKQogICAgIHJldHVybiBRV2Vi RnJhbWVQcml2YXRlOjpraXQoc3RhdGljX2Nhc3Q8V2ViQ29yZTo6QmFja0ZvcndhcmRMaXN0SW1w bCo+KGxzdCktPnBhZ2UoKS0+bWFpbkZyYW1lKCkpLT5wYWdlKCktPmhhbmRsZSgpOwogfQogCi1X ZWJDb3JlOjpIaXN0b3J5SXRlbSogUVdlYkhpc3RvcnlJdGVtUHJpdmF0ZTo6Y29yZShRV2ViSGlz dG9yeUl0ZW0qIHEpCitXZWJDb3JlOjpIaXN0b3J5SXRlbSogUVdlYkhpc3RvcnlJdGVtUHJpdmF0 ZTo6Y29yZShjb25zdCBRV2ViSGlzdG9yeUl0ZW0qIHEpCiB7CiAgICAgcmV0dXJuIHEtPmQtPml0 ZW07CiB9CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJoaXN0b3J5X3AuaCBiL1dlYktp dC9xdC9BcGkvcXdlYmhpc3RvcnlfcC5oCmluZGV4IGM5ZmY5MWIuLjFkZjIzNDkgMTAwNjQ0Ci0t LSBhL1dlYktpdC9xdC9BcGkvcXdlYmhpc3RvcnlfcC5oCisrKyBiL1dlYktpdC9xdC9BcGkvcXdl Ymhpc3RvcnlfcC5oCkBAIC00NSw3ICs0NSw3IEBAIHB1YmxpYzoKICAgICAgICAgICAgIGl0ZW0t PmRlcmVmKCk7CiAgICAgfQogCi0gICAgc3RhdGljIFdlYkNvcmU6Okhpc3RvcnlJdGVtKiBjb3Jl KFFXZWJIaXN0b3J5SXRlbSogcSk7CisgICAgc3RhdGljIFdlYkNvcmU6Okhpc3RvcnlJdGVtKiBj b3JlKGNvbnN0IFFXZWJIaXN0b3J5SXRlbSogcSk7CiAKICAgICBXZWJDb3JlOjpIaXN0b3J5SXRl bSogaXRlbTsKIH07CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcCBiL1dl YktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCmluZGV4IDUxNmViYzkuLjVlZWUyMWMgMTAwNjQ0Ci0t LSBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCisrKyBiL1dlYktpdC9xdC9BcGkvcXdlYnBh Z2UuY3BwCkBAIC0zMjIsNyArMzIyLDcgQEAgUVdlYlBhZ2VQcml2YXRlOjp+UVdlYlBhZ2VQcml2 YXRlKCkKICNlbmRpZgogfQogCi1XZWJDb3JlOjpQYWdlKiBRV2ViUGFnZVByaXZhdGU6OmNvcmUo UVdlYlBhZ2UqIHBhZ2UpCitXZWJDb3JlOjpQYWdlKiBRV2ViUGFnZVByaXZhdGU6OmNvcmUoY29u c3QgUVdlYlBhZ2UqIHBhZ2UpCiB7CiAgICAgcmV0dXJuIHBhZ2UtPmQtPnBhZ2U7CiB9CmRpZmYg LS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlX3AuaCBiL1dlYktpdC9xdC9BcGkvcXdlYnBh Z2VfcC5oCmluZGV4IGNmNGFiODguLjYzMTBlYWYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9BcGkv cXdlYnBhZ2VfcC5oCisrKyBiL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2VfcC5oCkBAIC03Miw3ICs3 Miw3IEBAIHB1YmxpYzoKICAgICBRV2ViUGFnZVByaXZhdGUoUVdlYlBhZ2UqKTsKICAgICB+UVdl YlBhZ2VQcml2YXRlKCk7CiAKLSAgICBzdGF0aWMgV2ViQ29yZTo6UGFnZSogY29yZShRV2ViUGFn ZSopOworICAgIHN0YXRpYyBXZWJDb3JlOjpQYWdlKiBjb3JlKGNvbnN0IFFXZWJQYWdlKik7CiAg ICAgc3RhdGljIFFXZWJQYWdlUHJpdmF0ZSogcHJpdihRV2ViUGFnZSopOwogCiAgICAgdm9pZCBj cmVhdGVNYWluRnJhbWUoKTsKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJL aXQvcXQvQ2hhbmdlTG9nCmluZGV4IDkyNDI4ZGYuLjJjZDY2MGYgMTAwNjQ0Ci0tLSBhL1dlYktp dC9xdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBA CisyMDEwLTA4LTIwICBBZGVtYXIgZGUgU291emEgUmVpcyBKciAgPGFkZW1hci5yZWlzQG9wZW5i b3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW1F0XSBjb25zdGlmeSBjb3JlKCkgYW5kIGtpdCgpIHBhcmFtZXRlcnMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0MzQ3CisKKyAgICAgICAgKiBB cGkvcXdlYmZyYW1lLmNwcDoKKyAgICAgICAgKFFXZWJGcmFtZTo6ZXZhbHVhdGVKYXZhU2NyaXB0 KToKKyAgICAgICAgKiBBcGkvcXdlYmZyYW1lX3AuaDoKKyAgICAgICAgKiBBcGkvcXdlYmhpc3Rv cnkuY3BwOgorICAgICAgICAoUVdlYkhpc3RvcnlJdGVtUHJpdmF0ZTo6Y29yZSk6CisgICAgICAg ICogQXBpL3F3ZWJoaXN0b3J5X3AuaDoKKyAgICAgICAgKiBBcGkvcXdlYnBhZ2UuY3BwOgorICAg ICAgICAoUVdlYlBhZ2VQcml2YXRlOjpjb3JlKToKKyAgICAgICAgKiBBcGkvcXdlYnBhZ2VfcC5o OgorCiAyMDEwLTA4LTE5ICBCYWxhenMgS2VsZW1lbiAgPGtiQGluZi51LXN6ZWdlZC5odT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVzLgotLSAKMS43LjIuMQoK