44344 2010-08-20 11:58:19 -0700 Web Inspector: element's css: pseudo-class locations 2010-08-23 05:50:16 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 phazei pfeldman bweinstein joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 267322 0 phazei 2010-08-20 11:58:19 -0700 Currently pseudo-classes, such as :first-letter :before :first-child etc, are listed after inherited elements. They should be listed above those with all the other Matched CSS Rules. They are directly affecting the element and it's very easy to miss if it's below 'Inherited' since that's usually ignored when styling a particular element. 267829 1 65099 pfeldman 2010-08-23 03:33:22 -0700 Created attachment 65099 [PATCH] Proposed fix. 267874 2 pfeldman 2010-08-23 05:50:16 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/StylesSidebarPane.js M WebCore/inspector/front-end/inspector.css Committed r65806 65099 2010-08-23 03:33:22 -0700 2010-08-23 05:25:30 -0700 [PATCH] Proposed fix. styles_fixes text/plain 6081 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjYxYmM4Zi4uNTIwNGU5NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wOC0yMyAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBlbGVtZW50J3MgY3NzOiBwc2V1ZG8t Y2xhc3MgbG9jYXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NDM0NAorCisgICAgICAgIEFsc28gY29udGFpbnMgYSBkcml2ZS1ieSBmaXggZm9y IDQ0MzAxIChncmF5IG91dCByZWFkLW9ubHkpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250 LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdHlsZXNT aWRlYmFyUGFuZS5wcm90b3R5cGUudXBkYXRlLmNvbXB1dGVkU3R5bGVDYWxsYmFjayk6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuU3R5bGVzU2lkZWJhclBhbmUucHJvdG90eXBlLnVwZGF0ZSk6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuU3R5bGVzU2lkZWJhclBhbmUucHJvdG90eXBlLl9yZWJ1aWxk VXBkYXRlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5TdHlsZXNTaWRlYmFyUGFuZS5wcm90b3R5 cGUuX3JlYnVpbGRTZWN0aW9uc0ZvclN0eWxlUnVsZXMpOgorICAgICAgICAoV2ViSW5zcGVjdG9y LlN0eWxlUHJvcGVydGllc1NlY3Rpb24pOgorCiAyMDEwLTA4LTIzICBQaGlsaXBwZSBOb3JtYW5k ICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXou CmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBh bmUuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU3R5bGVzU2lkZWJhclBhbmUuanMK aW5kZXggNWY1YTVhZC4uMzkzNTJhMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1N0eWxlc1NpZGViYXJQYW5lLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9TdHlsZXNTaWRlYmFyUGFuZS5qcwpAQCAtMTQzLDcgKzE0Myw3IEBAIFdlYkluc3BlY3Rv ci5TdHlsZXNTaWRlYmFyUGFuZS5wcm90b3R5cGUgPSB7CiAgICAgICAgIHsKICAgICAgICAgICAg IGlmIChjb21wdXRlZFN0eWxlKQogICAgICAgICAgICAgICAgIHRoaXMuX3JlZnJlc2hVcGRhdGUo bm9kZSwgY29tcHV0ZWRTdHlsZSwgZWRpdGVkU2VjdGlvbik7Ci0gICAgICAgIH07CisgICAgICAg IH0KIAogICAgICAgICBpZiAocmVmcmVzaCkKICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5jc3NN b2RlbC5nZXRDb21wdXRlZFN0eWxlQXN5bmMobm9kZS5pZCwgY29tcHV0ZWRTdHlsZUNhbGxiYWNr LmJpbmQodGhpcykpOwpAQCAtMTY2LDExICsxNjYsMTMgQEAgV2ViSW5zcGVjdG9yLlN0eWxlc1Np ZGViYXJQYW5lLnByb3RvdHlwZSA9IHsKICAgICB7CiAgICAgICAgIHRoaXMuYm9keUVsZW1lbnQu cmVtb3ZlQ2hpbGRyZW4oKTsKICAgICAgICAgdGhpcy5fY29tcHV0ZWRTdHlsZVBhbmUuYm9keUVs ZW1lbnQucmVtb3ZlQ2hpbGRyZW4oKTsKKwogICAgICAgICB2YXIgc3R5bGVSdWxlcyA9IHRoaXMu X3JlYnVpbGRTdHlsZVJ1bGVzKG5vZGUsIHN0eWxlcyk7CiAgICAgICAgIHZhciB1c2VkUHJvcGVy dGllcyA9IHt9OwogICAgICAgICB2YXIgZGlzYWJsZWRDb21wdXRlZFByb3BlcnRpZXMgPSB7fTsK ICAgICAgICAgdGhpcy5fbWFya1VzZWRQcm9wZXJ0aWVzKHN0eWxlUnVsZXMsIHVzZWRQcm9wZXJ0 aWVzLCBkaXNhYmxlZENvbXB1dGVkUHJvcGVydGllcyk7CiAgICAgICAgIHRoaXMuc2VjdGlvbnNb MF0gPSB0aGlzLl9yZWJ1aWxkU2VjdGlvbnNGb3JTdHlsZVJ1bGVzKHN0eWxlUnVsZXMsIHVzZWRQ cm9wZXJ0aWVzLCBkaXNhYmxlZENvbXB1dGVkUHJvcGVydGllcywgMCk7CisgICAgICAgIHZhciBh bmNob3JFbGVtZW50ID0gdGhpcy5zZWN0aW9uc1swXS5pbmhlcml0ZWRQcm9wZXJ0aWVzU2VwYXJh dG9yRWxlbWVudDsKIAogICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHN0eWxlcy5wc2V1ZG9F bGVtZW50cy5sZW5ndGg7ICsraSkgewogICAgICAgICAgICAgdmFyIHBzZXVkb0VsZW1lbnRDU1NS dWxlcyA9IHN0eWxlcy5wc2V1ZG9FbGVtZW50c1tpXTsKQEAgLTE4OSw3ICsxOTEsNyBAQCBXZWJJ bnNwZWN0b3IuU3R5bGVzU2lkZWJhclBhbmUucHJvdG90eXBlID0gewogICAgICAgICAgICAgdXNl ZFByb3BlcnRpZXMgPSB7fTsKICAgICAgICAgICAgIGRpc2FibGVkQ29tcHV0ZWRQcm9wZXJ0aWVz ID0ge307CiAgICAgICAgICAgICB0aGlzLl9tYXJrVXNlZFByb3BlcnRpZXMoc3R5bGVSdWxlcywg dXNlZFByb3BlcnRpZXMsIGRpc2FibGVkQ29tcHV0ZWRQcm9wZXJ0aWVzKTsKLSAgICAgICAgICAg IHRoaXMuc2VjdGlvbnNbcHNldWRvSWRdID0gdGhpcy5fcmVidWlsZFNlY3Rpb25zRm9yU3R5bGVS dWxlcyhzdHlsZVJ1bGVzLCB1c2VkUHJvcGVydGllcywgZGlzYWJsZWRDb21wdXRlZFByb3BlcnRp ZXMsIHBzZXVkb0lkKTsKKyAgICAgICAgICAgIHRoaXMuc2VjdGlvbnNbcHNldWRvSWRdID0gdGhp cy5fcmVidWlsZFNlY3Rpb25zRm9yU3R5bGVSdWxlcyhzdHlsZVJ1bGVzLCB1c2VkUHJvcGVydGll cywgZGlzYWJsZWRDb21wdXRlZFByb3BlcnRpZXMsIHBzZXVkb0lkLCBhbmNob3JFbGVtZW50KTsK ICAgICAgICAgfQogICAgIH0sCiAKQEAgLTI0NCwxNyArMjQ2LDYgQEAgV2ViSW5zcGVjdG9yLlN0 eWxlc1NpZGViYXJQYW5lLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHN0eWxlUnVsZXMucHVz aCh7IHN0eWxlOiBydWxlLnN0eWxlLCBzZWxlY3RvclRleHQ6IHJ1bGUuc2VsZWN0b3JUZXh0LCBw YXJlbnRTdHlsZVNoZWV0OiBydWxlLnBhcmVudFN0eWxlU2hlZXQsIHJ1bGU6IHJ1bGUgfSk7CiAg ICAgICAgIH0KIAotICAgICAgICAvLyBDb2xsZWN0IHVzZWQgcHJvcGVydGllcyBmaXJzdCBpbiBv cmRlciB0byBpZGVudGlmeSBpbmhlcml0ZWQgb25lcy4KLSAgICAgICAgdmFyIHVzZXJQcm9wZXJ0 eU5hbWVzID0ge307Ci0gICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgc3R5bGVSdWxlcy5sZW5n dGg7ICsraSkgewotICAgICAgICAgICAgdmFyIHN0eWxlUnVsZSA9IHN0eWxlUnVsZXNbaV07Ci0g ICAgICAgICAgICBpZiAoc3R5bGVSdWxlLmNvbXB1dGVkU3R5bGUgfHwgc3R5bGVSdWxlLmlzU3R5 bGVTZXBhcmF0b3IpCi0gICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICB2YXIg c3R5bGUgPSBzdHlsZVJ1bGUuc3R5bGU7Ci0gICAgICAgICAgICBmb3IgKHZhciBqID0gMDsgaiA8 IHN0eWxlLmxlbmd0aDsgKytqKQotICAgICAgICAgICAgICAgIHVzZXJQcm9wZXJ0eU5hbWVzW3N0 eWxlW2pdXSA9IHRydWU7Ci0gICAgICAgIH0KLQogICAgICAgICAvLyBXYWxrIHRoZSBub2RlIHN0 cnVjdHVyZSBhbmQgaWRlbnRpZnkgc3R5bGVzIHdpdGggaW5oZXJpdGVkIHByb3BlcnRpZXMuCiAg ICAgICAgIHZhciBwYXJlbnRTdHlsZXMgPSBzdHlsZXMucGFyZW50OwogICAgICAgICB2YXIgcGFy ZW50Tm9kZSA9IG5vZGUucGFyZW50Tm9kZTsKQEAgLTQwMiw3ICszOTMsNyBAQCBXZWJJbnNwZWN0 b3IuU3R5bGVzU2lkZWJhclBhbmUucHJvdG90eXBlID0gewogICAgICAgICB9CiAgICAgfSwKIAot ICAgIF9yZWJ1aWxkU2VjdGlvbnNGb3JTdHlsZVJ1bGVzOiBmdW5jdGlvbihzdHlsZVJ1bGVzLCB1 c2VkUHJvcGVydGllcywgZGlzYWJsZWRDb21wdXRlZFByb3BlcnRpZXMsIHBzZXVkb0lkKQorICAg IF9yZWJ1aWxkU2VjdGlvbnNGb3JTdHlsZVJ1bGVzOiBmdW5jdGlvbihzdHlsZVJ1bGVzLCB1c2Vk UHJvcGVydGllcywgZGlzYWJsZWRDb21wdXRlZFByb3BlcnRpZXMsIHBzZXVkb0lkLCBhbmNob3JF bGVtZW50KQogICAgIHsKICAgICAgICAgLy8gTWFrZSBhIHByb3BlcnR5IHNlY3Rpb24gZm9yIGVh Y2ggc3R5bGUgcnVsZS4KICAgICAgICAgdmFyIHNlY3Rpb25zID0gW107CkBAIC00MTYsNiArNDA3 LDggQEAgV2ViSW5zcGVjdG9yLlN0eWxlc1NpZGViYXJQYW5lLnByb3RvdHlwZSA9IHsKICAgICAg ICAgICAgICAgICAgICAgdmFyIGxpbmsgPSBXZWJJbnNwZWN0b3IucGFuZWxzLmVsZW1lbnRzLmxp bmtpZnlOb2RlUmVmZXJlbmNlKHN0eWxlUnVsZS5ub2RlKTsKICAgICAgICAgICAgICAgICAgICAg c2VwYXJhdG9yRWxlbWVudC5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZShXZWJJ bnNwZWN0b3IuVUlTdHJpbmcoIkluaGVyaXRlZCBmcm9tIikgKyAiICIpKTsKICAgICAgICAgICAg ICAgICAgICAgc2VwYXJhdG9yRWxlbWVudC5hcHBlbmRDaGlsZChsaW5rKTsKKyAgICAgICAgICAg ICAgICAgICAgaWYgKCFzZWN0aW9ucy5pbmhlcml0ZWRQcm9wZXJ0aWVzU2VwYXJhdG9yRWxlbWVu dCkKKyAgICAgICAgICAgICAgICAgICAgICAgIHNlY3Rpb25zLmluaGVyaXRlZFByb3BlcnRpZXNT ZXBhcmF0b3JFbGVtZW50ID0gc2VwYXJhdG9yRWxlbWVudDsKICAgICAgICAgICAgICAgICB9IGVs c2UgaWYgKCJwc2V1ZG9JZCIgaW4gc3R5bGVSdWxlKSB7CiAgICAgICAgICAgICAgICAgICAgIHZh ciBwc2V1ZG9OYW1lID0gV2ViSW5zcGVjdG9yLlN0eWxlc1NpZGViYXJQYW5lLlBzZXVkb0lkTmFt ZXNbc3R5bGVSdWxlLnBzZXVkb0lkXTsKICAgICAgICAgICAgICAgICAgICAgaWYgKHBzZXVkb05h bWUpCkBAIC00MjQsNyArNDE3LDcgQEAgV2ViSW5zcGVjdG9yLlN0eWxlc1NpZGViYXJQYW5lLnBy b3RvdHlwZSA9IHsKICAgICAgICAgICAgICAgICAgICAgICAgIHNlcGFyYXRvckVsZW1lbnQudGV4 dENvbnRlbnQgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlBzZXVkbyBlbGVtZW50Iik7CiAgICAg ICAgICAgICAgICAgfSBlbHNlCiAgICAgICAgICAgICAgICAgICAgIHNlcGFyYXRvckVsZW1lbnQu dGV4dENvbnRlbnQgPSBzdHlsZVJ1bGUudGV4dDsKLSAgICAgICAgICAgICAgICB0aGlzLmJvZHlF bGVtZW50LmFwcGVuZENoaWxkKHNlcGFyYXRvckVsZW1lbnQpOworICAgICAgICAgICAgICAgIHRo aXMuYm9keUVsZW1lbnQuaW5zZXJ0QmVmb3JlKHNlcGFyYXRvckVsZW1lbnQsIGFuY2hvckVsZW1l bnQpOwogICAgICAgICAgICAgICAgIGxhc3RXYXNTZXBhcmF0b3IgPSB0cnVlOwogICAgICAgICAg ICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgfQpAQCAtNDQ1LDcgKzQzOCw3IEBAIFdlYklu c3BlY3Rvci5TdHlsZXNTaWRlYmFyUGFuZS5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICAgICAg dGhpcy5fY29tcHV0ZWRTdHlsZVBhbmUuYm9keUVsZW1lbnQuYXBwZW5kQ2hpbGQoc2VjdGlvbi5l bGVtZW50KTsKICAgICAgICAgICAgICAgICBsYXN0V2FzU2VwYXJhdG9yID0gdHJ1ZTsKICAgICAg ICAgICAgIH0gZWxzZSB7Ci0gICAgICAgICAgICAgICAgdGhpcy5ib2R5RWxlbWVudC5hcHBlbmRD aGlsZChzZWN0aW9uLmVsZW1lbnQpOworICAgICAgICAgICAgICAgIHRoaXMuYm9keUVsZW1lbnQu aW5zZXJ0QmVmb3JlKHNlY3Rpb24uZWxlbWVudCwgYW5jaG9yRWxlbWVudCk7CiAgICAgICAgICAg ICAgICAgbGFzdFdhc1NlcGFyYXRvciA9IGZhbHNlOwogICAgICAgICAgICAgfQogICAgICAgICAg ICAgc2VjdGlvbnMucHVzaChzZWN0aW9uKTsKQEAgLTY3Nyw2ICs2NzAsOSBAQCBXZWJJbnNwZWN0 b3IuU3R5bGVQcm9wZXJ0aWVzU2VjdGlvbiA9IGZ1bmN0aW9uKHN0eWxlUnVsZSwgc3VidGl0bGUs IGNvbXB1dGVkU3R5bAogICAgIHRoaXMuaWRlbnRpZmllciA9IHN0eWxlUnVsZS5zZWxlY3RvclRl eHQ7CiAgICAgaWYgKHRoaXMuc3VidGl0bGUpCiAgICAgICAgIHRoaXMuaWRlbnRpZmllciArPSAi OiIgKyB0aGlzLnN1YnRpdGxlOworCisgICAgaWYgKCF0aGlzLmVkaXRhYmxlKQorICAgICAgICB0 aGlzLmVsZW1lbnQuYWRkU3R5bGVDbGFzcygicmVhZC1vbmx5Iik7CiB9CiAKIFdlYkluc3BlY3Rv ci5TdHlsZVByb3BlcnRpZXNTZWN0aW9uLnByb3RvdHlwZSA9IHsK