44342 2010-08-20 10:05:47 -0700 [GTK] Inspector extensions tests fail on GTK+ bots because onSelectionChanged is missing 2010-08-20 17:13:23 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P3 Normal --- 1 mrobinson webkit-unassigned caseq joepeck loislo pfeldman oldest_to_newest 267281 0 mrobinson 2010-08-20 10:05:47 -0700 For tests: inspector/extensions-api.html inspector/extensions.html The bots show diffs like this: panels : { elements : { createSidebarPane : <function> - onSelectionChanged : { - addListener : <function> - removeListener : <function> - } } scripts : { createSidebarPane : <function> - onSelectionChanged : { - addListener : <function> - removeListener : <function> - } } create : <function> } 267283 1 mrobinson 2010-08-20 10:14:20 -0700 Committed r65739: <http://trac.webkit.org/changeset/65739> 267433 2 mrobinson 2010-08-20 14:46:21 -0700 In this case, it appears that WebKitGTK+ is loading a stale copy of the inspector files for the tests. I should have a patch up shortly. Sorry for the noise! 267474 3 65008 mrobinson 2010-08-20 16:38:29 -0700 Created attachment 65008 Fix dependency tracking for inspector copied files 267479 4 65008 joepeck 2010-08-20 16:44:22 -0700 Comment on attachment 65008 Fix dependency tracking for inspector copied files > diff --git WebCore/GNUmakefile.am > # RemoteInspectorFrontend and InspectorBackendDispatcher > -DerivedSources/WebCore/RemoteInspectorFrontend.cpp DerivedSources/WebCore/RemoteInspectorFrontend.h DerivedSources/WebCore/InspectorBackendDispatcher.cpp DerivedSources/WebCore/InspectorBackendDispatcher.h: $(WebCore)/inspector/Inspector.idl $(SCRIPTS_BINDINGS) $(WebCore)/inspector/CodeGeneratorInspector.pm > +DerivedSources/WebCore/RemoteInspectorFrontend.cpp DerivedSources/WebCore/RemoteInspectorFrontend.h DerivedSources/WebCore/InspectorBackendDispatcher.cpp DerivedSources/WebCore/InspectorBackendDispatcher.h DerivedSources/WebCore/InspectorBackendStub.js: $(WebCore)/inspector/Inspector.idl $(SCRIPTS_BINDINGS) $(WebCore)/inspector/CodeGeneratorInspector.pm The comment above this should be updated as well. Maybe just something like: "All Web Inspector Generated Files" > +${GENSOURCES_INSPECTOR}/inspector.html: $(WebCore)/inspector/front-end/*.html \ > + $(WebCore)/inspector/front-end/*.js $(WebCore)/inspector/front-end/*.css \ > ... > mkdir -p ${GENSOURCES_INSPECTOR}/images > cp ${dist_webinspector_DATA} ${GENSOURCES_INSPECTOR} > cp ${dist_webinspectorimages_DATA} ${GENSOURCES_INSPECTOR}/images Separate these two lines, it makes it easier to read. And can you instead change the variable (dist_webinspector_DATA) to include the full paths? I'm surprised the `cp` later on works if that didn't have the proper paths. 267480 5 joepeck 2010-08-20 16:45:54 -0700 > > + $(WebCore)/inspector/front-end/*.js $(WebCore)/inspector/front-end/*.css \ These are what I wanted separated into two lines. 267489 6 65008 joepeck 2010-08-20 17:03:03 -0700 Comment on attachment 65008 Fix dependency tracking for inspector copied files Although I don't like the duplicated lines, I know you tried a few different approaches. r=me addressing the comments above. 267491 7 mrobinson 2010-08-20 17:13:23 -0700 Committed r65767: <http://trac.webkit.org/changeset/65767> 65008 2010-08-20 16:38:29 -0700 2010-08-20 17:03:03 -0700 Fix dependency tracking for inspector copied files bug-44342-20100820163831.patch text/plain 4259 mrobinson ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxYmNlNWNmZGYyNDZkMmRhYWJmYmI2NDVlYjg4NWJkYjNlMzI2NzRhLi5hZTE4Zjk1 ZWM4MTFhMWQ4MmJlMGJjZGNjYmU1YmUzYTIyN2Y1N2RmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAK KzIwMTAtMDgtMjAgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIEluc3Bl Y3RvciBleHRlbnNpb25zIHRlc3RzIGZhaWwgb24gR1RLKyBib3RzIGJlY2F1c2Ugb25TZWxlY3Rp b25DaGFuZ2VkIGlzIG1pc3NpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQ0MzQyCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvU2tpcHBlZDogVW5z a2lwIHRlc3RzIHdoaWNoIGFyZSBub3cgcGFzc2luZy4KKwogMjAxMC0wOC0yMCAgRXJpYyBDYXJs c29uICA8ZXJpYy5jYXJsc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4g QmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1NraXBwZWQg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAppbmRleCBjZjVkMGZkYzRlOTIwM2Zl NmFiYTU1YzA2YjM1NTZjODczZTBmNjZiLi4zN2UyYjdmOGVlODJhZDE4OTFkMmFjMGJjNDE0YmZk M2Y0NWNiNDY1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZApAQCAtNTkxOSw4ICs1OTE5LDMg QEAgcGVyZi8KICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0MzE2 CiBwbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9vYmplY3QtYXR0cmlidXRlcy5odG1sCiBwbGF0 Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS90aXRsZS1hbmQtYWx0Lmh0bWwKLQotIyBbR1RLXSBJbnNw ZWN0b3IgZXh0ZW5zaW9ucyB0ZXN0cyBmYWlsIG9uIEdUSysgYm90cyBiZWNhdXNlIG9uU2VsZWN0 aW9uQ2hhbmdlZCBpcyBtaXNzaW5nCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NDM0MgotaW5zcGVjdG9yL2V4dGVuc2lvbnMtYXBpLmh0bWwKLWluc3BlY3Rvci9l eHRlbnNpb25zLmh0bWwKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9D aGFuZ2VMb2cKaW5kZXggM2MzNjU1NGI0MGQ5N2JmOTVlNjZhMzFlNjFkNjU1YTlkNzU5NThmMS4u OGI1YzI0ZjQ0ODc2NzEzYTQ1NTFjYTY0ZDM0Y2MxNWU4YWVhOTg2OCAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAor MjAxMC0wOC0yMCAgTWFydGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gSW5zcGVj dG9yIGV4dGVuc2lvbnMgdGVzdHMgZmFpbCBvbiBHVEsrIGJvdHMgYmVjYXVzZSBvblNlbGVjdGlv bkNoYW5nZWQgaXMgbWlzc2luZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDQzNDIKKworICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOiBGaXggZGVwZW5k ZW5jeSB0cmFja2luZyBmb3IgY29waWVkIHdlYiBpbnNwZWN0b3IgZmlsZXMuCisKIDIwMTAtMDgt MjAgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBcml5YSBIaWRheWF0LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9HTlVtYWtlZmls ZS5hbSBiL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0KaW5kZXggNWFjZWZjMTdiMzZmOWQxZTNhNDFh OGU0MTJmZTdmOGQ4ZTEzMjIyYy4uMWMxMzdjYThmMjlkNTI0YjUyMTMyYzdjNWZiYjExNjQ0YmI2 MDRhMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQorKysgYi9XZWJDb3JlL0dO VW1ha2VmaWxlLmFtCkBAIC00NTMwLDcgKzQ1MzAsNyBAQCBEZXJpdmVkU291cmNlcy9XZWJDb3Jl L1hNTE5hbWVzLmNwcCBEZXJpdmVkU291cmNlcy9XZWJDb3JlL1hNTE5hbWVzLmg6ICQoV2ViQ29y ZQogCSQoQU1fVl9HRU4pJChQRVJMKSAtSSQoV2ViQ29yZSkvYmluZGluZ3Mvc2NyaXB0cyAkPCAt LWF0dHJzICQoV2ViQ29yZSkveG1sL3htbGF0dHJzLmluIC0tb3V0cHV0RGlyICIkKEdFTlNPVVJD RVNfV0VCQ09SRSkiCiAKICMgUmVtb3RlSW5zcGVjdG9yRnJvbnRlbmQgYW5kIEluc3BlY3RvckJh Y2tlbmREaXNwYXRjaGVyCi1EZXJpdmVkU291cmNlcy9XZWJDb3JlL1JlbW90ZUluc3BlY3RvckZy b250ZW5kLmNwcCBEZXJpdmVkU291cmNlcy9XZWJDb3JlL1JlbW90ZUluc3BlY3RvckZyb250ZW5k LmggRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9JbnNwZWN0b3JCYWNrZW5kRGlzcGF0Y2hlci5jcHAg RGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9JbnNwZWN0b3JCYWNrZW5kRGlzcGF0Y2hlci5oOiAkKFdl YkNvcmUpL2luc3BlY3Rvci9JbnNwZWN0b3IuaWRsICQoU0NSSVBUU19CSU5ESU5HUykgJChXZWJD b3JlKS9pbnNwZWN0b3IvQ29kZUdlbmVyYXRvckluc3BlY3Rvci5wbQorRGVyaXZlZFNvdXJjZXMv V2ViQ29yZS9SZW1vdGVJbnNwZWN0b3JGcm9udGVuZC5jcHAgRGVyaXZlZFNvdXJjZXMvV2ViQ29y ZS9SZW1vdGVJbnNwZWN0b3JGcm9udGVuZC5oIERlcml2ZWRTb3VyY2VzL1dlYkNvcmUvSW5zcGVj dG9yQmFja2VuZERpc3BhdGNoZXIuY3BwIERlcml2ZWRTb3VyY2VzL1dlYkNvcmUvSW5zcGVjdG9y QmFja2VuZERpc3BhdGNoZXIuaCBEZXJpdmVkU291cmNlcy9XZWJDb3JlL0luc3BlY3RvckJhY2tl bmRTdHViLmpzOiAkKFdlYkNvcmUpL2luc3BlY3Rvci9JbnNwZWN0b3IuaWRsICQoU0NSSVBUU19C SU5ESU5HUykgJChXZWJDb3JlKS9pbnNwZWN0b3IvQ29kZUdlbmVyYXRvckluc3BlY3Rvci5wbQog CSQoQU1fVl9HRU4pJChQRVJMKSAtSSQoV2ViQ29yZSkvYmluZGluZ3Mvc2NyaXB0cyAtSSQoV2Vi Q29yZSkvaW5zcGVjdG9yICQoV2ViQ29yZSkvYmluZGluZ3Mvc2NyaXB0cy9nZW5lcmF0ZS1iaW5k aW5ncy5wbCAkKElETF9QQVRIOiU9LS1pbmNsdWRlICIlIikgLS1vdXRwdXREaXIgIiQoR0VOU09V UkNFU19XRUJDT1JFKSIgLS1kZWZpbmVzICJMQU5HVUFHRV9KQVZBU0NSSVBUPTEgJChGRUFUVVJF X0RFRklORVMpIiAtLWdlbmVyYXRvciBJbnNwZWN0b3IgJDwKIAogSURMX1BBVEggOj0gXApAQCAt NDYzNyw4ICs0NjM3LDE0IEBAIGRpc3Rfd2ViaW5zcGVjdG9yaW1hZ2VzX0RBVEEgPSBcCiAJJChz aGVsbCBscyAkKFdlYkNvcmUpL2luc3BlY3Rvci9mcm9udC1lbmQvSW1hZ2VzLyouZ2lmKSBcCiAJ JChzaGVsbCBscyAkKFdlYkNvcmUpL2luc3BlY3Rvci9mcm9udC1lbmQvSW1hZ2VzLyoucG5nKQog CisjIEl0IHNlZW1zIHRoYXQgJChzaGVsbCkgZG9lcyBub3QgZXhwYW5kIHdoZW4gaXQgaXMgYSBy dWxlIGRlcGVuZGVuY3ksIHNvCisjIHdlIG11c3QgcmVkZWZpbmUgdGhpcyBsaXN0IG9mIGNvcGll ZCBmaWxlcyB3aXRoIHRyYWRpdGlvbmFsIGRlcGVuZGVuY3kgd2lsZGNhcmRzLgogbm9pbnN0X0RB VEEgPSAke0dFTlNPVVJDRVNfSU5TUEVDVE9SfS9pbnNwZWN0b3IuaHRtbAotJHtHRU5TT1VSQ0VT X0lOU1BFQ1RPUn0vaW5zcGVjdG9yLmh0bWw6Ciske0dFTlNPVVJDRVNfSU5TUEVDVE9SfS9pbnNw ZWN0b3IuaHRtbDogJChXZWJDb3JlKS9pbnNwZWN0b3IvZnJvbnQtZW5kLyouaHRtbCBcCisJCSQo V2ViQ29yZSkvaW5zcGVjdG9yL2Zyb250LWVuZC8qLmpzICQoV2ViQ29yZSkvaW5zcGVjdG9yL2Zy b250LWVuZC8qLmNzcyBcCisJCSQoV2ViQ29yZSkvaW5zcGVjdG9yL2Zyb250LWVuZC9JbWFnZXMv KiBcCisJCURlcml2ZWRTb3VyY2VzL1dlYkNvcmUvSW5zcGVjdG9yQmFja2VuZFN0dWIuanMgXAor CQkkKFdlYkNvcmUpL0VuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwogCW1rZGlyIC1w ICR7R0VOU09VUkNFU19JTlNQRUNUT1J9L2ltYWdlcwogCWNwICR7ZGlzdF93ZWJpbnNwZWN0b3Jf REFUQX0gJHtHRU5TT1VSQ0VTX0lOU1BFQ1RPUn0KIAljcCAke2Rpc3Rfd2ViaW5zcGVjdG9yaW1h Z2VzX0RBVEF9ICR7R0VOU09VUkNFU19JTlNQRUNUT1J9L2ltYWdlcwo=