44337 2010-08-20 08:22:21 -0700 [EFL] Added new callback when view's size is changed to fix issue with changing layout size 2010-08-26 09:53:21 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 miroslaw.s webkit-unassigned commit-queue gyuyoung.kim lucas.de.marchi miroslaw.s tonikitoo webkit.review.bot oldest_to_newest 267256 0 miroslaw.s 2010-08-20 08:22:21 -0700 There is an issue while changing view's size and changing fixed layout size in event view:EVAS_CALLBACK_RESIZE. The result was that scrollbar's max position was not calculated properly. Basically ewk_view_fixed_layout_size_set() was triggering smart_calculate() in the backing store while FrameView did not have visible content size updated yet, so the scrollbar's max positions were computed incorrectly. If we call ewk_view_fixed_layout_size_set() from the new callback, then the issue does not exist, because FrameView's visible content size is updated right before the callback function is called. Thanks, Miroslaw 267260 1 64959 miroslaw.s 2010-08-20 08:42:31 -0700 Created attachment 64959 New callback for view size changed 267261 2 webkit.review.bot 2010-08-20 08:44:18 -0700 Attachment 64959 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/efl/ewk/ewk_view.cpp:797: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 267262 3 64960 miroslaw.s 2010-08-20 08:48:37 -0700 Created attachment 64960 New callback for view size changed 269483 4 64960 lucas.de.marchi 2010-08-25 13:47:08 -0700 Comment on attachment 64960 New callback for view size changed > diff --git a/WebKit/efl/ChangeLog b/WebKit/efl/ChangeLog > index de65885..2887fd4 100644 > --- a/WebKit/efl/ChangeLog > +++ b/WebKit/efl/ChangeLog > @@ -1,3 +1,13 @@ > +2010-08-20 Miroslaw Szymanski <miroslaw.s@samsung.com> > + > + Reviewed by NOBODY (OOPS!). > + > + [EFL] Added new callback when view's size is changed to fix issue with changing layout size > + https://bugs.webkit.org/show_bug.cgi?id=44337 > + > + * ewk/ewk_view.cpp: > + (_ewk_view_smart_calculate): > + > 2010-08-15 Gyuyoung Kim <gyuyoung.kim@samsung.com> > > Reviewed by Antonio Gomes. > diff --git a/WebKit/efl/ewk/ewk_view.cpp b/WebKit/efl/ewk/ewk_view.cpp > index 7a98bac..5e19386 100644 > --- a/WebKit/efl/ewk/ewk_view.cpp > +++ b/WebKit/efl/ewk/ewk_view.cpp > @@ -792,6 +792,9 @@ static void _ewk_view_smart_calculate(Evas_Object* o) > sd->changed.frame_rect = EINA_TRUE; > sd->view.w = w; > sd->view.h = h; > + > + // This callback is a good place e.g. to change fixed layout size (ewk_view_fixed_layout_size_set) > + evas_object_smart_callback_call(o, "view,resized", 0); > } > sd->changed.size = EINA_FALSE; > lgtm, except by the fact it's missing the documentation about the signal emitted. Please, fill the doc in ewk_view.h 269484 5 64960 lucas.de.marchi 2010-08-25 13:50:21 -0700 Comment on attachment 64960 New callback for view size changed > diff --git a/WebKit/efl/ChangeLog b/WebKit/efl/ChangeLog > index de65885..2887fd4 100644 > --- a/WebKit/efl/ChangeLog > +++ b/WebKit/efl/ChangeLog > @@ -1,3 +1,13 @@ > +2010-08-20 Miroslaw Szymanski <miroslaw.s@samsung.com> > + > + Reviewed by NOBODY (OOPS!). > + > + [EFL] Added new callback when view's size is changed to fix issue with changing layout size > + https://bugs.webkit.org/show_bug.cgi?id=44337 > + > + * ewk/ewk_view.cpp: > + (_ewk_view_smart_calculate): > + > 2010-08-15 Gyuyoung Kim <gyuyoung.kim@samsung.com> > > Reviewed by Antonio Gomes. > diff --git a/WebKit/efl/ewk/ewk_view.cpp b/WebKit/efl/ewk/ewk_view.cpp > index 7a98bac..5e19386 100644 > --- a/WebKit/efl/ewk/ewk_view.cpp > +++ b/WebKit/efl/ewk/ewk_view.cpp > @@ -792,6 +792,9 @@ static void _ewk_view_smart_calculate(Evas_Object* o) > sd->changed.frame_rect = EINA_TRUE; > sd->view.w = w; > sd->view.h = h; > + > + // This callback is a good place e.g. to change fixed layout size (ewk_view_fixed_layout_size_set) And also this minor issue: comments must start with a capital letter and finish with a dot. 269726 6 tonikitoo 2010-08-25 22:53:54 -0700 Mirek Szymanski are you going to upload a new patch with comments addressed? 269852 7 65552 miroslaw.s 2010-08-26 06:37:22 -0700 Created attachment 65552 New callback for view size changed Thank you for comments. I've updated the patch. 269885 8 lucas.de.marchi 2010-08-26 08:01:43 -0700 lgtm. You have my informal r+. 269933 9 65552 commit-queue 2010-08-26 09:53:15 -0700 Comment on attachment 65552 New callback for view size changed Clearing flags on attachment: 65552 Committed r66111: <http://trac.webkit.org/changeset/66111> 269934 10 commit-queue 2010-08-26 09:53:21 -0700 All reviewed patches have been landed. Closing bug. 64959 2010-08-20 08:42:31 -0700 2010-08-20 08:48:37 -0700 New callback for view size changed new_callback_view_size_changed.diff text/plain 1136 miroslaw.s ZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvQ2hhbmdlTG9nIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK aW5kZXggZGU2NTg4NS4uMjg4N2ZkNCAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wOC0yMCAg TWlyb3NsYXcgU3p5bWFuc2tpICA8bWlyb3NsYXcuc0BzYW1zdW5nLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRUZMXSBBZGRlZCBuZXcgY2Fs bGJhY2sgd2hlbiB2aWV3J3Mgc2l6ZSBpcyBjaGFuZ2VkIHRvIGZpeCBpc3N1ZSB3aXRoIGNoYW5n aW5nIGxheW91dCBzaXplCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NDMzNworCisgICAgICAgICogZXdrL2V3a192aWV3LmNwcDoKKyAgICAgICAgKF9l d2tfdmlld19zbWFydF9jYWxjdWxhdGUpOgorCiAyMDEwLTA4LTE1ICBHeXV5b3VuZyBLaW0gIDxn eXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50b25pbyBH b21lcy4KZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcCBiL1dlYktpdC9l ZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCA3YTk4YmFjLi45YjU2YzNlIDEwMDY0NAotLS0gYS9X ZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKKysrIGIvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcu Y3BwCkBAIC03OTIsNiArNzkyLDkgQEAgc3RhdGljIHZvaWQgX2V3a192aWV3X3NtYXJ0X2NhbGN1 bGF0ZShFdmFzX09iamVjdCogbykKICAgICAgICAgc2QtPmNoYW5nZWQuZnJhbWVfcmVjdCA9IEVJ TkFfVFJVRTsKICAgICAgICAgc2QtPnZpZXcudyA9IHc7CiAgICAgICAgIHNkLT52aWV3LmggPSBo OworCisgICAgICAgIC8vIFRoaXMgY2FsbGJhY2sgaXMgYSBnb29kIHBsYWNlIGUuZy4gdG8gY2hh bmdlIGZpeGVkIGxheW91dCBzaXplIChld2tfdmlld19maXhlZF9sYXlvdXRfc2l6ZV9zZXQpCisg ICAgICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2NhbGwobywgInZpZXcscmVzaXplZCIs IE5VTEwpOwogICAgIH0KICAgICBzZC0+Y2hhbmdlZC5zaXplID0gRUlOQV9GQUxTRTsKIAo= 64960 2010-08-20 08:48:37 -0700 2010-08-26 06:37:22 -0700 New callback for view size changed new_callback_view_size_changed.diff text/plain 1133 miroslaw.s ZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvQ2hhbmdlTG9nIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK aW5kZXggZGU2NTg4NS4uMjg4N2ZkNCAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wOC0yMCAg TWlyb3NsYXcgU3p5bWFuc2tpICA8bWlyb3NsYXcuc0BzYW1zdW5nLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRUZMXSBBZGRlZCBuZXcgY2Fs bGJhY2sgd2hlbiB2aWV3J3Mgc2l6ZSBpcyBjaGFuZ2VkIHRvIGZpeCBpc3N1ZSB3aXRoIGNoYW5n aW5nIGxheW91dCBzaXplCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NDMzNworCisgICAgICAgICogZXdrL2V3a192aWV3LmNwcDoKKyAgICAgICAgKF9l d2tfdmlld19zbWFydF9jYWxjdWxhdGUpOgorCiAyMDEwLTA4LTE1ICBHeXV5b3VuZyBLaW0gIDxn eXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50b25pbyBH b21lcy4KZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcCBiL1dlYktpdC9l ZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCA3YTk4YmFjLi41ZTE5Mzg2IDEwMDY0NAotLS0gYS9X ZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKKysrIGIvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcu Y3BwCkBAIC03OTIsNiArNzkyLDkgQEAgc3RhdGljIHZvaWQgX2V3a192aWV3X3NtYXJ0X2NhbGN1 bGF0ZShFdmFzX09iamVjdCogbykKICAgICAgICAgc2QtPmNoYW5nZWQuZnJhbWVfcmVjdCA9IEVJ TkFfVFJVRTsKICAgICAgICAgc2QtPnZpZXcudyA9IHc7CiAgICAgICAgIHNkLT52aWV3LmggPSBo OworCisgICAgICAgIC8vIFRoaXMgY2FsbGJhY2sgaXMgYSBnb29kIHBsYWNlIGUuZy4gdG8gY2hh bmdlIGZpeGVkIGxheW91dCBzaXplIChld2tfdmlld19maXhlZF9sYXlvdXRfc2l6ZV9zZXQpCisg ICAgICAgIGV2YXNfb2JqZWN0X3NtYXJ0X2NhbGxiYWNrX2NhbGwobywgInZpZXcscmVzaXplZCIs IDApOwogICAgIH0KICAgICBzZC0+Y2hhbmdlZC5zaXplID0gRUlOQV9GQUxTRTsKIAo= 65552 2010-08-26 06:37:22 -0700 2010-08-26 09:53:15 -0700 New callback for view size changed new_callback_view_size_changed_2.diff text/plain 1663 miroslaw.s ZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvQ2hhbmdlTG9nIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK aW5kZXggZGU2NTg4NS4uMjg4N2ZkNCAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wOC0yMCAg TWlyb3NsYXcgU3p5bWFuc2tpICA8bWlyb3NsYXcuc0BzYW1zdW5nLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbRUZMXSBBZGRlZCBuZXcgY2Fs bGJhY2sgd2hlbiB2aWV3J3Mgc2l6ZSBpcyBjaGFuZ2VkIHRvIGZpeCBpc3N1ZSB3aXRoIGNoYW5n aW5nIGxheW91dCBzaXplCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NDMzNworCisgICAgICAgICogZXdrL2V3a192aWV3LmNwcDoKKyAgICAgICAgKF9l d2tfdmlld19zbWFydF9jYWxjdWxhdGUpOgorCiAyMDEwLTA4LTE1ICBHeXV5b3VuZyBLaW0gIDxn eXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQW50b25pbyBH b21lcy4KZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcCBiL1dlYktpdC9l ZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCA3YTk4YmFjLi5jZmIxNzAxIDEwMDY0NAotLS0gYS9X ZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKKysrIGIvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcu Y3BwCkBAIC03OTIsNiArNzkyLDkgQEAgc3RhdGljIHZvaWQgX2V3a192aWV3X3NtYXJ0X2NhbGN1 bGF0ZShFdmFzX09iamVjdCogbykKICAgICAgICAgc2QtPmNoYW5nZWQuZnJhbWVfcmVjdCA9IEVJ TkFfVFJVRTsKICAgICAgICAgc2QtPnZpZXcudyA9IHc7CiAgICAgICAgIHNkLT52aWV3LmggPSBo OworCisgICAgICAgIC8vIFRoaXMgY2FsbGJhY2sgaXMgYSBnb29kIHBsYWNlIGUuZy4gdG8gY2hh bmdlIGZpeGVkIGxheW91dCBzaXplIChld2tfdmlld19maXhlZF9sYXlvdXRfc2l6ZV9zZXQpLgor ICAgICAgICBldmFzX29iamVjdF9zbWFydF9jYWxsYmFja19jYWxsKG8sICJ2aWV3LHJlc2l6ZWQi LCAwKTsKICAgICB9CiAgICAgc2QtPmNoYW5nZWQuc2l6ZSA9IEVJTkFfRkFMU0U7CiAKZGlmZiAt LWdpdCBhL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmggYi9XZWJLaXQvZWZsL2V3ay9ld2tfdmll dy5oCmluZGV4IDhkZDYxNzguLjVlYzAwZjEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9lZmwvZXdrL2V3 a192aWV3LmgKKysrIGIvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuaApAQCAtODgsNiArODgsNyBA QCBleHRlcm4gIkMiIHsKICAqICAtICJpY29uLHJlY2VpdmVkIiwgdm9pZDogbWFpbiBmcmFtZSBy ZWNlaXZlZCBhbiBpY29uLgogICogIC0gInZpZXdwb3J0LGNoYW5nZWQiLCB2b2lkOiBSZXBvcnQg dGhhdCB2aWV3cG9ydCBoYXMgY2hhbmdlZC4KICAqICAtICJpbnB1dG1ldGhvZHMsY2hhbmdlZCIg d2l0aCBhIGJvb2xlYW4gaW5kaWNhdGluZyB3aGV0aGVyIGl0J3MgZW5hYmxlZCBvciBub3QuCisg KiAgLSAidmlldyxyZXNpemVkIiwgdm9pZDogdmlldyBvYmplY3QncyBzaXplIGhhcyBjaGFuZ2Vk LgogICovCiAKIHR5cGVkZWYgc3RydWN0IF9Fd2tfVmlld19TbWFydF9EYXRhIEV3a19WaWV3X1Nt YXJ0X0RhdGE7Cg==