44332 2010-08-20 04:29:29 -0700 [GStreamer] don't expose the private player in GStreamerGWorld 2010-08-22 23:12:30 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned oldest_to_newest 267199 0 pnormand 2010-08-20 04:29:29 -0700 Only a pointer to our playbin2 element instance is required. 267208 1 64946 pnormand 2010-08-20 04:51:04 -0700 Created attachment 64946 proposed patch 267236 2 64946 xan.lopez 2010-08-20 06:56:04 -0700 Comment on attachment 64946 proposed patch Yay. 267766 3 pnormand 2010-08-22 23:12:30 -0700 http://trac.webkit.org/changeset/65793 64946 2010-08-20 04:51:04 -0700 2010-08-20 06:56:04 -0700 proposed patch proposed-patch.patch text/plain 7577 pnormand RnJvbSAzZTc4MmQ3OWEzMjkzNGRhMTIwOTI5NzlhOWVhYzdkODY3ZjFhYmM3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBGcmksIDIwIEF1ZyAyMDEwIDEzOjUwOjQ0ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDIxICsrKysrKysrKysrKysrKysrKwogLi4uL2dyYXBoaWNzL2dz dHJlYW1lci9HU3RyZWFtZXJHV29ybGQuY3BwICAgICAgICAgfCAgIDIzICsrKysrKysrKy0tLS0t LS0tLS0KIC4uLi9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyR1dvcmxkLmgg IHwgICAgOSArKystLS0tCiAuLi4vZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ci5jcHAgICAgICB8ICAgIDIgKy0KIDQgZmlsZXMgY2hhbmdlZCwgMzcgaW5zZXJ0aW9ucygrKSwg MTggZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCA3MWQ4YmRjLi5lMDkwNzExIDEwMDY0NAotLS0gYS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEwLTA4 LTIwICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1N0cmVhbWVyXSBkb24ndCBl eHBvc2UgdGhlIHByaXZhdGUgcGxheWVyIGluIEdTdHJlYW1lckdXb3JsZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQzMzIKKworICAgICAgICBPbmx5 IGEgcG9pbnRlciB0byBvdXIgcGxheWJpbjIgZWxlbWVudCBpbnN0YW5jZSBpcyByZXF1aXJlZAor ICAgICAgICBpbnN0ZWFkIG9mIHRoZSB3aG9sZSBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIg aW5zdGFuY2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVh bWVyR1dvcmxkLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdTdHJlYW1lckdXb3JsZDo6Y3JlYXRl R1dvcmxkKToKKyAgICAgICAgKFdlYkNvcmU6OkdTdHJlYW1lckdXb3JsZDo6R1N0cmVhbWVyR1dv cmxkKToKKyAgICAgICAgKFdlYkNvcmU6OkdTdHJlYW1lckdXb3JsZDo6fkdTdHJlYW1lckdXb3Js ZCk6CisgICAgICAgIChXZWJDb3JlOjpHU3RyZWFtZXJHV29ybGQ6OmVudGVyRnVsbHNjcmVlbik6 CisgICAgICAgIChXZWJDb3JlOjpHU3RyZWFtZXJHV29ybGQ6OmV4aXRGdWxsc2NyZWVuKToKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyR1dvcmxkLmg6Cisg ICAgICAgIChXZWJDb3JlOjpHU3RyZWFtZXJHV29ybGQ6OnBpcGVsaW5lKToKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6Y3JlYXRl R1NUUGxheUJpbik6CisKIDIwMTAtMDgtMjAgIEFuZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5n QG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlh bnNlbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dT dHJlYW1lckdXb3JsZC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9H U3RyZWFtZXJHV29ybGQuY3BwCmluZGV4IGIyOTQ3OWQuLjk2YTYzOWIgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lckdXb3JsZC5jcHAKKysr IGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR1N0cmVhbWVyR1dvcmxkLmNw cApAQCAtNDgsMTcgKzQ4LDE3IEBAIGdib29sZWFuIGdzdEdXb3JsZFN5bmNNZXNzYWdlQ2FsbGJh Y2soR3N0QnVzKiBidXMsIEdzdE1lc3NhZ2UqIG1lc3NhZ2UsIGdwb2ludGVyCiAgICAgcmV0dXJu IFRSVUU7CiB9CiAKLVBhc3NSZWZQdHI8R1N0cmVhbWVyR1dvcmxkPiBHU3RyZWFtZXJHV29ybGQ6 OmNyZWF0ZUdXb3JsZChNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIqIHBsYXllcikKK1Bhc3NS ZWZQdHI8R1N0cmVhbWVyR1dvcmxkPiBHU3RyZWFtZXJHV29ybGQ6OmNyZWF0ZUdXb3JsZChHc3RF bGVtZW50KiBwaXBlbGluZSkKIHsKLSAgICByZXR1cm4gYWRvcHRSZWYobmV3IEdTdHJlYW1lckdX b3JsZChwbGF5ZXIpKTsKKyAgICByZXR1cm4gYWRvcHRSZWYobmV3IEdTdHJlYW1lckdXb3JsZChw aXBlbGluZSkpOwogfQogCi1HU3RyZWFtZXJHV29ybGQ6OkdTdHJlYW1lckdXb3JsZChNZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXIqIHBsYXllcikKLSAgICA6IG1fcGxheWVyKHBsYXllcikKK0dT dHJlYW1lckdXb3JsZDo6R1N0cmVhbWVyR1dvcmxkKEdzdEVsZW1lbnQqIHBpcGVsaW5lKQorICAg IDogbV9waXBlbGluZShwaXBlbGluZSkKICAgICAsIG1fZHluYW1pY1BhZE5hbWUoMCkKIHsKICAg ICAvLyBYT3ZlcmxheSBtZXNzYWdlcyBuZWVkIHRvIGJlIGhhbmRsZWQgc3luY2hyb25vdXNseS4K LSAgICBHc3RCdXMqIGJ1cyA9IGdzdF9waXBlbGluZV9nZXRfYnVzKEdTVF9QSVBFTElORShtX3Bs YXllci0+cGlwZWxpbmUoKSkpOworICAgIEdzdEJ1cyogYnVzID0gZ3N0X3BpcGVsaW5lX2dldF9i dXMoR1NUX1BJUEVMSU5FKG1fcGlwZWxpbmUpKTsKICAgICBnc3RfYnVzX3NldF9zeW5jX2hhbmRs ZXIoYnVzLCBnc3RfYnVzX3N5bmNfc2lnbmFsX2hhbmRsZXIsIHRoaXMpOwogICAgIGdfc2lnbmFs X2Nvbm5lY3QoYnVzLCAic3luYy1tZXNzYWdlOjplbGVtZW50IiwgR19DQUxMQkFDSyhnc3RHV29y bGRTeW5jTWVzc2FnZUNhbGxiYWNrKSwgdGhpcyk7CiAgICAgZ3N0X29iamVjdF91bnJlZihidXMp OwpAQCAtNjcsNiArNjcsOCBAQCBHU3RyZWFtZXJHV29ybGQ6OkdTdHJlYW1lckdXb3JsZChNZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIqIHBsYXllcikKIEdTdHJlYW1lckdXb3JsZDo6fkdTdHJl YW1lckdXb3JsZCgpCiB7CiAgICAgZXhpdEZ1bGxzY3JlZW4oKTsKKworICAgIG1fcGlwZWxpbmUg PSAwOwogfQogCiBib29sIEdTdHJlYW1lckdXb3JsZDo6ZW50ZXJGdWxsc2NyZWVuKCkKQEAgLTc3 LDcgKzc5LDYgQEAgYm9vbCBHU3RyZWFtZXJHV29ybGQ6OmVudGVyRnVsbHNjcmVlbigpCiAgICAg aWYgKCFtX3ZpZGVvV2luZG93KQogICAgICAgICBtX3ZpZGVvV2luZG93ID0gUGxhdGZvcm1WaWRl b1dpbmRvdzo6Y3JlYXRlV2luZG93KCk7CiAKLSAgICBHc3RFbGVtZW50KiBwaXBlbGluZSA9IG1f cGxheWVyLT5waXBlbGluZSgpOwogICAgIEdzdEVsZW1lbnQqIHBsYXRmb3JtVmlkZW9TaW5rID0g Z3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJhdXRvdmlkZW9zaW5rIiwgInBsYXRmb3JtVmlkZW9T aW5rIik7CiAgICAgR3N0RWxlbWVudCogY29sb3JzcGFjZSA9IGdzdF9lbGVtZW50X2ZhY3Rvcnlf bWFrZSgiZmZtcGVnY29sb3JzcGFjZSIsICJjb2xvcnNwYWNlIik7CiAgICAgR3N0RWxlbWVudCog cXVldWUgPSBnc3RfZWxlbWVudF9mYWN0b3J5X21ha2UoInF1ZXVlIiwgInF1ZXVlIik7CkBAIC04 NSw3ICs4Niw3IEBAIGJvb2wgR1N0cmVhbWVyR1dvcmxkOjplbnRlckZ1bGxzY3JlZW4oKQogCiAg ICAgLy8gR2V0IHZpZGVvIHNpbmsgYmluIGFuZCB0aGUgdGVlIGluc2lkZS4KICAgICBHT3duUHRy PEdzdEVsZW1lbnQ+IHZpZGVvU2luazsKLSAgICBnX29iamVjdF9nZXQocGlwZWxpbmUsICJ2aWRl by1zaW5rIiwgJnZpZGVvU2luay5vdXRQdHIoKSwgTlVMTCk7CisgICAgZ19vYmplY3RfZ2V0KG1f cGlwZWxpbmUsICJ2aWRlby1zaW5rIiwgJnZpZGVvU2luay5vdXRQdHIoKSwgTlVMTCk7CiAgICAg R3N0RWxlbWVudCogdGVlID0gZ3N0X2Jpbl9nZXRfYnlfbmFtZShHU1RfQklOKHZpZGVvU2luay5n ZXQoKSksICJ2aWRlb1RlZSIpOwogCiAgICAgLy8gQWRkIGFuZCBsaW5rIGEgcXVldWUsIGZmbXBl Z2NvbG9yc3BhY2UgYW5kIHNpbmsgaW4gdGhlIGJpbi4KQEAgLTExMiw3ICsxMTMsNyBAQCBib29s IEdTdHJlYW1lckdXb3JsZDo6ZW50ZXJGdWxsc2NyZWVuKCkKICAgICAvLyB0aGUgbmV3IHRlZSBi cmFuY2ggZG93bnN0cmVhbS4KIAogICAgIEdzdFF1ZXJ5KiBxdWVyeSA9IGdzdF9xdWVyeV9uZXdf c2VnbWVudChHU1RfRk9STUFUX1RJTUUpOwotICAgIGdib29sZWFuIHF1ZXJ5UmVzdWx0ID0gZ3N0 X2VsZW1lbnRfcXVlcnkocGlwZWxpbmUsIHF1ZXJ5KTsKKyAgICBnYm9vbGVhbiBxdWVyeVJlc3Vs dCA9IGdzdF9lbGVtZW50X3F1ZXJ5KG1fcGlwZWxpbmUsIHF1ZXJ5KTsKIAogICAgIC8vIFNlZSBo dHRwczovL2J1Z3ppbGxhLmdub21lLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjIwNDkwLgogI2lmIEdT VF9DSEVDS19WRVJTSU9OKDAsIDEwLCAzMCkKQEAgLTEyNSw3ICsxMjYsNyBAQCBib29sIEdTdHJl YW1lckdXb3JsZDo6ZW50ZXJGdWxsc2NyZWVuKCkKIAogICAgIEdzdEZvcm1hdCBmb3JtYXQ7CiAg ICAgZ2ludDY0IHBvc2l0aW9uOwotICAgIGlmICghZ3N0X2VsZW1lbnRfcXVlcnlfcG9zaXRpb24o cGlwZWxpbmUsICZmb3JtYXQsICZwb3NpdGlvbikpCisgICAgaWYgKCFnc3RfZWxlbWVudF9xdWVy eV9wb3NpdGlvbihtX3BpcGVsaW5lLCAmZm9ybWF0LCAmcG9zaXRpb24pKQogICAgICAgICBwb3Np dGlvbiA9IDA7CiAKICAgICBnZG91YmxlIHJhdGU7CkBAIC0xNDUsMTEgKzE0Niw5IEBAIHZvaWQg R1N0cmVhbWVyR1dvcmxkOjpleGl0RnVsbHNjcmVlbigpCiAgICAgaWYgKCFtX2R5bmFtaWNQYWRO YW1lKQogICAgICAgICByZXR1cm47CiAKLSAgICBHc3RFbGVtZW50KiBwaXBlbGluZSA9IG1fcGxh eWVyLT5waXBlbGluZSgpOwotCiAgICAgLy8gR2V0IHZpZGVvIHNpbmsgYmluIGFuZCB0aGUgZWxl bWVudHMgdG8gcmVtb3ZlLgogICAgIEdPd25QdHI8R3N0RWxlbWVudD4gdmlkZW9TaW5rOwotICAg IGdfb2JqZWN0X2dldChwaXBlbGluZSwgInZpZGVvLXNpbmsiLCAmdmlkZW9TaW5rLm91dFB0cigp LCBOVUxMKTsKKyAgICBnX29iamVjdF9nZXQobV9waXBlbGluZSwgInZpZGVvLXNpbmsiLCAmdmlk ZW9TaW5rLm91dFB0cigpLCBOVUxMKTsKICAgICBHc3RFbGVtZW50KiB0ZWUgPSBnc3RfYmluX2dl dF9ieV9uYW1lKEdTVF9CSU4odmlkZW9TaW5rLmdldCgpKSwgInZpZGVvVGVlIik7CiAgICAgR3N0 RWxlbWVudCogcGxhdGZvcm1WaWRlb1NpbmsgPSBnc3RfYmluX2dldF9ieV9uYW1lKEdTVF9CSU4o dmlkZW9TaW5rLmdldCgpKSwgInBsYXRmb3JtVmlkZW9TaW5rIik7CiAgICAgR3N0RWxlbWVudCog cXVldWUgPSBnc3RfYmluX2dldF9ieV9uYW1lKEdTVF9CSU4odmlkZW9TaW5rLmdldCgpKSwgInF1 ZXVlIik7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9H U3RyZWFtZXJHV29ybGQuaCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dT dHJlYW1lckdXb3JsZC5oCmluZGV4IDAzNThiMDEuLjY1OTA1MmEgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lckdXb3JsZC5oCisrKyBiL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dTdHJlYW1lckdXb3JsZC5oCkBAIC0y Myw3ICsyMyw2IEBACiAKICNpZiBFTkFCTEUoVklERU8pCiAKLSNpbmNsdWRlICJNZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXIuaCIKICNpbmNsdWRlICJQbGF0Zm9ybVZpZGVvV2luZG93LmgiCiAj aW5jbHVkZSAiUmVmQ291bnRlZC5oIgogI2luY2x1ZGUgIlJlZlB0ci5oIgpAQCAtNDQsMTAgKzQz LDEwIEBAIGNsYXNzIEdTdHJlYW1lckdXb3JsZCA6IHB1YmxpYyBSZWZDb3VudGVkPEdTdHJlYW1l ckdXb3JsZD4gewogICAgIGZyaWVuZCBnYm9vbGVhbiBnc3RHV29ybGRTeW5jTWVzc2FnZUNhbGxi YWNrKEdzdEJ1cyogYnVzLCBHc3RNZXNzYWdlKiBtZXNzYWdlLCBncG9pbnRlciBkYXRhKTsKIAog cHVibGljOgotICAgIHN0YXRpYyBQYXNzUmVmUHRyPEdTdHJlYW1lckdXb3JsZD4gY3JlYXRlR1dv cmxkKE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lciopOworICAgIHN0YXRpYyBQYXNzUmVmUHRy PEdTdHJlYW1lckdXb3JsZD4gY3JlYXRlR1dvcmxkKEdzdEVsZW1lbnQqKTsKICAgICB+R1N0cmVh bWVyR1dvcmxkKCk7CiAKLSAgICBHc3RFbGVtZW50KiBwaXBlbGluZSgpIGNvbnN0IHsgcmV0dXJu IG1fcGxheWVyLT5waXBlbGluZSgpOyB9CisgICAgR3N0RWxlbWVudCogcGlwZWxpbmUoKSBjb25z dCB7IHJldHVybiBtX3BpcGVsaW5lOyB9CiAKICAgICAvLyBSZXR1cm5zIHRoZSBmdWxsLXNjcmVl biB3aW5kb3cgY3JlYXRlZAogICAgIGJvb2wgZW50ZXJGdWxsc2NyZWVuKCk7CkBAIC01Nyw4ICs1 Niw4IEBAIHB1YmxpYzoKICAgICBQbGF0Zm9ybVZpZGVvV2luZG93KiBwbGF0Zm9ybVZpZGVvV2lu ZG93KCkgY29uc3QgeyByZXR1cm4gbV92aWRlb1dpbmRvdy5nZXQoKTsgfQogCiBwcml2YXRlOgot ICAgIEdTdHJlYW1lckdXb3JsZChNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIqKTsKLSAgICBN ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIqIG1fcGxheWVyOworICAgIEdTdHJlYW1lckdXb3Js ZChHc3RFbGVtZW50Kik7CisgICAgR3N0RWxlbWVudCogbV9waXBlbGluZTsKICAgICBSZWZQdHI8 UGxhdGZvcm1WaWRlb1dpbmRvdz4gbV92aWRlb1dpbmRvdzsKICAgICBnY2hhciogbV9keW5hbWlj UGFkTmFtZTsKIH07CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCA5 ZmZmOTg0Li5kOWQyZDk3IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dz dHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisrKyBiL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAK QEAgLTEzODQsNyArMTM4NCw3IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpj cmVhdGVHU1RQbGF5QmluKCkKICAgICBBU1NFUlQoIW1fcGxheUJpbik7CiAgICAgbV9wbGF5Qmlu ID0gZ3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJwbGF5YmluMiIsICJwbGF5Iik7CiAKLSAgICBt X2dzdEdXb3JsZCA9IEdTdHJlYW1lckdXb3JsZDo6Y3JlYXRlR1dvcmxkKHRoaXMpOworICAgIG1f Z3N0R1dvcmxkID0gR1N0cmVhbWVyR1dvcmxkOjpjcmVhdGVHV29ybGQobV9wbGF5QmluKTsKIAog ICAgIEdzdEJ1cyogYnVzID0gZ3N0X3BpcGVsaW5lX2dldF9idXMoR1NUX1BJUEVMSU5FKG1fcGxh eUJpbikpOwogICAgIGdzdF9idXNfYWRkX3NpZ25hbF93YXRjaChidXMpOwotLSAKMS43LjE=