44298 2010-08-19 15:00:16 -0700 Failing the download step should make the build red 2010-08-30 08:40:42 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jamesr webkit-unassigned commit-queue wsiegrist oldest_to_newest 266984 0 jamesr 2010-08-19 15:00:16 -0700 Currently if a test slave's download step fails the build does not go red. This makes it seems like the tests pass on the console view, which is quite dangerous. For example on a recent run of the SnowLeopard Intel Release (WebKit2 tests) bot the download step failed with this stderr: "File 'archives/mac-snowleopard-x86_64-release/65706.zip' not available at master", but the results of the build was "build successful". http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/builds/265 266990 1 wsiegrist 2010-08-19 15:04:01 -0700 FileUpload and FileDownload steps default to not flunking the whole build if they fail. This should be just a 1 line change to add flunkOnFailure=True to DownloadBuiltProduct. 271259 2 65869 jamesr 2010-08-29 19:01:28 -0700 Created attachment 65869 Patch 271286 3 65869 commit-queue 2010-08-29 21:26:22 -0700 Comment on attachment 65869 Patch Clearing flags on attachment: 65869 Committed r66353: <http://trac.webkit.org/changeset/66353> 271287 4 commit-queue 2010-08-29 21:26:26 -0700 All reviewed patches have been landed. Closing bug. 271446 5 wsiegrist 2010-08-30 08:40:42 -0700 Updated master. Graceful restart process has been kicked off. 65869 2010-08-29 19:01:28 -0700 2010-08-29 21:26:22 -0700 Patch bug-44298-20100829190126.patch text/plain 1480 jamesr SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY2MzQ1KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDgtMjkgIEphbWVzIFJvYmluc29uICA8 amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBNYWtlIGZhaWxpbmcgdGhlIGRvd25sb2FkIHN0ZXAgZmFpbCB0aGUgYnVp bGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0Mjk4 CisKKyAgICAgICAgSWYgdGhlIGRvd25sb2FkIHN0ZXAgZmFpbHMgb24gYSB0ZXN0IGJvdCwgdGhp cyBlbnN1cmVzIHRoYXQKKyAgICAgICAgdGhlIGJ1aWxkIGdvZXMgcmVkIGluc3RlYWQgb2Ygb25s eSB0aGUgZG93bmxvYWQgc3RlcCBnb2luZyByZWQKKyAgICAgICAgYW5kIHRoZSBvdmVyYWxsIGJ1 aWxkIHN0YXlpbmcgZ3JlZW4uCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53 ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnOgorCiAyMDEwLTA4LTI4ICBLZXZpbiBPbGxpdmll ciAgPGtldmlub0B0aGVvbGxpdmllcnMuY29tPgogCiAgICAgICAgIFt3eF0gQnVpbGQgZml4IGFm dGVyIGRpcmVjdG9yeSBhZGRpdGlvbi4KSW5kZXg6IFdlYktpdFRvb2xzL0J1aWxkU2xhdmVTdXBw b3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVy LmNmZwkocmV2aXNpb24gNjYyNDQpCisrKyBXZWJLaXRUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9i dWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCSh3b3JraW5nIGNvcHkpCkBAIC0xMzAs NiArMTMwLDcgQEAgY2xhc3MgRG93bmxvYWRCdWlsdFByb2R1Y3QodHJhbnNmZXIuRmlsZQogICAg IHNsYXZlZGVzdCA9IFdpdGhQcm9wZXJ0aWVzKCJXZWJLaXRCdWlsZC8lKGNvbmZpZ3VyYXRpb24p cy56aXAiKQogICAgIG1hc3RlcnNyYyA9IFdpdGhQcm9wZXJ0aWVzKCJhcmNoaXZlcy8lKGZ1bGxQ bGF0Zm9ybSlzLSUoYXJjaGl0ZWN0dXJlKXMtJShjb25maWd1cmF0aW9uKXMvJShnb3RfcmV2aXNp b24pcy56aXAiKQogICAgIGhhbHRPbkZhaWx1cmUgPSBUcnVlCisgICAgZmx1bmtPbkZhaWx1cmUg PSBUcnVlCiAKICAgICBkZWYgX19pbml0X18oc2VsZik6CiAgICAgICAgIHRyYW5zZmVyLkZpbGVE b3dubG9hZC5fX2luaXRfXyhzZWxmLCBzZWxmLm1hc3RlcnNyYywgc2VsZi5zbGF2ZWRlc3QpCg==