44295 2010-08-19 14:41:04 -0700 Insertion point does not show when dragging text into an editable area 2010-09-16 12:42:43 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 21834 44290 1 simon.fraser simon.fraser enrica oldest_to_newest 266974 0 simon.fraser 2010-08-19 14:41:04 -0700 65681 caused the caret to use the last-computed caret rect when painting, rather than forcing a style update. That seems to have changed the drawing of the insertion caret during drag and drop. This affects the pixel results of this test: editing/selection/drag-in-iframe.html 267277 1 simon.fraser 2010-08-20 09:53:27 -0700 <rdar://problem/8335352> 270722 2 simon.fraser 2010-08-27 13:56:36 -0700 My patch fixes the bug interactively, but the caret still doesn't get captured in the pixel result. Interactively, DragController::doSystemDrag() blocks in m_client->startDrag() until the drag is complete. In DRT, it seems to return immediately, so cleanupAfterSystemDrag() resets the drag caret to empty, before the snapshot is taken. 270759 3 65769 simon.fraser 2010-08-27 14:35:01 -0700 Created attachment 65769 Patch 270767 4 65769 enrica 2010-08-27 14:42:21 -0700 Comment on attachment 65769 Patch > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index c8f9bcf61fa93600c1aac821e070adcb3f67a2d9..95357b5dda1f94c6d24ea0838d6d22645fb4a4f8 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -1,5 +1,26 @@ > 2010-08-27 Simon Fraser <simon.fraser@apple.com> > > + Reviewed by NOBODY (OOPS!). > + > + Insertion point does not show when dragging text into an editable area > + https://bugs.webkit.org/show_bug.cgi?id=44295 > + > + r65681 caused the caret to use the last-computed caret rect when > + painting, rather than forcing a style update. Because of this, > + we now need to eagerly update the caret rect when changing > + the drag selection. > + > + Not testable in DRT because the drag selection is always cleared > + before EventSender returns, so the drag caret can never show in > + the pixel results. > + > + Tested by running editing/selection/drag-in-iframe.html manually. > + > + * editing/SelectionController.cpp: > + (WebCore::SelectionController::setSelection): > + > +2010-08-27 Simon Fraser <simon.fraser@apple.com> > + > Reviewed by Tony Chang. > > Crash in CSSStyleSelector.cpp > diff --git a/WebCore/editing/SelectionController.cpp b/WebCore/editing/SelectionController.cpp > index 3672e3e757bfdd87f40395e46004e4dab17e220d..97dde55e3cde543ccf23ea6344de4249ec8311ed 100644 > --- a/WebCore/editing/SelectionController.cpp > +++ b/WebCore/editing/SelectionController.cpp > @@ -118,6 +118,7 @@ void SelectionController::setSelection(const VisibleSelection& s, bool closeTypi > m_selection = s; > m_caretRectNeedsUpdate = true; > invalidateCaretRect(); > + updateCaretRect(); > return; > } > if (!m_frame) { Looks good to me. 270785 5 simon.fraser 2010-08-27 15:50:52 -0700 http://trac.webkit.org/changeset/66269 65769 2010-08-27 14:35:01 -0700 2010-08-27 14:52:15 -0700 Patch bug-44295-20100827143500.patch text/plain 1741 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YzhmOWJjZjYxZmE5MzYwMGMxYWFjODIxZTA3MGFkY2IzZjY3YTJkOS4uOTUzNTdiNWRkYTFmOTRj NmQyNGVhMDgzOGQ2ZDIyNjQ1ZmI0YTRmOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyNiBAQAogMjAxMC0wOC0yNyAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbnNlcnRpb24gcG9pbnQgZG9lcyBub3Qgc2hv dyB3aGVuIGRyYWdnaW5nIHRleHQgaW50byBhbiBlZGl0YWJsZSBhcmVhCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDI5NQorICAgICAgICAKKyAgICAg ICAgcjY1NjgxIGNhdXNlZCB0aGUgY2FyZXQgdG8gdXNlIHRoZSBsYXN0LWNvbXB1dGVkIGNhcmV0 IHJlY3Qgd2hlbgorICAgICAgICBwYWludGluZywgcmF0aGVyIHRoYW4gZm9yY2luZyBhIHN0eWxl IHVwZGF0ZS4gQmVjYXVzZSBvZiB0aGlzLAorICAgICAgICB3ZSBub3cgbmVlZCB0byBlYWdlcmx5 IHVwZGF0ZSB0aGUgY2FyZXQgcmVjdCB3aGVuIGNoYW5naW5nCisgICAgICAgIHRoZSBkcmFnIHNl bGVjdGlvbi4KKyAgICAgICAgCisgICAgICAgIE5vdCB0ZXN0YWJsZSBpbiBEUlQgYmVjYXVzZSB0 aGUgZHJhZyBzZWxlY3Rpb24gaXMgYWx3YXlzIGNsZWFyZWQKKyAgICAgICAgYmVmb3JlIEV2ZW50 U2VuZGVyIHJldHVybnMsIHNvIHRoZSBkcmFnIGNhcmV0IGNhbiBuZXZlciBzaG93IGluCisgICAg ICAgIHRoZSBwaXhlbCByZXN1bHRzLgorCisgICAgICAgIFRlc3RlZCBieSBydW5uaW5nIGVkaXRp bmcvc2VsZWN0aW9uL2RyYWctaW4taWZyYW1lLmh0bWwgbWFudWFsbHkuCisKKyAgICAgICAgKiBl ZGl0aW5nL1NlbGVjdGlvbkNvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VsZWN0 aW9uQ29udHJvbGxlcjo6c2V0U2VsZWN0aW9uKToKKworMjAxMC0wOC0yNyAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBieSBUb255IENo YW5nLgogCiAgICAgICAgIENyYXNoIGluIENTU1N0eWxlU2VsZWN0b3IuY3BwCmRpZmYgLS1naXQg YS9XZWJDb3JlL2VkaXRpbmcvU2VsZWN0aW9uQ29udHJvbGxlci5jcHAgYi9XZWJDb3JlL2VkaXRp bmcvU2VsZWN0aW9uQ29udHJvbGxlci5jcHAKaW5kZXggMzY3MmUzZTc1N2JmZGQ4N2Y0MDM5NWU0 NjAwNGU0ZGFiMTdlMjIwZC4uOTdkZGU1NWUzY2RlNTQzY2NmMjNlYTYzNDRkZTQyNDllYzgzMTFl ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9lZGl0aW5nL1NlbGVjdGlvbkNvbnRyb2xsZXIuY3BwCisr KyBiL1dlYkNvcmUvZWRpdGluZy9TZWxlY3Rpb25Db250cm9sbGVyLmNwcApAQCAtMTE4LDYgKzEx OCw3IEBAIHZvaWQgU2VsZWN0aW9uQ29udHJvbGxlcjo6c2V0U2VsZWN0aW9uKGNvbnN0IFZpc2li bGVTZWxlY3Rpb24mIHMsIGJvb2wgY2xvc2VUeXBpCiAgICAgICAgIG1fc2VsZWN0aW9uID0gczsK ICAgICAgICAgbV9jYXJldFJlY3ROZWVkc1VwZGF0ZSA9IHRydWU7CiAgICAgICAgIGludmFsaWRh dGVDYXJldFJlY3QoKTsKKyAgICAgICAgdXBkYXRlQ2FyZXRSZWN0KCk7CiAgICAgICAgIHJldHVy bjsKICAgICB9CiAgICAgaWYgKCFtX2ZyYW1lKSB7Cg==