44294 2010-08-19 14:39:14 -0700 After r65681, caret no longer displays promptly while editing form fields 2010-09-16 12:42:43 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 21834 44290 1 simon.fraser simon.fraser abarth enrica eric webkit.review.bot oldest_to_newest 266973 0 simon.fraser 2010-08-19 14:39:14 -0700 r65681 caused the caret to use the last-computed caret rect when painting, rather than forcing a style update. That seems to have changed the drawing of the caret in the middle of editing. This testcase shows a pixel difference as a result: fast/forms/input-text-scroll-left-on-blur.html 266989 1 simon.fraser 2010-08-19 15:03:53 -0700 Hmm, this only seems to be when you hit the end of the field and start to scroll. 267278 2 simon.fraser 2010-08-20 09:53:36 -0700 <rdar://problem/8335354> 267434 3 64995 simon.fraser 2010-08-20 14:46:42 -0700 Created attachment 64995 Patch 267930 4 enrica 2010-08-23 08:50:38 -0700 This looks good to me. 268777 5 simon.fraser 2010-08-24 14:02:10 -0700 http://trac.webkit.org/changeset/65934 268814 6 webkit.review.bot 2010-08-24 14:46:46 -0700 http://trac.webkit.org/changeset/65934 might have broken Leopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/65933 http://trac.webkit.org/changeset/65934 64995 2010-08-20 14:46:42 -0700 2010-08-23 09:39:09 -0700 Patch bug-44294-20100820144641.patch text/plain 1711 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Nzk5ODk3NWVjMzQxOTEyODk2Zjg4NWZiNDU0YzVlNDhiYTc1MDY3Yy4uNDQ3NjVkNjgwYjc0M2Rj ODYyNTI2MTQzZGZlY2U0Y2RkZTZmOGYyNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wOC0yMCAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZnRlciByNjU2ODEsIGNhcmV0IG5vIGxvbmdl ciBkaXNwbGF5cyBwcm9tcHRseSB3aGlsZSBlZGl0aW5nIGZvcm0gZmllbGRzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDI5NAorICAgICAgICAKKyAg ICAgICAgVGhlIGNhcmV0IG5vIGxvbmdlciBlYWdlcmx5IHVwZGF0ZXMgaXRzIHJlY3Qgb24gZXZl cnkgcGFpbnQsIHNvIHdlIGhhdmUKKyAgICAgICAgdG8gbWFudWFsbHkgdXBkYXRlIGl0IGFmdGVy IHNjcm9sbGluZyB0aGUgc2VsZWN0aW9uIGludG8gdmlldyB3aGVuCisgICAgICAgIHRoZSBzZWxl Y3Rpb24gY2hhbmdlcy4KKyAgICAgICAgCisgICAgICAgIFRlc3RlZCBieSB0aGUgcGl4ZWwgcmVz dWx0cyBvZiBmYXN0L2Zvcm1zL2lucHV0LXRleHQtc2Nyb2xsLWxlZnQtb24tYmx1ci5odG1sCisK KyAgICAgICAgKiBwYWdlL0ZyYW1lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lOjpyZXZl YWxTZWxlY3Rpb24pOgorCiAyMDEwLTA4LTE5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9XZWJD b3JlL3BhZ2UvRnJhbWUuY3BwIGIvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAppbmRleCAxNjVhYTMy N2ZkZDQzYjg5MTBlZjgwODkxOWU4ODg2OTVlOWFjNWFkLi44MDBhYWU2ZWU3NzFjNWFiYTZkMDE2 MTJmNTkwMTQxM2M5ZmM4MWEzIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvRnJhbWUuY3BwCisr KyBiL1dlYkNvcmUvcGFnZS9GcmFtZS5jcHAKQEAgLTEwODIsOCArMTA4MiwxMCBAQCB2b2lkIEZy YW1lOjpyZXZlYWxTZWxlY3Rpb24oY29uc3QgU2Nyb2xsQWxpZ25tZW50JiBhbGlnbm1lbnQsIGJv b2wgcmV2ZWFsRXh0ZW50KQogICAgICAgICAvLyBGSVhNRTogVGhpcyBjb2RlIG9ubHkgaGFuZGxl cyBzY3JvbGxpbmcgdGhlIHN0YXJ0Q29udGFpbmVyJ3MgbGF5ZXIsIGJ1dAogICAgICAgICAvLyB0 aGUgc2VsZWN0aW9uIHJlY3QgY291bGQgaW50ZXJzZWN0IG1vcmUgdGhhbiBqdXN0IHRoYXQuCiAg ICAgICAgIC8vIFNlZSA8cmRhcjovL3Byb2JsZW0vNDc5OTg5OT4uCi0gICAgICAgIGlmIChSZW5k ZXJMYXllciogbGF5ZXIgPSBzdGFydC5ub2RlKCktPnJlbmRlcmVyKCktPmVuY2xvc2luZ0xheWVy KCkpCisgICAgICAgIGlmIChSZW5kZXJMYXllciogbGF5ZXIgPSBzdGFydC5ub2RlKCktPnJlbmRl cmVyKCktPmVuY2xvc2luZ0xheWVyKCkpIHsKICAgICAgICAgICAgIGxheWVyLT5zY3JvbGxSZWN0 VG9WaXNpYmxlKHJlY3QsIGZhbHNlLCBhbGlnbm1lbnQsIGFsaWdubWVudCk7CisgICAgICAgICAg ICBzZWxlY3Rpb24oKS0+dXBkYXRlQXBwZWFyYW5jZSgpOworICAgICAgICB9CiAgICAgfQogfQog Cg==