44279 2010-08-19 11:33:18 -0700 [CHROMIUM] Assert w/canvas image draw 2010-08-19 16:43:42 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco abarth eric fishd jamesr kbr webkit.review.bot oldest_to_newest 266858 0 senorblanco 2010-08-19 11:33:18 -0700 Open http://ie.microsoft.com/testdrive/Performance/HamsterDanceRevolution/Default.html in a Debug Win chrome build w/--enable-accelerated-compositing and --enable-accelerated-2d-canvas Start game, assert in ImageSkia.cpp:422. Open LayoutTests/fast/canvas/arc360.html No arc is drawn. 266869 1 64882 senorblanco 2010-08-19 11:49:05 -0700 Created attachment 64882 Patch 266896 2 jamesr 2010-08-19 12:34:17 -0700 I'm not a reviewer, but this looks great to me. 266918 3 64882 kbr 2010-08-19 13:14:05 -0700 Comment on attachment 64882 Patch Looks good to me. 266954 4 senorblanco 2010-08-19 14:13:43 -0700 Committed r65700: <http://trac.webkit.org/changeset/65700> 267043 5 webkit.review.bot 2010-08-19 16:43:42 -0700 http://trac.webkit.org/changeset/65700 might have broken SnowLeopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/65699 http://trac.webkit.org/changeset/65700 http://trac.webkit.org/changeset/65701 http://trac.webkit.org/changeset/65702 http://trac.webkit.org/changeset/65703 http://trac.webkit.org/changeset/65704 http://trac.webkit.org/changeset/65705 http://trac.webkit.org/changeset/65706 http://trac.webkit.org/changeset/65707 http://trac.webkit.org/changeset/65708 http://trac.webkit.org/changeset/65709 http://trac.webkit.org/changeset/65710 http://trac.webkit.org/changeset/65711 http://trac.webkit.org/changeset/65712 http://trac.webkit.org/changeset/65713 64882 2010-08-19 11:49:05 -0700 2010-08-19 13:14:05 -0700 Patch bug-44279-20100819144903.patch text/plain 3625 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NTY4NikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzAgQEAKKzIwMTAtMDgtMTkgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgW0NIUk9NSVVNXSBBc3NlcnQgdy9jYW52YXMgaW1hZ2UgZHJhdworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQyNzkKKworICAgICAgICBEb24n dCB1c2UgYml0bWFwLT5waXhlbFJlZigpLT5nZXRQaXhlbHMoKSBkaXJlY3RseTsgcHJlZmVyCisg ICAgICAgIGJpdG1hcC0+cGl4ZWxzKCkgYW5kIGFuIFNrQXV0b0xvY2tQaXhlbHMuICBBbHNvLCBt YWtlIHN1cmUgdG8gc2V0CisgICAgICAgIHRoZSBiYWNraW5nIHN0b3JlIHN0YXRlIHRvIFNvZnR3 YXJlIHdoZW4gaXQgd2FzIE5vbmUuICBUaGlzIGhhbmRsZXMKKyAgICAgICAgbWlzc2luZyBkcmF3 cyB3aGVuIHRoZSBmaXJzdCBjYWxsIGlzIHNvZnR3YXJlLiAgRmluYWxseSwgcmVtb3ZlIHNvbWUK KyAgICAgICAgc3B1cmlvdXMgcHJlcGFyZUZvclNvZnR3YXJlRHJhdygpIGNhbGxzIGluIGFkZFBh dGgoKSBhbmQgYmVnaW5QYXRoKCkuCisgICAgICAgIEl0J3MgcmVhbGx5IHRoZSBmaWxsUGF0aCgp IG9yIHN0cm9rZVBhdGgoKSB0aGF0IG1hdHRlcnMuCisKKyAgICAgICAgQ292ZXJlZCBieSBMYXlv dXRUZXN0cy9mYXN0L2NhbnZhcy9hcmMzNjAuaHRtbCBhbmQgb3RoZXJzLgorCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6YWRkUGF0aCk6CisgICAgICAgIChXZWJDb3JlOjpH cmFwaGljc0NvbnRleHQ6OmJlZ2luUGF0aCk6CisgICAgICAgIFJlbW92ZSBzcHVyaW91cyBwcmVw YXJlRm9yU29mdHdhcmVEcmF3KCkgY2FsbHMuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv c2tpYS9JbWFnZVNraWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6ZHJhd0JpdG1hcEdMRVMyKToK KyAgICAgICAgTG9jayBTa0JpdG1hcCdzIHBpeGVscywgYW5kIHVzZSAtPmdldFBpeGVscygpLgor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9ybUNvbnRleHRTa2lhOjpwcmVwYXJlRm9yU29mdHdh cmVEcmF3KToKKyAgICAgICAgU3dpdGNoIGJhY2tpbmcgc3RvcmUgc3RhdGUgdG8gU29mdHdhcmUg d2hlbiBpdCB3YXMgTm9uZS4KKwogMjAxMC0wOC0xOSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJh c2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggQ2hyb21pdW0gYnVpbGQuCkluZGV4OiBXZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFNr aWEuY3BwCShyZXZpc2lvbiA2NTY4NCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tp YS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzIzLDcgKzMyMyw2 IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjphZGRQYXRoKGNvbnN0IFBhdGgKIHsKICAgICBpZiAo cGFpbnRpbmdEaXNhYmxlZCgpKQogICAgICAgICByZXR1cm47Ci0gICAgcGxhdGZvcm1Db250ZXh0 KCktPnByZXBhcmVGb3JTb2Z0d2FyZURyYXcoKTsKICAgICBwbGF0Zm9ybUNvbnRleHQoKS0+YWRk UGF0aCgqcGF0aC5wbGF0Zm9ybVBhdGgoKSk7CiB9CiAKQEAgLTMzMSw3ICszMzAsNiBAQCB2b2lk IEdyYXBoaWNzQ29udGV4dDo6YmVnaW5QYXRoKCkKIHsKICAgICBpZiAocGFpbnRpbmdEaXNhYmxl ZCgpKQogICAgICAgICByZXR1cm47Ci0gICAgcGxhdGZvcm1Db250ZXh0KCktPnByZXBhcmVGb3JT b2Z0d2FyZURyYXcoKTsKICAgICBwbGF0Zm9ybUNvbnRleHQoKS0+YmVnaW5QYXRoKCk7CiB9CiAK SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZVNraWEuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZVNraWEuY3BwCShy ZXZpc2lvbiA2NTY4NCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZVNr aWEuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MTksOCArNDE5LDkgQEAgc3RhdGljIHZvaWQgZHJh d0JpdG1hcEdMRVMyKEdyYXBoaWNzQ29udAogICAgICAgICBBU1NFUlQoYml0bWFwLT5jb25maWco KSA9PSBTa0JpdG1hcDo6a0FSR0JfODg4OF9Db25maWcpOwogICAgICAgICBBU1NFUlQoYml0bWFw LT5yb3dCeXRlcygpID09IGJpdG1hcC0+d2lkdGgoKSAqIDQpOwogICAgICAgICB0ZXh0dXJlID0g Z3B1Q2FudmFzLT5jcmVhdGVUZXh0dXJlKGJpdG1hcCwgR0xFUzJUZXh0dXJlOjpCR1JBOCwgYml0 bWFwLT53aWR0aCgpLCBiaXRtYXAtPmhlaWdodCgpKTsKLSAgICAgICAgQVNTRVJUKGJpdG1hcC0+ cGl4ZWxSZWYoKSk7Ci0gICAgICAgIHRleHR1cmUtPmxvYWQoYml0bWFwLT5waXhlbFJlZigpLT5w aXhlbHMoKSk7CisgICAgICAgIFNrQXV0b0xvY2tQaXhlbHMgbG9jaygqYml0bWFwKTsKKyAgICAg ICAgQVNTRVJUKGJpdG1hcC0+Z2V0UGl4ZWxzKCkpOworICAgICAgICB0ZXh0dXJlLT5sb2FkKGJp dG1hcC0+Z2V0UGl4ZWxzKCkpOwogICAgIH0KICAgICBncHVDYW52YXMtPmRyYXdUZXh0dXJlZFJl Y3QodGV4dHVyZSwgc3JjUmVjdCwgZHN0UmVjdCwgc3R5bGVDb2xvclNwYWNlLCBjb21wb3NpdGVP cCk7CiB9CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250 ZXh0U2tpYS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lh L1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCShyZXZpc2lvbiA2NTY4NCkKKysrIFdlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNzUzLDYgKzc1Myw4IEBAIHZvaWQgUGxhdGZvcm1Db250ZXh0U2tpYTo6cHJlcGFyZUZv clNvZnQKICAgICAgICAgICAgIHJlYWRiYWNrSGFyZHdhcmVUb1NvZnR3YXJlKCk7CiAgICAgICAg ICAgICBtX2JhY2tpbmdTdG9yZVN0YXRlID0gU29mdHdhcmU7CiAgICAgICAgIH0KKyAgICB9IGVs c2UgaWYgKG1fYmFja2luZ1N0b3JlU3RhdGUgPT0gTm9uZSkgeworICAgICAgICBtX2JhY2tpbmdT dG9yZVN0YXRlID0gU29mdHdhcmU7CiAgICAgfQogfQogCg==