44273 2010-08-19 10:30:59 -0700 Web Inspector: fall back to object formatting in case dom is not yet loaded. 2010-12-20 23:25:48 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 266810 0 pfeldman 2010-08-19 10:30:59 -0700 Sometimes DOM is loaded after the inline message is being formatted, so we get no nodeId for it. Let us fall back to object formatting in such cases. Patch to follow. 266811 1 64868 pfeldman 2010-08-19 10:32:53 -0700 Created attachment 64868 [PATCH] Proposed change. 266812 2 64868 yurys 2010-08-19 10:34:26 -0700 Comment on attachment 64868 [PATCH] Proposed change. WebCore/ChangeLog:10 + Patch to follow. Remove this from changelog. WebCore/inspector/front-end/ConsoleView.js:663 + console.log(JSON.stringify(parameters)); Remove this as well. 266814 3 64869 pfeldman 2010-08-19 10:34:40 -0700 Created attachment 64869 [PATCH] Proposed change. 324797 4 64869 eric 2010-12-20 22:30:42 -0800 Comment on attachment 64869 [PATCH] Proposed change. Looks abandoned. Maybe it never got committed? 324861 5 64869 commit-queue 2010-12-20 23:25:42 -0800 Comment on attachment 64869 [PATCH] Proposed change. Clearing flags on attachment: 64869 Committed r74399: <http://trac.webkit.org/changeset/74399> 324862 6 commit-queue 2010-12-20 23:25:48 -0800 All reviewed patches have been landed. Closing bug. 64868 2010-08-19 10:32:53 -0700 2010-08-19 10:34:40 -0700 [PATCH] Proposed change. patch text/plain 2605 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg N2ZlMzU5Zi4uMTdjZjhlMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wOC0xOSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBmYWxsIGJhY2sgdG8gb2JqZWN0IGZv cm1hdHRpbmcgaW4gY2FzZSBkb20gaXMgbm90IHlldCBsb2FkZWQuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDI3MworCisgICAgICAgIFNvbWV0aW1l cyBET00gaXMgbG9hZGVkIGFmdGVyIHRoZSBpbmxpbmUgbWVzc2FnZSBpcyBiZWluZyBmb3JtYXR0 ZWQsIHNvIHdlIGdldAorICAgICAgICBubyBub2RlSWQgZm9yIGl0LiBMZXQgdXMgZmFsbCBiYWNr IHRvIG9iamVjdCBmb3JtYXR0aW5nIGluIHN1Y2ggY2FzZXMuCisgICAgICAgIFBhdGNoIHRvIGZv bGxvdy4KKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAgICAgICAqIGluc3Bl Y3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29u c29sZVZpZXcucHJvdG90eXBlLl9mb3JtYXRub2RlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5D b25zb2xlTWVzc2FnZSk6CisKIDIwMTAtMDgtMTkgIEFuZHJlaSBQb3Blc2N1ICA8YW5kcmVpcEBn b29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxvdy4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qcyBiL1dlYkNvcmUv aW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qcwppbmRleCA0NzRjMzYyLi42ZDdlZTIx IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMK KysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCkBAIC01NzQs MTIgKzU3NCwxNiBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlID0gewogICAg ICAgICBlbGVtLmFwcGVuZENoaWxkKG5ldyBXZWJJbnNwZWN0b3IuT2JqZWN0UHJvcGVydGllc1Nl Y3Rpb24ob2JqLCBvYmouZGVzY3JpcHRpb24sIG51bGwsIHRydWUpLmVsZW1lbnQpOwogICAgIH0s CiAKLSAgICBfZm9ybWF0bm9kZTogZnVuY3Rpb24ob2JqZWN0LCBlbGVtKQorICAgIF9mb3JtYXRu b2RlOiBmdW5jdGlvbihvYmplY3QsIGVsZW0sIGxhc3RBdHRlbXB0KQogICAgIHsKICAgICAgICAg ZnVuY3Rpb24gcHJpbnROb2RlKG5vZGVJZCkKICAgICAgICAgewotICAgICAgICAgICAgaWYgKCFu b2RlSWQpCisgICAgICAgICAgICBpZiAoIW5vZGVJZCkgeworICAgICAgICAgICAgICAgIC8vIFNv bWV0aW1lcyBET00gaXMgbG9hZGVkIGFmdGVyIHRoZSBzeW5jIG1lc3NhZ2UgaXMgYmVpbmcgZm9y bWF0dGVkLCBzbyB3ZSBnZXQgbm8KKyAgICAgICAgICAgICAgICAvLyBub2RlSWQgaGVyZS4gU28g d2UgZmFsbCBiYWNrIHRvIG9iamVjdCBmb3JtYXR0aW5nIGhlcmUuCisgICAgICAgICAgICAgICAg dGhpcy5fZm9ybWF0b2JqZWN0KG9iamVjdCwgZWxlbSk7CiAgICAgICAgICAgICAgICAgcmV0dXJu OworICAgICAgICAgICAgfQogICAgICAgICAgICAgdmFyIHRyZWVPdXRsaW5lID0gbmV3IFdlYklu c3BlY3Rvci5FbGVtZW50c1RyZWVPdXRsaW5lKCk7CiAgICAgICAgICAgICB0cmVlT3V0bGluZS5z aG93SW5FbGVtZW50c1BhbmVsRW5hYmxlZCA9IHRydWU7CiAgICAgICAgICAgICB0cmVlT3V0bGlu ZS5yb290RE9NTm9kZSA9IFdlYkluc3BlY3Rvci5kb21BZ2VudC5ub2RlRm9ySWQobm9kZUlkKTsK QEAgLTU4OCw4ICs1OTIsNyBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlID0g ewogICAgICAgICAgICAgICAgIHRyZWVPdXRsaW5lLmVsZW1lbnQuYWRkU3R5bGVDbGFzcygic2lu Z2xlLW5vZGUiKTsKICAgICAgICAgICAgIGVsZW0uYXBwZW5kQ2hpbGQodHJlZU91dGxpbmUuZWxl bWVudCk7CiAgICAgICAgIH0KLQotICAgICAgICBvYmplY3QucHVzaE5vZGVUb0Zyb250ZW5kKHBy aW50Tm9kZSk7CisgICAgICAgIG9iamVjdC5wdXNoTm9kZVRvRnJvbnRlbmQocHJpbnROb2RlLmJp bmQodGhpcykpOwogICAgIH0sCiAKICAgICBfZm9ybWF0YXJyYXk6IGZ1bmN0aW9uKGFyciwgZWxl bSkKQEAgLTY1Nyw2ICs2NjAsNyBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZU1lc3NhZ2UgPSBmdW5j dGlvbihzb3VyY2UsIHR5cGUsIGxldmVsLCBsaW5lLCB1cmwsIGdyb3VwTGV2ZQogICAgIHRoaXMu dG90YWxSZXBlYXRDb3VudCA9IHJlcGVhdENvdW50OwogICAgIHRoaXMuX21lc3NhZ2VUZXh0ID0g bWVzc2FnZTsKICAgICB0aGlzLl9wYXJhbWV0ZXJzID0gcGFyYW1ldGVyczsKK2NvbnNvbGUubG9n KEpTT04uc3RyaW5naWZ5KHBhcmFtZXRlcnMpKTsKICAgICB0aGlzLl9zdGFja1RyYWNlID0gc3Rh Y2tUcmFjZTsKICAgICB0aGlzLl9mb3JtYXRNZXNzYWdlKCk7CiB9Cg== 64869 2010-08-19 10:34:40 -0700 2010-12-20 23:25:41 -0800 [PATCH] Proposed change. patch text/plain 2007 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg N2ZlMzU5Zi4uOWNmN2FkYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wOC0xOSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBmYWxsIGJhY2sgdG8gb2JqZWN0IGZv cm1hdHRpbmcgaW4gY2FzZSBkb20gaXMgbm90IHlldCBsb2FkZWQuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDI3MworCisgICAgICAgIFNvbWV0aW1l cyBET00gaXMgbG9hZGVkIGFmdGVyIHRoZSBpbmxpbmUgbWVzc2FnZSBpcyBiZWluZyBmb3JtYXR0 ZWQsIHNvIHdlIGdldAorICAgICAgICBubyBub2RlSWQgZm9yIGl0LiBMZXQgdXMgZmFsbCBiYWNr IHRvIG9iamVjdCBmb3JtYXR0aW5nIGluIHN1Y2ggY2FzZXMuCisKKyAgICAgICAgKiBpbnNwZWN0 b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNv bGVWaWV3LnByb3RvdHlwZS5fZm9ybWF0bm9kZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29u c29sZU1lc3NhZ2UpOgorCiAyMDEwLTA4LTE5ICBBbmRyZWkgUG9wZXNjdSAgPGFuZHJlaXBAZ29v Z2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBKZXJlbXkgT3Jsb3cuCmRpZmYgLS1naXQg YS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMgYi9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMKaW5kZXggNDc0YzM2Mi4uNWM3ZTYyYSAx MDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCisr KyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Db25zb2xlVmlldy5qcwpAQCAtNTc4LDgg KzU3OCwxMiBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlID0gewogICAgIHsK ICAgICAgICAgZnVuY3Rpb24gcHJpbnROb2RlKG5vZGVJZCkKICAgICAgICAgewotICAgICAgICAg ICAgaWYgKCFub2RlSWQpCisgICAgICAgICAgICBpZiAoIW5vZGVJZCkgeworICAgICAgICAgICAg ICAgIC8vIFNvbWV0aW1lcyBET00gaXMgbG9hZGVkIGFmdGVyIHRoZSBzeW5jIG1lc3NhZ2UgaXMg YmVpbmcgZm9ybWF0dGVkLCBzbyB3ZSBnZXQgbm8KKyAgICAgICAgICAgICAgICAvLyBub2RlSWQg aGVyZS4gU28gd2UgZmFsbCBiYWNrIHRvIG9iamVjdCBmb3JtYXR0aW5nIGhlcmUuCisgICAgICAg ICAgICAgICAgdGhpcy5fZm9ybWF0b2JqZWN0KG9iamVjdCwgZWxlbSk7CiAgICAgICAgICAgICAg ICAgcmV0dXJuOworICAgICAgICAgICAgfQogICAgICAgICAgICAgdmFyIHRyZWVPdXRsaW5lID0g bmV3IFdlYkluc3BlY3Rvci5FbGVtZW50c1RyZWVPdXRsaW5lKCk7CiAgICAgICAgICAgICB0cmVl T3V0bGluZS5zaG93SW5FbGVtZW50c1BhbmVsRW5hYmxlZCA9IHRydWU7CiAgICAgICAgICAgICB0 cmVlT3V0bGluZS5yb290RE9NTm9kZSA9IFdlYkluc3BlY3Rvci5kb21BZ2VudC5ub2RlRm9ySWQo bm9kZUlkKTsKQEAgLTU4OCw4ICs1OTIsNyBAQCBXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJv dG90eXBlID0gewogICAgICAgICAgICAgICAgIHRyZWVPdXRsaW5lLmVsZW1lbnQuYWRkU3R5bGVD bGFzcygic2luZ2xlLW5vZGUiKTsKICAgICAgICAgICAgIGVsZW0uYXBwZW5kQ2hpbGQodHJlZU91 dGxpbmUuZWxlbWVudCk7CiAgICAgICAgIH0KLQotICAgICAgICBvYmplY3QucHVzaE5vZGVUb0Zy b250ZW5kKHByaW50Tm9kZSk7CisgICAgICAgIG9iamVjdC5wdXNoTm9kZVRvRnJvbnRlbmQocHJp bnROb2RlLmJpbmQodGhpcykpOwogICAgIH0sCiAKICAgICBfZm9ybWF0YXJyYXk6IGZ1bmN0aW9u KGFyciwgZWxlbSkK