44269 2010-08-19 09:06:33 -0700 NetscapePlugin.h contains functions that should be in NetscapePluginWin.cpp 2010-08-19 16:43:57 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Windows XP RESOLVED FIXED InRadar, PlatformOnly P2 Normal --- 43189 1 aroben aroben abarth eric webkit.review.bot oldest_to_newest 266772 0 aroben 2010-08-19 09:06:33 -0700 NetscapePlugin.h contains functions that should be in NetscapePluginWin.cpp 266774 1 64861 aroben 2010-08-19 09:07:23 -0700 Created attachment 64861 Patch 266775 2 webkit.review.bot 2010-08-19 09:09:51 -0700 Attachment 64861 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 266833 3 aroben 2010-08-19 11:06:05 -0700 <rdar://problem/8330391> 266958 4 aroben 2010-08-19 14:26:31 -0700 Committed r65702: <http://trac.webkit.org/changeset/65702> 267045 5 webkit.review.bot 2010-08-19 16:43:57 -0700 http://trac.webkit.org/changeset/65702 might have broken SnowLeopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/65699 http://trac.webkit.org/changeset/65700 http://trac.webkit.org/changeset/65701 http://trac.webkit.org/changeset/65702 http://trac.webkit.org/changeset/65703 http://trac.webkit.org/changeset/65704 http://trac.webkit.org/changeset/65705 http://trac.webkit.org/changeset/65706 http://trac.webkit.org/changeset/65707 http://trac.webkit.org/changeset/65708 http://trac.webkit.org/changeset/65709 http://trac.webkit.org/changeset/65710 http://trac.webkit.org/changeset/65711 http://trac.webkit.org/changeset/65712 http://trac.webkit.org/changeset/65713 64861 2010-08-19 09:07:23 -0700 2010-08-19 09:27:51 -0700 Patch bug-44269-20100819120729.patch text/plain 5885 aroben ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg ODQ4ODA4MGI5MTBlNjg5Yzg1NGUxODllODBhZGJmOGQ4NmUxMjE3NS4uOGEzOTc2ZjUwMWU4NTQ5 MjdhZjc1N2JkOWFlNzZmOGM0YmFiNDNkZiAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wOC0xOSAgQWRh bSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIE5ldHNjYXBlUGx1Z2lu V2luLmNwcAorCisgICAgICAgIEZpeGVzIDxodHRwOi8vd2Via2l0Lm9yZy9iLzQ0MjY5PiBOZXRz Y2FwZVBsdWdpbi5oIGNvbnRhaW5zIGZ1bmN0aW9ucworICAgICAgICB0aGF0IHNob3VsZCBiZSBp biBOZXRzY2FwZVBsdWdpbldpbi5jcHAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBs dWdpbi5oOiBNb3ZlZCBmdW5jdGlvbnMgZnJvbQorICAgICAgICBoZXJlLi4uCisgICAgICAgICog V2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL3dpbi9OZXRzY2FwZVBsdWdpbldpbi5jcHA6IC4u LnRvIGhlcmUuCisKKyAgICAgICAgKiB3aW4vV2ViS2l0Mi52Y3Byb2o6IEFkZGVkIE5ldHNjYXBl UGx1Z2luV2luLmNwcCBhbmQgbGV0IFZTIHJlb3JkZXIKKyAgICAgICAgdGhlIGZpbGUgbGlzdC4K KwogMjAxMC0wOC0xOCAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEpvbiBIb25leWN1dHQuCmRpZmYgLS1naXQgYS9XZWJLaXQyL1dlYlByb2Nlc3Mv UGx1Z2lucy9OZXRzY2FwZS9OZXRzY2FwZVBsdWdpbi5oIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1Bs dWdpbnMvTmV0c2NhcGUvTmV0c2NhcGVQbHVnaW4uaAppbmRleCBjYjRkMTJkNmMwYWZmYTcwMDVm M2RiMWM3YTg2YmUyY2Y3NWYyOWNiLi4wMDhkODc2OTE1Y2M2ZDZkMGUzYmZmMGE1Yzc0N2ZhOGNk MTNjNGZiIDEwMDY0NAotLS0gYS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9OZXRzY2FwZS9O ZXRzY2FwZVBsdWdpbi5oCisrKyBiL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBl L05ldHNjYXBlUGx1Z2luLmgKQEAgLTE2Nyw0MyArMTY3LDYgQEAgcHJpdmF0ZToKICNlbmRpZgog fTsKIAotLy8gTW92ZSB0aGVzZSBmdW5jdGlvbnMgdG8gTmV0c2NhcGVQbHVnaW5XaW4uY3BwCi0j aWYgIVBMQVRGT1JNKE1BQykKLWlubGluZSBib29sIE5ldHNjYXBlUGx1Z2luOjpwbGF0Zm9ybVBv c3RJbml0aWFsaXplKCkKLXsKLSAgICByZXR1cm4gdHJ1ZTsKLX0KLQotaW5saW5lIHZvaWQgTmV0 c2NhcGVQbHVnaW46OnBsYXRmb3JtUGFpbnQoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0KiwgY29u c3QgV2ViQ29yZTo6SW50UmVjdCYpCi17Ci19Ci0KLWlubGluZSBib29sIE5ldHNjYXBlUGx1Z2lu OjpwbGF0Zm9ybUhhbmRsZU1vdXNlRXZlbnQoY29uc3QgV2ViTW91c2VFdmVudCYpCi17Ci0gICAg cmV0dXJuIGZhbHNlOwotfQotCi1pbmxpbmUgYm9vbCBOZXRzY2FwZVBsdWdpbjo6cGxhdGZvcm1I YW5kbGVXaGVlbEV2ZW50KGNvbnN0IFdlYldoZWVsRXZlbnQmKQotewotICAgIHJldHVybiBmYWxz ZTsKLX0KLQotaW5saW5lIHZvaWQgTmV0c2NhcGVQbHVnaW46OnBsYXRmb3JtU2V0Rm9jdXMoYm9v bCkKLXsKLX0KLQotaW5saW5lIGJvb2wgTmV0c2NhcGVQbHVnaW46OnBsYXRmb3JtSGFuZGxlTW91 c2VFbnRlckV2ZW50KGNvbnN0IFdlYk1vdXNlRXZlbnQmKQotewotICAgIHJldHVybiBmYWxzZTsK LX0KLQotaW5saW5lIGJvb2wgTmV0c2NhcGVQbHVnaW46OnBsYXRmb3JtSGFuZGxlTW91c2VMZWF2 ZUV2ZW50KGNvbnN0IFdlYk1vdXNlRXZlbnQmKQotewotICAgIHJldHVybiBmYWxzZTsKLX0KLQot I2VuZGlmCi0KIH0gLy8gbmFtZXNwYWNlIFdlYktpdAogCiAjZW5kaWYgLy8gTmV0c2NhcGVQbHVn aW5faApkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvTmV0c2NhcGUvd2lu L05ldHNjYXBlUGx1Z2luV2luLmNwcCBiL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL05ldHNj YXBlL3dpbi9OZXRzY2FwZVBsdWdpbldpbi5jcHAKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZGI4NmRiNjY3M2M4ODIz MTBlMDFhZTgxODQxOWI4NjE0ZWVmMjY4ZQotLS0gL2Rldi9udWxsCisrKyBiL1dlYktpdDIvV2Vi UHJvY2Vzcy9QbHVnaW5zL05ldHNjYXBlL3dpbi9OZXRzY2FwZVBsdWdpbldpbi5jcHAKQEAgLTAs MCArMSw3NCBAQAorLyoKKyAqIENvcHlyaWdodCAoQykgMjAxMCBBcHBsZSBJbmMuIEFsbCByaWdo dHMgcmVzZXJ2ZWQuCisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5k IGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJt aXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBtZXQ6 CisgKiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhlIGFi b3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQg dGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogMi4gUmVkaXN0cmlidXRpb25zIGluIGJpbmFy eSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGljZSwg dGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0 aGUKKyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3 aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBC WSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMgSVMnJworICogQU5EIEFOWSBF WFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQg VE8sCisgKiBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklU TkVTUyBGT1IgQSBQQVJUSUNVTEFSCisgKiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBF VkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklCVVRPUlMKKyAqIEJFIExJQUJMRSBG T1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsIEVYRU1QTEFSWSwg T1IKKyAqIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQg VE8sIFBST0NVUkVNRU5UIE9GCisgKiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NT IE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MKKyAqIElOVEVSUlVQVElPTikg SE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVSIElO CisgKiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVCAoSU5DTFVESU5HIE5FR0xJ R0VOQ0UgT1IgT1RIRVJXSVNFKQorICogQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNF IE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRgorICogVEhFIFBPU1NJQklMSVRZ IE9GIFNVQ0ggREFNQUdFLgorICovCisKKyNpbmNsdWRlICJOZXRzY2FwZVBsdWdpbi5oIgorCisj aW5jbHVkZSAiTm90SW1wbGVtZW50ZWQuaCIKKwordXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CisK K25hbWVzcGFjZSBXZWJLaXQgeworCitib29sIE5ldHNjYXBlUGx1Z2luOjpwbGF0Zm9ybVBvc3RJ bml0aWFsaXplKCkKK3sKKyAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIHJldHVybiB0cnVlOwor fQorCit2b2lkIE5ldHNjYXBlUGx1Z2luOjpwbGF0Zm9ybVBhaW50KEdyYXBoaWNzQ29udGV4dCos IGNvbnN0IEludFJlY3QmKQoreworICAgIG5vdEltcGxlbWVudGVkKCk7Cit9CisKK2Jvb2wgTmV0 c2NhcGVQbHVnaW46OnBsYXRmb3JtSGFuZGxlTW91c2VFdmVudChjb25zdCBXZWJNb3VzZUV2ZW50 JikKK3sKKyAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIHJldHVybiBmYWxzZTsKK30KKworYm9v bCBOZXRzY2FwZVBsdWdpbjo6cGxhdGZvcm1IYW5kbGVXaGVlbEV2ZW50KGNvbnN0IFdlYldoZWVs RXZlbnQmKQoreworICAgIG5vdEltcGxlbWVudGVkKCk7CisgICAgcmV0dXJuIGZhbHNlOworfQor Cit2b2lkIE5ldHNjYXBlUGx1Z2luOjpwbGF0Zm9ybVNldEZvY3VzKGJvb2wpCit7CisgICAgbm90 SW1wbGVtZW50ZWQoKTsKK30KKworYm9vbCBOZXRzY2FwZVBsdWdpbjo6cGxhdGZvcm1IYW5kbGVN b3VzZUVudGVyRXZlbnQoY29uc3QgV2ViTW91c2VFdmVudCYpCit7CisgICAgbm90SW1wbGVtZW50 ZWQoKTsKKyAgICByZXR1cm4gZmFsc2U7Cit9CisKK2Jvb2wgTmV0c2NhcGVQbHVnaW46OnBsYXRm b3JtSGFuZGxlTW91c2VMZWF2ZUV2ZW50KGNvbnN0IFdlYk1vdXNlRXZlbnQmKQoreworICAgIG5v dEltcGxlbWVudGVkKCk7CisgICAgcmV0dXJuIGZhbHNlOworfQorCit9IC8vIG5hbWVzcGFjZSBX ZWJLaXQKZGlmZiAtLWdpdCBhL1dlYktpdDIvd2luL1dlYktpdDIudmNwcm9qIGIvV2ViS2l0Mi93 aW4vV2ViS2l0Mi52Y3Byb2oKaW5kZXggMGI4YjllOTQ3YTMyOTA2ZWJlZmVjZTM0MTFlYTUzOWJi MTQ0MTU4Yi4uN2JmNTQxZDdkNTJjYzVhNzJhMTc4OWEyMzE4YmNmM2ZjZjM5NzExNCAxMDA3NTUK LS0tIGEvV2ViS2l0Mi93aW4vV2ViS2l0Mi52Y3Byb2oKKysrIGIvV2ViS2l0Mi93aW4vV2ViS2l0 Mi52Y3Byb2oKQEAgLTk2Niw2ICs5NjYsMTQgQEAKIAkJCQkJCVJlbGF0aXZlUGF0aD0iLi5cV2Vi UHJvY2Vzc1xQbHVnaW5zXE5ldHNjYXBlXE5ldHNjYXBlUGx1Z2luU3RyZWFtLmgiDQogCQkJCQkJ Pg0KIAkJCQkJPC9GaWxlPg0KKwkJCQkJPEZpbHRlcg0KKwkJCQkJCU5hbWU9IndpbiINCisJCQkJ CQk+DQorCQkJCQkJPEZpbGUNCisJCQkJCQkJUmVsYXRpdmVQYXRoPSIuLlxXZWJQcm9jZXNzXFBs dWdpbnNcTmV0c2NhcGVcd2luXE5ldHNjYXBlUGx1Z2luV2luLmNwcCINCisJCQkJCQkJPg0KKwkJ CQkJCTwvRmlsZT4NCisJCQkJCTwvRmlsdGVyPg0KIAkJCQk8L0ZpbHRlcj4NCiAJCQk8L0ZpbHRl cj4NCiAJCTwvRmlsdGVyPg0KQEAgLTEwNzMsMTkgKzEwODEsMTkgQEAKIAkJCQk+DQogCQkJPC9G aWxlPg0KIAkJCTxGaWxlDQotCQkJCVJlbGF0aXZlUGF0aD0iLi5cVUlQcm9jZXNzXFdlYkZyYW1l UG9saWN5TGlzdGVuZXJQcm94eS5jcHAiDQorCQkJCVJlbGF0aXZlUGF0aD0iLi5cVUlQcm9jZXNz XFdlYkZyYW1lTGlzdGVuZXJQcm94eS5jcHAiDQogCQkJCT4NCiAJCQk8L0ZpbGU+DQogCQkJPEZp bGUNCi0JCQkJUmVsYXRpdmVQYXRoPSIuLlxVSVByb2Nlc3NcV2ViRnJhbWVQb2xpY3lMaXN0ZW5l clByb3h5LmgiDQorCQkJCVJlbGF0aXZlUGF0aD0iLi5cVUlQcm9jZXNzXFdlYkZyYW1lTGlzdGVu ZXJQcm94eS5oIg0KIAkJCQk+DQogCQkJPC9GaWxlPg0KIAkJCTxGaWxlDQotCQkJCVJlbGF0aXZl UGF0aD0iLi5cVUlQcm9jZXNzXFdlYkZyYW1lTGlzdGVuZXJQcm94eS5jcHAiDQorCQkJCVJlbGF0 aXZlUGF0aD0iLi5cVUlQcm9jZXNzXFdlYkZyYW1lUG9saWN5TGlzdGVuZXJQcm94eS5jcHAiDQog CQkJCT4NCiAJCQk8L0ZpbGU+DQogCQkJPEZpbGUNCi0JCQkJUmVsYXRpdmVQYXRoPSIuLlxVSVBy b2Nlc3NcV2ViRnJhbWVMaXN0ZW5lclByb3h5LmgiDQorCQkJCVJlbGF0aXZlUGF0aD0iLi5cVUlQ cm9jZXNzXFdlYkZyYW1lUG9saWN5TGlzdGVuZXJQcm94eS5oIg0KIAkJCQk+DQogCQkJPC9GaWxl Pg0KIAkJCTxGaWxlDQo=