44263 2010-08-19 07:44:10 -0700 [Qt] Implement cursor change in WebKit2 2010-08-20 13:38:45 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 44250 0 kbalazs webkit-unassigned commit-queue tonikitoo oldest_to_newest 266729 0 kbalazs 2010-08-19 07:44:10 -0700 We have implemented the LAZY_NATIVE_CURSOR policy so we can handle cursor change in WebKit2. Let's do it! 266735 1 64851 kbalazs 2010-08-19 07:51:27 -0700 Created attachment 64851 proposed patch 267308 2 64851 tonikitoo 2010-08-20 11:20:00 -0700 Comment on attachment 64851 proposed patch Good work! 267326 3 kbalazs 2010-08-20 12:03:12 -0700 (In reply to comment #2) > (From update of attachment 64851 [details]) > Good work! You are so cruel. You bless my patch and give me an r- :( Seriously, am I right if I think you just did it accidentally? :) 267387 4 64851 commit-queue 2010-08-20 13:38:41 -0700 Comment on attachment 64851 proposed patch Clearing flags on attachment: 64851 Committed r65751: <http://trac.webkit.org/changeset/65751> 267389 5 commit-queue 2010-08-20 13:38:45 -0700 All reviewed patches have been landed. Closing bug. 64851 2010-08-19 07:51:27 -0700 2010-08-20 13:38:40 -0700 proposed patch land_wk2_cursor.diff text/plain 4824 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg MjkyMDIzNy4uZTM4MmFjNyAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wOC0xOSAgQmFsYXpzIEtlbGVt ZW4gIDxrYkBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW1F0XSBJbXBsZW1lbnQgY3Vyc29yIGNoYW5nZSBpbiBXZWJLaXQy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDI2Mwor CisgICAgICAgIEltcGxlbWVudGVkIFBhZ2VDbGllbnQ6OnNldEN1cnNvci4KKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL3F0L3FncmFwaGljc3drdmlldy5jcHA6IEFkZGVkIHVwZGF0ZUN1cnNvciBz bG90IHRvIGJlIGNvbm5lY3RlZCB0byB0aGUgUVdLUGFnZTo6c2V0Q3Vyc29yIHNpZ25hbC4KKyAg ICAgICAgKFFHcmFwaGljc1dLVmlldzo6UUdyYXBoaWNzV0tWaWV3KToKKyAgICAgICAgKFFHcmFw aGljc1dLVmlldzo6dXBkYXRlQ3Vyc29yKTogU2V0cyB0aGUgY3Vyc29yIG9mIHRoZSB3aWRnZXQu CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xZ3JhcGhpY3N3a3ZpZXcuaDoKKyAgICAgICAg KiBVSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuY3BwOgorICAgICAgICAoUVdLUGFnZVByaXZhdGU6 OnNldEN1cnNvcik6IEFkZGVkIGltcGxlbWVudGF0aW9uIGZvciBQYWdlQ2xpZW50OjpzZXRDdXJz b3IuIEVtaXR0aW5nIHNpbmdhbCB0aHJvdWdoIHRoZSBRV0tQYWdlLgorICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvcXQvcXdrcGFnZS5oOiBBZGRlZCBzZXRDdXJzb3Igc2lnbmFsLgorICAgICAgICAq IFVJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZV9wLmg6CisKIDIwMTAtMDgtMTggIFpvbHRhbiBIb3J2 YXRoICA8em9sdGFuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBS b2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQv cWdyYXBoaWNzd2t2aWV3LmNwcCBiL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xZ3JhcGhpY3N3 a3ZpZXcuY3BwCmluZGV4IGZkMGI4NmUuLmM2MTkyNmIgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9xdC9xZ3JhcGhpY3N3a3ZpZXcuY3BwCisrKyBiL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9xdC9xZ3JhcGhpY3N3a3ZpZXcuY3BwCkBAIC0yNyw2ICsyNyw3IEBACiAjaW5jbHVkZSAi V2ViUGFnZU5hbWVzcGFjZS5oIgogI2luY2x1ZGUgInF3a3BhZ2UuaCIKICNpbmNsdWRlICJxd2tw YWdlX3AuaCIKKyNpbmNsdWRlIDxRQ3Vyc29yPgogI2luY2x1ZGUgPFFHcmFwaGljc1NjZW5lTW91 c2VFdmVudD4KICNpbmNsdWRlIDxRR3JhcGhpY3NWaWV3PgogI2luY2x1ZGUgPFFQYWludGVyPgpA QCAtNjQsNiArNjUsNyBAQCBRR3JhcGhpY3NXS1ZpZXc6OlFHcmFwaGljc1dLVmlldyhXS1BhZ2VO YW1lc3BhY2VSZWYgcGFnZU5hbWVzcGFjZVJlZiwgQmFja2luZ1N0bwogICAgIGNvbm5lY3QoZC0+ cGFnZSwgU0lHTkFMKGxvYWRQcm9ncmVzcyhpbnQpKSwgdGhpcywgU0lHTkFMKGxvYWRQcm9ncmVz cyhpbnQpKSk7CiAgICAgY29ubmVjdChkLT5wYWdlLCBTSUdOQUwoaW5pdGlhbExheW91dENvbXBs ZXRlZCgpKSwgdGhpcywgU0lHTkFMKGluaXRpYWxMYXlvdXRDb21wbGV0ZWQoKSkpOwogICAgIGNv bm5lY3QoZC0+cGFnZSwgU0lHTkFMKHVybENoYW5nZWQoY29uc3QgUVVybCYpKSwgdGhpcywgU0lH TkFMKHVybENoYW5nZWQoY29uc3QgUVVybCYpKSk7CisgICAgY29ubmVjdChkLT5wYWdlLCBTSUdO QUwoY3Vyc29yQ2hhbmdlZChjb25zdCBRQ3Vyc29yJikpLCB0aGlzLCBTTE9UKHVwZGF0ZUN1cnNv cihjb25zdCBRQ3Vyc29yJikpKTsKIH0KIAogUUdyYXBoaWNzV0tWaWV3Ojp+UUdyYXBoaWNzV0tW aWV3KCkKQEAgLTEzNiw2ICsxMzgsMTEgQEAgdm9pZCBRR3JhcGhpY3NXS1ZpZXc6OnN0b3AoKQog ICAgIHBhZ2UoKS0+dHJpZ2dlckFjdGlvbihRV0tQYWdlOjpTdG9wKTsKIH0KIAordm9pZCBRR3Jh cGhpY3NXS1ZpZXc6OnVwZGF0ZUN1cnNvcihjb25zdCBRQ3Vyc29yJiBjdXJzb3IpCit7CisgICAg c2V0Q3Vyc29yKGN1cnNvcik7Cit9CisKIC8qISBccmVpbXAKICovCiBRVmFyaWFudCBRR3JhcGhp Y3NXS1ZpZXc6Oml0ZW1DaGFuZ2UoR3JhcGhpY3NJdGVtQ2hhbmdlIGNoYW5nZSwgY29uc3QgUVZh cmlhbnQmIHZhbHVlKQpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FncmFw aGljc3drdmlldy5oIGIvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FncmFwaGljc3drdmlldy5o CmluZGV4IGJlYzIyMGIuLjM3NWE4MGYgMTAwNjQ0Ci0tLSBhL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9xdC9xZ3JhcGhpY3N3a3ZpZXcuaAorKysgYi9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcWdy YXBoaWNzd2t2aWV3LmgKQEAgLTcsNiArNywxMCBAQAogI2luY2x1ZGUgPFFHcmFwaGljc1dpZGdl dD4KICNpbmNsdWRlICJxd2twYWdlLmgiCiAKK1FUX0JFR0lOX05BTUVTUEFDRQorY2xhc3MgUUN1 cnNvcjsKK1FUX0VORF9OQU1FU1BBQ0UKKwogY2xhc3MgUUdyYXBoaWNzV0tWaWV3UHJpdmF0ZTsK IAogV0tTdHJpbmdSZWYgV0tTdHJpbmdDcmVhdGVXaXRoUVN0cmluZyhRU3RyaW5nIHFTdHJpbmcp OwpAQCAtNjksNiArNzMsOCBAQCBwcm90ZWN0ZWQ6CiAKICAgICB2aXJ0dWFsIHZvaWQgaG92ZXJN b3ZlRXZlbnQoUUdyYXBoaWNzU2NlbmVIb3ZlckV2ZW50Kik7CiAKKyAgICBRX1NMT1Qgdm9pZCB1 cGRhdGVDdXJzb3IoY29uc3QgUUN1cnNvciYpOworCiBwcml2YXRlOgogICAgIFFHcmFwaGljc1dL Vmlld1ByaXZhdGUqIGQ7CiAgICAgZnJpZW5kIGNsYXNzIFFHcmFwaGljc1dLVmlld1ByaXZhdGU7 CmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAgYi9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5jcHAKaW5kZXggYjZkMjkxNi4uNWJmM2Q2OCAx MDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3a3BhZ2UuY3BwCisrKyBiL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmNwcApAQCAtNTYsNiArNTYsMTMgQEAgdm9p ZCBRV0tQYWdlUHJpdmF0ZTo6aW5pdChjb25zdCBRU2l6ZSYgdmlld3BvcnRTaXplLCBEcmF3aW5n QXJlYVByb3h5KiBwcm94eSkKICAgICBwYWdlLT5pbml0aWFsaXplV2ViUGFnZShJbnRTaXplKHZp ZXdwb3J0U2l6ZSksIHByb3h5KTsKIH0KIAordm9pZCBRV0tQYWdlUHJpdmF0ZTo6c2V0Q3Vyc29y KGNvbnN0IFdlYkNvcmU6OkN1cnNvciYgY3Vyc29yKQoreworI2lmbmRlZiBRVF9OT19DVVJTT1IK KyAgICBlbWl0IHEtPmN1cnNvckNoYW5nZWQoKmN1cnNvci5wbGF0Zm9ybUN1cnNvcigpKTsKKyNl bmRpZgorfQorCiB2b2lkIFFXS1BhZ2VQcml2YXRlOjp0b29sVGlwQ2hhbmdlZChjb25zdCBTdHJp bmcmLCBjb25zdCBTdHJpbmcmIG5ld1Rvb2x0aXApCiB7CiAgICAgZW1pdCBxLT5zdGF0dXNCYXJN ZXNzYWdlKFFTdHJpbmcobmV3VG9vbHRpcCkpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3F3a3BhZ2UuaCBiL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlLmgK aW5kZXggNjYwZDQ3Yi4uMTU0ZWIxZSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3F3a3BhZ2UuaAorKysgYi9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZS5oCkBA IC0xMiw2ICsxMiw3IEBACiAjaW5jbHVkZSA8V2ViS2l0Mi9XS1BhZ2UuaD4KICNpbmNsdWRlIDxX ZWJLaXQyL1dLUGFnZU5hbWVzcGFjZS5oPgogCitjbGFzcyBRQ3Vyc29yOwogY2xhc3MgUVdLR3Jh cGhpY3NXaWRnZXQ7CiBjbGFzcyBRV0tQYWdlUHJpdmF0ZTsKIApAQCAtNjAsNiArNjEsNyBAQCBw dWJsaWM6CiAgICAgUV9TSUdOQUwgdm9pZCBpbml0aWFsTGF5b3V0Q29tcGxldGVkKCk7CiAgICAg UV9TSUdOQUwgdm9pZCB1cmxDaGFuZ2VkKGNvbnN0IFFVcmwmKTsKICAgICBRX1NJR05BTCB2b2lk IGNvbnRlbnRzU2l6ZUNoYW5nZWQoY29uc3QgUVNpemUmKTsKKyAgICBRX1NJR05BTCB2b2lkIGN1 cnNvckNoYW5nZWQoY29uc3QgUUN1cnNvciYpOwogCiBwcm90ZWN0ZWQ6CiAgICAgdm9pZCB0aW1l ckV2ZW50KFFUaW1lckV2ZW50Kik7CmRpZmYgLS1naXQgYS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv cXQvcXdrcGFnZV9wLmggYi9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdrcGFnZV9wLmgKaW5k ZXggMGRlZGEzNC4uOTAzYmExZSAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3F3a3BhZ2VfcC5oCisrKyBiL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xd2twYWdlX3AuaApA QCAtNDcsNyArNDcsNyBAQCBwdWJsaWM6CiAjZW5kaWYgLy8gVVNFKEFDQ0VMRVJBVEVEX0NPTVBP U0lUSU5HKQogICAgIHZpcnR1YWwgdm9pZCBwcm9jZXNzRGlkRXhpdCgpIHsgfQogICAgIHZpcnR1 YWwgdm9pZCBwcm9jZXNzRGlkUmV2aXZlKCkgeyB9Ci0gICAgdmlydHVhbCB2b2lkIHNldEN1cnNv cihjb25zdCBXZWJDb3JlOjpDdXJzb3ImKSB7IH0KKyAgICB2aXJ0dWFsIHZvaWQgc2V0Q3Vyc29y KGNvbnN0IFdlYkNvcmU6OkN1cnNvciYpOwogICAgIHZpcnR1YWwgdm9pZCB0YWtlRm9jdXMoYm9v bCBkaXJlY3Rpb24pIHsgfQogICAgIHZpcnR1YWwgdm9pZCB0b29sVGlwQ2hhbmdlZChjb25zdCBX VEY6OlN0cmluZyYsIGNvbnN0IFdURjo6U3RyaW5nJik7CiAK