44249 2010-08-19 04:55:47 -0700 compilation issue with JSTimeRanges when video turned off 2010-09-03 09:16:31 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 zaheer.mot webkit-unassigned jchaffraix xan.lopez oldest_to_newest 266652 0 zaheer.mot 2010-08-19 04:55:47 -0700 Error in generated code DerivedSources/WebCore/JSDOMWindow.cpp:343:26: error: JSTimeRanges.h: No such file or directory The fix could be a) move JSTimeRanges.* outside ENABLE_VIDEO like JSHTMLVideoElement.* which is not specific to video b) change CodeGenerator.pm to generate the #if ENABLE(*) for implIncludes. This will impact all other headers so iam inclined towards 1. 266669 1 64833 zaheer.mot 2010-08-19 05:25:24 -0700 Created attachment 64833 Proposed patch 269751 2 zaheer.mot 2010-08-26 00:14:22 -0700 Xan, this is one more build error with video off Thx 273448 3 zaheer.mot 2010-09-02 10:49:15 -0700 Thanks Darin, could you pls do a commit-queue+ 273972 4 jchaffraix 2010-09-03 09:16:31 -0700 Landed in r66736. 64833 2010-08-19 05:25:24 -0700 2010-08-29 12:37:25 -0700 Proposed patch patch text/plain 1507 zaheer.mot SW5kZXg6IFdlYkNvcmUvR05VbWFrZWZpbGUuYW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9HTlVt YWtlZmlsZS5hbQkocmV2aXNpb24gNjU2NTQpCisrKyBXZWJDb3JlL0dOVW1ha2VmaWxlLmFtCSh3 b3JraW5nIGNvcHkpCkBAIC0zOTEsNiArMzkxLDggQEAKIAlEZXJpdmVkU291cmNlcy9XZWJDb3Jl L0pTSFRNTFVMaXN0RWxlbWVudC5oIFwKIAlEZXJpdmVkU291cmNlcy9XZWJDb3JlL0pTSFRNTFZp ZGVvRWxlbWVudC5jcHAgXAogCURlcml2ZWRTb3VyY2VzL1dlYkNvcmUvSlNIVE1MVmlkZW9FbGVt ZW50LmggXAorCURlcml2ZWRTb3VyY2VzL1dlYkNvcmUvSlNUaW1lUmFuZ2VzLmNwcCBcCisJRGVy aXZlZFNvdXJjZXMvV2ViQ29yZS9KU1RpbWVSYW5nZXMuaCBcCiAJRGVyaXZlZFNvdXJjZXMvV2Vi Q29yZS9KU0ltYWdlRGF0YS5jcHAgXAogCURlcml2ZWRTb3VyY2VzL1dlYkNvcmUvSlNJbWFnZURh dGEuaCBcCiAJRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9KU0luamVjdGVkU2NyaXB0SG9zdC5jcHAg XApAQCAtMzEyOCwxMCArMzEzMCw2IEBACiB3ZWJjb3JlX2NwcGZsYWdzICs9IC1ER1NUX0RJU0FC TEVfREVQUkVDQVRFRAogZW5kaWYgIyBFTkQgRU5BQkxFX0RFQlVHCiAKLXdlYmNvcmVfYnVpbHRf c291cmNlcyArPSBcCi0JRGVyaXZlZFNvdXJjZXMvV2ViQ29yZS9KU1RpbWVSYW5nZXMuY3BwIFwK LQlEZXJpdmVkU291cmNlcy9XZWJDb3JlL0pTVGltZVJhbmdlcy5oCi0KIHdlYmNvcmVfc291cmNl cyArPSBcCiAJV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0F1ZGlvQ29uc3RydWN0b3IuY3BwIFwKIAlX ZWJDb3JlL2JpbmRpbmdzL2pzL0pTQXVkaW9Db25zdHJ1Y3Rvci5oIFwKSW5kZXg6IFdlYkNvcmUv Q2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiA2NTY1 NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDgtMTggIFphaGVlciBBaG1hZCA8emFoZWVyLm1vdEBnbWFpbC5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gY29tcGlsYXRp b24gaXNzdWUgd2l0aCBKU1RpbWVSYW5nZXMgd2hlbiB2aWRlbyB0dXJuZWQgb2ZmCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDI0OQorCisgICAgICAg IE1vdmUgdGhlIEpTVGltZVJhbmdlcyBvdXRzaWRlIEVOQUJMRV9WSURFTyBpbiBHTlVNYWtlZmls ZS5hbQorICAgICAgICAqIFdlYkNvcmUvR05VTWFrZWZpbGUuYW0KKwogMjAxMC0wOC0xOCAgQXJp eWEgSGlkYXlhdCAgPGFyaXlhQHNlbmNoYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2Vu bmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCg==