44240 2010-08-19 04:41:25 -0700 REGRESSION (r62896): Interpreter incorrectly excludes prototype chain when validating put_by_id_transition 2010-08-24 10:08:04 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.6 RESOLVED FIXED InRadar P2 Normal --- 41929 1 ddkilzer webkit-unassigned darin ggaren oliver oldest_to_newest 266630 0 ddkilzer 2010-08-19 04:41:25 -0700 LayoutTests/fast/js/dictionary-no-cache.html fails using the JSC interpreter, but passes using the JSC JIT. --- a/LayoutTests/fast/js/dictionary-no-cache-expected.txt +++ b/LayoutTests/fast/js/dictionary-no-cache-expected.txt @@ -5,7 +5,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE PASS foundNewPrototypeProperty is true PASS foundRemovedPrototypeProperty is false -PASS calledNewPrototypeSetter is true +FAIL calledNewPrototypeSetter should be true. Was false. PASS getTestProperty(test4) is "on prototype" PASS getTestProperty(test4) is "on self" PASS getTestProperty(test5) is "on prototype's prototype" 266641 1 ddkilzer 2010-08-19 04:48:05 -0700 <rdar://problem/8328995> 268164 2 oliver 2010-08-23 16:32:10 -0700 *** Bug 44241 has been marked as a duplicate of this bug. *** 268194 3 65184 oliver 2010-08-23 16:51:37 -0700 Created attachment 65184 Patch 268199 4 65184 darin 2010-08-23 16:54:25 -0700 Comment on attachment 65184 Patch Is there a regression test covering this already? 268202 5 oliver 2010-08-23 17:05:39 -0700 Committed r65847 268222 6 ddkilzer 2010-08-23 17:40:37 -0700 (In reply to comment #4) > (From update of attachment 65184 [details]) > Is there a regression test covering this already? Yes, except we don't have any buildbots running tests with the JSC Interpreter: fast/js/dictionary-no-cache.html fast/js/pic/cached-prototype-setter.html 268614 7 ddkilzer 2010-08-24 10:08:04 -0700 The regression was introduced in r62896 for Bug 41929. <http://trac.webkit.org/changeset/62896> 65184 2010-08-23 16:51:37 -0700 2010-08-23 16:54:24 -0700 Patch bug-44240-20100823165135.patch text/plain 1639 oliver ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBjOWEyZjE0OTk5YjQxNTZlODZhOWI2OWI0NGExMjIxMDg5MGRlYjUzLi5m YTY1NDUyZjM4N2IzODJkZTYyZGU3MjE3ZjVkZGM0MDEzNTY4MWIwIDEwMDY0NAotLS0gYS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0x LDUgKzEsMTkgQEAKIDIwMTAtMDgtMjMgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4K IAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUkVHUkVT U0lPTl0gSW50ZXJwcmV0ZXIgaW5jb3JyZWN0bHkgZXhjbHVkZXMgcHJvdG90eXBlIGNoYWluIHdo ZW4gdmFsaWRhdGluZyBwdXRfYnlfaWRfdHJhbnNpdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQyNDAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzgzMjg5OTU+CisKKyAgICAgICAgRml4IGFuIGVycm9yIEkgaW50cm9kdWNlZCB3aGVuIGNsZWFu aW5nIHVwIHRoZSBpbnRlcnByZXRlciBzaWRlIG9mIHRoZSBsb2dpYworICAgICAgICB0byBwcmV2 ZW50IHNldHRlcnMgYmVpbmcgY2FsbGVkIGluIG9iamVjdCBpbml0aWFsaXNlcnMuCisKKyAgICAg ICAgKiBpbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHA6CisgICAgICAgIChKU0M6OkludGVycHJl dGVyOjpwcml2YXRlRXhlY3V0ZSk6CisKKzIwMTAtMDgtMjMgIE9saXZlciBIdW50ICA8b2xpdmVy QGFwcGxlLmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBieSBHYXZpbiBCYXJyYWNsb3VnaC4KIAog ICAgICAgICBKU09OLnN0cmluZ2lmeSBpcyBtdWNoIHNsb3dlciB0aGFuIEZpcmVmb3ggb24gcGFy dGljdWxhciBwYXRob2xvZ2ljYWwgaW5wdXQKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL2lu dGVycHJldGVyL0ludGVycHJldGVyLmNwcCBiL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0lu dGVycHJldGVyLmNwcAppbmRleCBiMTA0OWFkN2JjMTY0OTJlMDU0ZWFkYzFkMmU5Mjk2MjU3MWM0 Nzk1Li5kNDNlYjU3NDIyOGVjMTk5MTkyMzQzZTNjOWVjYjY5MTg4YjdkMWQ5IDEwMDY0NAotLS0g YS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAKKysrIGIvSmF2YVNj cmlwdENvcmUvaW50ZXJwcmV0ZXIvSW50ZXJwcmV0ZXIuY3BwCkBAIC0yOTUyLDcgKzI5NTIsNyBA QCBza2lwX2lkX2N1c3RvbV9zZWxmOgogICAgICAgICAgICAgICAgIEpTT2JqZWN0KiBiYXNlT2Jq ZWN0ID0gYXNPYmplY3QoYmFzZUNlbGwpOwogICAgICAgICAgICAgICAgIGludCBkaXJlY3QgPSB2 UENbOF0udS5vcGVyYW5kOwogICAgICAgICAgICAgICAgIAotICAgICAgICAgICAgICAgIGlmIChk aXJlY3QpIHsKKyAgICAgICAgICAgICAgICBpZiAoIWRpcmVjdCkgewogICAgICAgICAgICAgICAg ICAgICBSZWZQdHI8U3RydWN0dXJlPiogaXQgPSB2UENbNl0udS5zdHJ1Y3R1cmVDaGFpbi0+aGVh ZCgpOwogCiAgICAgICAgICAgICAgICAgICAgIEpTVmFsdWUgcHJvdG8gPSBiYXNlT2JqZWN0LT5z dHJ1Y3R1cmUoKS0+cHJvdG90eXBlRm9yTG9va3VwKGNhbGxGcmFtZSk7Cg==