44236 2010-08-19 02:19:24 -0700 GTK port doesnt compile with video turned off 2010-08-25 06:08:55 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 zaheer.mot webkit-unassigned commit-queue mrobinson xan.lopez oldest_to_newest 266607 0 zaheer.mot 2010-08-19 02:19:24 -0700 compilation error in WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.cpp with video turned off. Attaching possible patch. 266612 1 64824 zaheer.mot 2010-08-19 02:39:51 -0700 Created attachment 64824 Proposed patch 267172 2 64824 xan.lopez 2010-08-20 01:49:04 -0700 Comment on attachment 64824 Proposed patch This is not enough, you also need to disable the generation of the API files. Check in the main GNUMakefile.am how the geolocation stuff is made conditional. Also, I think the preferred style for conditional headers is to put them after all the unconditional ones. 267552 3 65024 zaheer.mot 2010-08-21 02:53:55 -0700 Created attachment 65024 Updated Patch 267553 4 65024 xan.lopez 2010-08-21 02:57:13 -0700 Comment on attachment 65024 Updated Patch Fantastic, thank you. 267762 5 zaheer.mot 2010-08-22 22:58:52 -0700 (In reply to comment #4) > (From update of attachment 65024 [details]) > Fantastic, thank you. Thank you. Could you push to the commit queue. 269175 6 65024 xan.lopez 2010-08-25 05:17:56 -0700 Comment on attachment 65024 Updated Patch Forgot to set cq+ 269195 7 65024 commit-queue 2010-08-25 06:08:50 -0700 Comment on attachment 65024 Updated Patch Clearing flags on attachment: 65024 Committed r66009: <http://trac.webkit.org/changeset/66009> 269196 8 commit-queue 2010-08-25 06:08:55 -0700 All reviewed patches have been landed. Closing bug. 64824 2010-08-19 02:39:51 -0700 2010-08-21 03:01:20 -0700 Proposed patch patch text/plain 2171 zaheer.mot SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NTY1NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDgtMTggIFphaGVlciBBaG1hZCA8emFoZWVyLm1vdEBnbWFp bC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg W0dUS10gR1RLIHBvcnQgZG9lc250IGNvbXBpbGUgd2l0aCB2aWRlbyB0dXJuZWQgb2ZmIAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQyMzYKKworICAg ICAgICBBZGQgdGhlIGF1ZGlvIGNvZGUgaW4gRU5BQkxFKFZJREVPKSBtYWNybworICAgICAgICAq IFdlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRIVE1MRWxlbWVudFdyYXBwZXJGYWN0b3J5 LmNwcAorCiAyMDEwLTA4LTE4ICBBcml5YSBIaWRheWF0ICA8YXJpeWFAc2VuY2hhLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KSW5kZXg6IFdl YkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRIVE1MRWxlbWVudFdyYXBwZXJGYWN0b3J5LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0SFRNTEVsZW1l bnRXcmFwcGVyRmFjdG9yeS5jcHAJKHJldmlzaW9uIDY1NjU0KQorKysgV2ViQ29yZS9iaW5kaW5n cy9nb2JqZWN0L1dlYktpdEhUTUxFbGVtZW50V3JhcHBlckZhY3RvcnkuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC05Niw3ICs5Niw5IEBACiAjaW5jbHVkZSAid2Via2l0L1dlYktpdERPTUhUTUxBbmNo b3JFbGVtZW50UHJpdmF0ZS5oIgogI2luY2x1ZGUgIndlYmtpdC9XZWJLaXRET01IVE1MQXBwbGV0 RWxlbWVudFByaXZhdGUuaCIKICNpbmNsdWRlICJ3ZWJraXQvV2ViS2l0RE9NSFRNTEFyZWFFbGVt ZW50UHJpdmF0ZS5oIgorI2lmIEVOQUJMRShWSURFTykKICNpbmNsdWRlICJ3ZWJraXQvV2ViS2l0 RE9NSFRNTEF1ZGlvRWxlbWVudFByaXZhdGUuaCIKKyNlbmRpZgogI2luY2x1ZGUgIndlYmtpdC9X ZWJLaXRET01IVE1MQlJFbGVtZW50UHJpdmF0ZS5oIgogI2luY2x1ZGUgIndlYmtpdC9XZWJLaXRE T01IVE1MQmFzZUVsZW1lbnRQcml2YXRlLmgiCiAjaW5jbHVkZSAid2Via2l0L1dlYktpdERPTUhU TUxCYXNlRm9udEVsZW1lbnRQcml2YXRlLmgiCkBAIC0xNzcsMTAgKzE3OSwxMiBAQAogICAgIHJl dHVybiB3cmFwSFRNTEFyZWFFbGVtZW50KHN0YXRpY19jYXN0PEhUTUxBcmVhRWxlbWVudCo+KGVs ZW1lbnQuZ2V0KCkpKTsKIH0KIAorI2lmIEVOQUJMRShWSURFTykKIHN0YXRpYyBncG9pbnRlciBj cmVhdGVBdWRpb1dyYXBwZXIoUGFzc1JlZlB0cjxIVE1MRWxlbWVudD4gZWxlbWVudCkKIHsKICAg ICByZXR1cm4gd3JhcEhUTUxBdWRpb0VsZW1lbnQoc3RhdGljX2Nhc3Q8SFRNTEF1ZGlvRWxlbWVu dCo+KGVsZW1lbnQuZ2V0KCkpKTsKIH0KKyNlbmRpZgogCiBzdGF0aWMgZ3BvaW50ZXIgY3JlYXRl QmFzZVdyYXBwZXIoUGFzc1JlZlB0cjxIVE1MRWxlbWVudD4gZWxlbWVudCkKIHsKQEAgLTQ1Myw3 ICs0NTcsOSBAQAogICAgIGlmIChtYXAuaXNFbXB0eSgpKSB7CiAgICAgICAgbWFwLnNldChhVGFn LmxvY2FsTmFtZSgpLmltcGwoKSwgY3JlYXRlQW5jaG9yV3JhcHBlcik7CiAgICAgICAgbWFwLnNl dChhcHBsZXRUYWcubG9jYWxOYW1lKCkuaW1wbCgpLCBjcmVhdGVBcHBsZXRXcmFwcGVyKTsKKyNp ZiBFTkFCTEUoVklERU8pCiAgICAgICAgbWFwLnNldChhdWRpb1RhZy5sb2NhbE5hbWUoKS5pbXBs KCksIGNyZWF0ZUF1ZGlvV3JhcHBlcik7CisjZW5kaWYKICAgICAgICBtYXAuc2V0KGFyZWFUYWcu bG9jYWxOYW1lKCkuaW1wbCgpLCBjcmVhdGVBcmVhV3JhcHBlcik7CiAgICAgICAgbWFwLnNldChi YXNlVGFnLmxvY2FsTmFtZSgpLmltcGwoKSwgY3JlYXRlQmFzZVdyYXBwZXIpOwogICAgICAgIG1h cC5zZXQoYmFzZWZvbnRUYWcubG9jYWxOYW1lKCkuaW1wbCgpLCBjcmVhdGVCYXNlRm9udFdyYXBw ZXIpOwo= 65024 2010-08-21 02:53:55 -0700 2010-08-25 06:08:50 -0700 Updated Patch patch text/plain 4092 zaheer.mot SW5kZXg6IEdOVW1ha2VmaWxlLmFtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEdOVW1ha2VmaWxlLmFtCShyZXZp c2lvbiA2NTY1NCkKKysrIEdOVW1ha2VmaWxlLmFtCSh3b3JraW5nIGNvcHkpCkBAIC0zNzcsNyAr Mzc3LDYgQEAKIAlEZXJpdmVkU291cmNlcy93ZWJraXQvV2ViS2l0RE9NSFRNTEFuY2hvckVsZW1l bnQuaCBcCiAJRGVyaXZlZFNvdXJjZXMvd2Via2l0L1dlYktpdERPTUhUTUxBcHBsZXRFbGVtZW50 LmggXAogCURlcml2ZWRTb3VyY2VzL3dlYmtpdC9XZWJLaXRET01IVE1MQXJlYUVsZW1lbnQuaCBc Ci0JRGVyaXZlZFNvdXJjZXMvd2Via2l0L1dlYktpdERPTUhUTUxBdWRpb0VsZW1lbnQuaCBcCiAJ RGVyaXZlZFNvdXJjZXMvd2Via2l0L1dlYktpdERPTUhUTUxCYXNlRWxlbWVudC5oIFwKIAlEZXJp dmVkU291cmNlcy93ZWJraXQvV2ViS2l0RE9NSFRNTEJhc2VGb250RWxlbWVudC5oIFwKIAlEZXJp dmVkU291cmNlcy93ZWJraXQvV2ViS2l0RE9NSFRNTEJsb2NrcXVvdGVFbGVtZW50LmggXApAQCAt NTQxLDggKzU0MCw2IEBACiAJRGVyaXZlZFNvdXJjZXMvd2Via2l0L1dlYktpdERPTUhUTUxBcHBs ZXRFbGVtZW50UHJpdmF0ZS5oIFwKIAlEZXJpdmVkU291cmNlcy93ZWJraXQvV2ViS2l0RE9NSFRN TEFyZWFFbGVtZW50LmNwcCBcCiAJRGVyaXZlZFNvdXJjZXMvd2Via2l0L1dlYktpdERPTUhUTUxB cmVhRWxlbWVudFByaXZhdGUuaCBcCi0JRGVyaXZlZFNvdXJjZXMvd2Via2l0L1dlYktpdERPTUhU TUxBdWRpb0VsZW1lbnQuY3BwIFwKLQlEZXJpdmVkU291cmNlcy93ZWJraXQvV2ViS2l0RE9NSFRN TEF1ZGlvRWxlbWVudFByaXZhdGUuaCBcCiAJRGVyaXZlZFNvdXJjZXMvd2Via2l0L1dlYktpdERP TUhUTUxCYXNlRWxlbWVudC5jcHAgXAogCURlcml2ZWRTb3VyY2VzL3dlYmtpdC9XZWJLaXRET01I VE1MQmFzZUVsZW1lbnRQcml2YXRlLmggXAogCURlcml2ZWRTb3VyY2VzL3dlYmtpdC9XZWJLaXRE T01IVE1MQmFzZUZvbnRFbGVtZW50LmNwcCBcCkBAIC03MjUsNiArNzIyLDE1IEBACiAJRGVyaXZl ZFNvdXJjZXMvd2Via2l0L1dlYktpdERPTUdlb2xvY2F0aW9uUHJpdmF0ZS5oCiBlbmRpZgogCitp ZiBFTkFCTEVfVklERU8KK3dlYmtpdGd0a19idWlsdF9oX2FwaSArPSBcCisJJCh0b3BfYnVpbGRk aXIpL0Rlcml2ZWRTb3VyY2VzL3dlYmtpdC9XZWJLaXRET01IVE1MQXVkaW9FbGVtZW50LmgKKwor d2Via2l0Z3RrX2dkb21fYnVpbHRfc291cmNlcyArPSBcCisJRGVyaXZlZFNvdXJjZXMvd2Via2l0 L1dlYktpdERPTUhUTUxBdWRpb0VsZW1lbnQuY3BwIFwKKwlEZXJpdmVkU291cmNlcy93ZWJraXQv V2ViS2l0RE9NSFRNTEF1ZGlvRWxlbWVudFByaXZhdGUuaAorZW5kaWYKKwogIyB3ZWJraXRlbnVt dHlwZXMue2gsY3BwfSBjYW5ub3QgYmUgaW4gd2Via2l0Z3RrX2J1aWx0X2hfYXBpLCBiZWNhdXNl CiAjIHRoZSBydWxlIHRoYXQgYnVpbGRzIGl0IGRlcGVuZHMgb24gd2Via2l0Z3RrX2J1aWx0X2hf YXBpIChjaXJjdWxhciBkZXBlbmRlbmN5KS4KIHdlYmtpdGd0a19idWlsdF9zb3VyY2VzICs9IFwK SW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRIVE1MRWxlbWVudFdyYXBwZXJG YWN0b3J5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0 SFRNTEVsZW1lbnRXcmFwcGVyRmFjdG9yeS5jcHAJKHJldmlzaW9uIDY1NjU0KQorKysgV2ViQ29y ZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdEhUTUxFbGVtZW50V3JhcHBlckZhY3RvcnkuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC05Niw3ICs5Niw2IEBACiAjaW5jbHVkZSAid2Via2l0L1dlYktpdERP TUhUTUxBbmNob3JFbGVtZW50UHJpdmF0ZS5oIgogI2luY2x1ZGUgIndlYmtpdC9XZWJLaXRET01I VE1MQXBwbGV0RWxlbWVudFByaXZhdGUuaCIKICNpbmNsdWRlICJ3ZWJraXQvV2ViS2l0RE9NSFRN TEFyZWFFbGVtZW50UHJpdmF0ZS5oIgotI2luY2x1ZGUgIndlYmtpdC9XZWJLaXRET01IVE1MQXVk aW9FbGVtZW50UHJpdmF0ZS5oIgogI2luY2x1ZGUgIndlYmtpdC9XZWJLaXRET01IVE1MQlJFbGVt ZW50UHJpdmF0ZS5oIgogI2luY2x1ZGUgIndlYmtpdC9XZWJLaXRET01IVE1MQmFzZUVsZW1lbnRQ cml2YXRlLmgiCiAjaW5jbHVkZSAid2Via2l0L1dlYktpdERPTUhUTUxCYXNlRm9udEVsZW1lbnRQ cml2YXRlLmgiCkBAIC0xNTMsNiArMTUyLDEwIEBACiAjaW5jbHVkZSAid2Via2l0L1dlYktpdERP TUhUTUxVTGlzdEVsZW1lbnRQcml2YXRlLmgiCiAjaW5jbHVkZSAid2Via2l0L3dlYmtpdGRvbS5o IgogCisjaWYgRU5BQkxFKFZJREVPKQorI2luY2x1ZGUgIndlYmtpdC9XZWJLaXRET01IVE1MQXVk aW9FbGVtZW50UHJpdmF0ZS5oIgorI2VuZGlmCisKICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5n Lmg+CiAKIG5hbWVzcGFjZSBXZWJLaXQgewpAQCAtMTc3LDEwICsxODAsMTIgQEAKICAgICByZXR1 cm4gd3JhcEhUTUxBcmVhRWxlbWVudChzdGF0aWNfY2FzdDxIVE1MQXJlYUVsZW1lbnQqPihlbGVt ZW50LmdldCgpKSk7CiB9CiAKKyNpZiBFTkFCTEUoVklERU8pCiBzdGF0aWMgZ3BvaW50ZXIgY3Jl YXRlQXVkaW9XcmFwcGVyKFBhc3NSZWZQdHI8SFRNTEVsZW1lbnQ+IGVsZW1lbnQpCiB7CiAgICAg cmV0dXJuIHdyYXBIVE1MQXVkaW9FbGVtZW50KHN0YXRpY19jYXN0PEhUTUxBdWRpb0VsZW1lbnQq PihlbGVtZW50LmdldCgpKSk7CiB9CisjZW5kaWYKIAogc3RhdGljIGdwb2ludGVyIGNyZWF0ZUJh c2VXcmFwcGVyKFBhc3NSZWZQdHI8SFRNTEVsZW1lbnQ+IGVsZW1lbnQpCiB7CkBAIC00NTMsNyAr NDU4LDkgQEAKICAgICBpZiAobWFwLmlzRW1wdHkoKSkgewogICAgICAgIG1hcC5zZXQoYVRhZy5s b2NhbE5hbWUoKS5pbXBsKCksIGNyZWF0ZUFuY2hvcldyYXBwZXIpOwogICAgICAgIG1hcC5zZXQo YXBwbGV0VGFnLmxvY2FsTmFtZSgpLmltcGwoKSwgY3JlYXRlQXBwbGV0V3JhcHBlcik7CisjaWYg RU5BQkxFKFZJREVPKQogICAgICAgIG1hcC5zZXQoYXVkaW9UYWcubG9jYWxOYW1lKCkuaW1wbCgp LCBjcmVhdGVBdWRpb1dyYXBwZXIpOworI2VuZGlmCiAgICAgICAgbWFwLnNldChhcmVhVGFnLmxv Y2FsTmFtZSgpLmltcGwoKSwgY3JlYXRlQXJlYVdyYXBwZXIpOwogICAgICAgIG1hcC5zZXQoYmFz ZVRhZy5sb2NhbE5hbWUoKS5pbXBsKCksIGNyZWF0ZUJhc2VXcmFwcGVyKTsKICAgICAgICBtYXAu c2V0KGJhc2Vmb250VGFnLmxvY2FsTmFtZSgpLmltcGwoKSwgY3JlYXRlQmFzZUZvbnRXcmFwcGVy KTsKSW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdl TG9nCShyZXZpc2lvbiA2NTY1NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDgtMTggIFphaGVlciBBaG1hZCA8emFoZWVyLm1vdEBn bWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0dUS10gR1RLIHBvcnQgZG9lc250IGNvbXBpbGUgd2l0aCB2aWRlbyB0dXJuZWQgb2ZmCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDIzNgorCisg ICAgICAgIEdlbmVyYXRlIHRoZSBhdWRpbyBHT2JqZWN0IERPTSBiaW5kaW5ncyBvbmx5IGlmIHZp ZGVvIGVuYWJsZWQKKyAgICAgICAgKiBXZWJDb3JlL0dOVU1ha2VmaWxlLmFtCisgICAgICAgICog V2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L1dlYktpdEhUTUxFbGVtZW50V3JhcHBlckZhY3Rvcnku Y3BwOgorICAgICAgICBNYWtlIHRoZSBhdWRpbyBjb2RlIGludm9jYXRpb24gY29uZGl0aW9uYWwK KworCiAyMDEwLTA4LTE4ICBBcml5YSBIaWRheWF0ICA8YXJpeWFAc2VuY2hhLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4K