44233 2010-08-19 00:44:34 -0700 Enable truncated floating point feature on ARM 2012-03-13 13:03:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other All RESOLVED FIXED P2 Enhancement --- 1 loki loki barraclough eric webkit.review.bot yong.li.webkit oldest_to_newest 266578 0 loki 2010-08-19 00:44:34 -0700 We can enable truncated floating point fast cases to speed up several arithmetic tests. 266586 1 64816 loki 2010-08-19 00:54:19 -0700 Created attachment 64816 Enable truncated floating point feature on ARM SunSpider: 1.011x as fast V8: 1.003x as fast WindScorpion: 1.003x as fast 266587 2 webkit.review.bot 2010-08-19 00:56:12 -0700 Attachment 64816 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/assembler/ARMAssembler.h:375: cmn_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] JavaScriptCore/assembler/ARMAssembler.h:587: vcvtr_s32_f64_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 269071 3 loki 2010-08-25 00:52:35 -0700 Committed revision 65993. 462519 4 yong.li.webkit 2011-09-06 08:02:15 -0700 (In reply to comment #3) > Committed revision 65993. This solution doesn't work for this test case: var largeNeg=-2715228072; alert(largeNeg >>> 5); // wrong when using ARM assembler. Also see https://bugs.webkit.org/show_bug.cgi?id=67486 Should we revert this commit? 462669 5 barraclough 2011-09-06 11:07:16 -0700 We should fix or revert. Do you have time to look into this Gabor, or would you prefer we just roll out for now? We should also add the test case to a layout test, if it is not already covered. 462848 6 yong.li.webkit 2011-09-06 14:12:31 -0700 (In reply to comment #5) > We should fix or revert. Do you have time to look into this Gabor, or would you prefer we just roll out for now? > > We should also add the test case to a layout test, if it is not already covered. I attached a patch to https://bugs.webkit.org/show_bug.cgi?id=67486, which contains a test case. Should I move that patch to here and close 67486? 463009 7 barraclough 2011-09-06 17:16:07 -0700 Hey Yong Li, thanks for the test case, and using a separate bug to track the roll out seems fine to me (this is what the sheriff bot does). Rolled out by bug #67486 525609 8 eric 2011-12-21 14:33:44 -0800 Attachment 64816 was posted by a committer and has review+, assigning to Gabor Loki for commit. 577711 9 barraclough 2012-03-13 13:03:45 -0700 This change was rolled out, looks like this is fixed by bug #67486 , and this change is now dead. Closing as invalid. If this is likely to be resurrected then apologies, and please feel free to reopen this bug. 64816 2010-08-19 00:54:19 -0700 2010-08-24 23:02:53 -0700 Enable truncated floating point feature on ARM 0001-Enable-truncated-floating-point-feature-on-ARM.patch text/plain 4771 loki RnJvbSA3Y2M2YTU3M2RjMDgyNjNmNTlkY2RkYjgzOGZiNzFlYjRiOTE3OWE3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHYWJvciBMb2tpIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KRGF0 ZTogVGh1LCAxOSBBdWcgMjAxMCAwOTo1MDowOCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIEVuYWJs ZSB0cnVuY2F0ZWQgZmxvYXRpbmcgcG9pbnQgZmVhdHVyZSBvbiBBUk0KClNpZ25lZC1vZmYtYnk6 IEdhYm9yIExva2kgPGxva2lAaW5mLnUtc3plZ2VkLmh1PgotLS0KIEphdmFTY3JpcHRDb3JlL0No YW5nZUxvZyAgICAgICAgICAgICAgICAgICAgIHwgICAyMiArKysrKysrKysrKysrKysrKysrKysr CiBKYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmggICAgICB8ICAgMTIgKysr KysrKysrKysrCiBKYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaCB8 ICAgMTYgKysrKysrKysrKy0tLS0tLQogMyBmaWxlcyBjaGFuZ2VkLCA0NCBpbnNlcnRpb25zKCsp LCA2IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBi L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBhNzA0ZDJmLi4xYWQyMjVhIDEwMDY0NAot LS0gYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTAtMDgtMTkgIEdhYm9yIExva2kgIDxsb2tpQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg RW5hYmxlIHRydW5jYXRlZCBmbG9hdGluZyBwb2ludCBmZWF0dXJlIG9uIEFSTQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQyMzMKKworICAgICAgICBF bmFibGUgdHJ1bmNhdGVkIGZsb2F0aW5nIHBvaW50IGZlYXR1cmUgd2l0aCB0aGUgaGVscCBvZiBW Q1ZUUi5TMzIuRjY0CisgICAgICAgIGluc3RydWN0aW9uLiBJZiBWQ1ZUUi5TMzIuRjY0IGNhbid0 IGZpdCB0aGUgcmVzdWx0IGludG8gYSAzMi1iaXQKKyAgICAgICAgaW50ZWdlci9yZWdpc3Rlciwg aXQgc2F0dXJhdGVzIGF0IElOVF9NQVggb3IgSU5UX01JTi4gVGVzdGluZyB0aGlzCisgICAgICAg IGxvb2tzIHF1aWNrZXIgdGhhbiB0ZXN0aW5nIEZQU0NSIGZvciBleGNlcHRpb24uCisKKyAgICAg ICAgSW5zcGlyZWQgYnkgSmFjb2IgQnJhbWxleSdzIHBhdGNoIGZyb20gSmFlZ2VyTW9ua2V5CisK KyAgICAgICAgKiBhc3NlbWJsZXIvQVJNQXNzZW1ibGVyLmg6CisgICAgICAgIChKU0M6OkFSTUFz c2VtYmxlcjo6KToKKyAgICAgICAgKEpTQzo6QVJNQXNzZW1ibGVyOjpjbW5fcik6CisgICAgICAg IChKU0M6OkFSTUFzc2VtYmxlcjo6dmN2dHJfczMyX2Y2NF9yKToKKyAgICAgICAgKiBhc3NlbWJs ZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaDoKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJsZXJBUk06 OnN1cHBvcnRzRmxvYXRpbmdQb2ludFRydW5jYXRlKToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3Nl bWJsZXJBUk06OmJyYW5jaFRydW5jYXRlRG91YmxlVG9JbnQzMik6CisKIDIwMTAtMDgtMTggIEFu ZHJlYXMgS2xpbmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBHZW9mZnJleSBHYXJlbi4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxl ci9BUk1Bc3NlbWJsZXIuaCBiL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9BUk1Bc3NlbWJsZXIu aAppbmRleCBkYTEyOGU3Li5kZmE3MjZhIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9hc3Nl bWJsZXIvQVJNQXNzZW1ibGVyLmgKKysrIGIvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL0FSTUFz c2VtYmxlci5oCkBAIC0xNjEsNiArMTYxLDcgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgICAg ICBWTU9WX0FSTSA9IDB4MGUxMDBhMTAsCiAgICAgICAgICAgICBWQ1ZUX0Y2NF9TMzIgPSAweDBl YjgwYmMwLAogICAgICAgICAgICAgVkNWVF9TMzJfRjY0ID0gMHgwZWJkMGI0MCwKKyAgICAgICAg ICAgIFZDVlRSX1MzMl9GNjQgPSAweDBlYmQwYmMwLAogICAgICAgICAgICAgVk1SU19BUFNSID0g MHgwZWYxZmExMCwKICNpZiBXVEZfQVJNX0FSQ0hfQVRfTEVBU1QoNSkKICAgICAgICAgICAgIENM WiA9IDB4MDE2ZjBmMTAsCkBAIC0zNzEsNiArMzcyLDExIEBAIG5hbWVzcGFjZSBKU0MgewogICAg ICAgICAgICAgZW1pdEluc3Qoc3RhdGljX2Nhc3Q8QVJNV29yZD4oY2MpIHwgQ01QIHwgU0VUX0ND LCAwLCBybiwgb3AyKTsKICAgICAgICAgfQogCisgICAgICAgIHZvaWQgY21uX3IoaW50IHJuLCBB Uk1Xb3JkIG9wMiwgQ29uZGl0aW9uIGNjID0gQUwpCisgICAgICAgIHsKKyAgICAgICAgICAgIGVt aXRJbnN0KHN0YXRpY19jYXN0PEFSTVdvcmQ+KGNjKSB8IENNTiB8IFNFVF9DQywgMCwgcm4sIG9w Mik7CisgICAgICAgIH0KKwogICAgICAgICB2b2lkIG9ycl9yKGludCByZCwgaW50IHJuLCBBUk1X b3JkIG9wMiwgQ29uZGl0aW9uIGNjID0gQUwpCiAgICAgICAgIHsKICAgICAgICAgICAgIGVtaXRJ bnN0KHN0YXRpY19jYXN0PEFSTVdvcmQ+KGNjKSB8IE9SUiwgcmQsIHJuLCBvcDIpOwpAQCAtNTc4 LDYgKzU4NCwxMiBAQCBuYW1lc3BhY2UgSlNDIHsKICAgICAgICAgICAgIGVtaXREb3VibGVQcmVj aXNpb25JbnN0KHN0YXRpY19jYXN0PEFSTVdvcmQ+KGNjKSB8IFZDVlRfUzMyX0Y2NCwgKHNkID4+ IDEpLCAwLCBkbSk7CiAgICAgICAgIH0KIAorICAgICAgICB2b2lkIHZjdnRyX3MzMl9mNjRfcihp bnQgc2QsIGludCBkbSwgQ29uZGl0aW9uIGNjID0gQUwpCisgICAgICAgIHsKKyAgICAgICAgICAg IEFTU0VSVCghKHNkICYgMHgxKSk7IC8vIHNkIG11c3QgYmUgZGl2aXNpYmxlIGJ5IDIKKyAgICAg ICAgICAgIGVtaXREb3VibGVQcmVjaXNpb25JbnN0KHN0YXRpY19jYXN0PEFSTVdvcmQ+KGNjKSB8 IFZDVlRSX1MzMl9GNjQsIChzZCA+PiAxKSwgMCwgZG0pOworICAgICAgICB9CisKICAgICAgICAg dm9pZCB2bXJzX2Fwc3IoQ29uZGl0aW9uIGNjID0gQUwpCiAgICAgICAgIHsKICAgICAgICAgICAg IG1fYnVmZmVyLnB1dEludChzdGF0aWNfY2FzdDxBUk1Xb3JkPihjYykgfCBWTVJTX0FQU1IpOwpk aWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyQVJNLmgg Yi9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJBUk0uaAppbmRleCA0OGRk ZjI0Li41ZGU4YjM0IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9B c3NlbWJsZXJBUk0uaAorKysgYi9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJs ZXJBUk0uaApAQCAtNzY5LDcgKzc2OSw3IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgc3VwcG9ydHNG bG9hdGluZ1BvaW50VHJ1bmNhdGUoKSBjb25zdAogICAgIHsKLSAgICAgICAgcmV0dXJuIGZhbHNl OworICAgICAgICByZXR1cm4gc19pc1ZGUFByZXNlbnQ7CiAgICAgfQogCiAgICAgYm9vbCBzdXBw b3J0c0Zsb2F0aW5nUG9pbnRTcXJ0KCkgY29uc3QKQEAgLTg3OCwxMyArODc4LDE3IEBAIHB1Ymxp YzoKICAgICAvLyBUcnVuY2F0ZXMgJ3NyYycgdG8gYW4gaW50ZWdlciwgYW5kIHBsYWNlcyB0aGUg cmVzdWx0aW5nICdkZXN0Jy4KICAgICAvLyBJZiB0aGUgcmVzdWx0IGlzIG5vdCByZXByZXNlbnRh YmxlIGFzIGEgMzIgYml0IHZhbHVlLCBicmFuY2guCiAgICAgLy8gTWF5IGFsc28gYnJhbmNoIGZv ciBzb21lIHZhbHVlcyB0aGF0IGFyZSByZXByZXNlbnRhYmxlIGluIDMyIGJpdHMKLSAgICAvLyAo c3BlY2lmaWNhbGx5LCBpbiB0aGlzIGNhc2UsIElOVF9NSU4pLgorICAgIC8vIChzcGVjaWZpY2Fs bHksIGluIHRoaXMgY2FzZSwgSU5UX01JTiBhbmQgSU5UX01BWCkuCiAgICAgSnVtcCBicmFuY2hU cnVuY2F0ZURvdWJsZVRvSW50MzIoRlBSZWdpc3RlcklEIHNyYywgUmVnaXN0ZXJJRCBkZXN0KQog ICAgIHsKLSAgICAgICAgVU5VU0VEX1BBUkFNKHNyYyk7Ci0gICAgICAgIFVOVVNFRF9QQVJBTShk ZXN0KTsKLSAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgICAgIHJldHVybiBqdW1w KCk7CisgICAgICAgIG1fYXNzZW1ibGVyLnZjdnRyX3MzMl9mNjRfcihBUk1SZWdpc3RlcnM6OlNE MCA8PCAxLCBzcmMpOworICAgICAgICAvLyBJZiBWQ1ZUUi5TMzIuRjY0IGNhbid0IGZpdCB0aGUg cmVzdWx0IGludG8gYSAzMi1iaXQKKyAgICAgICAgLy8gaW50ZWdlciwgaXQgc2F0dXJhdGVzIGF0 IElOVF9NQVggb3IgSU5UX01JTi4gVGVzdGluZyB0aGlzIGlzCisgICAgICAgIC8vIHByb2JhYmx5 IHF1aWNrZXIgdGhhbiB0ZXN0aW5nIEZQU0NSIGZvciBleGNlcHRpb24uCisgICAgICAgIG1fYXNz ZW1ibGVyLnZtb3ZfYXJtX3IoZGVzdCwgQVJNUmVnaXN0ZXJzOjpTRDAgPDwgMSk7CisgICAgICAg IG1fYXNzZW1ibGVyLnN1Yl9yKEFSTVJlZ2lzdGVyczo6UzAsIGRlc3QsIEFSTUFzc2VtYmxlcjo6 Z2V0T3AyKDB4ODAwMDAwMDApKTsKKyAgICAgICAgbV9hc3NlbWJsZXIuY21uX3IoQVJNUmVnaXN0 ZXJzOjpTMCwgQVJNQXNzZW1ibGVyOjpnZXRPcDIoMSksIEFSTUNvbmRpdGlvbihOb3RFcXVhbCkp OworICAgICAgICByZXR1cm4gSnVtcChtX2Fzc2VtYmxlci5qbXAoQVJNQ29uZGl0aW9uKEVxdWFs KSkpOwogICAgIH0KIAogICAgIC8vIENvbnZlcnQgJ3NyYycgdG8gYW4gaW50ZWdlciwgYW5kIHBs YWNlcyB0aGUgcmVzdWx0aW5nICdkZXN0Jy4KLS0gCjEuNy4wLjQKCg==