44232 2010-08-19 00:39:30 -0700 [Qt] Avoid unnecessary string copy in TextCodecQt::decode() 2010-08-19 01:16:21 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) All All RESOLVED FIXED Performance, Qt, QtTriaged P2 Normal --- 1 kling webkit-qt-unassigned oldest_to_newest 266575 0 kling 2010-08-19 00:39:30 -0700 The string returned by QTextCodec::toUnicode() is unnecessarily copied before it's appended to the return value. 266577 1 64815 kling 2010-08-19 00:41:52 -0700 Created attachment 64815 Proposed patch 266593 2 64815 kling 2010-08-19 01:16:10 -0700 Comment on attachment 64815 Proposed patch Clearing flags on attachment: 64815 Committed r65659: <http://trac.webkit.org/changeset/65659> 266594 3 kling 2010-08-19 01:16:21 -0700 All reviewed patches have been landed. Closing bug. 64815 2010-08-19 00:41:52 -0700 2010-08-19 01:16:10 -0700 Proposed patch bug-44232.diff text/plain 1265 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmRlZGMzYi4uNmE2YTU5MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wOC0xOSAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQXZvaWQgdW5uZWNlc3Nhcnkgc3RyaW5nIGNvcHkg aW4gVGV4dENvZGVjUXQ6OmRlY29kZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00NDIzMgorCisgICAgICAgICogcGxhdGZvcm0vdGV4dC9xdC9UZXh0 Q29kZWNRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0Q29kZWNRdDo6ZGVjb2RlKTogVXNl IFN0cmluZzo6YXBwZW5kKGNvbnN0IFVDaGFyKiwgaW50KQorICAgICAgICB0byBhdm9pZCBjcmVh dGluZyBhIHRlbXBvcmFyeSBzdHJpbmcuCisKIDIwMTAtMDgtMTggIEFuZHJlYXMgS2xpbmcgIDxh bmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KIAogICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBBcml5 YSBIaWRheWF0LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L3F0L1RleHRDb2Rl Y1F0LmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9xdC9UZXh0Q29kZWNRdC5jcHAKaW5kZXgg NzM1ZDc3My4uODhjOTUwMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L3F0L1Rl eHRDb2RlY1F0LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL3RleHQvcXQvVGV4dENvZGVjUXQu Y3BwCkBAIC0xMTAsNyArMTEwLDcgQEAgU3RyaW5nIFRleHRDb2RlY1F0OjpkZWNvZGUoY29uc3Qg Y2hhciogYnl0ZXMsIHNpemVfdCBsZW5ndGgsIGJvb2wgZmx1c2gsIGJvb2wgLyoKICAgICAgICAg aW50IHNpemUgPSBlbmQgLSBidWY7CiAgICAgICAgIHNpemUgPSBxTWluKHNpemUsIE1heElucHV0 Q2h1bmtTaXplKTsKICAgICAgICAgUVN0cmluZyBkZWNvZGVkID0gbV9jb2RlYy0+dG9Vbmljb2Rl KGJ1Ziwgc2l6ZSwgJm1fc3RhdGUpOwotICAgICAgICB1bmljb2RlLmFwcGVuZChkZWNvZGVkKTsK KyAgICAgICAgdW5pY29kZS5hcHBlbmQocmVpbnRlcnByZXRfY2FzdDxjb25zdCBVQ2hhcio+KGRl Y29kZWQudW5pY29kZSgpKSwgZGVjb2RlZC5sZW5ndGgoKSk7CiAgICAgICAgIGJ1ZiArPSBzaXpl OwogICAgIH0KIAo=