4423 2005-08-14 00:36:29 -0700 icon database is repeatedly modified and saved on cached HTML iBench tests 2005-08-14 18:18:17 -0700 1 1 1 Unclassified WebKit WebKit Misc. 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 mjs mjs oldest_to_newest 16620 0 mjs 2005-08-14 00:36:29 -0700 The icon database is repeatedly modified and saved on cached HTML iBench tests, taking up about 1% of the time. This despite the fact that none of the pages actually have a site icon. 16621 1 3373 mjs 2005-08-14 00:37:04 -0700 Created attachment 3373 the fix 16623 2 3373 darin 2005-08-14 00:40:49 -0700 Comment on attachment 3373 the fix r=me 3373 2005-08-14 00:37:04 -0700 2005-08-14 00:40:49 -0700 the fix avoid-icon-thrash.patch.txt text/plain 2066 mjs SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jvb3QvV2ViS2l0L0No YW5nZUxvZyx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS4zMjg3CmRpZmYgLXUgLXAgLXIxLjMyODcg Q2hhbmdlTG9nCi0tLSBDaGFuZ2VMb2cJMTEgQXVnIDIwMDUgMjM6MTA6NTQgLTAwMDAJMS4zMjg3 CisrKyBDaGFuZ2VMb2cJMTQgQXVnIDIwMDUgMDc6Mzc6MzUgLTAwMDAKQEAgLTEsMyArMSwxNCBA QAorMjAwNS0wOC0xNCAgTWFjaWVqIFN0YWNob3dpYWsgIDxtanNAYXBwbGUuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisJLSAxJSBzcGVlZHVwIG9uIEhUTUwg bG9hZCBzcGVlZCBpQmVuY2ggYnkgYXZvaWRpbmcgaWNvbiBkYXRhYmFzZSB0aHJhc2gKKwkKKyAg ICAgICAgKiBNaXNjLnN1YnByb2ovV2ViSWNvbkRhdGFiYXNlLm06CisgICAgICAgICgtW1dlYklj b25EYXRhYmFzZSBfc2V0SWNvblVSTDpmb3JVUkw6XSk6IEJlIG1vcmUgYWdncmVzc2l2ZSBhYm91 dCByZXR1cm5pbmcgZWFybHksIGJlY2F1c2UKKwl1cGRhdGluZyB0aGUgZGF0YWJhc2UgZG9lcyBz b21lIGV4cGVuc2l2ZSBkYXRhIHN0cnVjdHVyZSBjb3BpZXMuCisJCisKIDIwMDUtMDgtMTEgIEJl dGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFZpY2tp CkluZGV4OiBNaXNjLnN1YnByb2ovV2ViSWNvbkRhdGFiYXNlLm0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmls ZTogL2N2cy9yb290L1dlYktpdC9NaXNjLnN1YnByb2ovV2ViSWNvbkRhdGFiYXNlLm0sdgpyZXRy aWV2aW5nIHJldmlzaW9uIDEuNTgKZGlmZiAtdSAtcCAtcjEuNTggTWlzYy5zdWJwcm9qL1dlYklj b25EYXRhYmFzZS5tCi0tLSBNaXNjLnN1YnByb2ovV2ViSWNvbkRhdGFiYXNlLm0JMjEgSnVuIDIw MDUgMTg6MDU6NTcgLTAwMDAJMS41OAorKysgTWlzYy5zdWJwcm9qL1dlYkljb25EYXRhYmFzZS5t CTE0IEF1ZyAyMDA1IDA3OjM3OjM1IC0wMDAwCkBAIC0zNzgsMTMgKzM3OCwxOSBAQCBOU1NpemUg V2ViSWNvbkxhcmdlU2l6ZSA9IHsxMjgsIDEyOH07CiAgICAgQVNTRVJUKFVSTCk7CiAgICAgQVNT RVJUKFtzZWxmIF9pc0VuYWJsZWRdKTsKICAgICBBU1NFUlQoW3NlbGYgX2hhc0ljb25Gb3JJY29u VVJMOmljb25VUkxdKTsKLSAKLSAgICBpZiAoW1tfcHJpdmF0ZS0+cGFnZVVSTFRvSWNvblVSTCBv YmplY3RGb3JLZXk6VVJMXSBpc0VxdWFsVG9TdHJpbmc6aWNvblVSTF0gJiYKLSAgICAgICAgW19w cml2YXRlLT5pY29uc09uRGlza1dpdGhVUkxzIGNvbnRhaW5zT2JqZWN0Omljb25VUkxdKSB7CisK KyAgICBpZiAoW1tfcHJpdmF0ZS0+cGFnZVVSTFRvSWNvblVSTCBvYmplY3RGb3JLZXk6VVJMXSBp c0VxdWFsVG9TdHJpbmc6aWNvblVSTF0pIHsKICAgICAgICAgLy8gRG9uJ3QgZG8gYW55IHdvcmsg aWYgdGhlIGljb24gVVJMIGlzIGFscmVhZHkgYm91bmQgdG8gdGhlIHNpdGUgVVJMCiAgICAgICAg IHJldHVybjsKICAgICB9Ci0gICAgCisKKyAgICBpZiAoW19wcml2YXRlLT5pY29uVVJMc1dpdGhO b0ljb25zIGNvbnRhaW5zT2JqZWN0Omljb25VUkxdKSB7CisgICAgICAgIC8vIERvbid0IGRvIGFu eSB3b3JrIGlmIHRoZSBpY29uIFVSTCBpcyBpbiB0aGUgbmVnYXRpdmUgY2FjaGUsIGl0J3Mgbm90 CisgICAgICAgIC8vIHdvcnRoIGRvaW5nIHdvcmsganVzdCB0byByZWNvcmQgdGhhdCB0aGlzIHNp dGUgaXMgYXNzb2NpYXRlZCB3aXRoCisgICAgICAgIC8vIGEgbm9uZXhpc3RlbnQgaWNvbgorICAg ICAgICByZXR1cm47CisgICAgfQorCiAgICAgW19wcml2YXRlLT5wYWdlVVJMVG9JY29uVVJMIHNl dE9iamVjdDppY29uVVJMIGZvcktleTpVUkxdOwogICAgIFtfcHJpdmF0ZS0+aWNvblVSTFRvUGFn ZVVSTHMgX3dlYl9zZXRPYmplY3RVc2luZ1NldElmTmVjZXNzYXJ5OlVSTCBmb3JLZXk6aWNvblVS TF07CiAgICAgICAgIAo=