44223 2010-08-18 17:34:11 -0700 [chromium] Fixing previous Mac only build breakage with TilingDataTest.cpp 2010-08-19 11:46:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 scheib webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 266476 0 scheib 2010-08-18 17:34:11 -0700 [chromium] Fixing previous Mac only build breakage with TilingDataTest.cpp 266478 1 64793 scheib 2010-08-18 17:34:37 -0700 Created attachment 64793 Patch 266480 2 webkit.review.bot 2010-08-18 17:35:37 -0700 Attachment 64793 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/chromium/tests/TilingDataTest.cpp:33: You should add a blank line after implementation file's own header. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 266532 3 64793 levin 2010-08-18 20:59:31 -0700 Comment on attachment 64793 Patch > diff --git a/WebKit/chromium/ChangeLog b/WebKit/chromium/ChangeLog > index 829705e95a9f714ab2c42befa1192a8bb6c5288e..2fa65e8a61d426dd73f4be6b0f91160de715f1dc 100644 > --- a/WebKit/chromium/ChangeLog > +++ b/WebKit/chromium/ChangeLog > @@ -1,3 +1,16 @@ > +2010-08-18 Vincent Scheib <scheib@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Fixing previous Mac only build breakage with TilingDataTest.cpp Please include a link to the bug. > + > + The test included the wrong header, which had a compile option around the definition of the WebCore namespace. Without the namespace defined, error. Fixed by correctly including TilingData.h, which has no conditional compilation. The only place that I know of where lines are wrapped is in the ChangeLog. Please break this line appropriately -- maybe around 80 columns. > + > + Note: Style error is a false positive, since there is no .h file for TilingDataTest.cpp No need to make a note in the ChangeLog about a stylebot error that is mention in the bug. btw, that bug is https://bugs.webkit.org/show_bug.cgi?id=39514 if you feel inclined to fix it :) 266803 4 64866 scheib 2010-08-19 09:54:02 -0700 Created attachment 64866 Patch 266830 5 64866 commit-queue 2010-08-19 11:01:24 -0700 Comment on attachment 64866 Patch Rejecting patch 64866 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20876 test cases. fast/frames/flattening/iframe-flattening-offscreen.html -> failed Exiting early after 1 failures. 8000 tests run. 259.24s total testing time 7999 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 5 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3776377 266865 6 64866 commit-queue 2010-08-19 11:46:43 -0700 Comment on attachment 64866 Patch Clearing flags on attachment: 64866 Committed r65688: <http://trac.webkit.org/changeset/65688> 266866 7 commit-queue 2010-08-19 11:46:49 -0700 All reviewed patches have been landed. Closing bug. 64793 2010-08-18 17:34:37 -0700 2010-08-19 09:54:00 -0700 Patch bug-44223-20100818173436.patch text/plain 2010 scheib ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDgyOTcwNWU5NWE5ZjcxNGFiMmM0MmJlZmExMTkyYThiYjZjNTI4OGUu LjJmYTY1ZThhNjFkNDI2ZGQ3M2Y0YmU2YjBmOTExNjBkZTcxNWYxZGMgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDEwLTA4LTE4ICBWaW5jZW50IFNjaGVpYiAgPHNjaGVpYkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRml4aW5nIHByZXZpb3VzIE1hYyBvbmx5IGJ1aWxkIGJyZWFrYWdlIHdpdGggVGlsaW5nRGF0 YVRlc3QuY3BwCisKKyAgICAgICAgVGhlIHRlc3QgaW5jbHVkZWQgdGhlIHdyb25nIGhlYWRlciwg d2hpY2ggaGFkIGEgY29tcGlsZSBvcHRpb24gYXJvdW5kIHRoZSBkZWZpbml0aW9uIG9mIHRoZSBX ZWJDb3JlIG5hbWVzcGFjZS4gV2l0aG91dCB0aGUgbmFtZXNwYWNlIGRlZmluZWQsIGVycm9yLiBG aXhlZCBieSBjb3JyZWN0bHkgaW5jbHVkaW5nIFRpbGluZ0RhdGEuaCwgd2hpY2ggaGFzIG5vIGNv bmRpdGlvbmFsIGNvbXBpbGF0aW9uLgorCisgICAgICAgIE5vdGU6IFN0eWxlIGVycm9yIGlzIGEg ZmFsc2UgcG9zaXRpdmUsIHNpbmNlIHRoZXJlIGlzIG5vIC5oIGZpbGUgZm9yIFRpbGluZ0RhdGFU ZXN0LmNwcAorCisgICAgICAgICogV2ViS2l0Lmd5cDoKKyAgICAgICAgKiB0ZXN0cy9UaWxpbmdE YXRhVGVzdC5jcHA6CisKIDIwMTAtMDgtMTggIEppYW4gTGkgIDxqaWFubGlAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KZGlmZiAtLWdpdCBhL1dlYktp dC9jaHJvbWl1bS9XZWJLaXQuZ3lwIGIvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAKaW5kZXgg NGQ5MzA3MTJmZjc5OWJlZWUxZjlmMjJkY2IxMTlhZmFhMmI5MmViMi4uNGU4MTFkODVhNjUyMGY0 MTU3ZThhYjE4ODhiMjg0YTIwZGNiYTliMiAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL1dl YktpdC5neXAKKysrIGIvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAKQEAgLTczOCw4ICs3Mzgs NyBAQAogICAgICAgICAgICAgICAgICAgICAgICAgJ3Rlc3RzL0tleWJvYXJkVGVzdC5jcHAnLAog ICAgICAgICAgICAgICAgICAgICAgICAgJ3Rlc3RzL0tVUkxUZXN0LmNwcCcsCiAgICAgICAgICAg ICAgICAgICAgICAgICAndGVzdHMvUnVuQWxsVGVzdHMuY3BwJywKLSAgICAgICAgICAgICAgICAg ICAgICAgICMgRklYTUU6IFRoaXMgdGVzdCBpcyBjb21waWxlIGZhaWxpbmcgb24gbWFjLgotICAg ICAgICAgICAgICAgICAgICAgICAgIyAndGVzdHMvVGlsaW5nRGF0YVRlc3QuY3BwJywKKyAgICAg ICAgICAgICAgICAgICAgICAgICd0ZXN0cy9UaWxpbmdEYXRhVGVzdC5jcHAnLAogICAgICAgICAg ICAgICAgICAgICBdLAogICAgICAgICAgICAgICAgICAgICAnY29uZGl0aW9ucyc6IFsKICAgICAg ICAgICAgICAgICAgICAgICAgIFsnT1M9PSJ3aW4iJywgewpkaWZmIC0tZ2l0IGEvV2ViS2l0L2No cm9taXVtL3Rlc3RzL1RpbGluZ0RhdGFUZXN0LmNwcCBiL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9U aWxpbmdEYXRhVGVzdC5jcHAKaW5kZXggNDYzNTQyYmE1ZDYzODk5MWRiNDY1ZTMwNTBhNzUxNmJi Y2ZiYWZhMi4uOWVkNDFiMzJiOThlZWFlOGJlZjUzY2E0NjUzN2UzYTRmZDI4MjM0YiAxMDA3NTUK LS0tIGEvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1RpbGluZ0RhdGFUZXN0LmNwcAorKysgYi9XZWJL aXQvY2hyb21pdW0vdGVzdHMvVGlsaW5nRGF0YVRlc3QuY3BwCkBAIC0zMCw3ICszMCw3IEBACiAK ICNpbmNsdWRlICJjb25maWcuaCIKIAotI2luY2x1ZGUgIkdMRVMyVGV4dHVyZS5oIgorI2luY2x1 ZGUgIlRpbGluZ0RhdGEuaCIKICNpbmNsdWRlIDxndGVzdC9ndGVzdC5oPgogCiB1c2luZyBuYW1l c3BhY2UgV2ViQ29yZTsK 64866 2010-08-19 09:54:02 -0700 2010-08-19 11:46:43 -0700 Patch bug-44223-20100819095401.patch text/plain 2008 scheib ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDgyOTcwNWU5NWE5ZjcxNGFiMmM0MmJlZmExMTkyYThiYjZjNTI4OGUu LjliYjBlNGM3YzZiM2ZiYWJkZjU5ZmI2MGExMDNlZWI4MGJlMTczYzMgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE4IEBACisyMDEwLTA4LTE4ICBWaW5jZW50IFNjaGVpYiAgPHNjaGVpYkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRml4aW5nIHByZXZpb3VzIE1hYyBvbmx5IGJ1aWxkIGJyZWFrYWdlIHdpdGggVGlsaW5nRGF0 YVRlc3QuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00NDIyMworCisgICAgICAgIFRpbGluZ0RhdGFUZXN0LmNwcCBpbmNsdWRlZCB0aGUgd3Jvbmcg aGVhZGVyLCB3aGljaCBoYWQgYSBjb21waWxlIAorICAgICAgICBvcHRpb24gYXJvdW5kIHRoZSBk ZWZpbml0aW9uIG9mIHRoZSBXZWJDb3JlIG5hbWVzcGFjZS4gV2l0aG91dCB0aGUgCisgICAgICAg IG5hbWVzcGFjZSBkZWZpbmVkLCBlcnJvci4gRml4ZWQgYnkgY29ycmVjdGx5IGluY2x1ZGluZyBU aWxpbmdEYXRhLmgsIAorICAgICAgICB3aGljaCBoYXMgbm8gY29uZGl0aW9uYWwgY29tcGlsYXRp b24uCisKKyAgICAgICAgKiBXZWJLaXQuZ3lwOgorICAgICAgICAqIHRlc3RzL1RpbGluZ0RhdGFU ZXN0LmNwcDoKKwogMjAxMC0wOC0xOCAgSmlhbiBMaSAgPGppYW5saUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2No cm9taXVtL1dlYktpdC5neXAgYi9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cAppbmRleCA0ZDkz MDcxMmZmNzk5YmVlZTFmOWYyMmRjYjExOWFmYWEyYjkyZWIyLi40ZTgxMWQ4NWE2NTIwZjQxNTdl OGFiMTg4OGIyODRhMjBkY2JhOWIyIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0 Lmd5cAorKysgYi9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cApAQCAtNzM4LDggKzczOCw3IEBA CiAgICAgICAgICAgICAgICAgICAgICAgICAndGVzdHMvS2V5Ym9hcmRUZXN0LmNwcCcsCiAgICAg ICAgICAgICAgICAgICAgICAgICAndGVzdHMvS1VSTFRlc3QuY3BwJywKICAgICAgICAgICAgICAg ICAgICAgICAgICd0ZXN0cy9SdW5BbGxUZXN0cy5jcHAnLAotICAgICAgICAgICAgICAgICAgICAg ICAgIyBGSVhNRTogVGhpcyB0ZXN0IGlzIGNvbXBpbGUgZmFpbGluZyBvbiBtYWMuCi0gICAgICAg ICAgICAgICAgICAgICAgICAjICd0ZXN0cy9UaWxpbmdEYXRhVGVzdC5jcHAnLAorICAgICAgICAg ICAgICAgICAgICAgICAgJ3Rlc3RzL1RpbGluZ0RhdGFUZXN0LmNwcCcsCiAgICAgICAgICAgICAg ICAgICAgIF0sCiAgICAgICAgICAgICAgICAgICAgICdjb25kaXRpb25zJzogWwogICAgICAgICAg ICAgICAgICAgICAgICAgWydPUz09IndpbiInLCB7CmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21p dW0vdGVzdHMvVGlsaW5nRGF0YVRlc3QuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1RpbGlu Z0RhdGFUZXN0LmNwcAppbmRleCA0NjM1NDJiYTVkNjM4OTkxZGI0NjVlMzA1MGE3NTE2YmJjZmJh ZmEyLi44NjdiZDhkYjFjYTI4MzBmNWU1MjMxOWFiMGMxNGEyZjNhMGVlZjk5IDEwMDc1NQotLS0g YS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvVGlsaW5nRGF0YVRlc3QuY3BwCisrKyBiL1dlYktpdC9j aHJvbWl1bS90ZXN0cy9UaWxpbmdEYXRhVGVzdC5jcHAKQEAgLTMwLDcgKzMwLDggQEAKIAogI2lu Y2x1ZGUgImNvbmZpZy5oIgogCi0jaW5jbHVkZSAiR0xFUzJUZXh0dXJlLmgiCisjaW5jbHVkZSAi VGlsaW5nRGF0YS5oIgorCiAjaW5jbHVkZSA8Z3Rlc3QvZ3Rlc3QuaD4KIAogdXNpbmcgbmFtZXNw YWNlIFdlYkNvcmU7Cg==