4421 2005-08-13 23:02:25 -0700 speed up JavaScript by inlining some label stack functions 2005-08-14 09:39:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore 420+ Mac OS X 10.4 RESOLVED FIXED P2 Enhancement --- 1 darin darin oldest_to_newest 16607 0 darin 2005-08-13 23:02:25 -0700 I did some profiling and found a way to speed up JavaScript that helps us on iBench. 16609 1 3369 darin 2005-08-13 23:07:01 -0700 Created attachment 3369 patch inlines and simplifies some things, removes some unused functions 16610 2 darin 2005-08-13 23:07:49 -0700 Sped up iBench JavaScript by 0.5% in one test I did. Probably does more in conjunction with other speedups; I tested them separately. 3369 2005-08-13 23:07:01 -0700 2005-08-14 02:02:57 -0700 patch inlines and simplifies some things, removes some unused functions LabelStackInlinePatch.txt text/plain 2913 darin LS0tIGludGVybmFsLmgJMjAwNS0wOC0wNyAyMDoxODo0NS4wMDAwMDAwMDAgLTA3MDAKKysrIC9W b2x1bWVzL0hvbWUvZGFyaW4vRGVza3RvcC9QYXRjaGVzL3NhdmVkIHNwZWVkdXBzL2ludGVybmFs LmgJMjAwNS0wNy0yNSAyMzozMzozMi4wMDAwMDAwMDAgLTA3MDAKQEAgLTEzOSw5ICsxMzgsNiBA QAogICAgIExhYmVsU3RhY2soKTogdG9zKDBMKSwgaXRlcmF0aW9uRGVwdGgoMCksIHN3aXRjaERl cHRoKDApIHt9CiAgICAgfkxhYmVsU3RhY2soKTsKIAotICAgIExhYmVsU3RhY2soY29uc3QgTGFi ZWxTdGFjayAmb3RoZXIpOwotICAgIExhYmVsU3RhY2sgJm9wZXJhdG9yPShjb25zdCBMYWJlbFN0 YWNrICZvdGhlcik7Ci0KICAgICAvKioKICAgICAgKiBJZiBpZCBpcyBub3QgZW1wdHkgYW5kIGlz IG5vdCBpbiB0aGUgc3RhY2sgYWxyZWFkeSwgcHV0cyBpdCBvbiB0b3Agb2YKICAgICAgKiB0aGUg c3RhY2sgYW5kIHJldHVybnMgdHJ1ZSwgb3RoZXJ3aXNlIHJldHVybnMgZmFsc2UKQEAgLTE2NSwx MyArMTYxLDE1IEBACiAgICAgYm9vbCBpblN3aXRjaCgpIGNvbnN0IHsgcmV0dXJuIChzd2l0Y2hE ZXB0aCA+IDApOyB9CiAgICAgCiAgIHByaXZhdGU6CisgICAgTGFiZWxTdGFjayhjb25zdCBMYWJl bFN0YWNrICZvdGhlcik7CisgICAgTGFiZWxTdGFjayAmb3BlcmF0b3I9KGNvbnN0IExhYmVsU3Rh Y2sgJm90aGVyKTsKKwogICAgIHN0cnVjdCBTdGFja0VsZW0gewogICAgICAgSWRlbnRpZmllciBp ZDsKICAgICAgIFN0YWNrRWxlbSAqcHJldjsKICAgICB9OwogCiAgICAgU3RhY2tFbGVtICp0b3M7 Ci0gICAgdm9pZCBjbGVhcigpOwogICAgIGludCBpdGVyYXRpb25EZXB0aDsKICAgICBpbnQgc3dp dGNoRGVwdGg7CiAgIH07CkBAIC0zMTgsNiArMzE2LDggQEAKIAogICBwcml2YXRlOgogICAgIHZv aWQgY2xlYXIoKTsKKyAgICB2b2lkIGRlbGV0ZUFsbCgpOworICAgIAogICAgIEludGVycHJldGVy ICptX2ludGVycHJldGVyOwogICAgIFByb3RlY3RlZE9iamVjdCBnbG9iYWw7CiAgICAgRGVidWdn ZXIgKmRiZzsKQEAgLTQwNyw2ICs0MDcsMjMgQEAKICAgdm9pZCBwcmludEluZm8oRXhlY1N0YXRl ICpleGVjLCBjb25zdCBjaGFyICpzLCBWYWx1ZUltcCAqLCBpbnQgbGluZW5vID0gLTEpOwogI2Vu ZGlmCiAKK2lubGluZSBMYWJlbFN0YWNrOjp+TGFiZWxTdGFjaygpCit7CisgICAgU3RhY2tFbGVt ICpwcmV2OworICAgIGZvciAoU3RhY2tFbGVtICplID0gdG9zOyBlOyBlID0gcHJldikgeworICAg ICAgICBwcmV2ID0gZS0+cHJldjsKKyAgICAgICAgZGVsZXRlIGU7CisgICAgfQorfQorCitpbmxp bmUgdm9pZCBMYWJlbFN0YWNrOjpwb3AoKQoreworICAgIGlmIChTdGFja0VsZW0gKmUgPSB0b3Mp IHsKKyAgICAgICAgdG9zID0gZS0+cHJldjsKKyAgICAgICAgZGVsZXRlIGU7CisgICAgfQorfQor CiB9IC8vIG5hbWVzcGFjZQogCiAjZW5kaWYgLy8gIElOVEVSTkFMX0gKLS0tIGludGVybmFsLmNw cAkyMDA1LTA4LTA4IDEwOjAwOjMwLjAwMDAwMDAwMCAtMDcwMAorKysgL1ZvbHVtZXMvSG9tZS9k YXJpbi9EZXNrdG9wL1BhdGNoZXMvc2F2ZWQgc3BlZWR1cHMvaW50ZXJuYWwuY3BwCTIwMDUtMDct MjUgMjM6MzM6MjkuMDAwMDAwMDAwIC0wNzAwCkBAIC0yNjAsMzIgKzI2MCw2IEBACiAKIC8vIC0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSBMYWJlbFN0YWNrIC0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tCiAKLUxhYmVsU3RhY2s6OkxhYmVsU3RhY2soY29uc3QgTGFiZWxT dGFjayAmb3RoZXIpCi17Ci0gIHRvcyA9IDA7Ci0gICp0aGlzID0gb3RoZXI7Ci19Ci0KLUxhYmVs U3RhY2sgJkxhYmVsU3RhY2s6Om9wZXJhdG9yPShjb25zdCBMYWJlbFN0YWNrICZvdGhlcikKLXsK LSAgY2xlYXIoKTsKLSAgdG9zID0gMDsKLSAgU3RhY2tFbGVtICpjdXIgPSAwOwotICBTdGFja0Vs ZW0gKnNlID0gb3RoZXIudG9zOwotICB3aGlsZSAoc2UpIHsKLSAgICBTdGFja0VsZW0gKm5ld1By ZXYgPSBuZXcgU3RhY2tFbGVtOwotICAgIG5ld1ByZXYtPnByZXYgPSAwOwotICAgIG5ld1ByZXYt PmlkID0gc2UtPmlkOwotICAgIGlmIChjdXIpCi0gICAgICBjdXItPnByZXYgPSBuZXdQcmV2Owot ICAgIGVsc2UKLSAgICAgIHRvcyA9IG5ld1ByZXY7Ci0gICAgY3VyID0gbmV3UHJldjsKLSAgICBz ZSA9IHNlLT5wcmV2OwotICB9Ci0gIHJldHVybiAqdGhpczsKLX0KLQogYm9vbCBMYWJlbFN0YWNr OjpwdXNoKGNvbnN0IElkZW50aWZpZXIgJmlkKQogewogICBpZiAoY29udGFpbnMoaWQpKQpAQCAt MzEwLDMxICsyODQsNiBAQAogICByZXR1cm4gZmFsc2U7CiB9CiAKLXZvaWQgTGFiZWxTdGFjazo6 cG9wKCkKLXsKLSAgaWYgKHRvcykgewotICAgIFN0YWNrRWxlbSAqcHJldiA9IHRvcy0+cHJldjsK LSAgICBkZWxldGUgdG9zOwotICAgIHRvcyA9IHByZXY7Ci0gIH0KLX0KLQotTGFiZWxTdGFjazo6 fkxhYmVsU3RhY2soKQotewotICBjbGVhcigpOwotfQotCi12b2lkIExhYmVsU3RhY2s6OmNsZWFy KCkKLXsKLSAgU3RhY2tFbGVtICpwcmV2OwotCi0gIHdoaWxlICh0b3MpIHsKLSAgICBwcmV2ID0g dG9zLT5wcmV2OwotICAgIGRlbGV0ZSB0b3M7Ci0gICAgdG9zID0gcHJldjsKLSAgfQotfQotCiAv LyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0gQ29udGV4dEltcCAtLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLQogCiAvLyBFQ01BIDEwLjIKQEAgLTQyNSw3ICszNzQsNiBA QAogICBMZXhlcjo6Y3VycigpLT5kb25lUGFyc2luZygpOwogICBQcm9ncmFtTm9kZSAqcHJvZyA9 IHByb2dOb2RlOwogICBwcm9nTm9kZSA9IDA7Ci0vLyAgc2lkID0gLTE7CiAKICAgaWYgKHBhcnNl RXJyb3IgfHwgbGV4RXJyb3IpIHsKICAgICBpbnQgZWxpbmUgPSBMZXhlcjo6Y3VycigpLT5saW5l Tm8oKTsK