44205 2010-08-18 14:49:07 -0700 [Chromium] Add Full screen item to video context menu 2013-04-09 16:09:57 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED WONTFIX P2 Normal --- 0 boliu webkit-unassigned boliu scherkus oldest_to_newest 266391 0 boliu 2010-08-18 14:49:07 -0700 Corresponding Chromium patch: http://codereview.chromium.org/3124032 Adds a Fullscreen WebMediaPlayerAction. 266403 1 64778 boliu 2010-08-18 14:58:43 -0700 Created attachment 64778 Patch 266797 2 64778 scherkus 2010-08-19 09:46:06 -0700 Comment on attachment 64778 Patch WebKit/chromium/src/WebViewImpl.cpp:1516 + // Bring full screen window into focus if isFullscreen. is this a TODO or leftover comment? 266800 3 boliu 2010-08-19 09:48:11 -0700 It's a "Not Implemented"/TODO comment. 266821 4 64778 scherkus 2010-08-19 10:50:21 -0700 Comment on attachment 64778 Patch WebKit/chromium/src/WebViewImpl.cpp:1516 + // Bring full screen window into focus if isFullscreen. ok in which case you should make this a // FIXME: Bring full screen blah blah blah ... 266857 5 64879 boliu 2010-08-19 11:30:04 -0700 Created attachment 64879 Update comment to FIXME 271724 6 64879 abarth 2010-08-30 16:15:06 -0700 Comment on attachment 64879 Update comment to FIXME This patch is missing a ChangeLog. 872156 7 schenney 2013-04-09 16:09:57 -0700 LayoutTest failures for Chromium are being marked WontFix. The Bug is still accessible and referenced from TestExpectations. 64778 2010-08-18 14:58:43 -0700 2010-08-19 11:30:01 -0700 Patch bug-44205-20100818145841.patch text/plain 1228 boliu ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXJBY3Rpb24u aCBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXJBY3Rpb24uaAppbmRleCAx OTI3MDRmNjU0NWIyZGQxOTBlOTNjZGI1MGNhYjM1NWI4ZjMxMzM0Li40Y2ZmNTFiYmVhOWUyNmNm ZDllZDQ0MzlmZDE2MTZkMDFhZmMwMGMxIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYk1lZGlhUGxheWVyQWN0aW9uLmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJNZWRpYVBsYXllckFjdGlvbi5oCkBAIC0zOSw3ICszOSw4IEBAIHN0cnVjdCBXZWJNZWRpYVBs YXllckFjdGlvbiB7CiAgICAgICAgIFBsYXksCiAgICAgICAgIE11dGUsCiAgICAgICAgIExvb3As Ci0gICAgICAgIENvbnRyb2xzCisgICAgICAgIENvbnRyb2xzLAorICAgICAgICBGdWxsc2NyZWVu CiAgICAgfTsKIAogICAgIFR5cGUgdHlwZTsKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViVmlld0ltcGwuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAK aW5kZXggNjJiMjBkNWZiNTk0NzdkZjI0NDhiMDNiYTk1ZTg4MzA1MWExOWIxZC4uZjdiNDc4MjFh YzU2ZjhjMjhhOWI3NDM3YzZiMTQzMjViMjI2OGZmNSAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3 SW1wbC5jcHAKQEAgLTE1MTAsNiArMTUxMCwxMSBAQCB2b2lkIFdlYlZpZXdJbXBsOjpwZXJmb3Jt TWVkaWFQbGF5ZXJBY3Rpb24oY29uc3QgV2ViTWVkaWFQbGF5ZXJBY3Rpb24mIGFjdGlvbiwKICAg ICBjYXNlIFdlYk1lZGlhUGxheWVyQWN0aW9uOjpDb250cm9sczoKICAgICAgICAgbWVkaWFFbGVt ZW50LT5zZXRDb250cm9scyhhY3Rpb24uZW5hYmxlKTsKICAgICAgICAgYnJlYWs7CisgICAgY2Fz ZSBXZWJNZWRpYVBsYXllckFjdGlvbjo6RnVsbHNjcmVlbjoKKyAgICAgICAgaWYgKCFtZWRpYUVs ZW1lbnQtPmlzRnVsbHNjcmVlbigpKQorICAgICAgICAgICAgbWVkaWFFbGVtZW50LT5lbnRlckZ1 bGxzY3JlZW4oKTsKKyAgICAgICAgLy8gQnJpbmcgZnVsbCBzY3JlZW4gd2luZG93IGludG8gZm9j dXMgaWYgaXNGdWxsc2NyZWVuLgorICAgICAgICBicmVhazsKICAgICBkZWZhdWx0OgogICAgICAg ICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICB9Cg== 64879 2010-08-19 11:30:04 -0700 2010-08-30 16:15:06 -0700 Update comment to FIXME bug-44205-20100819113002.patch text/plain 1245 boliu ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXJBY3Rpb24u aCBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViTWVkaWFQbGF5ZXJBY3Rpb24uaAppbmRleCAx OTI3MDRmNjU0NWIyZGQxOTBlOTNjZGI1MGNhYjM1NWI4ZjMxMzM0Li40Y2ZmNTFiYmVhOWUyNmNm ZDllZDQ0MzlmZDE2MTZkMDFhZmMwMGMxIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vcHVi bGljL1dlYk1lZGlhUGxheWVyQWN0aW9uLmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJNZWRpYVBsYXllckFjdGlvbi5oCkBAIC0zOSw3ICszOSw4IEBAIHN0cnVjdCBXZWJNZWRpYVBs YXllckFjdGlvbiB7CiAgICAgICAgIFBsYXksCiAgICAgICAgIE11dGUsCiAgICAgICAgIExvb3As Ci0gICAgICAgIENvbnRyb2xzCisgICAgICAgIENvbnRyb2xzLAorICAgICAgICBGdWxsc2NyZWVu CiAgICAgfTsKIAogICAgIFR5cGUgdHlwZTsKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViVmlld0ltcGwuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAK aW5kZXggNjJiMjBkNWZiNTk0NzdkZjI0NDhiMDNiYTk1ZTg4MzA1MWExOWIxZC4uZTgzNmVhMWE1 ODAwYTJhY2ViYWY4NGI5MDE5MTlkMWJjOTM0NGQ0ZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3 SW1wbC5jcHAKQEAgLTE1MTAsNiArMTUxMCwxMSBAQCB2b2lkIFdlYlZpZXdJbXBsOjpwZXJmb3Jt TWVkaWFQbGF5ZXJBY3Rpb24oY29uc3QgV2ViTWVkaWFQbGF5ZXJBY3Rpb24mIGFjdGlvbiwKICAg ICBjYXNlIFdlYk1lZGlhUGxheWVyQWN0aW9uOjpDb250cm9sczoKICAgICAgICAgbWVkaWFFbGVt ZW50LT5zZXRDb250cm9scyhhY3Rpb24uZW5hYmxlKTsKICAgICAgICAgYnJlYWs7CisgICAgY2Fz ZSBXZWJNZWRpYVBsYXllckFjdGlvbjo6RnVsbHNjcmVlbjoKKyAgICAgICAgaWYgKCFtZWRpYUVs ZW1lbnQtPmlzRnVsbHNjcmVlbigpKQorICAgICAgICAgICAgbWVkaWFFbGVtZW50LT5lbnRlckZ1 bGxzY3JlZW4oKTsKKyAgICAgICAgLy8gRklYTUU6IEJyaW5nIGZ1bGwgc2NyZWVuIHdpbmRvdyBp bnRvIGZvY3VzIGlmIGlzRnVsbHNjcmVlbigpIGlzIFRSVUUuCisgICAgICAgIGJyZWFrOwogICAg IGRlZmF1bHQ6CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIH0K