44198 2010-08-18 13:17:24 -0700 [Chromium] m_downloadFilePath should be copied in WebURLRequestPrivateImpl's and WebURLResponsePrivateImpl's constructors 2010-08-18 16:18:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dumi dumi abarth eric fishd webkit.review.bot oldest_to_newest 266334 0 dumi 2010-08-18 13:17:24 -0700 The m_downloadFilePath flag is currently not propagated correctly, because WebURLRequestPrivateImpl's and WebURLResponsePrivateImpl's constructors don't copy it. We should fix that. 266407 1 64779 dumi 2010-08-18 15:00:56 -0700 Created attachment 64779 patch 266429 2 dumi 2010-08-18 15:47:05 -0700 landed: r65636. 266440 3 webkit.review.bot 2010-08-18 16:18:53 -0700 http://trac.webkit.org/changeset/65636 might have broken Chromium Mac Release The following changes are on the blame list: http://trac.webkit.org/changeset/65635 http://trac.webkit.org/changeset/65636 http://trac.webkit.org/changeset/65637 64779 2010-08-18 15:00:56 -0700 2010-08-18 15:03:47 -0700 patch patch text/plain 1769 dumi SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjU2MzEpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDgtMTggIER1bWl0 cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQcm9wYWdhdGUgdGhlIG1fZG93bmxvYWRGaWxlUGF0 aCBjb3JyZWN0bHkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00NDE5OAorCisgICAgICAgICogc3JjL1dlYlVSTFJlcXVlc3QuY3BwOgorICAgICAgICAo V2ViS2l0OjpXZWJVUkxSZXF1ZXN0UHJpdmF0ZUltcGw6OldlYlVSTFJlcXVlc3RQcml2YXRlSW1w bCk6CisgICAgICAgICogc3JjL1dlYlVSTFJlc3BvbnNlLmNwcDoKKyAgICAgICAgKFdlYktpdDo6 V2ViVVJMUmVzcG9uc2VQcml2YXRlSW1wbDo6V2ViVVJMUmVzcG9uc2VQcml2YXRlSW1wbCk6CisK IDIwMTAtMDgtMTcgIElseWEgVGlraG9ub3Zza3kgIDxsb2lzbG9AY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCkluZGV4OiBXZWJLaXQvY2hyb21p dW0vc3JjL1dlYlVSTFJlcXVlc3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9z cmMvV2ViVVJMUmVxdWVzdC5jcHAJKHJldmlzaW9uIDY1NjMxKQorKysgV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJVUkxSZXF1ZXN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTUsNiArNTUsOCBAQCBw dWJsaWM6CiAgICAgICAgIDogbV9yZXNvdXJjZVJlcXVlc3RBbGxvY2F0aW9uKCpwLT5tX3Jlc291 cmNlUmVxdWVzdCkKICAgICB7CiAgICAgICAgIG1fcmVzb3VyY2VSZXF1ZXN0ID0gJm1fcmVzb3Vy Y2VSZXF1ZXN0QWxsb2NhdGlvbjsKKyAgICAgICAgbV9hbGxvd1N0b3JlZENyZWRlbnRpYWxzID0g cC0+bV9hbGxvd1N0b3JlZENyZWRlbnRpYWxzOworICAgICAgICBtX2Rvd25sb2FkVG9GaWxlID0g cC0+bV9kb3dubG9hZFRvRmlsZTsKICAgICB9CiAKICAgICB2aXJ0dWFsIHZvaWQgZGlzcG9zZSgp IHsgZGVsZXRlIHRoaXM7IH0KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVVJMUmVzcG9u c2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVVJMUmVzcG9uc2Uu Y3BwCShyZXZpc2lvbiA2NTYzMSkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVVJMUmVzcG9u c2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01OSw2ICs1OSw3IEBAIHB1YmxpYzoKICAgICAgICAg OiBtX3Jlc291cmNlUmVzcG9uc2VBbGxvY2F0aW9uKCpwLT5tX3Jlc291cmNlUmVzcG9uc2UpCiAg ICAgewogICAgICAgICBtX3Jlc291cmNlUmVzcG9uc2UgPSAmbV9yZXNvdXJjZVJlc3BvbnNlQWxs b2NhdGlvbjsKKyAgICAgICAgbV9kb3dubG9hZEZpbGVQYXRoID0gcC0+bV9kb3dubG9hZEZpbGVQ YXRoOwogICAgIH0KIAogICAgIHZpcnR1YWwgdm9pZCBkaXNwb3NlKCkgeyBkZWxldGUgdGhpczsg fQo=