44196 2010-08-18 12:48:59 -0700 [chromium] Accelerated Compositing: Artifacts/blink when enabling compositor 2010-08-30 21:25:23 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 nduca webkit-unassigned commit-queue fishd nduca vangelis webkit.review.bot oldest_to_newest 266324 0 nduca 2010-08-18 12:48:59 -0700 When compositor activates due to a DOM change, webkit dirties only the rect affected by the change, for example just the client area but not the scroll bar. This causes the compositor to receive only the client area rather than the complete view, leading to bits of blue where none should be. 266371 1 64770 nduca 2010-08-18 14:22:37 -0700 Created attachment 64770 Invalidate view when compositor activates 266942 2 64896 nduca 2010-08-19 14:00:09 -0700 Created attachment 64896 Simpler fix, use rect(0,0,m_size.w,m_Size.h) instead of viewableRect 266945 3 webkit.review.bot 2010-08-19 14:04:27 -0700 Attachment 64896 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/chromium/src/WebViewImpl.cpp:2125: Missing space after , [whitespace/comma] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 266947 4 64898 nduca 2010-08-19 14:04:45 -0700 Created attachment 64898 Make style bot happy 266951 5 webkit.review.bot 2010-08-19 14:05:51 -0700 Attachment 64898 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/chromium/src/WebViewImpl.cpp:2125: Missing space after , [whitespace/comma] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 266991 6 64903 nduca 2010-08-19 15:06:23 -0700 Created attachment 64903 Trying again. Not my day for patch files, it seems. 271726 7 64903 abarth 2010-08-30 16:17:50 -0700 Comment on attachment 64903 Trying again. Not my day for patch files, it seems. Looks reasonable to me, but I'm not an expert in this area. 271749 8 64903 vangelis 2010-08-30 16:35:25 -0700 Comment on attachment 64903 Trying again. Not my day for patch files, it seems. Looks good on my side too. cq+ from me. 271774 9 64903 commit-queue 2010-08-30 17:03:21 -0700 Comment on attachment 64903 Trying again. Not my day for patch files, it seems. Rejecting patch 64903 from commit-queue. vangelis@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 271831 10 64903 vangelis 2010-08-30 18:14:35 -0700 Comment on attachment 64903 Trying again. Not my day for patch files, it seems. One more try to get it to the commit queue. 271832 11 64903 vangelis 2010-08-30 18:15:13 -0700 Comment on attachment 64903 Trying again. Not my day for patch files, it seems. with the flag set correctly this time :) 271834 12 64903 commit-queue 2010-08-30 18:18:46 -0700 Comment on attachment 64903 Trying again. Not my day for patch files, it seems. Rejecting patch 64903 from commit-queue. vangelis@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 271911 13 64903 commit-queue 2010-08-30 21:25:18 -0700 Comment on attachment 64903 Trying again. Not my day for patch files, it seems. Clearing flags on attachment: 64903 Committed r66450: <http://trac.webkit.org/changeset/66450> 271912 14 commit-queue 2010-08-30 21:25:23 -0700 All reviewed patches have been landed. Closing bug. 64770 2010-08-18 14:22:37 -0700 2010-08-19 14:00:09 -0700 Invalidate view when compositor activates enabling_artefacts.patch text/plain 2036 nduca SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjU2MjgpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDgtMTggIE5hdCBE dWNhICA8bmR1Y2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gQWNjZWxlcmF0ZWQgQ29tcG9zaXRpbmc6IEFy dGlmYWN0cy9ibGluayB3aGVuIGVuYWJsaW5nIGNvbXBvc2l0b3IuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDE5NgorCisgICAgICAgIElmIGFjY2Vs ZXJhdGVkIGNvbXBvc2l0aW5nIGVuYWJsZXMgYWZ0ZXIgYSBwYWdlIGxvYWRzLCB0aGUgZGlydGll ZAorICAgICAgICBwb3J0aW9uIG9mIHRoZSBzY3JlZW4gd2lsbCBiZSBvbmx5IGEgc3Vic2V0IG9m IHRoZSBmdWxsIHNjcmVlbiwKKyAgICAgICAgbGVhZGluZyB0byBhcnRlZmFjdHMuIEF2b2lkIHRo ZXNlIGFydGVmYWN0cyBieSBpbnZhbGlkYXRpbmcgdGhlCisgICAgICAgIHZpc2libGUgY29udGVu dCByZWN0IG9uIGNvbXBvc2l0b3IgaW5pdGlhbGl6YXRpb24uCisKKyAgICAgICAgKiBzcmMvV2Vi Vmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6c2V0SXNBY2NlbGVy YXRlZENvbXBvc2l0aW5nQWN0aXZlKToKKwogMjAxMC0wOC0xNyAgSWx5YSBUaWtob25vdnNreSAg PGxvaXNsb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgWXVyeSBTZW1pa2hh dHNreS4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCShyZXZpc2lvbiA2NTQ2 NCkKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yMTE3LDkgKzIxMTcsMTggQEAgdm9pZCBXZWJWaWV3SW1wbDo6c2V0SXNBY2NlbGVyYXRl ZENvbXBvcwogCiAgICAgaWYgKGFjdGl2ZSkgewogICAgICAgICBtX2xheWVyUmVuZGVyZXIgPSBM YXllclJlbmRlcmVyQ2hyb21pdW06OmNyZWF0ZShnZXRPbnNjcmVlbkdMRVMyQ29udGV4dCgpKTsK LSAgICAgICAgaWYgKG1fbGF5ZXJSZW5kZXJlci0+aGFyZHdhcmVDb21wb3NpdGluZygpKQorICAg ICAgICBpZiAobV9sYXllclJlbmRlcmVyLT5oYXJkd2FyZUNvbXBvc2l0aW5nKCkpIHsKICAgICAg ICAgICAgIG1faXNBY2NlbGVyYXRlZENvbXBvc2l0aW5nQWN0aXZlID0gdHJ1ZTsKLSAgICAgICAg ZWxzZSB7CisgICAgICAgICAgICAKKyAgICAgICAgICAgIC8vIEZvcmNlIGEgcmVkcmF3IHRoZSBl bnRpcmUgdmlldyBzbyB0aGF0IHRoZSBjb21wb3NpdG9yIGdldHMgdGhlIGVudGlyZSB2aWV3LAor ICAgICAgICAgICAgLy8gcmF0aGVyIHRoYW4ganVzdCB0aGUgY3VycmVudGx5LWRpcnR5IHN1YnNl dC4KKyAgICAgICAgICAgIFdlYkZyYW1lSW1wbCogd2ViZnJhbWUgPSBtYWluRnJhbWVJbXBsKCk7 CisgICAgICAgICAgICBpZiAod2ViZnJhbWUpIHsKKyAgICAgICAgICAgICAgRnJhbWVWaWV3KiB2 aWV3ID0gd2ViZnJhbWUtPmZyYW1lVmlldygpOworICAgICAgICAgICAgICBpZiAodmlldykKKyAg ICAgICAgICAgICAgICBtX2NsaWVudC0+ZGlkSW52YWxpZGF0ZVJlY3Qodmlldy0+dmlzaWJsZUNv bnRlbnRSZWN0KHRydWUpKTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfSBlbHNlIHsKICAgICAg ICAgICAgIG1fbGF5ZXJSZW5kZXJlci5jbGVhcigpOwogICAgICAgICAgICAgbV9pc0FjY2VsZXJh dGVkQ29tcG9zaXRpbmdBY3RpdmUgPSBmYWxzZTsKICAgICAgICAgfQo= 64896 2010-08-19 14:00:09 -0700 2010-08-19 14:04:45 -0700 Simpler fix, use rect(0,0,m_size.w,m_Size.h) instead of viewableRect enabling_artefacts.patch text/plain 1854 nduca SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjU2OTcpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDgtMTggIE5hdCBE dWNhICA8bmR1Y2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gQWNjZWxlcmF0ZWQgQ29tcG9zaXRpbmc6IEFy dGlmYWN0cy9ibGluayB3aGVuIGVuYWJsaW5nIGNvbXBvc2l0b3IuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDE5NgorCisgICAgICAgIElmIGFjY2Vs ZXJhdGVkIGNvbXBvc2l0aW5nIGVuYWJsZXMgYWZ0ZXIgYSBwYWdlIGxvYWRzLCB0aGUgZGlydGll ZAorICAgICAgICBwb3J0aW9uIG9mIHRoZSBzY3JlZW4gd2lsbCBiZSBvbmx5IGEgc3Vic2V0IG9m IHRoZSBmdWxsIHNjcmVlbiwKKyAgICAgICAgbGVhZGluZyB0byBhcnRlZmFjdHMuIEF2b2lkIHRo ZXNlIGFydGVmYWN0cyBieSBpbnZhbGlkYXRpbmcgdGhlCisgICAgICAgIHZpc2libGUgY29udGVu dCByZWN0IG9uIGNvbXBvc2l0b3IgaW5pdGlhbGl6YXRpb24uCisKKyAgICAgICAgKiBzcmMvV2Vi Vmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6c2V0SXNBY2NlbGVy YXRlZENvbXBvc2l0aW5nQWN0aXZlKToKKwogMjAxMC0wOC0xOSAgVmluY2VudCBTY2hlaWIgIDxz Y2hlaWJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpJ bmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHJldmlzaW9uIDY1Njk3KQorKysg V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIx MTcsOSArMjExNywxMyBAQCB2b2lkIFdlYlZpZXdJbXBsOjpzZXRJc0FjY2VsZXJhdGVkQ29tcG9z CiAKICAgICBpZiAoYWN0aXZlKSB7CiAgICAgICAgIG1fbGF5ZXJSZW5kZXJlciA9IExheWVyUmVu ZGVyZXJDaHJvbWl1bTo6Y3JlYXRlKGdldE9uc2NyZWVuR0xFUzJDb250ZXh0KCkpOwotICAgICAg ICBpZiAobV9sYXllclJlbmRlcmVyLT5oYXJkd2FyZUNvbXBvc2l0aW5nKCkpCisgICAgICAgIGlm IChtX2xheWVyUmVuZGVyZXItPmhhcmR3YXJlQ29tcG9zaXRpbmcoKSkgewogICAgICAgICAgICAg bV9pc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdBY3RpdmUgPSB0cnVlOwotICAgICAgICBlbHNlIHsK KyAgICAgICAgICAgIAorICAgICAgICAgICAgLy8gRm9yY2UgYSByZWRyYXcgdGhlIGVudGlyZSB2 aWV3IHNvIHRoYXQgdGhlIGNvbXBvc2l0b3IgZ2V0cyB0aGUgZW50aXJlIHZpZXcsCisgICAgICAg ICAgICAvLyByYXRoZXIgdGhhbiBqdXN0IHRoZSBjdXJyZW50bHktZGlydHkgc3Vic2V0LgorICAg ICAgICAgICAgbV9jbGllbnQtPmRpZEludmFsaWRhdGVSZWN0KEludFJlY3QoMCwwLG1fc2l6ZS53 aWR0aCxtX3NpemUuaGVpZ2h0KSk7CisgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBtX2xh eWVyUmVuZGVyZXIuY2xlYXIoKTsKICAgICAgICAgICAgIG1faXNBY2NlbGVyYXRlZENvbXBvc2l0 aW5nQWN0aXZlID0gZmFsc2U7CiAgICAgICAgIH0K 64898 2010-08-19 14:04:45 -0700 2010-08-19 15:06:23 -0700 Make style bot happy enabling_artefacts.patch text/plain 1854 nduca SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjU2OTcpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDgtMTggIE5hdCBE dWNhICA8bmR1Y2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gQWNjZWxlcmF0ZWQgQ29tcG9zaXRpbmc6IEFy dGlmYWN0cy9ibGluayB3aGVuIGVuYWJsaW5nIGNvbXBvc2l0b3IuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDE5NgorCisgICAgICAgIElmIGFjY2Vs ZXJhdGVkIGNvbXBvc2l0aW5nIGVuYWJsZXMgYWZ0ZXIgYSBwYWdlIGxvYWRzLCB0aGUgZGlydGll ZAorICAgICAgICBwb3J0aW9uIG9mIHRoZSBzY3JlZW4gd2lsbCBiZSBvbmx5IGEgc3Vic2V0IG9m IHRoZSBmdWxsIHNjcmVlbiwKKyAgICAgICAgbGVhZGluZyB0byBhcnRlZmFjdHMuIEF2b2lkIHRo ZXNlIGFydGVmYWN0cyBieSBpbnZhbGlkYXRpbmcgdGhlCisgICAgICAgIHZpc2libGUgY29udGVu dCByZWN0IG9uIGNvbXBvc2l0b3IgaW5pdGlhbGl6YXRpb24uCisKKyAgICAgICAgKiBzcmMvV2Vi Vmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6c2V0SXNBY2NlbGVy YXRlZENvbXBvc2l0aW5nQWN0aXZlKToKKwogMjAxMC0wOC0xOSAgVmluY2VudCBTY2hlaWIgIDxz Y2hlaWJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpJ bmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHJldmlzaW9uIDY1Njk3KQorKysg V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIx MTcsOSArMjExNywxMyBAQCB2b2lkIFdlYlZpZXdJbXBsOjpzZXRJc0FjY2VsZXJhdGVkQ29tcG9z CiAKICAgICBpZiAoYWN0aXZlKSB7CiAgICAgICAgIG1fbGF5ZXJSZW5kZXJlciA9IExheWVyUmVu ZGVyZXJDaHJvbWl1bTo6Y3JlYXRlKGdldE9uc2NyZWVuR0xFUzJDb250ZXh0KCkpOwotICAgICAg ICBpZiAobV9sYXllclJlbmRlcmVyLT5oYXJkd2FyZUNvbXBvc2l0aW5nKCkpCisgICAgICAgIGlm IChtX2xheWVyUmVuZGVyZXItPmhhcmR3YXJlQ29tcG9zaXRpbmcoKSkgewogICAgICAgICAgICAg bV9pc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdBY3RpdmUgPSB0cnVlOwotICAgICAgICBlbHNlIHsK KyAgICAgICAgICAgIAorICAgICAgICAgICAgLy8gRm9yY2UgYSByZWRyYXcgdGhlIGVudGlyZSB2 aWV3IHNvIHRoYXQgdGhlIGNvbXBvc2l0b3IgZ2V0cyB0aGUgZW50aXJlIHZpZXcsCisgICAgICAg ICAgICAvLyByYXRoZXIgdGhhbiBqdXN0IHRoZSBjdXJyZW50bHktZGlydHkgc3Vic2V0LgorICAg ICAgICAgICAgbV9jbGllbnQtPmRpZEludmFsaWRhdGVSZWN0KEludFJlY3QoMCwwLG1fc2l6ZS53 aWR0aCxtX3NpemUuaGVpZ2h0KSk7CisgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBtX2xh eWVyUmVuZGVyZXIuY2xlYXIoKTsKICAgICAgICAgICAgIG1faXNBY2NlbGVyYXRlZENvbXBvc2l0 aW5nQWN0aXZlID0gZmFsc2U7CiAgICAgICAgIH0K 64903 2010-08-19 15:06:23 -0700 2010-08-30 21:25:17 -0700 Trying again. Not my day for patch files, it seems. again.patch text/plain 1857 nduca SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjU2OTcpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDgtMTggIE5hdCBE dWNhICA8bmR1Y2FAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gQWNjZWxlcmF0ZWQgQ29tcG9zaXRpbmc6IEFy dGlmYWN0cy9ibGluayB3aGVuIGVuYWJsaW5nIGNvbXBvc2l0b3IuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDE5NgorCisgICAgICAgIElmIGFjY2Vs ZXJhdGVkIGNvbXBvc2l0aW5nIGVuYWJsZXMgYWZ0ZXIgYSBwYWdlIGxvYWRzLCB0aGUgZGlydGll ZAorICAgICAgICBwb3J0aW9uIG9mIHRoZSBzY3JlZW4gd2lsbCBiZSBvbmx5IGEgc3Vic2V0IG9m IHRoZSBmdWxsIHNjcmVlbiwKKyAgICAgICAgbGVhZGluZyB0byBhcnRlZmFjdHMuIEF2b2lkIHRo ZXNlIGFydGVmYWN0cyBieSBpbnZhbGlkYXRpbmcgdGhlCisgICAgICAgIHZpc2libGUgY29udGVu dCByZWN0IG9uIGNvbXBvc2l0b3IgaW5pdGlhbGl6YXRpb24uCisKKyAgICAgICAgKiBzcmMvV2Vi Vmlld0ltcGwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJWaWV3SW1wbDo6c2V0SXNBY2NlbGVy YXRlZENvbXBvc2l0aW5nQWN0aXZlKToKKwogMjAxMC0wOC0xOSAgVmluY2VudCBTY2hlaWIgIDxz Y2hlaWJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpJ bmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHJldmlzaW9uIDY1Njk3KQorKysg V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIx MTcsOSArMjExNywxMyBAQCB2b2lkIFdlYlZpZXdJbXBsOjpzZXRJc0FjY2VsZXJhdGVkQ29tcG9z CiAKICAgICBpZiAoYWN0aXZlKSB7CiAgICAgICAgIG1fbGF5ZXJSZW5kZXJlciA9IExheWVyUmVu ZGVyZXJDaHJvbWl1bTo6Y3JlYXRlKGdldE9uc2NyZWVuR0xFUzJDb250ZXh0KCkpOwotICAgICAg ICBpZiAobV9sYXllclJlbmRlcmVyLT5oYXJkd2FyZUNvbXBvc2l0aW5nKCkpCisgICAgICAgIGlm IChtX2xheWVyUmVuZGVyZXItPmhhcmR3YXJlQ29tcG9zaXRpbmcoKSkgewogICAgICAgICAgICAg bV9pc0FjY2VsZXJhdGVkQ29tcG9zaXRpbmdBY3RpdmUgPSB0cnVlOwotICAgICAgICBlbHNlIHsK KyAgICAgICAgICAgIAorICAgICAgICAgICAgLy8gRm9yY2UgYSByZWRyYXcgdGhlIGVudGlyZSB2 aWV3IHNvIHRoYXQgdGhlIGNvbXBvc2l0b3IgZ2V0cyB0aGUgZW50aXJlIHZpZXcsCisgICAgICAg ICAgICAvLyByYXRoZXIgdGhhbiBqdXN0IHRoZSBjdXJyZW50bHktZGlydHkgc3Vic2V0LgorICAg ICAgICAgICAgbV9jbGllbnQtPmRpZEludmFsaWRhdGVSZWN0KEludFJlY3QoMCwgMCwgbV9zaXpl LndpZHRoLCBtX3NpemUuaGVpZ2h0KSk7CisgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBt X2xheWVyUmVuZGVyZXIuY2xlYXIoKTsKICAgICAgICAgICAgIG1faXNBY2NlbGVyYXRlZENvbXBv c2l0aW5nQWN0aXZlID0gZmFsc2U7CiAgICAgICAgIH0K