44180 2010-08-18 09:03:41 -0700 WebView::paint fails to paint a child WebView of a Layered Window 2010-08-18 11:18:38 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 jberlin jberlin aroben jberlin jhoneycutt oldest_to_newest 266139 0 jberlin 2010-08-18 09:03:41 -0700 Even though GetUpdateRect and GetUpdateRgn for a child WebView of a Layered Window report that the region that should be painted as non-empty in WebView::paint before the call to BeginPaint (http://msdn.microsoft.com/en-us/library/aa922023.aspx), BeginPaint still fills the rcPaint field of the PAINTSTRUCT with an empty RECT. This means http://trac.webkit.org/changeset/58900 causes WebView::paint to end the paint early, before painting the contents of child WebView of a Layered Window. A fix would be to check if the m_backingStoreBitmap is null after the call to ensureBackingStore (which will notice that the WebView isn't zero-sized in the case of the child WebView of a Layered Window that isn't zero-sized) instead of checking if the rcPaint rect is empty in order to determine whether to continue on with the paint or not. 266194 1 64724 jberlin 2010-08-18 10:14:39 -0700 Created attachment 64724 Check if m_backingStoreBitmap is null instead of whether rcPaint is empty 266214 2 64724 aroben 2010-08-18 10:36:11 -0700 Comment on attachment 64724 Check if m_backingStoreBitmap is null instead of whether rcPaint is empty > + bool backingStoreCompletelyDirty = ensureBackingStore(); > + if (!m_backingStoreBitmap) { > + EndPaint(m_viewWindow, &ps); > return; > } We should only call EndPaint if a dc was passed to this function. Otherwise we won't have called BeginPaint. r=me 266260 3 jberlin 2010-08-18 11:13:14 -0700 (In reply to comment #2) > (From update of attachment 64724 [details]) > > + bool backingStoreCompletelyDirty = ensureBackingStore(); > > + if (!m_backingStoreBitmap) { > > + EndPaint(m_viewWindow, &ps); > > return; > > } > > We should only call EndPaint if a dc was passed to this function. Otherwise we won't have called BeginPaint. Added in the check for whether there was a dc passed in. > > r=me Thanks! 266264 4 64724 jberlin 2010-08-18 11:18:30 -0700 Comment on attachment 64724 Check if m_backingStoreBitmap is null instead of whether rcPaint is empty Committed in r65618 http://trac.webkit.org/changeset/65618 64724 2010-08-18 10:14:39 -0700 2010-08-18 11:18:30 -0700 Check if m_backingStoreBitmap is null instead of whether rcPaint is empty makeWebViewPaintWorkWithLayeredWindows.patch text/plain 1789 jberlin SW5kZXg6IFdlYktpdC93aW4vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vQ2hh bmdlTG9nCShyZXZpc2lvbiA2NTYxMSkKKysrIFdlYktpdC93aW4vQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDgtMDkgIEplc3NpZSBCZXJsaW4gIDxqYmVy bGluQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBCdWcgNDQxODAgLSBXZWJWaWV3OjpwYWludCBmYWlscyB0byBwYWludCBhIGNoaWxk IFdlYlZpZXcgb2YgYSBMYXllcmVkIFdpbmRvdy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0MTgwCisgICAgICAgIAorICAgICAgICBEZWNpZGUgdG8g ZW5kIHBhaW50aW5nIGlmIHRoZSBtX2JhY2tpbmdTdG9yZUJpdG1hcCBpcyBudWxsIGFmdGVyIHRo ZSBjYWxsIHRvCisgICAgICAgIGVuc3VyZUJhY2tpbmdTdG9yZSgpIGluc3RlYWQgb2Ygd2hlbiB0 aGUgcmNQYWludCByZWN0IGZpbGxlZCBieSBCZWdpblBhaW50IGlzIGVtcHR5LgorICAgICAgICBU aGUgcmNQYWludCByZWN0IGZpbGxlZCBieSBCZWdpblBhaW50IGlzIGFsd2F5cyBlbXB0eSBmb3Ig YSBjaGlsZCBXZWJWaWV3IG9mIGEgTGF5ZXJlZCAKKyAgICAgICAgV2luZG93LCBldmVuIGlmIEdl dFVwZGF0ZVJlY3QgYW5kIEdldFVwZGF0ZVJnbiByZXBvcnQgYSBub24tZW1wdHkgcmVnaW9uIHRo YXQgbmVlZHMKKyAgICAgICAgcGFpbnRpbmcuCisKKyAgICAgICAgKiBXZWJWaWV3LmNwcDoKKyAg ICAgICAgKFdlYlZpZXc6OnBhaW50KToKKwogMjAxMC0wOC0xNyAgSmVzdXMgU2FuY2hlei1QYWxl bmNpYSAgPGplc3VzLnBhbGVuY2lhQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJLaXQvd2luL1dlYlZpZXcuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYktpdC93aW4vV2ViVmlldy5jcHAJKHJldmlzaW9uIDY1NjExKQorKysgV2ViS2l0L3dp bi9XZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtOTc3LDE2ICs5NzcsMTUgQEAgdm9pZCBX ZWJWaWV3OjpwYWludChIREMgZGMsIExQQVJBTSBvcHRpbwogICAgICAgICB3aW5kb3dzVG9QYWlu dCA9IFBhaW50V2ViVmlld0FuZENoaWxkcmVuOwogICAgIH0KIAotICAgIGlmICg6OklzUmVjdEVt cHR5KCZyY1BhaW50KSkgewotICAgICAgICBpZiAoIWRjKQotICAgICAgICAgICAgRW5kUGFpbnQo bV92aWV3V2luZG93LCAmcHMpOworICAgIGJvb2wgYmFja2luZ1N0b3JlQ29tcGxldGVseURpcnR5 ID0gZW5zdXJlQmFja2luZ1N0b3JlKCk7CisgICAgaWYgKCFtX2JhY2tpbmdTdG9yZUJpdG1hcCkg eworICAgICAgICBFbmRQYWludChtX3ZpZXdXaW5kb3csICZwcyk7CiAgICAgICAgIHJldHVybjsK ICAgICB9CiAKICAgICBtX3BhaW50Q291bnQrKzsKIAogICAgIEhEQyBiaXRtYXBEQyA9IDo6Q3Jl YXRlQ29tcGF0aWJsZURDKGhkYyk7Ci0gICAgYm9vbCBiYWNraW5nU3RvcmVDb21wbGV0ZWx5RGly dHkgPSBlbnN1cmVCYWNraW5nU3RvcmUoKTsKICAgICA6OlNlbGVjdE9iamVjdChiaXRtYXBEQywg bV9iYWNraW5nU3RvcmVCaXRtYXAtPmhhbmRsZSgpKTsKIAogICAgIC8vIFVwZGF0ZSBvdXIgYmFj a2luZyBzdG9yZSBpZiBuZWVkZWQuCg==