4417 2005-08-13 22:45:09 -0700 speed up JavaScript with some small changes to the property map code 2005-08-14 09:25:10 -0700 1 1 1 Unclassified WebKit JavaScriptCore 420+ Mac OS X 10.4 RESOLVED FIXED P2 Enhancement --- 1 darin darin oldest_to_newest 16597 0 darin 2005-08-13 22:45:09 -0700 I did some analysis of JavaScript iBench performance, and found some speedups. This one is an improvement of a couple functions related to property maps, including inlining the default constructor. 16598 1 3365 darin 2005-08-13 22:45:46 -0700 Created attachment 3365 patch to inline default constructor and improve some property map functions 16606 2 darin 2005-08-13 23:01:10 -0700 I measured a 2% improvement to the benchmark with this patch. 3365 2005-08-13 22:45:46 -0700 2005-08-14 01:11:23 -0700 patch to inline default constructor and improve some property map functions PropertyMapPatch.txt text/plain 1677 darin LS0tIHByb3BlcnR5X21hcC5oCTIwMDUtMDgtMDcgMjA6MTg6NDUuMDAwMDAwMDAwIC0wNzAwCisr KyAvVm9sdW1lcy9Ib21lL2RhcmluL0Rlc2t0b3AvUGF0Y2hlcy9zYXZlZCBzcGVlZHVwcy9wcm9w ZXJ0eV9tYXAuaAkyMDA1LTA3LTI1IDIzOjM0OjA1LjAwMDAwMDAwMCAtMDcwMApAQCAtMTA1LDYg KzEwNCwxMCBAQAogICAgICAgICBFbnRyeSBfc2luZ2xlRW50cnk7CiAgICAgfTsKIAoraW5saW5l IFByb3BlcnR5TWFwOjpQcm9wZXJ0eU1hcCgpIDogX3RhYmxlKE5VTEwpCit7Cit9CisKIH0gLy8g bmFtZXNwYWNlCiAKICNlbmRpZiAvLyBfS0pTX1BST1BFUlRZX01BUF9IXwotLS0gcHJvcGVydHlf bWFwLmNwcAkyMDA1LTA4LTA3IDIwOjE4OjQ1LjAwMDAwMDAwMCAtMDcwMAorKysgL1ZvbHVtZXMv SG9tZS9kYXJpbi9EZXNrdG9wL1BhdGNoZXMvc2F2ZWQgc3BlZWR1cHMvcHJvcGVydHlfbWFwLmNw cAkyMDA1LTA3LTI1IDIzOjM0OjA2LjAwMDAwMDAwMCAtMDcwMApAQCAtMTAyLDEwICs5OCw2IEBA CiAKIC8vIEFsZ29yaXRobSBjb25jZXB0cyBmcm9tIEFsZ29yaXRobXMgaW4gQysrLCBTZWRnZXdp Y2suCiAKLVByb3BlcnR5TWFwOjpQcm9wZXJ0eU1hcCgpIDogX3RhYmxlKDApCi17Ci19Ci0KIFBy b3BlcnR5TWFwOjp+UHJvcGVydHlNYXAoKQogewogICAgIGlmICghX3RhYmxlKSB7CkBAIC0xMTcs MTIgKzEwOSwxNCBAQAogICAgICAgICByZXR1cm47CiAgICAgfQogICAgIAotICAgIGludCBzaXpl ID0gX3RhYmxlLT5zaXplOworICAgIGludCBtaW5pbXVtS2V5c1RvUHJvY2VzcyA9IF90YWJsZS0+ a2V5Q291bnQgKyBfdGFibGUtPnNlbnRpbmVsQ291bnQ7CiAgICAgRW50cnkgKmVudHJpZXMgPSBf dGFibGUtPmVudHJpZXM7Ci0gICAgZm9yIChpbnQgaSA9IDA7IGkgPCBzaXplOyBpKyspIHsKKyAg ICBmb3IgKGludCBpID0gMDsgaSA8IG1pbmltdW1LZXlzVG9Qcm9jZXNzOyBpKyspIHsKICAgICAg ICAgVVN0cmluZzo6UmVwICprZXkgPSBlbnRyaWVzW2ldLmtleTsKICAgICAgICAgaWYgKGtleSkK ICAgICAgICAgICAgIGtleS0+ZGVyZWYoKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgKytt aW5pbXVtS2V5c1RvUHJvY2VzczsKICAgICB9CiAgICAga2pzX2Zhc3RfZnJlZShfdGFibGUpOwog fQpAQCAtNTQzLDEyICs1MDAsMTYgQEAKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGlu dCBzaXplID0gX3RhYmxlLT5zaXplOworICAgIGludCBtaW5pbXVtS2V5c1RvUHJvY2VzcyA9IF90 YWJsZS0+a2V5Q291bnQgKyBfdGFibGUtPnNlbnRpbmVsQ291bnQ7CiAgICAgRW50cnkgKmVudHJp ZXMgPSBfdGFibGUtPmVudHJpZXM7Ci0gICAgZm9yIChpbnQgaSA9IDA7IGkgPCBzaXplOyBpKysp IHsKKyAgICBmb3IgKGludCBpID0gMDsgaSA8IG1pbmltdW1LZXlzVG9Qcm9jZXNzOyBpKyspIHsK ICAgICAgICAgVmFsdWVJbXAgKnYgPSBlbnRyaWVzW2ldLnZhbHVlOwotICAgICAgICBpZiAodiAm JiAhdi0+bWFya2VkKCkpCi0gICAgICAgICAgICB2LT5tYXJrKCk7CisgICAgICAgIGlmICh2KSB7 CisgICAgICAgICAgICBpZiAoIXYtPm1hcmtlZCgpKQorICAgICAgICAgICAgICAgIHYtPm1hcmso KTsKKyAgICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgICsrbWluaW11bUtleXNUb1Byb2Nlc3M7 CisgICAgICAgIH0KICAgICB9CiB9CiAK