44157 2010-08-18 02:13:56 -0700 [GStreamer] use ResourceHandle::setDefersLoading in WebKitWebSourceGStreamer 2010-12-06 13:38:18 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 44158 1 pnormand webkit-unassigned oldest_to_newest 265996 0 pnormand 2010-08-18 02:13:56 -0700 We should replace the platform-specific calls to pause/unpause the download with use of ResourceHandle::setDefersLoading 265999 1 pnormand 2010-08-18 02:19:07 -0700 *** Bug 41512 has been marked as a duplicate of this bug. *** 266019 2 64682 pnormand 2010-08-18 03:22:15 -0700 Created attachment 64682 proposed patch 267927 3 64682 mrobinson 2010-08-23 08:40:33 -0700 Comment on attachment 64682 proposed patch LGTM! Be sure to land after deferred loading lands in the soup backend. 271986 4 pnormand 2010-08-31 01:58:56 -0700 (In reply to comment #3) > (From update of attachment 64682 [details]) > LGTM! Be sure to land after deferred loading lands in the soup backend. Feel free to clear the r+ flag for now. Trying to land the patch from bug 44158 is counter-productive as it'd need work again after the SoupURILoader code lands from bug 44261 273241 5 64682 pnormand 2010-09-02 00:11:09 -0700 Comment on attachment 64682 proposed patch Clearing r+ flag as per comment 4 312871 6 64682 mrobinson 2010-11-23 08:49:17 -0800 Comment on attachment 64682 proposed patch Gogogogo! 317826 7 pnormand 2010-12-06 13:38:18 -0800 Committed r73396: <http://trac.webkit.org/changeset/73396> 64682 2010-08-18 03:22:15 -0700 2010-11-23 08:49:16 -0800 proposed patch proposed-patch.patch text/plain 2561 pnormand RnJvbSAxMmFjZGY2M2QzOTcwZThhOWUxYWUxZTlhNzIxMjgyNTEwOGIyNTFjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDE4IEF1ZyAyMDEwIDExOjE3OjIyICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogLi4uL2dzdHJlYW1lci9XZWJLaXRX ZWJTb3VyY2VHU3RyZWFtZXIuY3BwICAgICAgICAgfCAgIDE1ICsrLS0tLS0tLS0tLS0tLQogMiBm aWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCAxMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDVkMjZmMTgu LmQ2YWI2NzAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDgtMTggIFBoaWxpcHBlIE5vcm1hbmQgIDxw bm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtHU3RyZWFtZXJdIHVzZSBSZXNvdXJjZUhhbmRsZTo6c2V0RGVmZXJzTG9h ZGluZyBpbiBXZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0MTU3CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKHdl YktpdFdlYlNyY05lZWREYXRhTWFpbkNiKToKKyAgICAgICAgKHdlYktpdFdlYlNyY0Vub3VnaERh dGFNYWluQ2IpOiBSZXBsYWNlZCBwbGF0Zm9ybS1zcGVjaWZpYyBjb2RlCisgICAgICAgIHdpdGgg Y3Jvc3MtcGxhdGZvcm0gUmVzb3VyY2VIYW5kbGU6OnNldERlZmVyc0xvYWRpbmcgY2FsbHMuCisK IDIwMTAtMDgtMTggIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCmRpZmYgLS1naXQgYS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3Bw IGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0V2ViU291cmNlR1N0 cmVhbWVyLmNwcAppbmRleCAxMDU5YjU5Li40OTUxYTJjIDEwMDY0NAotLS0gYS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwCisr KyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdT dHJlYW1lci5jcHAKQEAgLTUzNiwxMyArNTM2LDcgQEAgc3RhdGljIGdib29sZWFuIHdlYktpdFdl YlNyY05lZWREYXRhTWFpbkNiKFdlYktpdFdlYlNyYyogc3JjKQogewogICAgIFdlYktpdFdlYlNy Y1ByaXZhdGUqIHByaXYgPSBzcmMtPnByaXY7CiAKLSNpZiBVU0UoTkVUV09SS19TT1VQKQotICAg IFJlc291cmNlSGFuZGxlSW50ZXJuYWwqIGQgPSBwcml2LT5yZXNvdXJjZUhhbmRsZS0+Z2V0SW50 ZXJuYWwoKTsKLSAgICBpZiAoZC0+bV9tc2cpCi0gICAgICAgIHNvdXBfc2Vzc2lvbl91bnBhdXNl X21lc3NhZ2UoUmVzb3VyY2VIYW5kbGU6OmRlZmF1bHRTZXNzaW9uKCksIGQtPm1fbXNnKTsKLSNl bmRpZgotICAgIC8vIFBvcnRzIG5vdCB1c2luZyBsaWJzb3VwIG5lZWQgdG8gY2FsbCB0aGUgdW5w YXVzZS9zY2hlZHVsZSBBUEkgb2YgdGhlaXIKLSAgICAvLyB1bmRlcmx5aW5nIG5ldHdvcmsgaW1w bGVtZW50YXRpb24gaGVyZS4KKyAgICBwcml2LT5yZXNvdXJjZUhhbmRsZS0+c2V0RGVmZXJzTG9h ZGluZyhmYWxzZSk7CiAKICAgICBHU1RfT0JKRUNUX0xPQ0soc3JjKTsKICAgICBwcml2LT5wYXVz ZWQgPSBGQUxTRTsKQEAgLTU3MiwxMiArNTY2LDcgQEAgc3RhdGljIGdib29sZWFuIHdlYktpdFdl YlNyY0Vub3VnaERhdGFNYWluQ2IoV2ViS2l0V2ViU3JjKiBzcmMpCiB7CiAgICAgV2ViS2l0V2Vi U3JjUHJpdmF0ZSogcHJpdiA9IHNyYy0+cHJpdjsKIAotI2lmIFVTRShORVRXT1JLX1NPVVApCi0g ICAgUmVzb3VyY2VIYW5kbGVJbnRlcm5hbCogZCA9IHByaXYtPnJlc291cmNlSGFuZGxlLT5nZXRJ bnRlcm5hbCgpOwotICAgIHNvdXBfc2Vzc2lvbl9wYXVzZV9tZXNzYWdlKFJlc291cmNlSGFuZGxl OjpkZWZhdWx0U2Vzc2lvbigpLCBkLT5tX21zZyk7Ci0jZW5kaWYKLSAgICAvLyBQb3J0cyBub3Qg dXNpbmcgbGlic291cCBuZWVkIHRvIGNhbGwgdGhlIHBhdXNlL3Vuc2NoZWR1bGUgQVBJIG9mIHRo ZWlyCi0gICAgLy8gdW5kZXJseWluZyBuZXR3b3JrIGltcGxlbWVudGF0aW9uIGhlcmUuCisgICAg cHJpdi0+cmVzb3VyY2VIYW5kbGUtPnNldERlZmVyc0xvYWRpbmcodHJ1ZSk7CiAKICAgICBHU1Rf T0JKRUNUX0xPQ0soc3JjKTsKICAgICBwcml2LT5wYXVzZWQgPSBUUlVFOwotLSAKMS43LjE=