44151 2010-08-17 22:28:54 -0700 ASSERT(!m_database->sqliteDatabase().transactionInProgress()); can fail 2010-08-20 14:54:34 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 42959 1 abarth dumi dumi oldest_to_newest 265950 0 abarth 2010-08-17 22:28:54 -0700 http://trac.webkit.org/browser/trunk/WebCore/storage/SQLTransaction.cpp#L276 // Transaction Steps 3 - Peform preflight steps, jumping to the error callback if they fail if (m_wrapper && !m_wrapper->performPreflight(this)) { ASSERT(!m_database->sqliteDatabase().transactionInProgress()); m_sqliteTransaction.clear(); m_transactionError = m_wrapper->sqlError(); if (!m_transactionError) m_transactionError = SQLError::create(SQLError::UNKNOWN_ERR, "unknown error occured setting up transaction"); handleTransactionError(false); return; } 267342 1 dumi 2010-08-20 12:25:57 -0700 Looking. I'm assuming this was discovered by the same fuzzer? 267349 2 abarth 2010-08-20 12:37:42 -0700 Yep. 267385 3 64985 dumi 2010-08-20 13:34:00 -0700 Created attachment 64985 patch 267395 4 64985 abarth 2010-08-20 13:54:51 -0700 Comment on attachment 64985 patch ok 267438 5 dumi 2010-08-20 14:54:34 -0700 landed: r65755. 64985 2010-08-20 13:34:00 -0700 2010-08-20 13:54:51 -0700 patch patch text/plain 3993 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NTc1MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDgtMjAgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZW1vdmluZyBhbiBpbmNvcnJlY3QgQVNTRVJULgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQxNTEKKworICAgICAgICBBIGZhaWx1cmUgaW4gdGhl IHByZWZsaWdodCBzdGVwIG9mIGEgdHJhbnNhY3Rpb24gd3JhcHBlciBkb2VzIG5vdAorICAgICAg ICBndWFyYW50ZWUgdGhhdCB0aGUgdHJhbnNhY3Rpb24gaXMgcm9sbGVkIGJhY2sgKGFuZCBpdCBz aG91bGRuJ3QpLgorCisgICAgICAgIFRlc3Q6IHN0b3JhZ2UvY2hhbmdlLXZlcnNpb24tbm8tY3Jh c2gtb24tcHJlZmxpZ2h0LWZhaWx1cmUuaHRtbAorCisgICAgICAgICogc3RvcmFnZS9TUUxUcmFu c2FjdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTUUxUcmFuc2FjdGlvbjo6b3BlblRyYW5z YWN0aW9uQW5kUHJlZmxpZ2h0KToKKwogMjAxMC0wOC0xOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2Vi Q29yZS9zdG9yYWdlL1NRTFRyYW5zYWN0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3N0 b3JhZ2UvU1FMVHJhbnNhY3Rpb24uY3BwCShyZXZpc2lvbiA2NTc1MCkKKysrIFdlYkNvcmUvc3Rv cmFnZS9TUUxUcmFuc2FjdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI3Myw3ICsyNzMsNiBA QCB2b2lkIFNRTFRyYW5zYWN0aW9uOjpvcGVuVHJhbnNhY3Rpb25BbmRQCiAKICAgICAvLyBUcmFu c2FjdGlvbiBTdGVwcyAzIC0gUGVmb3JtIHByZWZsaWdodCBzdGVwcywganVtcGluZyB0byB0aGUg ZXJyb3IgY2FsbGJhY2sgaWYgdGhleSBmYWlsCiAgICAgaWYgKG1fd3JhcHBlciAmJiAhbV93cmFw cGVyLT5wZXJmb3JtUHJlZmxpZ2h0KHRoaXMpKSB7Ci0gICAgICAgIEFTU0VSVCghbV9kYXRhYmFz ZS0+c3FsaXRlRGF0YWJhc2UoKS50cmFuc2FjdGlvbkluUHJvZ3Jlc3MoKSk7CiAgICAgICAgIG1f c3FsaXRlVHJhbnNhY3Rpb24uY2xlYXIoKTsKICAgICAgICAgbV90cmFuc2FjdGlvbkVycm9yID0g bV93cmFwcGVyLT5zcWxFcnJvcigpOwogICAgICAgICBpZiAoIW1fdHJhbnNhY3Rpb25FcnJvcikK SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY1NzUwKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDgtMjAgIER1bWl0cnUgRGFuaWxpdWMg IDxkdW1pQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBDaGVjayB0aGF0IGEgZmFpbHVyZSBpbiB0aGUgcHJlZmxpZ2h0IHN0ZXAg b2YgYSB0cmFuc2FjdGlvbiB3cmFwcGVyIGRvZXMgbm90IHRyaWdnZXIgYW55IGFzc2VydGlvbi4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0MTUxCisK KyAgICAgICAgKiBzdG9yYWdlL2NoYW5nZS12ZXJzaW9uLW5vLWNyYXNoLW9uLXByZWZsaWdodC1m YWlsdXJlLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogc3RvcmFnZS9jaGFuZ2UtdmVy c2lvbi1uby1jcmFzaC1vbi1wcmVmbGlnaHQtZmFpbHVyZS5odG1sOiBBZGRlZC4KKwogMjAxMC0w OC0yMCAgSm9obiBHcmVnZyAgPGpvaG5ueWdAZ29vZ2xlLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCBjaHJvbWl1bSByZWJhc2VsaW5lLgpJbmRleDogTGF5b3V0VGVzdHMvc3RvcmFnZS9jaGFu Z2UtdmVyc2lvbi1uby1jcmFzaC1vbi1wcmVmbGlnaHQtZmFpbHVyZS1leHBlY3RlZC50eHQKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvc3RvcmFnZS9jaGFuZ2UtdmVyc2lvbi1uby1jcmFzaC1v bi1wcmVmbGlnaHQtZmFpbHVyZS1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9zdG9yYWdlL2NoYW5nZS12ZXJzaW9uLW5vLWNyYXNoLW9uLXByZWZsaWdodC1mYWlsdXJl LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzIEBACitUaGlzIHRlc3QgdmVy aWZpZXMgdGhhdCBubyBhc3NlcnRpb24gaXMgdHJpZ2dlcmVkIHdoZW4gY2hhbmdlVmVyc2lvbigp J3MgcHJlZmxpZ2h0IHN0ZXAgZmFpbHMuCitQQVNTOiBkYi5jaGFuZ2VWZXJzaW9uKCkgZmFpbGVk IGFzIGV4cGVjdGVkLCBhbmQgbm8gYXNzZXJ0aW9ucyB3ZXJlIHRyaWdnZXJlZC4KKwpJbmRleDog TGF5b3V0VGVzdHMvc3RvcmFnZS9jaGFuZ2UtdmVyc2lvbi1uby1jcmFzaC1vbi1wcmVmbGlnaHQt ZmFpbHVyZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3N0b3JhZ2UvY2hhbmdlLXZl cnNpb24tbm8tY3Jhc2gtb24tcHJlZmxpZ2h0LWZhaWx1cmUuaHRtbAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL3N0b3JhZ2UvY2hhbmdlLXZlcnNpb24tbm8tY3Jhc2gtb24tcHJlZmxpZ2h0 LWZhaWx1cmUuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwzNiBAQAorPGh0bWw+Cis8aGVh ZD4KKzxzY3JpcHQ+CitmdW5jdGlvbiBmaW5pc2hUZXN0KCkKK3sKKyAgICBpZiAod2luZG93Lmxh eW91dFRlc3RDb250cm9sbGVyKQorICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlE b25lKCk7Cit9CisKK2Z1bmN0aW9uIGxvZyhtZXNzYWdlKQoreworICAgIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJjb25zb2xlIikuaW5uZXJUZXh0ICs9IG1lc3NhZ2UgKyAiXG4iOworfQorCitm dW5jdGlvbiBydW5UZXN0KCkgeworICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIp IHsKKyAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworICAgICAgICBs YXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgICAgfQorCisgICAgdmFyIGRi ID0gd2luZG93Lm9wZW5EYXRhYmFzZSgiQ2hhbmdlVmVyc2lvbkZhaWx1cmVUZXN0IiwgIjEiLCAi VGVzdCB0aGUgcHJlZmxpZ2h0IHN0ZXAiLCAxMDI0KTsKKyAgICBkYi5jaGFuZ2VWZXJzaW9uKCIy IiwgIjMiLCBudWxsLCBmdW5jdGlvbihlcnJvcikgeworICAgICAgICBsb2coIlBBU1M6IGRiLmNo YW5nZVZlcnNpb24oKSBmYWlsZWQgYXMgZXhwZWN0ZWQsIGFuZCBubyBhc3NlcnRpb25zIHdlcmUg dHJpZ2dlcmVkLiIpOworICAgICAgICBmaW5pc2hUZXN0KCk7CisgICAgfSwgZnVuY3Rpb24oKSB7 CisgICAgICAgIGxvZygiRkFJTDogZGIuY2hhbmdlVmVyc2lvbigpIHdhcyBleHBlY3RlZCB0byBm YWlsLiIpOworICAgICAgICBmaW5pc2hUZXN0KCk7CisgICAgfSk7Cit9Cis8L3NjcmlwdD4KKzwv aGVhZD4KKzxib2R5IG9ubG9hZD0icnVuVGVzdCgpOyI+CitUaGlzIHRlc3QgdmVyaWZpZXMgdGhh dCBubyBhc3NlcnRpb24gaXMgdHJpZ2dlcmVkIHdoZW4gY2hhbmdlVmVyc2lvbigpJ3MgcHJlZmxp Z2h0IHN0ZXAgZmFpbHMuCis8cHJlIGlkPSJjb25zb2xlIj48L3ByZT4KKzwvYm9keT4KKzwvaHRt bD4K