44149 2010-08-17 19:34:52 -0700 AX: Images within anchors causes crash 2011-09-09 16:23:35 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 ctguil cfleizach cfleizach webkit.review.bot oldest_to_newest 265908 0 64662 ctguil 2010-08-17 19:34:52 -0700 Created attachment 64662 Layout Test The chromium render is crashing: http://code.google.com/p/chromium/issues/detail?id=52538 I've attached a layout test the reproduces the crash. This is looks similar to the crash from https://bugs.webkit.org/show_bug.cgi?id=42309 266320 1 cfleizach 2010-08-18 12:36:16 -0700 chris i'm not getting a crash with this test on ToT (on a Snow leopard mac). Can you attach the crash log 267390 2 64986 ctguil 2010-08-20 13:39:36 -0700 Created attachment 64986 anchor-with-image-causes-crash-stderr.txt Hey Chris. Not sure how I missed your message in email. Is this file you wanted? I'm seeing the crash on Vista and my checkout is at r65572. 267393 3 cfleizach 2010-08-20 13:45:24 -0700 ah, something caught by the new assert. might be a new case not properly handled. still doesn't explain why it didn't crash for me 267416 4 ctguil 2010-08-20 14:35:16 -0700 Looking at this again I'm only seeing the assert being hit and no crash occurring (if I remove the assert) for the layout test. Can you see the assert being hit in debug mode? 267421 5 cfleizach 2010-08-20 14:39:10 -0700 i was pretty sure i ran my unit test in debug mode, so it should have asserted there and crashed. i must have done something wrong 267993 6 cfleizach 2010-08-23 10:47:32 -0700 crashing for me too now 277578 7 cfleizach 2010-09-10 18:02:51 -0700 i've been looking at what could be related when you have code like <ul> <li style="display: inline;"><a href="http:"><img style="display: block;" src="" width="200" height="100"></a></li> <li style="display: inline;"><a href="http:"><img style="display: block;" src="" width="200" height="100"></a></li> <li style="display: inline;"><a href="http:"><img style="display: block;" src="" width="200" height="100"></a></li> </ul> the <ul> reports that it has four children. there's a continuation that points to the 2nd image. the problem is that i don't know if it's a logic error in nextSibling(), an unaccounted case, or there's an issue in how continuations are stored in renderers. 278465 8 67469 ctguil 2010-09-13 14:10:42 -0700 Created attachment 67469 Similar Layout Test - divs within anchors Original URL: http://o.aolcdn.com/cdn.webmail.aol.com/mailtour/affinity/en-us/ 279888 9 67756 ctguil 2010-09-15 18:44:07 -0700 Created attachment 67756 Layout Tests that actually causes a crash This layout test actually causes a crash. 465050 10 106928 dmazzoni 2011-09-09 15:14:36 -0700 Created attachment 106928 Patch 465073 11 106928 cfleizach 2011-09-09 15:55:08 -0700 Comment on attachment 106928 Patch this looks ok to me, can you also check if this fixes https://bugs.webkit.org/show_bug.cgi?id=58930 r=me 465086 12 106928 webkit.review.bot 2011-09-09 16:23:30 -0700 Comment on attachment 106928 Patch Clearing flags on attachment: 106928 Committed r94888: <http://trac.webkit.org/changeset/94888> 465087 13 webkit.review.bot 2011-09-09 16:23:35 -0700 All reviewed patches have been landed. Closing bug. 64662 2010-08-17 19:34:52 -0700 2010-08-17 19:34:52 -0700 Layout Test MyPatch.txt text/plain 2050 ctguil SW5kZXg6IGFuY2hvci13aXRoLWltYWdlLWNhdXNlcy1jcmFzaC1leHBlY3RlZC50eHQKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gYW5jaG9yLXdpdGgtaW1hZ2UtY2F1c2VzLWNyYXNoLWV4cGVjdGVkLnR4dAkocmV2 aXNpb24gMCkKKysrIGFuY2hvci13aXRoLWltYWdlLWNhdXNlcy1jcmFzaC1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTAgQEAKKyAgIAorVGhpcyBjYW4gY2F1c2UgYSBjcmFz aC4KKworT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdl cywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCisKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFy c2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBhbmNob3Itd2l0aC1pbWFnZS1j YXVzZXMtY3Jhc2guaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBhbmNob3Itd2l0aC1pbWFnZS1jYXVzZXMt Y3Jhc2guaHRtbAkocmV2aXNpb24gMCkKKysrIGFuY2hvci13aXRoLWltYWdlLWNhdXNlcy1jcmFz aC5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQ3IEBACis8IURPQ1RZUEUgSFRNTCBQVUJM SUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJz dHlsZXNoZWV0IiBocmVmPSIuLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+ Cis8c2NyaXB0Pg0KKyAgICB2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gZmFsc2U7DQorDQorICAg IGZ1bmN0aW9uIHF1ZXJ5SXNFbmFibGVkT25EZWNlbmRhbnRzKGFjY2Vzc2liaWxpdHlPYmplY3Qp IHsNCisgICAgICAgIGFjY2Vzc2liaWxpdHlPYmplY3QuaXNFbmFibGVkDQorDQorICAgICAgICB2 YXIgY291bnQgPSBhY2Nlc3NpYmlsaXR5T2JqZWN0LmNoaWxkcmVuQ291bnQ7DQorICAgICAgICBm b3IgKHZhciBpID0gMDsgaSA8IGNvdW50OyArK2kpDQorICAgICAgICAgICAgcXVlcnlJc0VuYWJs ZWRPbkRlY2VuZGFudHMoYWNjZXNzaWJpbGl0eU9iamVjdC5jaGlsZEF0SW5kZXgoaSkpOw0KKyAg ICB9Cis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0 LXByZS5qcyI+PC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKworPGEgaHJlZj0iYWJvdXQ6Ymxh bmsiPg0KKyAgPGltZyBzdHlsZT0iZGlzcGxheTogYmxvY2s7Ij4NCis8L2E+DQorPGEgaHJlZj0i YWJvdXQ6YmxhbmsiPg0KKyAgPGltZyBzdHlsZT0iZGlzcGxheTogYmxvY2s7Ij4NCis8L2E+DQor PGEgaHJlZj0iYWJvdXQ6YmxhbmsiPg0KKyAgPGltZyBzdHlsZT0iZGlzcGxheTogYmxvY2s7Ij4N Cis8L2E+DQorCis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwv ZGl2PgorCis8c2NyaXB0Pg0KKyAgICBkZXNjcmlwdGlvbigiVGhpcyBjYW4gY2F1c2UgYSBjcmFz aC4iKTsNCisNCisgICAgaWYgKHdpbmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikgew0KKyAg ICAgICAgLy8gRmlyc3QgYnVpbGQgdXAgZnVsbCBhY2Nlc3NpYmlsaXR5IHRyZWUuDQorICAgICAg ICBkb2N1bWVudC5ib2R5LmZvY3VzKCk7DQorICAgICAgICBxdWVyeUlzRW5hYmxlZE9uRGVjZW5k YW50cyhhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1c2VkRWxlbWVudCk7DQorICAgIH0NCisN CisgICAgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsNCis8L3NjcmlwdD4KKworPHNjcmlwdCBz cmM9Ii4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2Jv ZHk+Cis8L2h0bWw+CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBhbmNob3Itd2l0aC1pbWFnZS1jYXVz ZXMtY3Jhc2guaHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkFkZGVkOiBzdm46ZXhlY3V0YWJsZQogICArICoKCg== 64986 2010-08-20 13:39:36 -0700 2010-08-20 13:39:36 -0700 anchor-with-image-causes-crash-stderr.txt anchor-with-image-causes-crash-stderr.txt text/plain 622 ctguil Q0ZVUkxDb25uZWN0aW9uU2NoZWR1bGVXaXRoQ3VycmVudE1lc3NhZ2VRdWV1ZTogTk8gTE9OR0VS IE5FRURFRCBUTyBCRSBDQUxMRUQgLSBkb25lIGJ5IENGVVJMQ29ubmVjdGlvblNjaGVkdWxlV2l0 aFJ1bkxvb3AgKDQpIChzZWUgcmRhcjovLzU3MzU5MTIpQ0ZVUkxDb25uZWN0aW9uU2NoZWR1bGVX aXRoQ3VycmVudE1lc3NhZ2VRdWV1ZTogTk8gTE9OR0VSIE5FRURFRCBUTyBCRSBDQUxMRUQgLSBk b25lIGJ5IENGVVJMQ29ubmVjdGlvblNjaGVkdWxlV2l0aFJ1bkxvb3AgKDMpIChzZWUgcmRhcjov LzU3MzU5MTIpQ0ZVUkxDb25uZWN0aW9uU2NoZWR1bGVXaXRoQ3VycmVudE1lc3NhZ2VRdWV1ZTog Tk8gTE9OR0VSIE5FRURFRCBUTyBCRSBDQUxMRUQgLSBkb25lIGJ5IENGVVJMQ29ubmVjdGlvblNj aGVkdWxlV2l0aFJ1bkxvb3AgKDIpIChzZWUgcmRhcjovLzU3MzU5MTIpQVNTRVJUSU9OIEZBSUxF RDogb2JqLT5wYXJlbnRPYmplY3QoKSA9PSB0aGlzCihjOlxjeWd3aW5caG9tZVxDaHJpc1x3ZWJr aXRcV2ViQ29yZVxhY2Nlc3NpYmlsaXR5XEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwOjMz MjkgV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6YWRkQ2hpbGRyZW4pCg== 67469 2010-09-13 14:10:42 -0700 2010-09-13 14:10:42 -0700 Similar Layout Test - divs within anchors anchor-with-div-causes-debug-assert.html text/html 2262 ctguil PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgo8aHRtbD4KPGhl YWQ+CjxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMt dGVzdC1zdHlsZS5jc3MiPgo8c2NyaXB0PgogICAgdmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IGZh bHNlOwoKICAgIGZ1bmN0aW9uIHF1ZXJ5SXNFbmFibGVkT25EZWNlbmRhbnRzKGFjY2Vzc2liaWxp dHlPYmplY3QpIHsKICAgICAgICBhY2Nlc3NpYmlsaXR5T2JqZWN0LmlzRW5hYmxlZAoKICAgICAg ICB2YXIgY291bnQgPSBhY2Nlc3NpYmlsaXR5T2JqZWN0LmNoaWxkcmVuQ291bnQ7CiAgICAgICAg Zm9yICh2YXIgaSA9IDA7IGkgPCBjb3VudDsgKytpKQogICAgICAgICAgICBxdWVyeUlzRW5hYmxl ZE9uRGVjZW5kYW50cyhhY2Nlc3NpYmlsaXR5T2JqZWN0LmNoaWxkQXRJbmRleChpKSk7CiAgICB9 Cjwvc2NyaXB0Pgo8c2NyaXB0IHNyYz0iLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUu anMiPjwvc2NyaXB0Pgo8L2hlYWQ+Cjxib2R5PgoKPGE+PGRpdj48L2Rpdj48L2E+DQo8YT48ZGl2 PjwvZGl2PjwvYT4NCjxhIGhyZWY9ImFib3V0OmJsYW5rIj48ZGl2PjwvZGl2PjwvYT4KCjxwIGlk PSJkZXNjcmlwdGlvbiI+PC9wPgo8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KCjxzY3JpcHQ+CiAg ICBkZXNjcmlwdGlvbigiVGhpcyBjYW4gY2F1c2UgYSBjcmFzaC4iKTsKCiAgICBpZiAod2luZG93 LmFjY2Vzc2liaWxpdHlDb250cm9sbGVyKSB7CiAgICAgICAgLy8gRmlyc3QgYnVpbGQgdXAgZnVs bCBhY2Nlc3NpYmlsaXR5IHRyZWUuCiAgICAgICAgZG9jdW1lbnQuYm9keS5mb2N1cygpOwogICAg ICAgIHF1ZXJ5SXNFbmFibGVkT25EZWNlbmRhbnRzKGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmZv Y3VzZWRFbGVtZW50KTsKICAgIH0KCiAgICBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOwo8L3Nj cmlwdD4KCjxzY3JpcHQgc3JjPSIuLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMi Pjwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4KPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRG Ly9EVEQgSFRNTC8vRU4iPgo8aHRtbD4KPGhlYWQ+CjxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJl Zj0iLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgo8c2NyaXB0PgogICAg dmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IGZhbHNlOwoKICAgIGZ1bmN0aW9uIHF1ZXJ5SXNFbmFi bGVkT25EZWNlbmRhbnRzKGFjY2Vzc2liaWxpdHlPYmplY3QpIHsKICAgICAgICBhY2Nlc3NpYmls aXR5T2JqZWN0LmlzRW5hYmxlZAoKICAgICAgICB2YXIgY291bnQgPSBhY2Nlc3NpYmlsaXR5T2Jq ZWN0LmNoaWxkcmVuQ291bnQ7CiAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBjb3VudDsgKytp KQogICAgICAgICAgICBxdWVyeUlzRW5hYmxlZE9uRGVjZW5kYW50cyhhY2Nlc3NpYmlsaXR5T2Jq ZWN0LmNoaWxkQXRJbmRleChpKSk7CiAgICB9Cjwvc2NyaXB0Pgo8c2NyaXB0IHNyYz0iLi4vZmFz dC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0Pgo8L2hlYWQ+Cjxib2R5PgoK PGEgaHJlZj0iYWJvdXQ6YmxhbmsiPgogIDxpbWcgc3R5bGU9ImRpc3BsYXk6IGJsb2NrOyI+Cjwv YT4KPGEgaHJlZj0iYWJvdXQ6YmxhbmsiPgogIDxpbWcgc3R5bGU9ImRpc3BsYXk6IGJsb2NrOyI+ CjwvYT4KPGEgaHJlZj0iYWJvdXQ6YmxhbmsiPgogIDxpbWcgc3R5bGU9ImRpc3BsYXk6IGJsb2Nr OyI+CjwvYT4KCjxwIGlkPSJkZXNjcmlwdGlvbiI+PC9wPgo8ZGl2IGlkPSJjb25zb2xlIj48L2Rp dj4KCjxzY3JpcHQ+CiAgICBkZXNjcmlwdGlvbigiVGhpcyBjYW4gY2F1c2UgYSBjcmFzaC4iKTsK CQoJZG9jdW1lbnQuYm9keS5jaGlsZHJlblswXS5jaGlsZHJlblswXS5vZmZzZXRXaWR0aDsKCiAg ICBpZiAod2luZG93LmFjY2Vzc2liaWxpdHlDb250cm9sbGVyKSB7CiAgICAgICAgLy8gRmlyc3Qg YnVpbGQgdXAgZnVsbCBhY2Nlc3NpYmlsaXR5IHRyZWUuCiAgICAgICAgZG9jdW1lbnQuYm9keS5m b2N1cygpOwogICAgICAgIHF1ZXJ5SXNFbmFibGVkT25EZWNlbmRhbnRzKGFjY2Vzc2liaWxpdHlD b250cm9sbGVyLmZvY3VzZWRFbGVtZW50KTsKICAgIH0KCiAgICBzdWNjZXNzZnVsbHlQYXJzZWQg PSB0cnVlOwo8L3NjcmlwdD4KCjxzY3JpcHQgc3JjPSIuLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10 ZXN0LXBvc3QuanMiPjwvc2NyaXB0Pgo8L2JvZHk+CjwvaHRtbD4K 67756 2010-09-15 18:44:07 -0700 2010-09-15 18:44:07 -0700 Layout Tests that actually causes a crash MyPatch.txt text/plain 2025 ctguil SW5kZXg6IExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvZGl2LXdpdGhpbi1hbmNob3JzLWNhdXNl cy1jcmFzaC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvZGl2 LXdpdGhpbi1hbmNob3JzLWNhdXNlcy1jcmFzaC5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0 VGVzdHMvYWNjZXNzaWJpbGl0eS9kaXYtd2l0aGluLWFuY2hvcnMtY2F1c2VzLWNyYXNoLmh0bWwJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNDkgQEAKKw0KKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAi LS8vSUVURi8vRFREIEhUTUwvL0VOIj4gDQorPGh0bWw+IA0KKzxoZWFkPiANCis8bGluayByZWw9 InN0eWxlc2hlZXQiIGhyZWY9Ii4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3Qtc3R5bGUuY3Nz Ij4gDQorPHNjcmlwdD4gDQorICAgIHZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSBmYWxzZTsNCisg DQorICAgIGZ1bmN0aW9uIHF1ZXJ5SXNFbmFibGVkT25EZWNlbmRhbnRzKGFjY2Vzc2liaWxpdHlP YmplY3QpIHsNCisgICAgICAgIGFjY2Vzc2liaWxpdHlPYmplY3QuaXNFbmFibGVkDQorIA0KKyAg ICAgICAgdmFyIGNvdW50ID0gYWNjZXNzaWJpbGl0eU9iamVjdC5jaGlsZHJlbkNvdW50Ow0KKyAg ICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBjb3VudDsgKytpKQ0KKyAgICAgICAgICAgIHF1ZXJ5 SXNFbmFibGVkT25EZWNlbmRhbnRzKGFjY2Vzc2liaWxpdHlPYmplY3QuY2hpbGRBdEluZGV4KGkp KTsNCisgICAgfQ0KKzwvc2NyaXB0PiANCis8c2NyaXB0IHNyYz0iLi4vZmFzdC9qcy9yZXNvdXJj ZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PiANCis8L2hlYWQ+IA0KKzxib2R5PiANCisgDQor PGE+PGRpdj48L2Rpdj48L2E+DQ0KKzxhPjxkaXY+PC9kaXY+PC9hPg0NCis8YSBocmVmPSJhYm91 dDpibGFuayI+PGRpdj48L2Rpdj48L2E+IA0KKyANCis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4g DQorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+IA0KKyANCis8c2NyaXB0PiANCisgICAgZGVzY3Jp cHRpb24oIlRoaXMgY2FuIGNhdXNlIGEgY3Jhc2guIik7DQorIA0KKyAgICBpZiAod2luZG93LmFj Y2Vzc2liaWxpdHlDb250cm9sbGVyKSB7DQorICAgICAgICAvLyBGaXJzdCBidWlsZCB1cCBmdWxs IGFjY2Vzc2liaWxpdHkgdHJlZS4NCisgICAgICAgIGRvY3VtZW50LmJvZHkuZm9jdXMoKTsNCisg ICAgICAgIHF1ZXJ5SXNFbmFibGVkT25EZWNlbmRhbnRzKGFjY2Vzc2liaWxpdHlDb250cm9sbGVy LmZvY3VzZWRFbGVtZW50KTsNCisgICAgICAgIA0KKyAgICAgICAgLy8gUmVtb3ZlIGFuY2hvciB0 aGF0IGNhdXNlcyBkZWJ1ZyBhc3NlcnQgaW4gQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6YWRk Q2hpbGRyZW4NCisgICAgICAgIGRvY3VtZW50LmJvZHkucmVtb3ZlQ2hpbGQoZG9jdW1lbnQuYm9k eS5jaGlsZHJlblsyXSkNCisgICAgICAgIA0KKyAgICAgICAgLy8gQnVpbGQgdXAgZnVsbCBhY2Nl c3NpYmlsaXR5IHRyZWUuDQorICAgICAgICBkb2N1bWVudC5ib2R5LmZvY3VzKCk7DQorICAgICAg ICBxdWVyeUlzRW5hYmxlZE9uRGVjZW5kYW50cyhhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5mb2N1 c2VkRWxlbWVudCk7DQorICAgIH0NCisgDQorICAgIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7 DQorPC9zY3JpcHQ+IA0KKyANCis8c2NyaXB0IHNyYz0iLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMt dGVzdC1wb3N0LmpzIj48L3NjcmlwdD4gDQorPC9ib2R5PiANCis8L2h0bWw+IApcIE5vIG5ld2xp bmUgYXQgZW5kIG9mIGZpbGUKClByb3BlcnR5IGNoYW5nZXMgb246IExheW91dFRlc3RzL2FjY2Vz c2liaWxpdHkvZGl2LXdpdGhpbi1hbmNob3JzLWNhdXNlcy1jcmFzaC5odG1sCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K QWRkZWQ6IHN2bjpleGVjdXRhYmxlCiAgICsgKgoK 106928 2011-09-09 15:14:36 -0700 2011-09-09 16:23:30 -0700 Patch bug-44149-20110909151435.patch text/plain 6078 dmazzoni SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0ODc1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDktMDkgIERvbWluaWMg TWF6em9uaSAgPGRtYXp6b25pQGdvb2dsZS5jb20+CisKKyAgICAgICAgQVg6IEltYWdlcyB3aXRo aW4gYW5jaG9ycyBjYXVzZXMgY3Jhc2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQ0MTQ5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRml4ZXMgdGhlIHdheSBwYXJlbnQgUmVuZGVyT2JqZWN0IG9mIGFuIEFj Y2Vzc2liaWxpdHlSZW5kZXJPYmplY3QKKyAgICAgICAgaXMgY29tcHV0ZWQgaW4gdGhlIHByZXNl bmNlIG9mIGFkamFjZW50IGNvbnRpbnVhdGlvbnMuCisKKyAgICAgICAgVGVzdDogYWNjZXNzaWJp bGl0eS9kaXYtd2l0aGluLWFuY2hvcnMtY2F1c2VzLWNyYXNoLmh0bWwKKworICAgICAgICAqIGFj Y2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjpyZW5kZXJQYXJlbnRPYmplY3QpOgorCiAy MDExLTA5LTA5ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CiAKICAg ICAgICAgVW56aXAgaW5pdGlhbGl6YXRpb24gbGlzdHMgYW5kIGNvbnN0cnVjdG9ycyBpbiBKU0Nl bGwgaGllcmFyY2h5ICg1LzcpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0Fj Y2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAJKHJldmlzaW9uIDk0 ODY1KQorKysgU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVy T2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDE0LDEzICs0MTQsMTcgQEAgUmVuZGVyT2Jq ZWN0KiBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OgogICAgIGVsc2UgaWYgKHBhcmVudCAmJiAo Zmlyc3RDaGlsZCA9IHBhcmVudC0+Zmlyc3RDaGlsZCgpKSAmJiBmaXJzdENoaWxkLT5ub2RlKCkp IHsKICAgICAgICAgLy8gR2V0IHRoZSBub2RlJ3MgcmVuZGVyZXIgYW5kIGZvbGxvdyB0aGF0IGNv bnRpbnVhdGlvbiBjaGFpbiB1bnRpbCB0aGUgZmlyc3QgY2hpbGQgaXMgZm91bmQKICAgICAgICAg UmVuZGVyT2JqZWN0KiBub2RlUmVuZGVyRmlyc3RDaGlsZCA9IGZpcnN0Q2hpbGQtPm5vZGUoKS0+ cmVuZGVyZXIoKTsKLSAgICAgICAgaWYgKG5vZGVSZW5kZXJGaXJzdENoaWxkICE9IGZpcnN0Q2hp bGQpIHsKKyAgICAgICAgd2hpbGUgKG5vZGVSZW5kZXJGaXJzdENoaWxkICE9IGZpcnN0Q2hpbGQp IHsKICAgICAgICAgICAgIGZvciAoUmVuZGVyT2JqZWN0KiBjb250c1Rlc3QgPSBub2RlUmVuZGVy Rmlyc3RDaGlsZDsgY29udHNUZXN0OyBjb250c1Rlc3QgPSBuZXh0Q29udGludWF0aW9uKGNvbnRz VGVzdCkpIHsKICAgICAgICAgICAgICAgICBpZiAoY29udHNUZXN0ID09IGZpcnN0Q2hpbGQpIHsK ICAgICAgICAgICAgICAgICAgICAgcGFyZW50ID0gbm9kZVJlbmRlckZpcnN0Q2hpbGQtPnBhcmVu dCgpOwogICAgICAgICAgICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICB9CiAgICAg ICAgICAgICB9CisgICAgICAgICAgICBpZiAoZmlyc3RDaGlsZCA9PSBwYXJlbnQtPmZpcnN0Q2hp bGQoKSkKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIGZpcnN0Q2hpbGQgPSBw YXJlbnQtPmZpcnN0Q2hpbGQoKTsKKyAgICAgICAgICAgIG5vZGVSZW5kZXJGaXJzdENoaWxkID0g Zmlyc3RDaGlsZC0+bm9kZSgpLT5yZW5kZXJlcigpOwogICAgICAgICB9CiAgICAgfQogICAgICAg ICAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDk0ODc1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDktMDkgIERvbWluaWMgTWF6em9u aSAgPGRtYXp6b25pQGdvb2dsZS5jb20+CisKKyAgICAgICAgQWRkIGEgdGVzdCB0byBjYXRjaCBh IGNhc2Ugd2hlcmUgYW4gYXNzZXJ0aW9uIGZhaWx1cmUgb3IKKyAgICAgICAgY3Jhc2ggaXMgdHJp Z2dlcmVkIGluIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Qgd2hlbiBkZWxldGluZworICAgICAg ICBhIG5vZGUgdGhhdCBpbmNsdWRlcyBhIGNvbnRpbnVhdGlvbi4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0MTQ5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2Rpdi13aXRoaW4t YW5jaG9ycy1jYXVzZXMtY3Jhc2guaHRtbDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFj L2FjY2Vzc2liaWxpdHkvZGl2LXdpdGhpbi1hbmNob3JzLWNhdXNlcy1jcmFzaC1leHBlY3RlZC50 eHQ6IEFkZGVkLgorCiAyMDExLTA5LTA5ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3Jn PgogCiAgICAgICAgIEdUSyByZWJhc2VsaW5lLgpJbmRleDogTGF5b3V0VGVzdHMvYWNjZXNzaWJp bGl0eS9kaXYtd2l0aGluLWFuY2hvcnMtY2F1c2VzLWNyYXNoLmh0bWwKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g TGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9kaXYtd2l0aGluLWFuY2hvcnMtY2F1c2VzLWNyYXNo Lmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2Rpdi13aXRo aW4tYW5jaG9ycy1jYXVzZXMtY3Jhc2guaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw2OSBA QAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPiAKKzxodG1s PiAKKzxoZWFkPiAKKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vZmFzdC9qcy9yZXNv dXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPiAKKzxzY3JpcHQ+IAorICAgIHZhciBzdWNjZXNzZnVs bHlQYXJzZWQgPSBmYWxzZTsKKworICAgIGZ1bmN0aW9uIGJ1aWxkQWNjZXNzaWJpbGl0eVRyZWUo YWNjZXNzaWJpbGl0eU9iamVjdCwgaW5kZW50KSB7CisgICAgICAgIHZhciBzdHIgPSAiIjsKKyAg ICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBpbmRlbnQ7IGkrKykKKyAgICAgICAgICAgIHN0ciAr PSAiICAgICI7CisgICAgICAgIHN0ciArPSBhY2Nlc3NpYmlsaXR5T2JqZWN0LnJvbGU7CisgICAg ICAgIHN0ciArPSAiICIgKyBhY2Nlc3NpYmlsaXR5T2JqZWN0LnN0cmluZ1ZhbHVlOworICAgICAg ICBzdHIgKz0gIlxuIjsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRyZWUiKS5p bm5lclRleHQgKz0gc3RyOworCisgICAgICAgIGlmIChhY2Nlc3NpYmlsaXR5T2JqZWN0LnN0cmlu Z1ZhbHVlLmluZGV4T2YoJ0VuZCBvZiB0ZXN0JykgPj0gMCkKKyAgICAgICAgICAgIHJldHVybiBm YWxzZTsKKworICAgICAgICB2YXIgY291bnQgPSBhY2Nlc3NpYmlsaXR5T2JqZWN0LmNoaWxkcmVu Q291bnQ7CisgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgY291bnQ7ICsraSkgeworICAgICAg ICAgICAgaWYgKCFidWlsZEFjY2Vzc2liaWxpdHlUcmVlKGFjY2Vzc2liaWxpdHlPYmplY3QuY2hp bGRBdEluZGV4KGkpLCBpbmRlbnQgKyAxKSkKKyAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7 CisgICAgICAgIH0KKworICAgICAgICByZXR1cm4gdHJ1ZTsKKyAgICB9Cis8L3NjcmlwdD4gCis8 c2NyaXB0IHNyYz0iLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0 PiAKKzwvaGVhZD4gCis8Ym9keT4gCisgCis8YT48ZGl2PjwvZGl2PjwvYT4KKworPGE+PGRpdj48 L2Rpdj48L2E+CisKKzxhIGhyZWY9ImFib3V0OmJsYW5rIj48ZGl2PjwvZGl2PjwvYT4gCisKKzxk aXY+RW5kIG9mIHRlc3Q8L2Rpdj4KKworPHByZSBpZD0idHJlZSI+PC9wcmU+CisgCis8cCBpZD0i ZGVzY3JpcHRpb24iPjwvcD4gCis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4gCisgCis8c2NyaXB0 PiAKKyAgICBkZXNjcmlwdGlvbigiVGhpcyBjYW4gY2F1c2UgYSBjcmFzaC4iKTsKKyAKKyAgICBp ZiAod2luZG93LmFjY2Vzc2liaWxpdHlDb250cm9sbGVyKSB7CisgICAgICAgIC8vIEZpcnN0IGJ1 aWxkIHVwIGZ1bGwgYWNjZXNzaWJpbGl0eSB0cmVlLgorICAgICAgICBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgidHJlZSIpLmlubmVyVGV4dCArPSAiQmVmb3JlOlxuIjsKKyAgICAgICAgZG9jdW1l bnQuYm9keS5mb2N1cygpOworICAgICAgICBidWlsZEFjY2Vzc2liaWxpdHlUcmVlKGFjY2Vzc2li aWxpdHlDb250cm9sbGVyLmZvY3VzZWRFbGVtZW50LCAwKTsKKyAgICAgICAgCisgICAgICAgIC8v IFJlbW92ZSBhbmNob3IgdGhhdCBjYXVzZXMgZGVidWcgYXNzZXJ0IGluIEFjY2Vzc2liaWxpdHlS ZW5kZXJPYmplY3Q6OmFkZENoaWxkcmVuCisgICAgICAgIGRvY3VtZW50LmJvZHkucmVtb3ZlQ2hp bGQoZG9jdW1lbnQuYm9keS5jaGlsZHJlblsyXSkKKyAgICAgICAgCisgICAgICAgIC8vIEJ1aWxk IHVwIGZ1bGwgYWNjZXNzaWJpbGl0eSB0cmVlIGFnYWluLgorICAgICAgICBkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgidHJlZSIpLmlubmVyVGV4dCArPSAiQWZ0ZXI6XG4iOworICAgICAgICBkb2N1 bWVudC5ib2R5LmZvY3VzKCk7CisgICAgICAgIGJ1aWxkQWNjZXNzaWJpbGl0eVRyZWUoYWNjZXNz aWJpbGl0eUNvbnRyb2xsZXIuZm9jdXNlZEVsZW1lbnQsIDApOworICAgIH0KKyAKKyAgICBzdWNj ZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3JpcHQ+IAorIAorPHNjcmlwdCBzcmM9Ii4uL2Zh c3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+IAorPC9ib2R5PiAKKzwv aHRtbD4gCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9kaXYt d2l0aGluLWFuY2hvcnMtY2F1c2VzLWNyYXNoLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9kaXYtd2l0aGluLWFuY2hvcnMt Y2F1c2VzLWNyYXNoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL3Bs YXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L2Rpdi13aXRoaW4tYW5jaG9ycy1jYXVzZXMtY3Jhc2gt ZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE5IEBACitFbmQgb2YgdGVzdAor QmVmb3JlOgorQVhSb2xlOiBBWFdlYkFyZWEgQVhWYWx1ZTogCisgICAgQVhSb2xlOiBBWExpbmsg QVhWYWx1ZTogCisgICAgQVhSb2xlOiBBWEdyb3VwIEFYVmFsdWU6IAorICAgICAgICBBWFJvbGU6 IEFYU3RhdGljVGV4dCBBWFZhbHVlOiBFbmQgb2YgdGVzdAorQWZ0ZXI6CitBWFJvbGU6IEFYV2Vi QXJlYSBBWFZhbHVlOiAKKyAgICBBWFJvbGU6IEFYR3JvdXAgQVhWYWx1ZTogCisgICAgICAgIEFY Um9sZTogQVhTdGF0aWNUZXh0IEFYVmFsdWU6IEVuZCBvZiB0ZXN0CitUaGlzIGNhbiBjYXVzZSBh IGNyYXNoLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1l c3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBzdWNjZXNzZnVs bHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisK