44143 2010-08-17 17:06:44 -0700 new-run-webkit-tests: remove --show-sources option 2010-08-17 17:59:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dpranke dpranke oldest_to_newest 265856 0 dpranke 2010-08-17 17:06:44 -0700 new-run-webkit-tests: remove --show-sources option 265858 1 64655 dpranke 2010-08-17 17:09:44 -0700 Created attachment 64655 Patch 265867 2 64655 levin 2010-08-17 17:27:56 -0700 Comment on attachment 64655 Patch > diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/test_types/text_diff.py b/WebKitTools/Scripts/webkitpy/layout_tests/test_types/text_diff.py > + return port.compare_text(self._get_normalized_text(file1), > + self._get_normalized_text(file2)) Consider fixing the alignment here. 265868 3 dpranke 2010-08-17 17:30:16 -0700 (In reply to comment #2) > (From update of attachment 64655 [details]) > > > diff --git a/WebKitTools/Scripts/webkitpy/layout_tests/test_types/text_diff.py b/WebKitTools/Scripts/webkitpy/layout_tests/test_types/text_diff.py > > + return port.compare_text(self._get_normalized_text(file1), > > + self._get_normalized_text(file2)) > Consider fixing the alignment here. will do. thanks! 265881 4 dpranke 2010-08-17 17:59:59 -0700 Committed r65578: <http://trac.webkit.org/changeset/65578> 64655 2010-08-17 17:09:44 -0700 2010-08-17 17:27:56 -0700 Patch bug-44143-20100817170943.patch text/plain 7517 dpranke ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAwYmM4MGU1YjMzZTIwZTY3ZjVlOTJmZjYwODQyNTE1MTNkMmJiNTYyLi5kN2JmNDYw OTM3NTNiMjNmNTczYTZkN2UwNjJkM2E5OTAwNjUyNmQzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUgQEAK IDIwMTAtMDgtMTcgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CiAKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbmV3LXJ1bi13ZWJraXQt dGVzdHM6IHJlbW92ZSAtLXNob3ctc291cmNlcyBvcHRpb24KKworICAgICAgICAtLXNob3ctc291 cmNlcyBpcyBwcmV0dHkgbXVjaCBvYnNvbGV0ZSB3aXRoIC0tdHJhY2UgZXZlcnl0aGluZywgc28K KyAgICAgICAgSSdtIHJlbW92aW5nIGl0LgorCisgICAgICAgIEFsc28gcmVuYW1lIGEgY291cGxl IG9mIG1ldGhvZHMgaW4gdGhlIFRlc3RUZXh0RGlmZiBjbGFzcyB0byBtYWtlIHRoZWlyCisgICAg ICAgIGludGVuZGVkIHZpc2liaWxpdHkgKHByaXZhdGUpIG1vcmUgb2J2aW91cy4KKworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQxNDMKKworICAgICAg ICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2xheW91dF9wYWNrYWdlL3ByaW50aW5n LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRf dGVzdHMucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvdGVzdF90 eXBlcy9pbWFnZV9kaWZmLnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3Rlc3RfdHlwZXMvdGVzdF90eXBlX2Jhc2UucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvdGVzdF90eXBlcy90ZXh0X2RpZmYucHk6CisKKzIwMTAtMDgtMTcg IERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQg YnkgRXJpYyBTZWlkZWwuCiAKICAgICAgICAgZml4IHRlc3Qtd2Via2l0cHksIGFkZCBlYXN5IHdh eSB0byBmaW5kIGEgY2hlY2tvdXQgcm9vdApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvbGF5b3V0X3BhY2thZ2UvcHJpbnRpbmcucHkgYi9XZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9wcmlu dGluZy5weQppbmRleCBmODM4YTdiNmJlOGNmZmM5YTY3NjQ2ODMwNzc1ZDllMTVkZjQ0NTgzLi44 MWNkYzliNjdiYTU1NTMwMjAyMzk2NTM4OWY0ZjBiYWI0OGEwYWFkIDEwMDY0NAotLS0gYS9XZWJL aXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9sYXlvdXRfcGFja2FnZS9wcmlu dGluZy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9s YXlvdXRfcGFja2FnZS9wcmludGluZy5weQpAQCAtMTIzLDEyICsxMjMsNiBAQCBkZWYgcHJpbnRf b3B0aW9ucygpOgogICAgICAgICAgICAgaGVscD0ic2hvdyBkZXRhaWxlZCBoZWxwIG9uIGNvbnRy b2xsaW5nIHByaW50IG91dHB1dCIpLAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbigiLXYi LCAiLS12ZXJib3NlIiwgYWN0aW9uPSJzdG9yZV90cnVlIiwKICAgICAgICAgICAgIGRlZmF1bHQ9 RmFsc2UsIGhlbHA9ImluY2x1ZGUgZGVidWctbGV2ZWwgbG9nZ2luZyIpLAotCi0gICAgICAgICMg RklYTUU6IHdlIHNob3VsZCByZW1vdmUgdGhpczsgaXQncyBwcmV0dHkgbXVjaCBvYnNvbGV0ZSB3 aXRoIHRoZQotICAgICAgICAjIC0tcHJpbnQgdHJhY2UtZXZlcnl0aGluZyBvcHRpb24uCi0gICAg ICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLXNvdXJjZXMiLCBhY3Rpb249InN0b3JlX3RydWUi LAotICAgICAgICAgICAgaGVscD0oInNob3cgZXhwZWN0ZWQgcmVzdWx0IGZpbGUgcGF0aCBmb3Ig ZWFjaCB0ZXN0ICIKLSAgICAgICAgICAgICAgICAgIihpbXBsaWVzIC0tdmVyYm9zZSkiKSksCiAg ICAgXQogCiAKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rlc3RzLnB5CmluZGV4IGNiNDUzZjAxODIwMjVkM2I4 MGI2MDg2ZjIzZWFiNDhlNmI1ZmJmOWQuLjA2MjM5NjYwZmU3YTA3NTQ4OTU3NjU5NmYyZWFlNDMz MWIwOGI0YjkgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0 X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHMucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weQpAQCAtNTc5LDggKzU3OSw2IEBA IGNsYXNzIFRlc3RSdW5uZXI6CiAgICAgICAgIHRlc3RfYXJncy5uZXdfYmFzZWxpbmUgPSBzZWxm Ll9vcHRpb25zLm5ld19iYXNlbGluZQogICAgICAgICB0ZXN0X2FyZ3MucmVzZXRfcmVzdWx0cyA9 IHNlbGYuX29wdGlvbnMucmVzZXRfcmVzdWx0cwogCi0gICAgICAgIHRlc3RfYXJncy5zaG93X3Nv dXJjZXMgPSBzZWxmLl9vcHRpb25zLnNvdXJjZXMKLQogICAgICAgICBpZiBzZWxmLl9vcHRpb25z LnN0YXJ0dXBfZGlhbG9nOgogICAgICAgICAgICAgc2hlbGxfYXJncy5hcHBlbmQoJy0tdGVzdHNo ZWxsLXN0YXJ0dXAtZGlhbG9nJykKIApAQCAtMTY2Myw4ICsxNjYxLDYgQEAgZGVmIHBhcnNlX2Fy Z3MoYXJncz1Ob25lKToKICAgICBvcHRpb25fcGFyc2VyID0gb3B0cGFyc2UuT3B0aW9uUGFyc2Vy KG9wdGlvbl9saXN0PW9wdGlvbl9saXN0KQogCiAgICAgb3B0aW9ucywgYXJncyA9IG9wdGlvbl9w YXJzZXIucGFyc2VfYXJncyhhcmdzKQotICAgIGlmIG9wdGlvbnMuc291cmNlczoKLSAgICAgICAg b3B0aW9ucy52ZXJib3NlID0gVHJ1ZQogCiAgICAgcmV0dXJuIG9wdGlvbnMsIGFyZ3MKIApkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvdGVzdF90 eXBlcy9pbWFnZV9kaWZmLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvdGVzdF90eXBlcy9pbWFnZV9kaWZmLnB5CmluZGV4IDJhNTQ2ODY1ZGEwNzZkOGY2NDJj MzE3OGJmMzEzMTBmNDY4YWM1MGEuLmM5ZjQxMDc5OThiMWRkMDNmODY1MDM2YTZmMDBiNzdhMDAz NDJjNjUgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl c3RzL3Rlc3RfdHlwZXMvaW1hZ2VfZGlmZi5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy90ZXN0X3R5cGVzL2ltYWdlX2RpZmYucHkKQEAgLTE0NCwxMCAr MTQ0LDYgQEAgY2xhc3MgSW1hZ2VEaWZmKHRlc3RfdHlwZV9iYXNlLlRlc3RUeXBlQmFzZSk6CiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Jy5jaGVja3N1bScpCiAgICAgICAgIGV4cGVjdGVkX3BuZ19maWxlID0gc2VsZi5fcG9ydC5leHBl Y3RlZF9maWxlbmFtZShmaWxlbmFtZSwgJy5wbmcnKQogCi0gICAgICAgIGlmIHRlc3RfYXJncy5z aG93X3NvdXJjZXM6Ci0gICAgICAgICAgICBfbG9nLmRlYnVnKCdVc2luZyAlcycgJSBleHBlY3Rl ZF9oYXNoX2ZpbGUpCi0gICAgICAgICAgICBfbG9nLmRlYnVnKCdVc2luZyAlcycgJSBleHBlY3Rl ZF9wbmdfZmlsZSkKLQogICAgICAgICAjIEZJWE1FOiBXZSByZXBlYXQgdGhpcyBwYXR0ZXJuIG9m dGVuLCB3ZSBzaG91bGQgc2hhcmUgY29kZS4KICAgICAgICAgdHJ5OgogICAgICAgICAgICAgd2l0 aCBjb2RlY3Mub3BlbihleHBlY3RlZF9oYXNoX2ZpbGUsICJyIiwgImFzY2lpIikgYXMgZmlsZToK ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Rl c3RfdHlwZXMvdGVzdF90eXBlX2Jhc2UucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy90ZXN0X3R5cGVzL3Rlc3RfdHlwZV9iYXNlLnB5CmluZGV4IDhkYjJlM2Rm NTNiOTVlY2I3Njg5YTFlZmU2NjAwMTI0ZDE5NGIyYjcuLmRkNDQ2NDJiMjUxMjI0NmFlYzM4NTNl NjAxZmMwMTExODJiMmY4YjggMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3Rlc3RfdHlwZXMvdGVzdF90eXBlX2Jhc2UucHkKKysrIGIvV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvdGVzdF90eXBlcy90ZXN0X3R5cGVf YmFzZS5weQpAQCAtNTgsOSArNTgsNiBAQCBjbGFzcyBUZXN0QXJndW1lbnRzKG9iamVjdCk6CiAg ICAgIyBXaGV0aGVyIHRvIHVzZSB3ZGlmZiB0byBnZW5lcmF0ZSBieS13b3JkIGRpZmZzLgogICAg IHdkaWZmID0gRmFsc2UKIAotICAgICMgV2hldGhlciB0byByZXBvcnQgdGhlIGxvY2F0aW9ucyBv ZiB0aGUgZXhwZWN0ZWQgcmVzdWx0IGZpbGVzIHVzZWQuCi0gICAgc2hvd19zb3VyY2VzID0gRmFs c2UKLQogIyBQeXRob24gYnVnIHdvcmthcm91bmQuICBTZWUgdGhlIHdkaWZmIGNvZGUgaW4gV3Jp dGVPdXRwdXRGaWxlcyBmb3IgYW4KICMgZXhwbGFuYXRpb24uCiBfd2RpZmZfYXZhaWxhYmxlID0g VHJ1ZQpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVz dHMvdGVzdF90eXBlcy90ZXh0X2RpZmYucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy90ZXN0X3R5cGVzL3RleHRfZGlmZi5weQppbmRleCAxOGY3NGI4OTdmMzg4 ODlhYjUxZWY0MmMxY2Y2ODFiNmUzMzM1Y2EyLi4zMjViYmE3NjMwODlhZGRhZWEwYzUyNTBiNzI0 MGVlZDVhODdlYmI0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy90ZXN0X3R5cGVzL3RleHRfZGlmZi5weQorKysgYi9XZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy90ZXN0X3R5cGVzL3RleHRfZGlmZi5weQpAQCAtNDgs MjUgKzQ4LDIyIEBAIF9sb2cgPSBsb2dnaW5nLmdldExvZ2dlcigid2Via2l0cHkubGF5b3V0X3Rl c3RzLnRlc3RfdHlwZXMudGV4dF9kaWZmIikKIAogY2xhc3MgVGVzdFRleHREaWZmKHRlc3RfdHlw ZV9iYXNlLlRlc3RUeXBlQmFzZSk6CiAKLSAgICBkZWYgZ2V0X25vcm1hbGl6ZWRfb3V0cHV0X3Rl eHQoc2VsZiwgb3V0cHV0KToKKyAgICBkZWYgX2dldF9ub3JtYWxpemVkX291dHB1dF90ZXh0KHNl bGYsIG91dHB1dCk6CiAgICAgICAgICMgU29tZSB0ZXN0cyBwcm9kdWNlICJcclxuIiBleHBsaWNp dGx5LiAgT3VyIHN5c3RlbSAoUHl0aG9uL0N5Z3dpbikKICAgICAgICAgIyBoZWxwZnVsbHkgY2hh bmdlcyB0aGUgIlxuIiB0byAiXHJcbiIsIHJlc3VsdGluZyBpbiAiXHJcclxuIi4KICAgICAgICAg bm9ybSA9IG91dHB1dC5yZXBsYWNlKCJcclxyXG4iLCAiXHJcbiIpLnN0cmlwKCJcclxuIikucmVw bGFjZSgKICAgICAgICAgICAgICAiXHJcbiIsICJcbiIpCiAgICAgICAgIHJldHVybiBub3JtICsg IlxuIgogCi0gICAgZGVmIGdldF9ub3JtYWxpemVkX2V4cGVjdGVkX3RleHQoc2VsZiwgZmlsZW5h bWUsIHNob3dfc291cmNlcyk6CisgICAgZGVmIF9nZXRfbm9ybWFsaXplZF9leHBlY3RlZF90ZXh0 KHNlbGYsIGZpbGVuYW1lKToKICAgICAgICAgIiIiR2l2ZW4gdGhlIGZpbGVuYW1lIG9mIHRoZSB0 ZXN0LCByZWFkIHRoZSBleHBlY3RlZCBvdXRwdXQgZnJvbSBhIGZpbGUKICAgICAgICAgYW5kIG5v cm1hbGl6ZSB0aGUgdGV4dC4gIFJldHVybnMgYSBzdHJpbmcgd2l0aCB0aGUgZXhwZWN0ZWQgdGV4 dCwgb3IgJycKICAgICAgICAgaWYgdGhlIGV4cGVjdGVkIG91dHB1dCBmaWxlIHdhcyBub3QgZm91 bmQuIiIiCiAgICAgICAgICMgUmVhZCB0aGUgcG9ydC1zcGVjaWZpYyBleHBlY3RlZCB0ZXh0Lgog ICAgICAgICBleHBlY3RlZF9maWxlbmFtZSA9IHNlbGYuX3BvcnQuZXhwZWN0ZWRfZmlsZW5hbWUo ZmlsZW5hbWUsICcudHh0JykKLSAgICAgICAgaWYgc2hvd19zb3VyY2VzOgotICAgICAgICAgICAg X2xvZy5kZWJ1ZygnVXNpbmcgJXMnICUgZXhwZWN0ZWRfZmlsZW5hbWUpCisgICAgICAgIHJldHVy biBzZWxmLl9nZXRfbm9ybWFsaXplZF90ZXh0KGV4cGVjdGVkX2ZpbGVuYW1lKQogCi0gICAgICAg IHJldHVybiBzZWxmLmdldF9ub3JtYWxpemVkX3RleHQoZXhwZWN0ZWRfZmlsZW5hbWUpCi0KLSAg ICBkZWYgZ2V0X25vcm1hbGl6ZWRfdGV4dChzZWxmLCBmaWxlbmFtZSk6CisgICAgZGVmIF9nZXRf bm9ybWFsaXplZF90ZXh0KHNlbGYsIGZpbGVuYW1lKToKICAgICAgICAgIyBGSVhNRTogV2UgcmVw ZWF0IHRoaXMgcGF0dGVybiBvZnRlbiwgd2Ugc2hvdWxkIHNoYXJlIGNvZGUuCiAgICAgICAgIHRy eToKICAgICAgICAgICAgICMgTk9URTogLWV4cGVjdGVkLnR4dCBmaWxlcyBhcmUgQUxXQVlTIHV0 Zi04LiAgSG93ZXZlciwKQEAgLTk4LDkgKzk1LDggQEAgY2xhc3MgVGVzdFRleHREaWZmKHRlc3Rf dHlwZV9iYXNlLlRlc3RUeXBlQmFzZSk6CiAgICAgICAgICAgICByZXR1cm4gZmFpbHVyZXMKIAog ICAgICAgICAjIE5vcm1hbGl6ZSB0ZXh0IHRvIGRpZmYKLSAgICAgICAgb3V0cHV0ID0gc2VsZi5n ZXRfbm9ybWFsaXplZF9vdXRwdXRfdGV4dChvdXRwdXQpCi0gICAgICAgIGV4cGVjdGVkID0gc2Vs Zi5nZXRfbm9ybWFsaXplZF9leHBlY3RlZF90ZXh0KGZpbGVuYW1lLAotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0ZXN0X2FyZ3Muc2hvd19zb3Vy Y2VzKQorICAgICAgICBvdXRwdXQgPSBzZWxmLl9nZXRfbm9ybWFsaXplZF9vdXRwdXRfdGV4dChv dXRwdXQpCisgICAgICAgIGV4cGVjdGVkID0gc2VsZi5fZ2V0X25vcm1hbGl6ZWRfZXhwZWN0ZWRf dGV4dChmaWxlbmFtZSkKIAogICAgICAgICAjIFdyaXRlIG91dHB1dCBmaWxlcyBmb3IgbmV3IHRl c3RzLCB0b28uCiAgICAgICAgIGlmIHBvcnQuY29tcGFyZV90ZXh0KG91dHB1dCwgZXhwZWN0ZWQp OgpAQCAtMTI3LDUgKzEyMyw1IEBAIGNsYXNzIFRlc3RUZXh0RGlmZih0ZXN0X3R5cGVfYmFzZS5U ZXN0VHlwZUJhc2UpOgogICAgICAgICAgIEZhbHNlIG90aGVyd2lzZS4KICAgICAgICAgIiIiCiAK LSAgICAgICAgcmV0dXJuIHBvcnQuY29tcGFyZV90ZXh0KHNlbGYuZ2V0X25vcm1hbGl6ZWRfdGV4 dChmaWxlMSksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2VsZi5nZXRf bm9ybWFsaXplZF90ZXh0KGZpbGUyKSkKKyAgICAgICAgcmV0dXJuIHBvcnQuY29tcGFyZV90ZXh0 KHNlbGYuX2dldF9ub3JtYWxpemVkX3RleHQoZmlsZTEpLAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIHNlbGYuX2dldF9ub3JtYWxpemVkX3RleHQoZmlsZTIpKQo=