44140 2010-08-17 16:25:29 -0700 No back/forward list entry added when submitting a form via an onclick handler inside a frame 2011-02-03 15:07:28 -0800 1 1 1 Unclassified WebKit History 528+ (Nightly build) All All RESOLVED FIXED http://development.rhubarbproductions.com/iframe/ P2 Major --- 1 kevin webkit-unassigned beidson commit-queue fishd mihaip priyajeet.hora oldest_to_newest 265835 0 kevin 2010-08-17 16:25:29 -0700 Visit the test link and enter some text in the field and click the "Go to Frame 2" link. In the Resulting frame, click the "Go Back to Frame 1 via javascript history" link and you will see it move back to frame 1 as expected and the field still has the text you typed as expected from a back function. Now click the form Send button. Clicking the "Go Back to Frame 1 via javascript history" link now breaks in one of 2 ways. If the test link was the 1st page you loaded in the browser tab, nothing will happen instead of going back to frame 1 in the IFRAME. If you had a page loaded in the tab prior to loading the test link, it will go back to that page because it doesn't see any other page in the history between the 2. The IFRAME change is not incrementing the history when the form is submitted. If you open the IFRAME in a New Tab on it's own via the contextual menu, you'll find that submitting the form now increments just fine and you can return to Frame 1 via the link. It's only when it's an IFRAME. This is broken in the latest Webkit, Safari 5 and Chrome, while it works as expected in Firefox, Internet Explorer and Opera. 285715 1 priyajeet.hora 2010-09-27 14:00:07 -0700 Can confirm this issue. 286309 2 mihaip 2010-09-28 09:50:18 -0700 As far as I can tell, this only happens when an onclick handler is used to submit the form. Here's two variants on the reported testcase: http://persistent.info/webkit/test-cases/form-submit-history/container.html has an <input type="submit"> and lets normal form submission happen. That seems to work fine (history length of 2 if the test case is opened in a new tab). http://persistent.info/webkit/test-cases/form-submit-history/container-onclick.html has an <input type="button"> which submits the form via an onclick handler. That results in a history length of 1 (if the test case is opened in a new tab). 286467 3 mihaip 2010-09-28 12:49:36 -0700 This bug appears to be triggered by http://trac.webkit.org/changeset/52033 (which was fixing bug 32383). In RedirectScheduler::scheduleFormSubmission we lock the back-forward list if a submission is triggered by JS. Brady, is there a reason why this wasn't also restricted to submissions that were not in response to user gestures? 286477 4 69090 mihaip 2010-09-28 12:59:14 -0700 Created attachment 69090 Patch 286499 5 69090 dglazkov 2010-09-28 13:37:40 -0700 Comment on attachment 69090 Patch ok. 286501 6 priyajeet.hora 2010-09-28 13:43:09 -0700 So to be clear, you guys are removing the restriction so that JS can trigger submits? Right? Or is that the restriction is being extended to also apply to submits not triggered via JS? 286504 7 mihaip 2010-09-28 13:48:41 -0700 (In reply to comment #6) > So to be clear, you guys are removing the restriction so that JS can trigger submits? Right? > > Or is that the restriction is being extended to also apply to submits not triggered via JS? The restriction isn't about triggering submits, it's about submits adding history entries. With this change, we don't suppress the history entry if the form submit is done by a user action (e.g. a click on the submit button). Entirely programatic submits (e.g. calling form.submit() inside a setTimeout) inside iframes will still not generate history entries. 286513 8 priyajeet.hora 2010-09-28 14:00:49 -0700 What if it's a programmatic submit like below, even though it is triggered by a user gesture? <button type='button' onclick='foo();' /> foo() { ... ... form.submit(); ... } I would assume this should still keep isUserGesture true, thus making everything false and not locking out the history list. What if - foo() { ... ... setTimeout(t, form.submit()); ... } Will in this case isUserGesture be true or false? Technically it was triggered by a user action however due to that setTimeout it becomes entirely programmatic according to you. Thanks 286582 9 mihaip 2010-09-28 15:31:36 -0700 (In reply to comment #8) > What if it's a programmatic submit like below, even though it is triggered by a user gesture? <snip> > I would assume this should still keep isUserGesture true, thus making everything false and not locking out the history list. Yes. That's what form-submit-in-frame-via-onclick.html in my patch tests. > Will in this case isUserGesture be true or false? > Technically it was triggered by a user action however due to that setTimeout it becomes entirely programmatic according to you. isUserGesture will be false. For better or worse, this is consistent with user gesture checks throughout WebKit (e.g. for popup blocking). 286598 10 69090 commit-queue 2010-09-28 15:56:51 -0700 Comment on attachment 69090 Patch Rejecting patch 69090 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2 Last 500 characters of output: uccessful. Files=14, Tests=304, 1 wallclock secs ( 0.63 cusr + 0.13 csys = 0.76 CPU) Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/abarth/git/webkit-queue/LayoutTests Testing 21476 test cases. java/lc3/JSObject/ToObject-001.html -> failed Exiting early after 1 failures. 17582 tests run. 261.25s total testing time 17581 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 28 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/4167003 286602 11 69090 mihaip 2010-09-28 16:00:25 -0700 Comment on attachment 69090 Patch Looks like flaky tests made the CQ reject this. http/tests/appcache/origin-quota.html failed the first time, java/lc3/JSObject/ToObject-001.html the second. 286622 12 69090 commit-queue 2010-09-28 16:40:32 -0700 Comment on attachment 69090 Patch Rejecting patch 69090 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'land-attachment', '--force-clean', '--ignore-builders', '--quiet', '--non-interactive', '--parent-command=commit-queue', 69090]" exit_code: 2 Last 500 characters of output: d by pre-commit hook (exit code 1) with output: The following files contain tab characters: trunk/LayoutTests/fast/history/resources/form-with-input-submit.html trunk/LayoutTests/fast/history/resources/form-with-onclick-submit.html Please use spaces instead to indent. If you must commit a file with tabs, use svn propset to set the "allow-tabs" property. at /usr/local/git/libexec/git-core/git-svn line 572 Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Full output: http://queues.webkit.org/results/4191004 286627 13 69090 mihaip 2010-09-28 16:43:10 -0700 Comment on attachment 69090 Patch (In reply to comment #12) > (From update of attachment 69090 [details]) > Rejecting patch 69090 from commit-queue. > The following files contain tab characters: Oops, will remove tabs and land by hand. 286632 14 mihaip 2010-09-28 16:50:22 -0700 Committed r68609: <http://trac.webkit.org/changeset/68609> 286663 15 priyajeet.hora 2010-09-28 17:32:28 -0700 (In reply to comment #9) > <snip> Cool thanks. Any idea what will be the timeline when this get's up taken by a non-dev channel build of Chrome? And same question for someone at Apple, when will this be up taken by Safari 5? 286664 16 mihaip 2010-09-28 17:35:00 -0700 (In reply to comment #15) > Any idea what will be the timeline when this get's up taken by a non-dev channel build of Chrome? Chrome 8 is the most likely release this will be in. 345008 17 priyajeet.hora 2011-02-03 14:21:37 -0800 Been almost 4 months, does Safari folks plan to upgrade to a newer webkit version or uptake the fix for this bug? :( 345034 18 kevin 2011-02-03 15:07:28 -0800 Safari 4 was Webkit 531.x Safari 5 is Webkit 533.x likely jumping over Webkit Nightlies of 532.x Webkit is currently 534.x... ...so my completely uniformed guess would be Webkit 535.x release in Safari 6 unless they decide to push a 5.5 or a 5.1 release with a lot of updates. 69090 2010-09-28 12:59:14 -0700 2010-09-28 16:43:10 -0700 Patch bug-44140-20100928125913.patch text/plain 10398 mihaip ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5NGFhYzhlZjU1NGNiOTM3ZTA2NjZiZGZlMzg3MjdkYWU4NWZlOTkzLi5jOWExZmFh MWE4ZmQ4ZGQxOTQ0NTM0YzkzNDllOTc5OGJkNjYyZWZhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAK KzIwMTAtMDktMjggIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gYmFjay9mb3J3 YXJkIGxpc3QgZW50cnkgYWRkZWQgd2hlbiBzdWJtaXR0aW5nIGEgZm9ybSB2aWEgYW4gb25jbGlj ayBoYW5kbGVyIGluc2lkZSBhIGZyYW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00NDE0MAorICAgICAgICAKKyAgICAgICAgQWRkIHRlc3RzIGZvciB1 c2VyLWdlc3R1cmUgaW5pdGlhdGVkIGZvcm0gc3VibWlzc2lvbnMgaW5zaWRlIGlmcmFtZXMgdG8K KyAgICAgICAgbWFrZSBzdXJlIHRoYXQgdGhleSBnZW5lcmF0ZSBiYWNrL2ZvcndhcmQgbGlzdCBl bnRyaWVzLgorCisgICAgICAgICogZmFzdC9oaXN0b3J5L2Zvcm0tc3VibWl0LWluLWZyYW1lLWV4 cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9oaXN0b3J5L2Zvcm0tc3VibWl0LWlu LWZyYW1lLXZpYS1vbmNsaWNrLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9o aXN0b3J5L2Zvcm0tc3VibWl0LWluLWZyYW1lLXZpYS1vbmNsaWNrLmh0bWw6IEFkZGVkLgorICAg ICAgICAqIGZhc3QvaGlzdG9yeS9mb3JtLXN1Ym1pdC1pbi1mcmFtZS5odG1sOiBBZGRlZC4KKyAg ICAgICAgKiBmYXN0L2hpc3RvcnkvcmVzb3VyY2VzL2Zvcm0td2l0aC1pbnB1dC1zdWJtaXQuaHRt bDogQWRkZWQuCisgICAgICAgICogZmFzdC9oaXN0b3J5L3Jlc291cmNlcy9mb3JtLXdpdGgtb25j bGljay1zdWJtaXQuaHRtbDogQWRkZWQuCisKIDIwMTAtMDktMjggIEFuZHJlaSBQb3Blc2N1ICA8 YW5kcmVpcEBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEplcmVteSBPcmxvdy4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvaGlzdG9yeS9mb3JtLXN1Ym1pdC1pbi1mcmFt ZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2hpc3RvcnkvZm9ybS1zdWJtaXQtaW4t ZnJhbWUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjc3NGYxNDMzMjYwMTU3ZmQyOTlmODgyNmQ0 YWIyNzQxNWJiZjg5NWYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2hpc3Rv cnkvZm9ybS1zdWJtaXQtaW4tZnJhbWUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTggQEAKK1Rl c3RzIHRoYXQgZm9ybSBzdWJtaXNzaW9ucyBpbnNpZGUgYW4gaWZyYW1lIGdlbmVyYXRlIGhpc3Rv cnkgZW50cmllcy4KKworCisKKy0tLS0tLS0tCitGcmFtZTogJ3RoZS1mcmFtZScKKy0tLS0tLS0t CitUaGlzIHBhZ2UgaXMgdGhlIHRhcmdldCBvZiBhIHJlZGlyZWN0LgorCitQQVNTOiBIaXN0b3J5 IGl0ZW0gY291bnQgc2hvdWxkIGJlIDIgYW5kIGlzLgorCisKKz09PT09PT09PT09PT09IEJhY2sg Rm9yd2FyZCBMaXN0ID09PT09PT09PT09PT09CisgICAgICAgIChmaWxlIHRlc3QpOmZhc3QvaGlz dG9yeS9mb3JtLXN1Ym1pdC1pbi1mcmFtZS5odG1sICAqKm5hdiB0YXJnZXQqKgorICAgICAgICAg ICAgKGZpbGUgdGVzdCk6ZmFzdC9oaXN0b3J5L3Jlc291cmNlcy9mb3JtLXdpdGgtaW5wdXQtc3Vi bWl0Lmh0bWwgKGluIGZyYW1lICJ0aGUtZnJhbWUiKQorY3Vyci0+ICAoZmlsZSB0ZXN0KTpmYXN0 L2hpc3RvcnkvZm9ybS1zdWJtaXQtaW4tZnJhbWUuaHRtbAorICAgICAgICAgICAgKGZpbGUgdGVz dCk6ZmFzdC9oaXN0b3J5L3Jlc291cmNlcy9yZWRpcmVjdC10YXJnZXQuaHRtbCMyIChpbiBmcmFt ZSAidGhlLWZyYW1lIikgICoqbmF2IHRhcmdldCoqCis9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9oaXN0 b3J5L2Zvcm0tc3VibWl0LWluLWZyYW1lLXZpYS1vbmNsaWNrLWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL2Zhc3QvaGlzdG9yeS9mb3JtLXN1Ym1pdC1pbi1mcmFtZS12aWEtb25jbGljay1leHBl Y3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uNmY4MTE5NDU1NWY4ZTcyYjA1YWM0MTI3YjJlMGMxNzEyMmY1 ZDkyNwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvaGlzdG9yeS9mb3JtLXN1 Ym1pdC1pbi1mcmFtZS12aWEtb25jbGljay1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxOCBAQAor VGVzdHMgdGhhdCBmb3JtIHN1Ym1pc3Npb25zICh2aWEgYW4gb25jbGljayBoYW5kbGVyKSBpbnNp ZGUgYW4gaWZyYW1lIGdlbmVyYXRlIGhpc3RvcnkgZW50cmllcy4KKworCisKKy0tLS0tLS0tCitG cmFtZTogJ3RoZS1mcmFtZScKKy0tLS0tLS0tCitUaGlzIHBhZ2UgaXMgdGhlIHRhcmdldCBvZiBh IHJlZGlyZWN0LgorCitQQVNTOiBIaXN0b3J5IGl0ZW0gY291bnQgc2hvdWxkIGJlIDIgYW5kIGlz LgorCisKKz09PT09PT09PT09PT09IEJhY2sgRm9yd2FyZCBMaXN0ID09PT09PT09PT09PT09Cisg ICAgICAgIChmaWxlIHRlc3QpOmZhc3QvaGlzdG9yeS9mb3JtLXN1Ym1pdC1pbi1mcmFtZS12aWEt b25jbGljay5odG1sICAqKm5hdiB0YXJnZXQqKgorICAgICAgICAgICAgKGZpbGUgdGVzdCk6ZmFz dC9oaXN0b3J5L3Jlc291cmNlcy9mb3JtLXdpdGgtb25jbGljay1zdWJtaXQuaHRtbCAoaW4gZnJh bWUgInRoZS1mcmFtZSIpCitjdXJyLT4gIChmaWxlIHRlc3QpOmZhc3QvaGlzdG9yeS9mb3JtLXN1 Ym1pdC1pbi1mcmFtZS12aWEtb25jbGljay5odG1sCisgICAgICAgICAgICAoZmlsZSB0ZXN0KTpm YXN0L2hpc3RvcnkvcmVzb3VyY2VzL3JlZGlyZWN0LXRhcmdldC5odG1sIzIgKGluIGZyYW1lICJ0 aGUtZnJhbWUiKSAgKipuYXYgdGFyZ2V0KioKKz09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2hpc3Rvcnkv Zm9ybS1zdWJtaXQtaW4tZnJhbWUtdmlhLW9uY2xpY2suaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv aGlzdG9yeS9mb3JtLXN1Ym1pdC1pbi1mcmFtZS12aWEtb25jbGljay5odG1sCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LmY5Y2E0ZTE3NGJjMjRkZjU4ZjM2YWVmZDYwOTk4YjYzNWU2ODZjOTcKLS0tIC9kZXYvbnVsbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2hpc3RvcnkvZm9ybS1zdWJtaXQtaW4tZnJhbWUtdmlhLW9u Y2xpY2suaHRtbApAQCAtMCwwICsxLDQ0IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGJv ZHk+Cis8cCBpZD0iZGVzY3JpcHRpb24iPlRlc3RzIHRoYXQgZm9ybSBzdWJtaXNzaW9ucyAodmlh IGFuIG9uY2xpY2sgaGFuZGxlcikgaW5zaWRlIGFuIGlmcmFtZSBnZW5lcmF0ZSBoaXN0b3J5IGVu dHJpZXMuPC9wPgorCis8ZGl2IGlkPSJtYW51YWwtZXhwbGFuYXRpb24iIHN0eWxlPSJkaXNwbGF5 OiBub25lOyBjb2xvcjogYmx1ZSI+V2hlbiBydW5uaW5nIHRoaXMgdGVzdCBvdXRzaWRlIG9mIERS VCwgcGxlYXNlIGNsaWNrIG9uIHRoZSAiU3VibWl0IiBidXR0b24uPC9kaXY+CisKKzxwcmUgaWQ9 ImNvbnNvbGUiPjwvcHJlPgorCis8aWZyYW1lIGlkPSJ0aGUtZnJhbWUiIHNyYz0icmVzb3VyY2Vz L2Zvcm0td2l0aC1vbmNsaWNrLXN1Ym1pdC5odG1sIiBvbmxvYWQ9InN1Ym1pdEZvcm0oKSI+PC9p ZnJhbWU+CisKKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7Cisg ICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuY2xlYXJCYWNrRm9yd2FyZExpc3QoKTsKKyAgICBsYXlv dXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xs ZXIuZHVtcEFzVGV4dCgpOworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBDaGlsZEZyYW1l c0FzVGV4dCgpOworfQorCit2YXIgZm9ybVN1Ym1pdHRlZCA9IGZhbHNlOworCitmdW5jdGlvbiBz dWJtaXRGb3JtKCkKK3sKKyAgICBpZiAoZm9ybVN1Ym1pdHRlZCkgcmV0dXJuOworICAgIGZvcm1T dWJtaXR0ZWQgPSB0cnVlOworCisgICAgLy8gTWFrZSBzdXJlIHdlIGFsd2F5cyBnZW5lcmF0ZSBo aXN0b3J5IGVudHJpZXMgZm9yIHRoZSBwYWdlIHRoYXQgd2UncmUgb24uCisgICAgd2luZG93LnNl dFRpbWVvdXQoZnVuY3Rpb24oKSB7CisgICAgICAgIGlmICh3aW5kb3cuZXZlbnRTZW5kZXIpIHsK KyAgICAgICAgICAgIHZhciBmcmFtZU5vZGUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgndGhl LWZyYW1lJyk7CisgICAgICAgICAgICB2YXIgc3VibWl0QnV0dG9uTm9kZSA9IGZyYW1lTm9kZS5j b250ZW50V2luZG93LmRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdzdWJtaXQtYnV0dG9uJyk7Cisg ICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbygKKyAgICAgICAgICAgICAgICBmcmFt ZU5vZGUub2Zmc2V0TGVmdCArIHN1Ym1pdEJ1dHRvbk5vZGUub2Zmc2V0TGVmdCArIHN1Ym1pdEJ1 dHRvbk5vZGUub2Zmc2V0V2lkdGggLyAyLAorICAgICAgICAgICAgICAgIGZyYW1lTm9kZS5vZmZz ZXRUb3AgKyBzdWJtaXRCdXR0b25Ob2RlLm9mZnNldFRvcCArIHN1Ym1pdEJ1dHRvbk5vZGUub2Zm c2V0SGVpZ2h0IC8gMik7CisgICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZURvd24oKTsKKyAg ICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsgIAorICAgICAgICB9IGVsc2UgeworICAg ICAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ21hbnVhbC1leHBsYW5hdGlvbicpLnN0 eWxlLmRpc3BsYXkgPSAnJzsgICAgCisgICAgICAgIH0KKyAgICB9LCAwKTsKK30KKzwvc2NyaXB0 PgorPC9ib2R5PgorPC9odG1sPgpcIE5vIG5ld2xpbmUgYXQgZW5kIG9mIGZpbGUKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvaGlzdG9yeS9mb3JtLXN1Ym1pdC1pbi1mcmFtZS5odG1sIGIv TGF5b3V0VGVzdHMvZmFzdC9oaXN0b3J5L2Zvcm0tc3VibWl0LWluLWZyYW1lLmh0bWwKbmV3IGZp bGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMC4uMmQ1MzI5MThjNGZlZjRmMTk2M2MzZjIxZThhOGZjZDk2MTNkNjE5MQotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvaGlzdG9yeS9mb3JtLXN1Ym1pdC1pbi1mcmFtZS5o dG1sCkBAIC0wLDAgKzEsNDQgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8Ym9keT4KKzxw IGlkPSJkZXNjcmlwdGlvbiI+VGVzdHMgdGhhdCBmb3JtIHN1Ym1pc3Npb25zIGluc2lkZSBhbiBp ZnJhbWUgZ2VuZXJhdGUgaGlzdG9yeSBlbnRyaWVzLjwvcD4KKworPGRpdiBpZD0ibWFudWFsLWV4 cGxhbmF0aW9uIiBzdHlsZT0iZGlzcGxheTogbm9uZTsgY29sb3I6IGJsdWUiPldoZW4gcnVubmlu ZyB0aGlzIHRlc3Qgb3V0c2lkZSBvZiBEUlQsIHBsZWFzZSBjbGljayBvbiB0aGUgIlN1Ym1pdCIg YnV0dG9uLjwvZGl2PgorCis8cHJlIGlkPSJjb25zb2xlIj48L3ByZT4KKworPGlmcmFtZSBpZD0i dGhlLWZyYW1lIiBzcmM9InJlc291cmNlcy9mb3JtLXdpdGgtaW5wdXQtc3VibWl0Lmh0bWwiIG9u bG9hZD0ic3VibWl0Rm9ybSgpIj48L2lmcmFtZT4KKworPHNjcmlwdD4KK2lmICh3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIpIHsKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5jbGVhckJhY2tG b3J3YXJkTGlzdCgpOworICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsK KyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgbGF5b3V0VGVzdENv bnRyb2xsZXIuZHVtcENoaWxkRnJhbWVzQXNUZXh0KCk7Cit9CisKK3ZhciBmb3JtU3VibWl0dGVk ID0gZmFsc2U7CisKK2Z1bmN0aW9uIHN1Ym1pdEZvcm0oKQoreworICAgIGlmIChmb3JtU3VibWl0 dGVkKSByZXR1cm47CisgICAgZm9ybVN1Ym1pdHRlZCA9IHRydWU7CisKKyAgICAvLyBNYWtlIHN1 cmUgd2UgYWx3YXlzIGdlbmVyYXRlIGhpc3RvcnkgZW50cmllcyBmb3IgdGhlIHBhZ2UgdGhhdCB3 ZSdyZSBvbi4KKyAgICB3aW5kb3cuc2V0VGltZW91dChmdW5jdGlvbigpIHsKKyAgICAgICAgaWYg KHdpbmRvdy5ldmVudFNlbmRlcikgeworICAgICAgICAgICAgdmFyIGZyYW1lTm9kZSA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCd0aGUtZnJhbWUnKTsKKyAgICAgICAgICAgIHZhciBzdWJtaXRC dXR0b25Ob2RlID0gZnJhbWVOb2RlLmNvbnRlbnRXaW5kb3cuZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ3N1Ym1pdC1idXR0b24nKTsKKyAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRv KAorICAgICAgICAgICAgICAgIGZyYW1lTm9kZS5vZmZzZXRMZWZ0ICsgc3VibWl0QnV0dG9uTm9k ZS5vZmZzZXRMZWZ0ICsgc3VibWl0QnV0dG9uTm9kZS5vZmZzZXRXaWR0aCAvIDIsCisgICAgICAg ICAgICAgICAgZnJhbWVOb2RlLm9mZnNldFRvcCArIHN1Ym1pdEJ1dHRvbk5vZGUub2Zmc2V0VG9w ICsgc3VibWl0QnV0dG9uTm9kZS5vZmZzZXRIZWlnaHQgLyAyKTsKKyAgICAgICAgICAgIGV2ZW50 U2VuZGVyLm1vdXNlRG93bigpOworICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VVcCgpOyAg CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgn bWFudWFsLWV4cGxhbmF0aW9uJykuc3R5bGUuZGlzcGxheSA9ICcnOyAgICAKKyAgICAgICAgfQor ICAgIH0sIDApOworfQorPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBh dCBlbmQgb2YgZmlsZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9oaXN0b3J5L3Jlc291 cmNlcy9mb3JtLXdpdGgtaW5wdXQtc3VibWl0Lmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2hpc3Rv cnkvcmVzb3VyY2VzL2Zvcm0td2l0aC1pbnB1dC1zdWJtaXQuaHRtbApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi41NTZj OThhNmY2ZWM1ZDU3ZjBlZjdhODM4YWJhZDliMWJlYWNlNGNlCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9oaXN0b3J5L3Jlc291cmNlcy9mb3JtLXdpdGgtaW5wdXQtc3VibWl0 Lmh0bWwKQEAgLTAsMCArMSwxMSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5Pgor RnJhbWUgMQorCis8c2NyaXB0PmRvY3VtZW50LndyaXRlKCc8Zm9ybSBtZXRob2Q9InBvc3QiIGFj dGlvbj0icmVkaXJlY3QtdGFyZ2V0Lmh0bWwjJyArIChoaXN0b3J5Lmxlbmd0aCArIDEpICsgJyI+ Jyk7PC9zY3JpcHQ+CisJPGlucHV0IGlkPSJzdWJtaXQtYnV0dG9uIiB0eXBlPSJzdWJtaXQiPgor PC9mb3JtPgorCis8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9oaXN0b3J5L3Jlc291cmNlcy9mb3JtLXdpdGgt b25jbGljay1zdWJtaXQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvaGlzdG9yeS9yZXNvdXJjZXMv Zm9ybS13aXRoLW9uY2xpY2stc3VibWl0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXgg MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOTQ2ZjZmYmU2OGViYmY0 MDAzMTJhYTI0NzEyNjdjNzIwMGIyNjJjMgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvaGlzdG9yeS9yZXNvdXJjZXMvZm9ybS13aXRoLW9uY2xpY2stc3VibWl0Lmh0bWwKQEAg LTAsMCArMSwxMSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorRnJhbWUgMQor Cis8c2NyaXB0PmRvY3VtZW50LndyaXRlKCc8Zm9ybSBuYW1lPSJ0ZXN0Zm9ybSIgbWV0aG9kPSJw b3N0IiBhY3Rpb249InJlZGlyZWN0LXRhcmdldC5odG1sIycgKyAoaGlzdG9yeS5sZW5ndGggKyAx KSArICciPicpOzwvc2NyaXB0PgorCTxpbnB1dCB0eXBlPSJidXR0b24iIGlkPSJzdWJtaXQtYnV0 dG9uIiB2YWx1ZT0iU3VibWl0IiBvbkNsaWNrPSJkb2N1bWVudC5mb3Jtcy50ZXN0Zm9ybS5zdWJt aXQoKTsiPgorPC9mb3JtPgorCis8L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQg b2YgZmlsZQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxv ZwppbmRleCA5ZWE1MjAxNmE1NmFhZTEwYTViMTFjYzM3Zjg2NjhiY2MwODRiYTUxLi5mNDQ3YmQ4 OGJkMjgxMzBlOWQ3NTkwNmI1NThjM2U5MWJhMDdmYzc3IDEwMDY0NAotLS0gYS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEwLTA5 LTI4ICBNaWhhaSBQYXJwYXJpdGEgIDxtaWhhaXBAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIGJhY2svZm9yd2FyZCBsaXN0 IGVudHJ5IGFkZGVkIHdoZW4gc3VibWl0dGluZyBhIGZvcm0gdmlhIGFuIG9uY2xpY2sgaGFuZGxl ciBpbnNpZGUgYSBmcmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDQxNDAKKyAgICAgICAgCisgICAgICAgIExvY2sgdGhlIGJhY2svZm9yd2FyZCBs aXN0IGZvciBKYXZhU2NyaXB0IGZvcm0gc3VibWlzc2lvbnMgaW5zaWRlIGZyYW1lcworICAgICAg ICBvbmx5IGlmIHRoZXkncmUgbm90IGluIHJlc3BvbnNlIHRvIHVzZXIgZ2VzdHVyZXMuCisKKyAg ICAgICAgVGVzdHM6IGZhc3QvaGlzdG9yeS9mb3JtLXN1Ym1pdC1pbi1mcmFtZS12aWEtb25jbGlj ay5odG1sCisgICAgICAgICAgICAgICBmYXN0L2hpc3RvcnkvZm9ybS1zdWJtaXQtaW4tZnJhbWUu aHRtbAorCisgICAgICAgICogbG9hZGVyL1JlZGlyZWN0U2NoZWR1bGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlJlZGlyZWN0U2NoZWR1bGVyOjpzY2hlZHVsZUZvcm1TdWJtaXNzaW9uKToKKwog MjAxMC0wOS0yOCAgQW5kcmVpIFBvcGVzY3UgIDxhbmRyZWlwQGdvb2dsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgSmVyZW15IE9ybG93LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9sb2FkZXIv UmVkaXJlY3RTY2hlZHVsZXIuY3BwIGIvV2ViQ29yZS9sb2FkZXIvUmVkaXJlY3RTY2hlZHVsZXIu Y3BwCmluZGV4IGNlMGUzZjgzZTE2ZjAxNGY2Zjg0MDFmNjI1NDAxMWY4YzE0ZmE2ZWEuLmNlNDFj ZGVjZDgyZDNmY2Y2OGFkNjYxNDM2OTIyYmUyNTZiMDlkODQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv bG9hZGVyL1JlZGlyZWN0U2NoZWR1bGVyLmNwcAorKysgYi9XZWJDb3JlL2xvYWRlci9SZWRpcmVj dFNjaGVkdWxlci5jcHAKQEAgLTMxOCw3ICszMTgsNyBAQCB2b2lkIFJlZGlyZWN0U2NoZWR1bGVy OjpzY2hlZHVsZUZvcm1TdWJtaXNzaW9uKFBhc3NSZWZQdHI8Rm9ybVN1Ym1pc3Npb24+IHN1Ym1p cwogICAgIC8vIHRvIG1hdGNoIElFIGFuZCBPcGVyYS4KICAgICAvLyBTZWUgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyMzgzIGZvciB0aGUgb3JpZ2luYWwgbW90aXZh dGlvbiBmb3IgdGhpcy4KICAgICBib29sIGlzVXNlckdlc3R1cmUgPSBtX2ZyYW1lLT5sb2FkZXIo KS0+aXNQcm9jZXNzaW5nVXNlckdlc3R1cmUoKTsKLSAgICBib29sIGxvY2tCYWNrRm9yd2FyZExp c3QgPSBtdXN0TG9ja0JhY2tGb3J3YXJkTGlzdChtX2ZyYW1lLCBpc1VzZXJHZXN0dXJlKSB8fCAo c3VibWlzc2lvbi0+c3RhdGUoKS0+Zm9ybVN1Ym1pc3Npb25UcmlnZ2VyKCkgPT0gU3VibWl0dGVk QnlKYXZhU2NyaXB0ICYmIG1fZnJhbWUtPnRyZWUoKS0+cGFyZW50KCkpOworICAgIGJvb2wgbG9j a0JhY2tGb3J3YXJkTGlzdCA9IG11c3RMb2NrQmFja0ZvcndhcmRMaXN0KG1fZnJhbWUsIGlzVXNl ckdlc3R1cmUpIHx8IChzdWJtaXNzaW9uLT5zdGF0ZSgpLT5mb3JtU3VibWlzc2lvblRyaWdnZXIo KSA9PSBTdWJtaXR0ZWRCeUphdmFTY3JpcHQgJiYgbV9mcmFtZS0+dHJlZSgpLT5wYXJlbnQoKSAm JiAhaXNVc2VyR2VzdHVyZSk7CiAKICAgICBzY2hlZHVsZShhZG9wdFB0cihuZXcgU2NoZWR1bGVk Rm9ybVN1Ym1pc3Npb24oc3VibWlzc2lvbiwgbG9ja0JhY2tGb3J3YXJkTGlzdCwgZHVyaW5nTG9h ZCwgaXNVc2VyR2VzdHVyZSkpKTsKIH0K