44130 2010-08-17 14:06:36 -0700 Allow non-Skia ports to compile with ENABLE(ACCELERATED_2D_CANVAS). 2010-08-17 16:00:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco fishd jamesr oldest_to_newest 265759 0 senorblanco 2010-08-17 14:06:36 -0700 Allow non-Skia ports to compile with ENABLE(ACCELERATED_2D_CANVAS). 265760 1 64629 senorblanco 2010-08-17 14:07:58 -0700 Created attachment 64629 Patch 265764 2 jamesr 2010-08-17 14:15:35 -0700 Seems OK. 265800 3 64629 levin 2010-08-17 15:25:56 -0700 Comment on attachment 64629 Patch > Index: WebCore/ChangeLog > =================================================================== > --- WebCore/ChangeLog (revision 65540) > +++ WebCore/ChangeLog (working copy) > @@ -1,3 +1,23 @@ > +2010-08-17 Stephen White <senorblanco@chromium.org> > + > + Reviewed by NOBODY (OOPS!). > + > + Allow non-Skia ports to compile with ENABLE(ACCELERATED_2D_CANVAS). > + > + No tests; if it compiles, it's good. > + > + * html/canvas/CanvasRenderingContext2D.cpp: > + (WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D): > + Fix a warning (treated as error). Fixed the warning that rootView wasn't used. (It took me a minute to figure out what you were fixing.) 265815 4 senorblanco 2010-08-17 16:00:44 -0700 Committed r65569: <http://trac.webkit.org/changeset/65569> 64629 2010-08-17 14:07:58 -0700 2010-08-17 15:25:55 -0700 Patch bug-44130-20100817170756.patch text/plain 2893 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2NTU0MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMTAtMDgtMTcgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWxsb3cgbm9uLVNraWEgcG9ydHMgdG8gY29tcGlsZSB3aXRoIEVOQUJMRShBQ0NFTEVS QVRFRF8yRF9DQU5WQVMpLgorCisgICAgICAgIE5vIHRlc3RzOyBpZiBpdCBjb21waWxlcywgaXQn cyBnb29kLgorCisgICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJE LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6Q2FudmFz UmVuZGVyaW5nQ29udGV4dDJEKToKKyAgICAgICAgRml4IGEgd2FybmluZyAodHJlYXRlZCBhcyBl cnJvcikuCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6c2V0R3JhcGhpY3NDb250ZXh0M0Qp OgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjpzeW5jU29mdHdhcmVDYW52YXMp OgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5oOgorICAgICAg ICBNYWtlIHNldEdyYXBoaWNzQ29udGV4dDNEKCkgYW5kIHN5bmNTb2Z0d2FyZUNhbnZhcygpIHN0 dWJiZWQgb3V0LAorICAgICAgICBidXQgc3RpbGwgcHJlc2VudCBpbiBub24tU2tpYSBwb3J0cy4g IFRoaXMgYWxsb3dzIENocm9tZSBNYWMgdG8KKyAgICAgICAgY29tcGlsZSB3aXRoIEVOQUJMRShB Q0NFTEVSQVRFRF8yRF9DQU5WQVMpIChhbHRob3VnaCBpdCBpc24ndCBob29rZWQKKyAgICAgICAg dXAgeWV0LCBpdCBzaG91bGQgYXQgbGVhc3QgY29tcGlsZSkuCisKIDIwMTAtMDgtMTcgIEZhZHkg U2FtdWVsICA8ZnNhbXVlbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2 aWQgSHlhdHQuCkluZGV4OiBXZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRl eHQyRC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJp bmdDb250ZXh0MkQuY3BwCShyZXZpc2lvbiA2NTU0MCkKKysrIFdlYkNvcmUvaHRtbC9jYW52YXMv Q2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTI2LDcgKzEy Niw3IEBAIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6Q2FudmFzUmVuZGVyaW4KICAgICAgICAg cmV0dXJuOwogICAgIGlmIChGcmFtZVZpZXcqIHZpZXcgPSBjYW52YXMtPmRvY3VtZW50KCktPnZp ZXcoKSkgewogICAgICAgICBpZiAoU2Nyb2xsVmlldyogcm9vdFZpZXcgPSB2aWV3LT5yb290KCkp IHsKLSAgICAgICAgICAgIGlmIChIb3N0V2luZG93KiBob3N0V2luZG93ID0gdmlldy0+cm9vdCgp LT5ob3N0V2luZG93KCkpIHsKKyAgICAgICAgICAgIGlmIChIb3N0V2luZG93KiBob3N0V2luZG93 ID0gcm9vdFZpZXctPmhvc3RXaW5kb3coKSkgewogICAgICAgICAgICAgICAgIC8vIFNldCB1cCBv dXIgY29udGV4dAogICAgICAgICAgICAgICAgIEdyYXBoaWNzQ29udGV4dDNEOjpBdHRyaWJ1dGVz IGF0dHI7CiAgICAgICAgICAgICAgICAgYXR0ci5zdGVuY2lsID0gdHJ1ZTsKSW5kZXg6IFdlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dC5jcHAJKHJldmlzaW9uIDY1 NTQwKQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC02MDAsNCArNjAwLDE0IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0Ojph ZGp1c3RMaW5lVG9QaXhlbEIKICAgICB9CiB9CiAKKyNpZiAhUExBVEZPUk0oU0tJQSkKK3ZvaWQg R3JhcGhpY3NDb250ZXh0OjpzZXRHcmFwaGljc0NvbnRleHQzRChHcmFwaGljc0NvbnRleHQzRCos IGNvbnN0IEludFNpemUmKQoreworfQorCit2b2lkIEdyYXBoaWNzQ29udGV4dDo6c3luY1NvZnR3 YXJlQ2FudmFzKCkKK3sKK30KKyNlbmRpZgorCiB9CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL0dyYXBoaWNzQ29udGV4dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0LmgJKHJldmlzaW9uIDY1NTQwKQorKysgV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQuaAkod29ya2luZyBjb3B5KQpAQCAtNDA4 LDEwICs0MDgsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHBhdHRlcm4gZ2V0SGFp a3VTdHJva2VTdHlsZSgpOwogI2VuZGlmCiAKLSNpZiBQTEFURk9STShTS0lBKQogICAgICAgICB2 b2lkIHNldEdyYXBoaWNzQ29udGV4dDNEKEdyYXBoaWNzQ29udGV4dDNEKiwgY29uc3QgSW50U2l6 ZSYpOwogICAgICAgICB2b2lkIHN5bmNTb2Z0d2FyZUNhbnZhcygpOwotI2VuZGlmCiAKICAgICBw cml2YXRlOgogICAgICAgICB2b2lkIHNhdmVQbGF0Zm9ybVN0YXRlKCk7Cg==