44112 2010-08-17 08:56:02 -0700 Web Inspector: activate/deactivate breakpoints using v8 debugger flag 2010-08-19 08:45:13 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 podivilov webkit-unassigned commit-queue yurys oldest_to_newest 265571 0 podivilov 2010-08-17 08:56:02 -0700 Web Inspector: activate/deactivate breakpoints using v8 debugger flag 265574 1 64597 podivilov 2010-08-17 08:58:01 -0700 Created attachment 64597 Proposed patch. 265953 2 64597 yurys 2010-08-17 22:42:07 -0700 Comment on attachment 64597 Proposed patch. WebKit/chromium/src/js/DebuggerScript.js:200 + Debug.debuggerFlags().breakPointsActive.setValue(args.enabled); Breakpoints are always activated in the frontend when it's just launched. With this code we may deactivate breakpoints, then close frontend, reopen frontend and get an inconsistent state of the flag in the debugger script and frontend. Please fix this. 266764 3 64597 commit-queue 2010-08-19 08:45:08 -0700 Comment on attachment 64597 Proposed patch. Clearing flags on attachment: 64597 Committed r65674: <http://trac.webkit.org/changeset/65674> 266765 4 commit-queue 2010-08-19 08:45:13 -0700 All reviewed patches have been landed. Closing bug. 64597 2010-08-17 08:58:01 -0700 2010-08-19 08:45:08 -0700 Proposed patch. reactivation.patch text/plain 2104 podivilov ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDgwNzIyNWQuLjNkNzdmMjggMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDEzIEBACisyMDEwLTA4LTE3ICBQYXZlbCBQb2Rpdmlsb3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdl YiBJbnNwZWN0b3I6IGFjdGl2YXRlL2RlYWN0aXZhdGUgYnJlYWtwb2ludHMgdXNpbmcgdjggZGVi dWdnZXIgZmxhZy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQ0MTEyCisKKyAgICAgICAgKiBzcmMvanMvRGVidWdnZXJTY3JpcHQuanM6CisgICAgICAg ICgpOgorCiAyMDEwLTA4LTE2ICBLaW51a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9yZz4K IAogICAgICAgICBVbnJldmlld2VkOyBhdHRlbXB0IHRvIGZpeCBDaHJvbWl1bSBXaW5kb3dzIGJ1 aWxkLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9EZWJ1Z2dlclNjcmlwdC5q cyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvanMvRGVidWdnZXJTY3JpcHQuanMKaW5kZXggNTE3ODdm Ni4uNWE4YTdiZiAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9qcy9EZWJ1Z2dlclNj cmlwdC5qcworKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL2pzL0RlYnVnZ2VyU2NyaXB0LmpzCkBA IC0zMiw3ICszMiw2IEBACiAKIHZhciBEZWJ1Z2dlclNjcmlwdCA9IHt9OwogRGVidWdnZXJTY3Jp cHQuX2JyZWFrcG9pbnRzID0ge307Ci1EZWJ1Z2dlclNjcmlwdC5fYnJlYWtwb2ludHNBY3RpdmF0 ZWQgPSB0cnVlOwogCiBEZWJ1Z2dlclNjcmlwdC5QYXVzZU9uRXhjZXB0aW9uc1N0YXRlID0gewog ICAgIERvbnRQYXVzZU9uRXhjZXB0aW9ucyA6IDAsCkBAIC05NSw3ICs5NCw3IEBAIERlYnVnZ2Vy U2NyaXB0LnNldEJyZWFrcG9pbnQgPSBmdW5jdGlvbihleGVjU3RhdGUsIGFyZ3MpCiB7CiAgICAg YXJncy5saW5lTnVtYmVyID0gRGVidWdnZXJTY3JpcHQuX3dlYmtpdFRvVjhMaW5lTnVtYmVyKGFy Z3MubGluZU51bWJlcik7CiAgICAgdmFyIGJyZWFrSWQgPSBEZWJ1Zy5zZXRTY3JpcHRCcmVha1Bv aW50QnlJZChhcmdzLnNjcmlwdElkLCBhcmdzLmxpbmVOdW1iZXIsIDAgLyogY29sdW1uICovLCBh cmdzLmNvbmRpdGlvbik7Ci0gICAgaWYgKCFhcmdzLmVuYWJsZWQgfHwgIURlYnVnZ2VyU2NyaXB0 Ll9icmVha3BvaW50c0FjdGl2YXRlZCkKKyAgICBpZiAoIWFyZ3MuZW5hYmxlZCkKICAgICAgICAg RGVidWcuZGlzYWJsZVNjcmlwdEJyZWFrUG9pbnQoYnJlYWtJZCk7CiAKICAgICB2YXIgbG9jYXRp b25zID0gRGVidWcuZmluZEJyZWFrUG9pbnRBY3R1YWxMb2NhdGlvbnMoYnJlYWtJZCk7CkBAIC0x OTgsMTQgKzE5Nyw3IEBAIERlYnVnZ2VyU2NyaXB0LmNsZWFyQnJlYWtwb2ludHMgPSBmdW5jdGlv bihleGVjU3RhdGUsIGFyZ3MpCiAKIERlYnVnZ2VyU2NyaXB0LnNldEJyZWFrcG9pbnRzQWN0aXZh dGVkID0gZnVuY3Rpb24oZXhlY1N0YXRlLCBhcmdzKQogewotICAgIGZvciAodmFyIGtleSBpbiBE ZWJ1Z2dlclNjcmlwdC5fYnJlYWtwb2ludHMpIHsKLSAgICAgICAgdmFyIGJyZWFrSWQgPSBEZWJ1 Z2dlclNjcmlwdC5fYnJlYWtwb2ludHNba2V5XTsKLSAgICAgICAgaWYgKGFyZ3MuZW5hYmxlZCkK LSAgICAgICAgICAgIERlYnVnLmVuYWJsZVNjcmlwdEJyZWFrUG9pbnQoYnJlYWtJZCk7Ci0gICAg ICAgIGVsc2UKLSAgICAgICAgICAgIERlYnVnLmRpc2FibGVTY3JpcHRCcmVha1BvaW50KGJyZWFr SWQpOwotICAgIH0KLSAgICBEZWJ1Z2dlclNjcmlwdC5fYnJlYWtwb2ludHNBY3RpdmF0ZWQgPSBh cmdzLmVuYWJsZWQ7CisgICAgRGVidWcuZGVidWdnZXJGbGFncygpLmJyZWFrUG9pbnRzQWN0aXZl LnNldFZhbHVlKGFyZ3MuZW5hYmxlZCk7CiB9CiAKIERlYnVnZ2VyU2NyaXB0Ll9mcmFtZU1pcnJv clRvSlNDYWxsRnJhbWUgPSBmdW5jdGlvbihmcmFtZU1pcnJvciwgY2FsbGVyRnJhbWUpCg==