44095 2010-08-17 02:32:58 -0700 [GTK] Fix wrapping of core Events in the bindings 2010-08-17 05:25:37 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned oldest_to_newest 265443 0 xan.lopez 2010-08-17 02:32:58 -0700 We were mistakenly wrapping any Event or subclass as a WebKitDOMEvent, but we need to return the proper GObject type whenever appropriate (ie, a WebKitDOMMouseEvent for MouseEvent). 265444 1 64567 xan.lopez 2010-08-17 02:35:10 -0700 Created attachment 64567 wrapevents.diff Patch. 265478 2 64567 gustavo 2010-08-17 05:16:35 -0700 Comment on attachment 64567 wrapevents.diff OK! 265479 3 64567 xan.lopez 2010-08-17 05:25:20 -0700 Comment on attachment 64567 wrapevents.diff Landed in r65497. 265480 4 xan.lopez 2010-08-17 05:25:37 -0700 Closing bug. 64567 2010-08-17 02:35:10 -0700 2010-08-17 05:25:20 -0700 wrapevents.diff wrapevents.diff text/plain 3275 xan.lopez RnJvbSBiMTM2MWM3OGI4MmNjMjVhYTNjNzE4M2QwNmI5Y2RmNGFhMmZlNTc5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhsb3BlekBpZ2FsaWEuY29tPgpEYXRlOiBU dWUsIDE3IEF1ZyAyMDEwIDE3OjM0OjEyICswODAwClN1YmplY3Q6IFtQQVRDSF0gMjAxMC0wOC0x NyAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CgogICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgoKICAgICAgICBbR1RLXSBGaXggd3JhcHBpbmcgb2YgY29yZSBFdmVudHMg aW4gdGhlIGJpbmRpbmdzCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQ0MDk1CgogICAgICAgIFJldHVybiB0aGUgcHJvcGVyIEdPYmplY3QgdHlwZSBpbnN0 ZWFkIG9mIGhhcmRjb2RpbmcKICAgICAgICBXZWJLaXRET01FdmVudCBmb3IgYWxsIEV2ZW50IHR5 cGVzLgoKICAgICAgICAqIGJpbmRpbmdzL2dvYmplY3QvR09iamVjdEV2ZW50TGlzdGVuZXIuY3Bw OgogICAgICAgIChXZWJDb3JlOjpHT2JqZWN0RXZlbnRMaXN0ZW5lcjo6aGFuZGxlRXZlbnQpOgog ICAgICAgICogYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01CaW5kaW5nLmNwcDoKICAgICAgICAo V2ViS2l0OjpraXQpOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgfCAgIDE1ICsrKysrKysrKysrKysrKwogV2ViQ29yZS9iaW5kaW5ncy9nb2Jq ZWN0L0dPYmplY3RFdmVudExpc3RlbmVyLmNwcCB8ICAgIDMgKystCiBXZWJDb3JlL2JpbmRpbmdz L2dvYmplY3QvV2ViS2l0RE9NQmluZGluZy5jcHAgICAgIHwgICAgMyArKy0KIDMgZmlsZXMgY2hh bmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJD b3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGVmOGE5MWIuLjBjODEwN2Yg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDgtMTcgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtd IEZpeCB3cmFwcGluZyBvZiBjb3JlIEV2ZW50cyBpbiB0aGUgYmluZGluZ3MKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0MDk1CisKKyAgICAgICAgUmV0 dXJuIHRoZSBwcm9wZXIgR09iamVjdCB0eXBlIGluc3RlYWQgb2YgaGFyZGNvZGluZworICAgICAg ICBXZWJLaXRET01FdmVudCBmb3IgYWxsIEV2ZW50IHR5cGVzLgorCisgICAgICAgICogYmluZGlu Z3MvZ29iamVjdC9HT2JqZWN0RXZlbnRMaXN0ZW5lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpH T2JqZWN0RXZlbnRMaXN0ZW5lcjo6aGFuZGxlRXZlbnQpOgorICAgICAgICAqIGJpbmRpbmdzL2dv YmplY3QvV2ViS2l0RE9NQmluZGluZy5jcHA6CisgICAgICAgIChXZWJLaXQ6OmtpdCk6CisKIDIw MTAtMDgtMTcgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmlu ZGluZ3MvZ29iamVjdC9HT2JqZWN0RXZlbnRMaXN0ZW5lci5jcHAgYi9XZWJDb3JlL2JpbmRpbmdz L2dvYmplY3QvR09iamVjdEV2ZW50TGlzdGVuZXIuY3BwCmluZGV4IDFhNGY2ODAuLjNjZTg0NjEg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9HT2JqZWN0RXZlbnRMaXN0ZW5l ci5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy9nb2JqZWN0L0dPYmplY3RFdmVudExpc3RlbmVy LmNwcApAQCAtMjEsNiArMjEsNyBAQAogCiAjaW5jbHVkZSAiRXZlbnQuaCIKICNpbmNsdWRlICJF dmVudExpc3RlbmVyLmgiCisjaW5jbHVkZSAid2Via2l0L1dlYktpdERPTUV2ZW50LmgiCiAjaW5j bHVkZSAid2Via2l0L1dlYktpdERPTUV2ZW50UHJpdmF0ZS5oIgogI2luY2x1ZGUgPHd0Zi9IYXNo TWFwLmg+CiAjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgpAQCAtMzAsNyArMzEsNyBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiB2b2lkIEdPYmplY3RFdmVudExpc3RlbmVyOjpoYW5kbGVFdmVu dChTY3JpcHRFeGVjdXRpb25Db250ZXh0KiwgRXZlbnQqIGV2ZW50KQogewogICAgIGdib29sZWFu IGhhbmRsZWQgPSBGQUxTRTsKLSAgICBXZWJLaXRET01FdmVudCogZ29iamVjdEV2ZW50ID0gV2Vi S2l0Ojp3cmFwRXZlbnQoZXZlbnQpOworICAgIFdlYktpdERPTUV2ZW50KiBnb2JqZWN0RXZlbnQg PSBXRUJLSVRfRE9NX0VWRU5UKFdlYktpdDo6a2l0KGV2ZW50KSk7CiAgICAgZ19zaWduYWxfZW1p dF9ieV9uYW1lKG1fb2JqZWN0LCBtX3NpZ25hbE5hbWUudXRmOCgpLmRhdGEoKSwgZ29iamVjdEV2 ZW50LCAmaGFuZGxlZCk7CiB9CiAKZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvZ29iamVj dC9XZWJLaXRET01CaW5kaW5nLmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRE T01CaW5kaW5nLmNwcAppbmRleCAxMTU0ZDZjLi4zYzA2NmUzIDEwMDY0NAotLS0gYS9XZWJDb3Jl L2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RE9NQmluZGluZy5jcHAKKysrIGIvV2ViQ29yZS9iaW5k aW5ncy9nb2JqZWN0L1dlYktpdERPTUJpbmRpbmcuY3BwCkBAIC0zMiw2ICszMiw3IEBACiAjaW5j bHVkZSAiVUlFdmVudC5oIgogI2luY2x1ZGUgIldlYktpdERPTURPTVdpbmRvd1ByaXZhdGUuaCIK ICNpbmNsdWRlICJXZWJLaXRET01FbGVtZW50UHJpdmF0ZS5oIgorI2luY2x1ZGUgIldlYktpdERP TUV2ZW50UHJpdmF0ZS5oIgogI2luY2x1ZGUgIldlYktpdERPTU5vZGUuaCIKICNpbmNsdWRlICJX ZWJLaXRET01Ob2RlUHJpdmF0ZS5oIgogI2luY2x1ZGUgIldlYktpdEhUTUxFbGVtZW50V3JhcHBl ckZhY3RvcnkuaCIKQEAgLTE0MCw3ICsxNDEsNyBAQCBncG9pbnRlciBraXQoRXZlbnQqIGV2ZW50 KQogICAgIGVsc2UgaWYgKGV2ZW50LT5pc1VJRXZlbnQoKSkKICAgICAgICAgd3JhcHBlZEV2ZW50 ID0gd3JhcFVJRXZlbnQoc3RhdGljX2Nhc3Q8VUlFdmVudCo+KGV2ZW50KSk7CiAgICAgZWxzZQot ICAgICAgICB3cmFwcGVkRXZlbnQgPSAwOworICAgICAgICB3cmFwcGVkRXZlbnQgPSB3cmFwRXZl bnQoZXZlbnQpOwogCiAgICAgcmV0dXJuIERPTU9iamVjdENhY2hlOjpwdXQoZXZlbnQsIHdyYXBw ZWRFdmVudCk7CiB9Ci0tIAoxLjcuMi4xCgo=