44094 2010-08-17 01:11:04 -0700 [Qt] Short lived shadow buffer for blur operation 2010-08-18 23:39:39 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED HTML5, Qt, QtTriaged P2 Normal --- 34479 1 ariya.hidayat ariya.hidayat abarth eric kling krit webkit.review.bot oldest_to_newest 265411 0 ariya.hidayat 2010-08-17 01:11:04 -0700 Everytime we need blur shadow, we create and destroy QImage for the scratch buffer. Technically we do not need to do this, we can keep a persistent buffer which has a limited life time so that successive blur will just reuse the same buffer. 266435 1 64784 ariya.hidayat 2010-08-18 16:08:09 -0700 Created attachment 64784 Patch 266442 2 64784 kling 2010-08-18 16:20:10 -0700 Comment on attachment 64784 Patch (Informal) LGTM :) 266552 3 64784 kenneth 2010-08-18 22:45:27 -0700 Comment on attachment 64784 Patch Making it formal :-) r=me WebCore/ChangeLog:10 + we create a buffer which will be automatically purged via a timer. Maybe this description would be nice to have in the class? 266564 4 ariya.hidayat 2010-08-18 23:21:56 -0700 Committed r65654: <http://trac.webkit.org/changeset/65654> 266568 5 webkit.review.bot 2010-08-18 23:39:39 -0700 http://trac.webkit.org/changeset/65654 might have broken SnowLeopard Intel Release (Tests) 64784 2010-08-18 16:08:09 -0700 2010-08-18 22:45:27 -0700 Patch bug-44094-20100818160645.patch text/plain 4203 ariya.hidayat ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDUwMTVkZTYwOTFjMDYxMWE1YjIzYzZmNjhkMjhkOTFiYzNlZjAyNi4uZjlhZmNkNDg4NjlhNjcx MDBjMTM5OTdiMDVlMGFkN2RhODMyZmM0YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0wOC0xOCAgQXJp eWEgSGlkYXlhdCAgPGFyaXlhQHNlbmNoYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBTaG9ydCBsaXZlZCBzaGFkb3cgYnVmZmVyIGZv ciBibHVyIG9wZXJhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDQwOTQKKworICAgICAgICBDb250ZXh0U2hhZG93IG5lZWRzIGEgc2NyYXRjaCBp bWFnZSBhcyB0aGUgYnVmZmVyIGZvciB0aGUgYmx1ciBmaWx0ZXIuCisgICAgICAgIEluc3RlYWQg b2YgY3JlYXRpbmcgYW5kIGRlc3Ryb3lpbmcgdGhlIGJ1ZmZlciBmb3IgZXZlcnkgb3BlcmF0aW9u LAorICAgICAgICB3ZSBjcmVhdGUgYSBidWZmZXIgd2hpY2ggd2lsbCBiZSBhdXRvbWF0aWNhbGx5 IHB1cmdlZCB2aWEgYSB0aW1lci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3F0L0Nv bnRleHRTaGFkb3cuY3BwOgorICAgICAgICAoV2ViQ29yZTo6KToKKyAgICAgICAgKFdlYkNvcmU6 OlNoYWRvd0J1ZmZlcjo6U2hhZG93QnVmZmVyKToKKyAgICAgICAgKFdlYkNvcmU6OlNoYWRvd0J1 ZmZlcjo6c2NyYXRjaEltYWdlKToKKyAgICAgICAgKFdlYkNvcmU6OlNoYWRvd0J1ZmZlcjo6c2No ZWR1bGVQdXJnZSk6CisgICAgICAgIChXZWJDb3JlOjpTaGFkb3dCdWZmZXI6OnB1cmdlQnVmZmVy KToKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRleHRTaGFkb3c6OmRyYXdTaGFkb3dSZWN0KToKKwog MjAxMC0wOC0xOCAgU2hpbmljaGlybyBIYW1hamkgIDxoYW1hamlAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvcXQvQ29udGV4dFNoYWRvdy5jcHAgYi9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL3F0L0NvbnRleHRTaGFkb3cuY3BwCmluZGV4IDA1MTEyMTgyMDg4ODc4NTcwYTAx MTMzMDFmODdhNTIzOWNiY2I4OGEuLmIyNTU1Y2M5OWExYTUzZjE4YWE4MDhmODkyZjZjNGIyM2Nh MjI2MTUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvQ29udGV4dFNo YWRvdy5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9Db250ZXh0U2hhZG93 LmNwcApAQCAtMjgsOCArMjgsNjggQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJD b250ZXh0U2hhZG93LmgiCiAKKyNpbmNsdWRlICJUaW1lci5oIgorI2luY2x1ZGUgPHd0Zi9Ob25j b3B5YWJsZS5oPgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK2NsYXNzIFNoYWRvd0J1ZmZlcjog cHVibGljIE5vbmNvcHlhYmxlIHsKK3B1YmxpYzoKKyAgICBTaGFkb3dCdWZmZXIoKTsKKworICAg IFFJbWFnZSogc2NyYXRjaEltYWdlKGNvbnN0IFFTaXplJiBzaXplKTsKKworICAgIHZvaWQgc2No ZWR1bGVQdXJnZSgpOworCitwcml2YXRlOgorICAgIFFJbWFnZSBpbWFnZTsKKyAgICB2b2lkIHB1 cmdlQnVmZmVyKFRpbWVyPFNoYWRvd0J1ZmZlcj4qKTsKKyAgICBUaW1lcjxTaGFkb3dCdWZmZXI+ IHB1cmdlVGltZXI7Cit9OworCitTaGFkb3dCdWZmZXI6OlNoYWRvd0J1ZmZlcigpCisgICAgOiBw dXJnZVRpbWVyKHRoaXMsICZTaGFkb3dCdWZmZXI6OnB1cmdlQnVmZmVyKQoreworfQorCitRSW1h Z2UqIFNoYWRvd0J1ZmZlcjo6c2NyYXRjaEltYWdlKGNvbnN0IFFTaXplJiBzaXplKQoreworICAg IGludCB3aWR0aCA9IHNpemUud2lkdGgoKTsKKyAgICBpbnQgaGVpZ2h0ID0gc2l6ZS5oZWlnaHQo KTsKKworICAgIC8vIFdlIGRvIG5vdCBuZWVkIHRvIHJlY3JlYXRlIHRoZSBidWZmZXIgaWYgdGhl IGJ1ZmZlciBpcyByZWFzb25hYmx5CisgICAgLy8gbGFyZ2VyIHRoYW4gdGhlIHJlcXVlc3RlZCBz aXplLiBIb3dldmVyLCBpZiB0aGUgcmVxdWVzdGVkIHNpemUgaXMKKyAgICAvLyBtdWNoIHNtYWxs ZXIgdGhhbiBvdXIgYnVmZmVyLCByZWR1Y2Ugb3VyIGJ1ZmZlciBzbyB0aGF0IHdlIHdpbGwgbm90 CisgICAgLy8ga2VlcCB0b28gbWFueSBhbGxvY2F0ZWQgcGl4ZWxzIGZvciB0b28gbG9uZy4KKyAg ICBpZiAoIWltYWdlLmlzTnVsbCgpICYmIChpbWFnZS53aWR0aCgpID4gd2lkdGgpICYmIChpbWFn ZS5oZWlnaHQoKSA+IGhlaWdodCkpCisgICAgICAgIGlmICgoKDIgKiB3aWR0aCkgPiBpbWFnZS53 aWR0aCgpKSAmJiAoKDIgKiBoZWlnaHQpID4gaW1hZ2UuaGVpZ2h0KCkpKSB7CisgICAgICAgICAg ICBpbWFnZS5maWxsKFF0Ojp0cmFuc3BhcmVudCk7CisgICAgICAgICAgICByZXR1cm4gJmltYWdl OworICAgICAgICB9CisKKyAgICAvLyBSb3VuZCB0byB0aGUgbmVhcmVzdCAzMiBwaXhlbHMgc28g d2UgZG8gbm90IGdyb3cgdGhlIGJ1ZmZlciBldmVyeXRpbWUKKyAgICAvLyB0aGVyZSBpcyBsYXJn ZXIgcmVxdWVzdCBieSAxIHBpeGVsLgorICAgIHdpZHRoID0gKDEgKyAod2lkdGggPj4gNSkpIDw8 IDU7CisgICAgaGVpZ2h0ID0gKDEgKyAoaGVpZ2h0ID4+IDUpKSA8PCA1OworCisgICAgaW1hZ2Ug PSBRSW1hZ2Uod2lkdGgsIGhlaWdodCwgUUltYWdlOjpGb3JtYXRfQVJHQjMyX1ByZW11bHRpcGxp ZWQpOworICAgIGltYWdlLmZpbGwoUXQ6OnRyYW5zcGFyZW50KTsKKyAgICByZXR1cm4gJmltYWdl OworfQorCit2b2lkIFNoYWRvd0J1ZmZlcjo6c2NoZWR1bGVQdXJnZSgpCit7CisgICAgc3RhdGlj IGNvbnN0IGRvdWJsZSBCdWZmZXJQdXJnZURlbGF5ID0gMjsgLy8gc2Vjb25kcworICAgIHB1cmdl VGltZXIuc3RhcnRPbmVTaG90KEJ1ZmZlclB1cmdlRGVsYXkpOworfQorCit2b2lkIFNoYWRvd0J1 ZmZlcjo6cHVyZ2VCdWZmZXIoVGltZXI8U2hhZG93QnVmZmVyPiopCit7CisgICAgaW1hZ2UgPSBR SW1hZ2UoKTsKK30KKworUV9HTE9CQUxfU1RBVElDKFNoYWRvd0J1ZmZlciwgc2NyYXRjaFNoYWRv d0J1ZmZlcikKKwogQ29udGV4dFNoYWRvdzo6Q29udGV4dFNoYWRvdygpCiAgICAgOiB0eXBlKE5v U2hhZG93KQogICAgICwgYmx1clJhZGl1cygwKQpAQCAtMjM1LDE2ICsyOTUsMTggQEAgdm9pZCBD b250ZXh0U2hhZG93OjpkcmF3U2hhZG93UmVjdChRUGFpbnRlciogcCwgY29uc3QgUVJlY3RGJiBy ZWN0KQogICAgICAgICAgICAgYWxpZ25lZEJ1ZmZlclJlY3QuYWRqdXN0KC1leHRyYSwgLWV4dHJh LCBleHRyYSwgZXh0cmEpOwogICAgICAgICB9CiAKLSAgICAgICAgUUltYWdlIHNoYWRvd0ltYWdl KGFsaWduZWRCdWZmZXJSZWN0LnNpemUoKSwgUUltYWdlOjpGb3JtYXRfQVJHQjMyX1ByZW11bHRp cGxpZWQpOwotICAgICAgICBzaGFkb3dJbWFnZS5maWxsKFF0Ojp0cmFuc3BhcmVudCk7Ci0gICAg ICAgIFFQYWludGVyIHNoYWRvd1BhaW50ZXIoJnNoYWRvd0ltYWdlKTsKKyAgICAgICAgU2hhZG93 QnVmZmVyKiBzaGFkb3dCdWZmZXIgPSBzY3JhdGNoU2hhZG93QnVmZmVyKCk7CisgICAgICAgIFFJ bWFnZSogc2hhZG93SW1hZ2UgPSBzaGFkb3dCdWZmZXItPnNjcmF0Y2hJbWFnZShhbGlnbmVkQnVm ZmVyUmVjdC5zaXplKCkpOworICAgICAgICBRUGFpbnRlciBzaGFkb3dQYWludGVyKHNoYWRvd0lt YWdlKTsKIAogICAgICAgICBzaGFkb3dQYWludGVyLmZpbGxSZWN0KHNoYWRvd1JlY3QudHJhbnNs YXRlZCgtYWxpZ25lZEJ1ZmZlclJlY3QudG9wTGVmdCgpKSwgY29sb3IpOwogICAgICAgICBzaGFk b3dQYWludGVyLmVuZCgpOwogCi0gICAgICAgIHNoYWRvd0JsdXIoc2hhZG93SW1hZ2UsIGJsdXJS YWRpdXMsIGNvbG9yKTsKKyAgICAgICAgc2hhZG93Qmx1cigqc2hhZG93SW1hZ2UsIGJsdXJSYWRp dXMsIGNvbG9yKTsKKworICAgICAgICBwLT5kcmF3SW1hZ2UoYWxpZ25lZEJ1ZmZlclJlY3QudG9w TGVmdCgpLCAqc2hhZG93SW1hZ2UpOwogCi0gICAgICAgIHAtPmRyYXdJbWFnZShhbGlnbmVkQnVm ZmVyUmVjdC50b3BMZWZ0KCksIHNoYWRvd0ltYWdlKTsKKyAgICAgICAgc2hhZG93QnVmZmVyLT5z Y2hlZHVsZVB1cmdlKCk7CiAKICAgICAgICAgcmV0dXJuOwogICAgIH0K