44079 2010-08-16 15:44:27 -0700 [Chromium] fast/events/popup-allowed-from-gesture-initiated-form-submit.html causing debug ASSERT 2011-04-15 18:22:19 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 japhet webkit-unassigned abarth commit-queue creis eric fishd mihaip webkit.review.bot oldest_to_newest 265270 0 japhet 2010-08-16 15:44:27 -0700 ASSERTION FAILED: m_expectedClientRedirectDest.protocolIs("javascript") || m_expectedClientRedirectDest == url (third_party/WebKit/WebKit/chromium/src/FrameLoaderClientImpl.cpp:701 virtual void WebKit::FrameLoaderClientImpl::dispatchDidStartProvisionalLoad()) This test is causing the test that runs immediately after it to hit the above ASSERT. I suspect r65381, but I'm not yet certain. 386366 1 creis 2011-04-14 21:55:51 -0700 I ran into this ASSERT in another context, which I think sheds some light on it. FrameLoaderClientImpl keeps track of whether a redirect is in progress using m_expectedClientRedirect{Src,Dest}. If so, this ASSERT is making sure the url of the next navigation matches the expectation. However, there's at least two cases where this isn't true. In my case, a navigation can be aborted if the embedder returns PolicyIgnore. That doesn't clean up this m_expectedClientRedirectSrc field, so we fail the ASSERT. In the case of this layout test, the form submission targets "_blank", causing it to open in a new window. However, at the time of FrameLoader::submitForm, the new frame doesn't exist yet. FrameLoader instead calls scheduleFormSubmission on the current frame, even though the navigation won't occur there. As a result, we end up expecting the redirect in the wrong frame. Any future navigations in the form's frame will fail the ASSERT. There may be more cases where a redirect doesn't get canceled through the expected approach, so I'm inclined to think the ASSERT is broken. I've put together a patch that changes it into an "if" instead of an assertion, which should make sure we do the right thing in these corner cases. 386367 2 89734 creis 2011-04-14 21:58:30 -0700 Created attachment 89734 Patch 386768 3 89734 creis 2011-04-15 11:25:51 -0700 Comment on attachment 89734 Patch Layout tests seem to be happy with this change, including the one that had been disabled. 386939 4 89734 fishd 2011-04-15 14:32:04 -0700 Comment on attachment 89734 Patch OK 387046 5 89734 commit-queue 2011-04-15 17:01:35 -0700 Comment on attachment 89734 Patch Clearing flags on attachment: 89734 Committed r84055: <http://trac.webkit.org/changeset/84055> 387047 6 commit-queue 2011-04-15 17:01:40 -0700 All reviewed patches have been landed. Closing bug. 387135 7 webkit.review.bot 2011-04-15 18:22:19 -0700 http://trac.webkit.org/changeset/84055 might have broken WinCairo Debug (Build) 89734 2011-04-14 21:58:30 -0700 2011-04-15 17:01:35 -0700 Patch bug-44079-20110414215828.patch text/plain 3624 creis SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA4MzQ2MikKKysrIFNvdXJj ZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTEtMDQtMTQgIENoYXJsaWUgUmVpcyAgPGNyZWlzQGNocm9taXVtLm9yZz4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ2hyb21pdW1dIGZh c3QvZXZlbnRzL3BvcHVwLWFsbG93ZWQtZnJvbS1nZXN0dXJlLWluaXRpYXRlZC1mb3JtLXN1Ym1p dC5odG1sIGNhdXNpbmcgZGVidWcgQVNTRVJUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00NDA3OQorCisgICAgICAgIFJlbW92ZSBhbiBhc3NlcnQgd2hv c2UgaW52YXJpYW50IGRvZXNuJ3QgaG9sZC4KKworICAgICAgICAqIHNyYy9GcmFtZUxvYWRlckNs aWVudEltcGwuY3BwOgorCiAyMDExLTA0LTA1ICBIYW5zIFdlbm5ib3JnICA8aGFuc0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU3RldmUgQmxvY2suCkluZGV4OiBTb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9GcmFtZUxvYWRlckNsaWVudEltcGwuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL0ZyYW1lTG9hZGVyQ2xpZW50SW1wbC5jcHAJ KHJldmlzaW9uIDgzNDYyKQorKysgU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvRnJhbWVMb2Fk ZXJDbGllbnRJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNzE0LDEwICs3MTQsMTggQEAgdm9p ZCBGcmFtZUxvYWRlckNsaWVudEltcGw6OmRpc3BhdGNoRGlkUwogICAgICAgICAvLyBtX2V4cGVj dGVkQ2xpZW50UmVkaXJlY3REZXN0IGNvdWxkIGJlIHNvbWV0aGluZyBsaWtlCiAgICAgICAgIC8v ICJqYXZhc2NyaXB0Omhpc3RvcnkuZ28oLTEpIiB0aHVzIHdlIG5lZWQgdG8gZXhjbHVkZSB1cmwg c3RhcnRzIHdpdGgKICAgICAgICAgLy8gImphdmFzY3JpcHQ6Ii4gU2VlIGJ1ZzogMTA4MDg3Mwot ICAgICAgICBBU1NFUlQobV9leHBlY3RlZENsaWVudFJlZGlyZWN0RGVzdC5wcm90b2NvbElzKCJq YXZhc2NyaXB0IikKLSAgICAgICAgICAgIHx8IG1fZXhwZWN0ZWRDbGllbnRSZWRpcmVjdERlc3Qg PT0gdXJsKTsKLSAgICAgICAgZHMtPmFwcGVuZFJlZGlyZWN0KG1fZXhwZWN0ZWRDbGllbnRSZWRp cmVjdFNyYyk7Ci0gICAgICAgIGNvbXBsZXRpbmdDbGllbnRSZWRpcmVjdCA9IHRydWU7CisgICAg ICAgIGlmIChtX2V4cGVjdGVkQ2xpZW50UmVkaXJlY3REZXN0LnByb3RvY29sSXMoImphdmFzY3Jp cHQiKQorICAgICAgICAgICAgfHwgbV9leHBlY3RlZENsaWVudFJlZGlyZWN0RGVzdCA9PSB1cmwp IHsKKyAgICAgICAgICAgIGRzLT5hcHBlbmRSZWRpcmVjdChtX2V4cGVjdGVkQ2xpZW50UmVkaXJl Y3RTcmMpOworICAgICAgICAgICAgY29tcGxldGluZ0NsaWVudFJlZGlyZWN0ID0gdHJ1ZTsKKyAg ICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIC8vIEFueSBwZW5kaW5nIHJlZGlyZWN0IGlzIG5v IGxvbmdlciBpbiBwcm9ncmVzcy4gVGhpcyBjYW4gaGFwcGVuCisgICAgICAgICAgICAvLyBpZiB0 aGUgbmF2aWdhdGlvbiB3YXMgY2FuY2VsZWQgd2l0aCBQb2xpY3lJZ25vcmUsIG9yIGlmIHRoZQor ICAgICAgICAgICAgLy8gcmVkaXJlY3Qgd2FzIHNjaGVkdWxlZCBvbiB0aGUgd3JvbmcgZnJhbWUg KGUuZy4sIGR1ZSB0byBhIGZvcm0KKyAgICAgICAgICAgIC8vIHN1Ym1pc3Npb24gdGFyZ2V0ZWQg dG8gX2JsYW5rLCBhcyBpbiBodHRwOi8vd2Via2l0Lm9yZy9iLzQ0MDc5KS4KKyAgICAgICAgICAg IG1fZXhwZWN0ZWRDbGllbnRSZWRpcmVjdFNyYyA9IEtVUkwoKTsKKyAgICAgICAgICAgIG1fZXhw ZWN0ZWRDbGllbnRSZWRpcmVjdERlc3QgPSBLVVJMKCk7CisgICAgICAgIH0KICAgICB9CiAgICAg ZHMtPmFwcGVuZFJlZGlyZWN0KHVybCk7CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDgzNDYyKQorKysg TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIw MTEtMDQtMTQgIENoYXJsaWUgUmVpcyAgPGNyZWlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ2hyb21pdW1dIGZhc3QvZXZl bnRzL3BvcHVwLWFsbG93ZWQtZnJvbS1nZXN0dXJlLWluaXRpYXRlZC1mb3JtLXN1Ym1pdC5odG1s IGNhdXNpbmcgZGVidWcgQVNTRVJUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00NDA3OQorCisgICAgICAgIFJlbW92ZSBhbiBhc3NlcnQgd2hvc2UgaW52 YXJpYW50IGRvZXNuJ3QgaG9sZC4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL3Rlc3Rf ZXhwZWN0YXRpb25zLnR4dDogUmUtZW5hYmxlIHRlc3QuCisKIDIwMTEtMDQtMTEgIEppYW4gTGkg IDxqaWFubGlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIFVwZGF0ZWQgY2hy b21pdW0gdGVzdCBleHBlY3RhdGlvbnMuCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJv bWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxh dGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CShyZXZpc2lvbiA4MzQ2MikKKysr IExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25zLnR4dAkod29y a2luZyBjb3B5KQpAQCAtMjI0OCwxMCArMjI0OCw2IEBAIEJVR1dLNDM5MTIgV0lOIExJTlVYIDog c3ZnL2N1c3RvbS9hYnNvbHUKIC8vIFRpbWVzIG91dCBmcmVxdWVudGx5IHNpbmNlIHRoZSB0ZXN0 IHdhcyBhZGRlZAogQlVHQ1I1MjAxNyBNQUMgTElOVVggOiBodHRwL3Rlc3RzL21pc2MvaXNpbmRl eC13aXRoLW5vLWZvcm0uaHRtbCA9IFBBU1MgVElNRU9VVAogCi0vLyBQcm9iYWJseSBodHRwOi8v dHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC82NTM4MQotLy8gVGhpcyB0ZXN0IGNhdXNlcyB0aGUg bmV4dCBvbmUgdG8gcnVuIHRvIEFTU0VSVAotQlVHV0s0NDA3OSBERUJVRyBTS0lQIDogZmFzdC9l dmVudHMvcG9wdXAtYWxsb3dlZC1mcm9tLWdlc3R1cmUtaW5pdGlhdGVkLWZvcm0tc3VibWl0Lmh0 bWwgPSBQQVNTCi0KIC8vIEZsYWt5LiBOb3Qgc3VyZSB3aGVuIGl0IHN0YXJ0ZWQgdG8gZmFpbC4K IEJVR0NSNTI1NzIgV0lOIExJTlVYIERFQlVHIDogaHR0cC90ZXN0cy9taXNjL2ltYWdlLWJsb2Nr ZWQtc3JjLWNoYW5nZS5odG1sID0gUEFTUyBURVhUCiAK