44067 2010-08-16 12:35:23 -0700 Single-character replace does not substitute metachars 2010-08-23 16:13:38 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED https://bugzilla.mozilla.org/show_bug.cgi?id=587366 P2 Normal --- 1 christopher.leary msaboff barraclough commit-queue ggaren msaboff oliver oldest_to_newest 265198 0 christopher.leary 2010-08-16 12:35:23 -0700 Steps to reproduce: Command: jsc -e 'print(")".replace(")", "*$&*"))' Actual: *$&* Expected: *)* References: ECMAv5:15.5.4.11 267078 1 64914 msaboff 2010-08-19 17:16:50 -0700 Created attachment 64914 Patch to fix single character search string optimization. Added check to only execute single character replace() optimization if there aren't any back references by checking for existence of '$' in replace string. 268146 2 64914 commit-queue 2010-08-23 16:13:34 -0700 Comment on attachment 64914 Patch to fix single character search string optimization. Clearing flags on attachment: 64914 Committed r65840: <http://trac.webkit.org/changeset/65840> 268147 3 commit-queue 2010-08-23 16:13:38 -0700 All reviewed patches have been landed. Closing bug. 64914 2010-08-19 17:16:50 -0700 2010-08-23 16:13:34 -0700 Patch to fix single character search string optimization. 44067.patch text/plain 1722 msaboff SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY1NzE1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDgtMTkgIE1pY2hhZWwg U2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRml4ZWQgY2FzZSB3aGVyZSBhIHNpbmdsZSBjaGFyYWN0ZXIg c2VhcmNoIHN0cmluZyBpbiBhIHN0cmluZy5yZXBsYWNlKCkKKyAgICAgICAgZGlkIG5vdCBwcm9w ZXJseSBoYW5kbGUgYmFjayByZWZlcmVuY2UgcmVwbGFjZW1lbnQuICBUaGUgZml4IGlzIHRvIAor ICAgICAgICBjaGVjayBmb3IgYSAnJCcgYXMgcGFydCBvZiB0aGUgY2hlY2sgdG8gc2VlIGlmIHdl IGNhbiBleGVjdXRlIHRoZQorICAgICAgICBzaW5nbGUgY2hhcmFjdGVyIHJlcGxhY2Ugb3B0aW1p emF0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDQwNjcKKworICAgICAgICAqIHJ1bnRpbWUvU3RyaW5nUHJvdG90eXBlLmNwcDoKKyAgICAgICAg KEpTQzo6c3RyaW5nUHJvdG9GdW5jUmVwbGFjZSk6CisKIDIwMTAtMDgtMTkgIEFuZHJlYXMgS2xp bmcgIDxhbmRyZWFzLmtsaW5nQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHZW9m ZnJleSBHYXJlbi4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RyaW5nUHJvdG90eXBl LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cmluZ1Byb3RvdHlw ZS5jcHAJKHJldmlzaW9uIDY1NjExKQorKysgSmF2YVNjcmlwdENvcmUvcnVudGltZS9TdHJpbmdQ cm90b3R5cGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MjUsOSArNDI1LDEwIEBAIEVuY29kZWRK U1ZhbHVlIEpTQ19IT1NUX0NBTEwgc3RyaW5nUHJvdG8KICAgICAvLyBOb3QgYSByZWd1bGFyIGV4 cHJlc3Npb24sIHNvIHRyZWF0IHRoZSBwYXR0ZXJuIGFzIGEgc3RyaW5nLgogCiAgICAgVVN0cmlu ZyBwYXR0ZXJuU3RyaW5nID0gcGF0dGVybi50b1N0cmluZyhleGVjKTsKLSAgICBpZiAocGF0dGVy blN0cmluZy5sZW5ndGgoKSA9PSAxICYmIGNhbGxUeXBlID09IENhbGxUeXBlTm9uZSkKKyAgICAv LyBTcGVjaWFsIGNhc2UgZm9yIHNpbmdsZSBjaGFyYWN0ZXIgcGF0dGVybnMgd2l0aG91dCBiYWNr IHJlZmVyZW5jZSByZXBsYWNlbWVudAorICAgIGlmIChwYXR0ZXJuU3RyaW5nLmxlbmd0aCgpID09 IDEgJiYgY2FsbFR5cGUgPT0gQ2FsbFR5cGVOb25lICYmIHJlcGxhY2VtZW50U3RyaW5nLmZpbmQo JyQnLCAwKSA9PSBub3RGb3VuZCkKICAgICAgICAgcmV0dXJuIEpTVmFsdWU6OmVuY29kZShzb3Vy Y2VWYWwtPnJlcGxhY2VDaGFyYWN0ZXIoZXhlYywgcGF0dGVyblN0cmluZ1swXSwgcmVwbGFjZW1l bnRTdHJpbmcpKTsKLSAgICAKKwogICAgIGNvbnN0IFVTdHJpbmcmIHNvdXJjZSA9IHNvdXJjZVZh bC0+dmFsdWUoZXhlYyk7CiAgICAgc2l6ZV90IG1hdGNoUG9zID0gc291cmNlLmZpbmQocGF0dGVy blN0cmluZyk7CiAK