44066 2010-08-16 12:23:47 -0700 [Qt] qt/Skipped needs cleanup on outdaded comments 2010-08-16 18:20:11 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Trivial --- 0 ademar webkit-unassigned commit-queue oldest_to_newest 265195 0 ademar 2010-08-16 12:23:47 -0700 The Skipped file has a few cleanups to be made. Namely: - move bug reference to the right place (#35145) - remove outdated bug reference (#32922) - move inspector testcase to the right place - add reference to bug closed on qt-4.7 (QTBUG-9618) Patch is on the way. 265197 1 64508 ademar 2010-08-16 12:29:46 -0700 Created attachment 64508 minor fixes/cleanup, no logical changes No logical changes, only cleanups and minor reorganization. The list of skipped tests is still the same. 265236 2 64508 ariya.hidayat 2010-08-16 14:19:21 -0700 Comment on attachment 64508 minor fixes/cleanup, no logical changes LGTM, r+. 265331 3 64508 commit-queue 2010-08-16 18:20:07 -0700 Comment on attachment 64508 minor fixes/cleanup, no logical changes Clearing flags on attachment: 64508 Committed r65476: <http://trac.webkit.org/changeset/65476> 265332 4 commit-queue 2010-08-16 18:20:11 -0700 All reviewed patches have been landed. Closing bug. 64508 2010-08-16 12:29:46 -0700 2010-08-16 18:20:07 -0700 minor fixes/cleanup, no logical changes 0001-Minor-improvements-fixes-to-the-list-of-Skipped-Qt-t.patch text/plain 4907 ademar RnJvbSBhODllZmVjYjhkNGRhNmEzODhkNTM5ODE0MmI0NGQ5NmE4ZDk1ZTJlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVtYXIgZGUgU291emEgUmVpcyBKciA8YWRlbWFyLnJlaXNA b3BlbmJvc3NhLm9yZz4KRGF0ZTogVHVlLCAxMCBBdWcgMjAxMCAxODowMzoxOSAtMDMwMApTdWJq ZWN0OiBbUEFUQ0hdIE1pbm9yIGltcHJvdmVtZW50cy9maXhlcyB0byB0aGUgbGlzdCBvZiBTa2lw cGVkIFF0IHRlc3RzCgogLSBtb3ZlIGJ1ZyByZWZlcmVuY2UgdG8gdGhlIHJpZ2h0IHBsYWNlICgj MzUxNDUpCiAtIHJlbW92ZSBvdXRkYXRlZCBidWcgcmVmZXJlbmNlICgjMzI5MjIpCiAtIG1vdmUg aW5zcGVjdG9yIHRlc3RjYXNlIHRvIHRoZSByaWdodCBwbGFjZQogLSBhZGQgcmVmZXJlbmNlIHRv IGJ1ZyBjbG9zZWQgb24gcXQtNC43IChRVEJVRy05NjE4KQotLS0KIExheW91dFRlc3RzL0NoYW5n ZUxvZyAgICAgICAgICAgfCAgIDE2ICsrKysrKysrKysrKysrKysKIExheW91dFRlc3RzL3BsYXRm b3JtL3F0L1NraXBwZWQgfCAgIDE5ICsrKysrKysrKystLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdl ZCwgMjYgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGE4YzU0OC4uY2Fm ZjgxMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEwLTA4LTE2ICBBZGVtYXIgZGUgU291emEg UmVpcyBKciAgPGFkZW1hci5yZWlzQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBxdC9Ta2lwcGVkIG5lZWRzIGNsZWFu dXAgb24gb3V0ZGFkZWQgY29tbWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQ0MDY2CisKKyAgICAgICAgTWlub3IgaW1wcm92ZW1lbnRzL2ZpeGVz IHRvIHRoZSBsaXN0IG9mIFNraXBwZWQgUXQgdGVzdHMKKworICAgICAgICAgLSBtb3ZlIGJ1ZyBy ZWZlcmVuY2UgdG8gdGhlIHJpZ2h0IHBsYWNlICgjMzUxNDUpCisgICAgICAgICAtIHJlbW92ZSBv dXRkYXRlZCBidWcgcmVmZXJlbmNlICgjMzI5MjIpCisgICAgICAgICAtIG1vdmUgaW5zcGVjdG9y IHRlc3RjYXNlIHRvIHRoZSByaWdodCBwbGFjZQorICAgICAgICAgLSBhZGQgcmVmZXJlbmNlIHRv IGJ1ZyBjbG9zZWQgb24gcXQtNC43IChRVEJVRy05NjE4KQorCisgICAgICAgICogcGxhdGZvcm0v cXQvU2tpcHBlZDogY2xlYW51cHMgb25seSwgbm8gbG9naWNhbCBjaGFuZ2VzCisKIDIwMTAtMDgt MTYgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQgYnVpbGQgZml4LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tp cHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKaW5kZXggODY5MDMzZC4uYTY2 NjM0OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAorKysgYi9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCkBAIC0zMzEsOCArMzMxLDYgQEAgaHR0cC90 ZXN0cy94bWxodHRwcmVxdWVzdC9hY2Nlc3MtY29udHJvbC1wcmVmbGlnaHQtc3luYy1ub3Qtc3Vw cG9ydGVkLmh0bWwKIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvYWNjZXNzLWNvbnRyb2wtcmVz cG9uc2Utd2l0aC1ib2R5LXN5bmMuaHRtbAogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9jYWNo ZS1vdmVycmlkZS5odG1sCiBodHRwL3Rlc3RzL3htbGh0dHByZXF1ZXN0L3NpbXBsZS1jcm9zcy1v cmlnaW4tcHJvZ3Jlc3MtZXZlbnRzLmh0bWwKLSMgLS0tIGh0dHA6Ly9idWdyZXBvcnRzLnF0Lm5v a2lhLmNvbS9icm93c2UvUVRCVUctOTYxOAotaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9jb29r aWVzLmh0bWwKIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvbWV0aG9kcy1sb3dlci1jYXNlLmh0 bWwKIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3QvbWV0aG9kcy5odG1sCiBodHRwL3Rlc3RzL3ht bGh0dHByZXF1ZXN0L3JlZGlyZWN0LWNyb3NzLW9yaWdpbi10cmlwbWluZS5odG1sCkBAIC0zNDEs NiArMzM5LDEwIEBAIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qvd29ya2Vycy9tZXRob2RzLWFz eW5jLmh0bWwKIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qvd29ya2Vycy9tZXRob2RzLmh0bWwK IGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qvd29ya2Vycy9zaGFyZWQtd29ya2VyLW1ldGhvZHMt YXN5bmMuaHRtbAogCisjIC0tLSBodHRwOi8vYnVncmVwb3J0cy5xdC5ub2tpYS5jb20vYnJvd3Nl L1FUQlVHLTk2MTgKKyMgKGZpeGVkIGluIHF0LTQuNykKK2h0dHAvdGVzdHMveG1saHR0cHJlcXVl c3QvY29va2llcy5odG1sCisKICMgQ2F1c2VkIGJ5IHRoZSB3YXkgUXQgY2FjaGVzIG5ldHdvcmsg Y29ubmVjdGlvbnMgdXNpbmcgdXNlckBob3N0bmFtZSBhcyB0aGUga2V5CiAjIFNlZSBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzcwODQgYW5kIGh0dHA6Ly9idWdyZXBv cnRzLnF0Lm5va2lhLmNvbS9icm93c2UvUVRCVUctOTYxOQogaHR0cC90ZXN0cy94bWxodHRwcmVx dWVzdC9yZS1sb2dpbi1hc3luYy5odG1sCkBAIC01OTQsNyArNTk2LDYgQEAgaHR0cC90ZXN0cy9j b29raWVzL3NpbXBsZS1jb29raWVzLW1heC1hZ2UuaHRtbAogaHR0cC90ZXN0cy9jb29raWVzL3Np bXBsZS1jb29raWVzLWV4cGlyZWQuaHRtbAogaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC93b3Jr ZXJzL2Nsb3NlLmh0bWwKIGh0dHAvdGVzdHMveG1saHR0cHJlcXVlc3Qvd29ya2Vycy9zaGFyZWQt d29ya2VyLWNsb3NlLmh0bWwKLWluc3BlY3Rvci90aW1lbGluZS1wYWludC5odG1sCiAKIHN0b3Jh Z2UvZGF0YWJhc2UtbG9jay1hZnRlci1yZWxvYWQuaHRtbAogc3RvcmFnZS9lbXB0eS1zdGF0ZW1l bnQuaHRtbApAQCAtNjE3LDggKzYxOCw2IEBAIGZhc3Qvd29ya2Vycy9zaGFyZWQtd29ya2VyLWZy YW1lLWxpZmVjeWNsZS5odG1sCiBzdmcvY3VzdG9tL3BhdGgtZ2V0VG90YWxMZW5ndGguc3ZnCiBz dmcvY3VzdG9tL2dseXBoLXNldHRpbmctZC1hdHRyaWJ1dGUuc3ZnCiAKLSMgLS0tLSBjcmFzaGVz IC0gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMyOTIyCi0KICMgVGVz dHMgdGhhdCBjdXJyZW50bHkgZmFpbCBidXQgcGVyaGFwcyB1c2VkIHRvIHdvcmsgYXQgc29tZSBw b2ludC4KIGZhc3QvZG9tL29wZW4tYW5kLWNsb3NlLWJ5LURPTS5odG1sCiBmYXN0L2RvbS9XaW5k b3cvbmV3LXdpbmRvdy1vcGVuZXIuaHRtbApAQCAtMjE0Miw4ICsyMTQxLDYgQEAgZWRpdGluZy9z ZWxlY3Rpb24vZmFrZS1kcmFnLmh0bWwKIGVkaXRpbmcvc2VsZWN0aW9uL2lubGluZS1jbG9zZXN0 LWxlYWYtY2hpbGQuaHRtbAogZWRpdGluZy9zZWxlY3Rpb24vbWl4ZWQtZWRpdGFiaWxpdHktMS5o dG1sCiBlZGl0aW5nL3NlbGVjdGlvbi9zZWxlY3QtZnJvbS10ZXh0ZmllbGQtb3V0d2FyZHMuaHRt bAotZWRpdGluZy9zZWxlY3Rpb24vZXh0ZW5kLXNlbGVjdGlvbi5odG1sCi1lZGl0aW5nL3NlbGVj dGlvbi9leHRlbmQtYWZ0ZXItbW91c2Utc2VsZWN0aW9uLmh0bWwKIGVkaXRpbmcvc2VsZWN0aW9u LzQ5ODM4NTguaHRtbAogZWRpdGluZy9zZWxlY3Rpb24vZW5kLW9mLWRvY3VtZW50Lmh0bWwKIGVk aXRpbmcvc2VsZWN0aW9uL21vdmUtbGVmdC1yaWdodC5odG1sCkBAIC0yMTY2LDYgKzIxNjMsMTEg QEAgZWRpdGluZy9zZWxlY3Rpb24vc2VsZWN0LWFsbC0wMDUuaHRtbAogZWRpdGluZy9zZWxlY3Rp b24vc2VsZWN0LWFsbC0wMDYuaHRtbAogZWRpdGluZy9zZWxlY3Rpb24vc2VsZWN0LWJveC5odG1s CiAKKyMgW1F0XSBlZGl0aW5nIHRlc3RzIGZhaWxzIGFmdGVyIHI1NDk4MAorIyBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzUxNDUKK2VkaXRpbmcvc2VsZWN0aW9uL2V4 dGVuZC1zZWxlY3Rpb24uaHRtbAorZWRpdGluZy9zZWxlY3Rpb24vZXh0ZW5kLWFmdGVyLW1vdXNl LXNlbGVjdGlvbi5odG1sCisKICMgc3RkZXJyCiBlZGl0aW5nL3NlbGVjdGlvbi9lZGl0YWJsZS1s aW5rcy5odG1sCiBlZGl0aW5nL3NlbGVjdGlvbi9kcmFnLXRleHQtZGVsYXkuaHRtbApAQCAtMjE5 OCw4ICsyMjAwLDYgQEAgZWRpdGluZy9zZWxlY3Rpb24vNTEwOTgxNy5odG1sCiBlZGl0aW5nL3Nl bGVjdGlvbi81MzU0NDU1LTEuaHRtbAogZWRpdGluZy9zZWxlY3Rpb24vNTM1NDQ1NS0yLmh0bWwK IGVkaXRpbmcvc2VsZWN0aW9uL2NhcmV0LWFuZC1mb2N1cy1yaW5nLmh0bWwKLSMgW1F0XSBlZGl0 aW5nIHRlc3RzIGZhaWxzIGFmdGVyIHI1NDk4MAotIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzUxNDUKIGVkaXRpbmcvc2VsZWN0aW9uLzUxMzY2OTYuaHRtbAogZWRp dGluZy9zZWxlY3Rpb24vYWZ0ZXItbGluZS13cmFwLmh0bWwKIGVkaXRpbmcvc2VsZWN0aW9uLzEz ODA0Lmh0bWwKQEAgLTU0MjgsNiArNTQyOCw3IEBAIGZhc3QvZG9tL2JlZm9yZWxvYWQvcmVtb3Zl LXZpZGVvLWluLWJlZm9yZWxvYWQtbGlzdGVuZXIuaHRtbAogCiAjIFtRdF0gU29tZSBpbnNwZWN0 b3IgdGVzdCBmYWlsIGludGVybWl0dGVudGx5CiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00MjA5MAoraW5zcGVjdG9yL3RpbWVsaW5lLXBhaW50Lmh0bWwKIGluc3Bl Y3Rvci90aW1lbGluZS1sYXlvdXQuaHRtbAogaW5zcGVjdG9yL3RpbWVsaW5lLXBhcnNlLWh0bWwu aHRtbAogaW5zcGVjdG9yL3RpbWVsaW5lLXJlY2FsY3VsYXRlLXN0eWxlcy5odG1sCi0tIAoxLjcu Mi4xCgo=