44065 2010-08-16 11:23:37 -0700 Self inclusion in Document.h and RenderTheme.h 2010-08-17 08:36:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P3 Trivial --- 0 ademar webkit-unassigned commit-queue eric.carlson eric oldest_to_newest 265176 0 ademar 2010-08-16 11:23:37 -0700 WebCore/dom/Document.h and WebCore/rendering/RenderTheme.h both include themselves. 265182 1 64506 ademar 2010-08-16 11:39:13 -0700 Created attachment 64506 Fix for self inclusion trivial fix 265184 2 64506 commit-queue 2010-08-16 11:44:19 -0700 Comment on attachment 64506 Fix for self inclusion Rejecting patch 64506 from review queue. ademar.reis@openbossa.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your reviewer rights. 265190 3 64506 commit-queue 2010-08-16 12:01:06 -0700 Comment on attachment 64506 Fix for self inclusion Rejecting patch 64506 from commit-queue. ademar.reis@openbossa.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in WebKitTools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). Due to bug 30084 the commit-queue will require a restart after your change. Please contact eseidel@chromium.org to request a commit-queue restart. After restart the commit-queue will correctly respect your committer rights. 265191 4 64507 ademar 2010-08-16 12:01:12 -0700 Created attachment 64507 Fix for self inclusion trivial fix 265275 5 64507 commit-queue 2010-08-16 16:05:04 -0700 Comment on attachment 64507 Fix for self inclusion Rejecting patch 64507 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Last 500 characters of output: ue/LayoutTests Testing 20850 test cases. media/video-currentTime-set.html -> timed out Sampling process 15922 for 10 seconds with 10 milliseconds of run time between samples Sampling completed, processing symbols... Sample analysis of process 15922 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt Exiting early after 1 failures. 17197 tests run. 746.42s total testing time 17196 test cases (99%) succeeded 1 test case (<1%) timed out 34 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3708270 265508 6 ademar 2010-08-17 06:45:53 -0700 I can't understand how a trivial fix for double header inclusion could trigger a failure on the media/video-currentTime-set.html test. I guess this is a hiccup on the mac build-bot... What should I do now? 265511 7 eric 2010-08-17 06:49:17 -0700 I believe this is some CoreVideo bug on Leopard. I need to move the commit-queue to snow leopard since this bug is unlikely to ever get fixed. Basically the media and compositing tests randomly crash or hang on certain leopard machines. The commit-queue happens to be one such machine. :( 265563 8 64507 commit-queue 2010-08-17 08:35:59 -0700 Comment on attachment 64507 Fix for self inclusion Clearing flags on attachment: 64507 Committed r65504: <http://trac.webkit.org/changeset/65504> 265564 9 commit-queue 2010-08-17 08:36:04 -0700 All reviewed patches have been landed. Closing bug. 64506 2010-08-16 11:39:13 -0700 2010-08-16 12:01:12 -0700 Fix for self inclusion 0001-Remove-self-inclusion-of-a-couple-of-header-files.patch text/plain 1676 ademar RnJvbSBmNzc3Njk0MjVhYzM2NTdjNTVkM2JmYzYxNGIzM2FiNWI1NmNiYWQ0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVtYXIgZGUgU291emEgUmVpcyBKciA8YWRlbWFyLnJlaXNA b3BlbmJvc3NhLm9yZz4KRGF0ZTogVHVlLCAxMCBBdWcgMjAxMCAxNDozOTowMCAtMDMwMApTdWJq ZWN0OiBbUEFUQ0hdIFJlbW92ZSBzZWxmLWluY2x1c2lvbiBvZiBhIGNvdXBsZSBvZiBoZWFkZXIg ZmlsZXMKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICB8ICAgIDggKysrKysr KysKIFdlYkNvcmUvZG9tL0RvY3VtZW50LmggICAgICAgICAgfCAgICAxIC0KIFdlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRoZW1lLmggfCAgICAxIC0KIDMgZmlsZXMgY2hhbmdlZCwgOCBpbnNlcnRp b25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIv V2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTE3ZDc2ZC4uN2Q1MDIxZiAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMSBAQAor MjAxMC0wOC0xNiAgQWRlbWFyIGRlIFNvdXphIFJlaXMgSnIgIDxhZGVtYXIucmVpc0BvcGVuYm9z c2Eub3JnPgorCisgICAgICAgIFNlbGYgaW5jbHVzaW9uIGluIERvY3VtZW50LmggYW5kIFJlbmRl clRoZW1lLmgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ0MDY1CisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuaDoKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyVGhlbWUuaDoKKwogMjAxMC0wOC0xNiAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBOb3QgcmV2aWV3ZWQ6IGZpeCBMZW9wYXJkIFJlbGVhc2Ug aW5zcGVjdG9yIHRlc3RzLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vRG9jdW1lbnQuaCBiL1dl YkNvcmUvZG9tL0RvY3VtZW50LmgKaW5kZXggNjA3ZGM3Mi4uZTI5MTJjZCAxMDA2NDQKLS0tIGEv V2ViQ29yZS9kb20vRG9jdW1lbnQuaAorKysgYi9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCkBAIC0z Miw3ICszMiw2IEBACiAjaW5jbHVkZSAiQ29sbGVjdGlvblR5cGUuaCIKICNpbmNsdWRlICJDb2xv ci5oIgogI2luY2x1ZGUgIkNvbnRhaW5lck5vZGUuaCIKLSNpbmNsdWRlICJEb2N1bWVudC5oIgog I2luY2x1ZGUgIkRvY3VtZW50TWFya2VyLmgiCiAjaW5jbHVkZSAiUXVhbGlmaWVkTmFtZS5oIgog I2luY2x1ZGUgIlNjcmlwdEV4ZWN1dGlvbkNvbnRleHQuaCIKZGlmZiAtLWdpdCBhL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRoZW1lLmggYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5o CmluZGV4IDI0OTYzYzIuLmQ1MGE5YzQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlclRoZW1lLmgKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWUuaApAQCAtMjks NyArMjksNiBAQAogI2luY2x1ZGUgIlRoZW1lVHlwZXMuaCIKICNlbmRpZgogI2luY2x1ZGUgIlJl bmRlck9iamVjdC5oIgotI2luY2x1ZGUgIlJlbmRlclRoZW1lLmgiCiAjaW5jbHVkZSAiU2Nyb2xs VHlwZXMuaCIKICNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi9SZWZD b3VudGVkLmg+Ci0tIAoxLjcuMi4xCgo= 64507 2010-08-16 12:01:12 -0700 2010-08-17 08:35:59 -0700 Fix for self inclusion 0001-Remove-self-inclusion-of-a-couple-of-header-files.patch text/plain 1800 ademar RnJvbSA3MjFiODA5MmM0OWU0ZTc1ZGE2MzU2MDliMjNkZTYzMWFjZGEyZmRkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBZGVtYXIgZGUgU291emEgUmVpcyBKciA8YWRlbWFyLnJlaXNA b3BlbmJvc3NhLm9yZz4KRGF0ZTogVHVlLCAxMCBBdWcgMjAxMCAxNDozOTowMCAtMDMwMApTdWJq ZWN0OiBbUEFUQ0hdIFJlbW92ZSBzZWxmLWluY2x1c2lvbiBvZiBhIGNvdXBsZSBvZiBoZWFkZXIg ZmlsZXMKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICB8ICAgMTIgKysrKysr KysrKysrCiBXZWJDb3JlL2RvbS9Eb2N1bWVudC5oICAgICAgICAgIHwgICAgMSAtCiBXZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJUaGVtZS5oIHwgICAgMSAtCiAzIGZpbGVzIGNoYW5nZWQsIDEyIGlu c2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VM b2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1MTdkNzZkLi4zMmU2MDI0IDEwMDY0NAotLS0g YS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEwLTA4LTE2ICBBZGVtYXIgZGUgU291emEgUmVpcyBKciAgPGFkZW1hci5yZWlzQG9w ZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVHJpdmlhbCBmaXggcmVtb3ZpbmcgdGhlIHNlbGYtaW5jbHVzaW9uIG9mIGEgY291cGxl IG9mIGhlYWRlciBmaWxlcy4KKworICAgICAgICBTZWxmIGluY2x1c2lvbiBpbiBEb2N1bWVudC5o IGFuZCBSZW5kZXJUaGVtZS5oCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00NDA2NQorCisgICAgICAgICogZG9tL0RvY3VtZW50Lmg6CisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlclRoZW1lLmg6CisKIDIwMTAtMDgtMTYgIFBhdmVsIEZlbGRtYW4gIDxw ZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm90IHJldmlld2VkOiBmaXggTGVvcGFy ZCBSZWxlYXNlIGluc3BlY3RvciB0ZXN0cy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL0RvY3Vt ZW50LmggYi9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCmluZGV4IDYwN2RjNzIuLmUyOTEyY2QgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKKysrIGIvV2ViQ29yZS9kb20vRG9jdW1l bnQuaApAQCAtMzIsNyArMzIsNiBAQAogI2luY2x1ZGUgIkNvbGxlY3Rpb25UeXBlLmgiCiAjaW5j bHVkZSAiQ29sb3IuaCIKICNpbmNsdWRlICJDb250YWluZXJOb2RlLmgiCi0jaW5jbHVkZSAiRG9j dW1lbnQuaCIKICNpbmNsdWRlICJEb2N1bWVudE1hcmtlci5oIgogI2luY2x1ZGUgIlF1YWxpZmll ZE5hbWUuaCIKICNpbmNsdWRlICJTY3JpcHRFeGVjdXRpb25Db250ZXh0LmgiCmRpZmYgLS1naXQg YS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZS5oIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGhlbWUuaAppbmRleCAyNDk2M2MyLi5kNTBhOWM0IDEwMDY0NAotLS0gYS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUaGVtZS5oCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1l LmgKQEAgLTI5LDcgKzI5LDYgQEAKICNpbmNsdWRlICJUaGVtZVR5cGVzLmgiCiAjZW5kaWYKICNp bmNsdWRlICJSZW5kZXJPYmplY3QuaCIKLSNpbmNsdWRlICJSZW5kZXJUaGVtZS5oIgogI2luY2x1 ZGUgIlNjcm9sbFR5cGVzLmgiCiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQdHIuaD4KICNpbmNsdWRl IDx3dGYvUmVmQ291bnRlZC5oPgotLSAKMS43LjIuMQoK