44054 2010-08-16 06:36:29 -0700 Chromium DevTools: Support runtime property name/value pairs instead of feature names as navigation state. 2010-08-18 03:27:59 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman abarth eric loislo webkit.review.bot yurys oldest_to_newest 265067 0 pfeldman 2010-08-16 06:36:29 -0700 Patch to follow. 265068 1 64490 pfeldman 2010-08-16 06:38:39 -0700 Created attachment 64490 [PATCH] Proposed fix. 265073 2 64490 yurys 2010-08-16 06:52:28 -0700 Comment on attachment 64490 [PATCH] Proposed fix. WebKit/chromium/public/WebDevToolsAgentClient.h:54 + virtual void runtimeFeatureStateChanged(const WebString& feature, bool enabled) { } let's remove this one 266005 3 pfeldman 2010-08-18 02:38:10 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/chromium/ChangeLog M WebKit/chromium/public/WebDevToolsAgent.h M WebKit/chromium/public/WebDevToolsAgentClient.h M WebKit/chromium/src/WebDevToolsAgentImpl.cpp M WebKit/chromium/src/WebDevToolsAgentImpl.h Committed r65594 266021 4 webkit.review.bot 2010-08-18 03:27:59 -0700 http://trac.webkit.org/changeset/65594 might have broken Qt Windows 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/65594 http://trac.webkit.org/changeset/65595 http://trac.webkit.org/changeset/65596 http://trac.webkit.org/changeset/65597 64490 2010-08-16 06:38:39 -0700 2010-08-16 06:52:28 -0700 [PATCH] Proposed fix. runtime_features text/plain 6426 pfeldman ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGRjYzgwMzkuLmI3ZTA0YTQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSw1ICsx LDIxIEBACiAyMDEwLTA4LTE2ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3Jn PgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENocm9t aXVtIERldlRvb2xzOiBTdXBwb3J0IHJ1bnRpbWUgcHJvcGVydHkgbmFtZS92YWx1ZSBwYWlycwor ICAgICAgICBpbnN0ZWFkIG9mIGZlYXR1cmUgbmFtZXMgYXMgbmF2aWdhdGlvbiBzdGF0ZS4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0MDU0CisKKyAg ICAgICAgKiBwdWJsaWMvV2ViRGV2VG9vbHNBZ2VudC5oOgorICAgICAgICAqIHB1YmxpYy9XZWJE ZXZUb29sc0FnZW50Q2xpZW50Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYkRldlRvb2xzQWdlbnRD bGllbnQ6OnJ1bnRpbWVQcm9wZXJ0eUNoYW5nZWQpOgorICAgICAgICAqIHNyYy9XZWJEZXZUb29s c0FnZW50SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkRldlRvb2xzQWdlbnRJbXBsOjpz ZXRSdW50aW1lUHJvcGVydHkpOgorICAgICAgICAoV2ViS2l0OjpXZWJEZXZUb29sc0FnZW50SW1w bDo6c2V0QXB1QWdlbnRFbmFibGVkKToKKyAgICAgICAgKiBzcmMvV2ViRGV2VG9vbHNBZ2VudElt cGwuaDoKKworMjAxMC0wOC0xNiAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9y Zz4KKwogICAgICAgICBSZXZpZXdlZCBieSBKb3NlcGggUGVjb3Jhcm8uCiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogdXBzdHJlYW0gZnJvbnRlbmQtc2lkZSBXZWJTb2NrZXQgdHJhbnNwb3J0Lgpk aWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEZXZUb29sc0FnZW50LmggYi9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRldlRvb2xzQWdlbnQuaAppbmRleCBiNzRiNTg1Li5h MzU1YTBmIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRldlRvb2xzQWdl bnQuaAorKysgYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRldlRvb2xzQWdlbnQuaApAQCAt NjAsNiArNjAsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGluc3BlY3RFbGVtZW50QXQo Y29uc3QgV2ViUG9pbnQmKSA9IDA7CiAKICAgICB2aXJ0dWFsIHZvaWQgc2V0UnVudGltZUZlYXR1 cmVFbmFibGVkKGNvbnN0IFdlYlN0cmluZyYgZmVhdHVyZSwgYm9vbCBlbmFibGVkKSA9IDA7Cisg ICAgdmlydHVhbCB2b2lkIHNldFJ1bnRpbWVQcm9wZXJ0eShjb25zdCBXZWJTdHJpbmcmIG5hbWUs IGNvbnN0IFdlYlN0cmluZyYgdmFsdWUpID0gMDsKIAogICAgIC8vIEV4cG9zZWQgZm9yIExheW91 dFRlc3RDb250cm9sbGVyLgogICAgIHZpcnR1YWwgdm9pZCBldmFsdWF0ZUluV2ViSW5zcGVjdG9y KGxvbmcgY2FsbElkLCBjb25zdCBXZWJTdHJpbmcmIHNjcmlwdCkgPSAwOwpkaWZmIC0tZ2l0IGEv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEZXZUb29sc0FnZW50Q2xpZW50LmggYi9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYkRldlRvb2xzQWdlbnRDbGllbnQuaAppbmRleCBlYzAxM2FjLi44 M2YyNzE0IDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRldlRvb2xzQWdl bnRDbGllbnQuaAorKysgYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkRldlRvb2xzQWdlbnRD bGllbnQuaApAQCAtNTIsNiArNTIsNyBAQCBwdWJsaWM6CiAKICAgICAvLyBOb3RpZmllcyBob3N0 IHVwb24gcnVudGltZSBmZWF0dXJlIGJlaW5nIGVuYWJsZWQvZGlzYWJsZWQuCiAgICAgdmlydHVh bCB2b2lkIHJ1bnRpbWVGZWF0dXJlU3RhdGVDaGFuZ2VkKGNvbnN0IFdlYlN0cmluZyYgZmVhdHVy ZSwgYm9vbCBlbmFibGVkKSB7IH0KKyAgICB2aXJ0dWFsIHZvaWQgcnVudGltZVByb3BlcnR5Q2hh bmdlZChjb25zdCBXZWJTdHJpbmcmIG5hbWUsIGNvbnN0IFdlYlN0cmluZyYgdmFsdWUpIHsgfQog CiAgICAgdmlydHVhbCBXZWJDU3RyaW5nIGluamVjdGVkU2NyaXB0U291cmNlKCkgeyByZXR1cm4g V2ViQ1N0cmluZygpOyB9CiAgICAgdmlydHVhbCBXZWJDU3RyaW5nIGRlYnVnZ2VyU2NyaXB0U291 cmNlKCkgeyByZXR1cm4gV2ViQ1N0cmluZygpOyB9CmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYkRldlRvb2xzQWdlbnRJbXBsLmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi RGV2VG9vbHNBZ2VudEltcGwuY3BwCmluZGV4IDlhMTM5ZGUuLjM5YjZiY2UgMTAwNjQ0Ci0tLSBh L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRGV2VG9vbHNBZ2VudEltcGwuY3BwCisrKyBiL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViRGV2VG9vbHNBZ2VudEltcGwuY3BwCkBAIC0yMzcsNyArMjM3LDcg QEAgdm9pZCBXZWJEZXZUb29sc0FnZW50SW1wbDo6ZGV0YWNoKCkKIHZvaWQgV2ViRGV2VG9vbHNB Z2VudEltcGw6OmZyb250ZW5kTG9hZGVkKCkKIHsKICAgICBpbnNwZWN0b3JDb250cm9sbGVyKCkt PmNvbm5lY3RGcm9udGVuZCgpOwotICAgIG1fY2xpZW50LT5ydW50aW1lRmVhdHVyZVN0YXRlQ2hh bmdlZChrRnJvbnRlbmRDb25uZWN0ZWRGZWF0dXJlTmFtZSwgdHJ1ZSk7CisgICAgbV9jbGllbnQt PnJ1bnRpbWVQcm9wZXJ0eUNoYW5nZWQoa0Zyb250ZW5kQ29ubmVjdGVkRmVhdHVyZU5hbWUsICJ0 cnVlIik7CiB9CiAKIHZvaWQgV2ViRGV2VG9vbHNBZ2VudEltcGw6OmRpZE5hdmlnYXRlKCkKQEAg LTI2OCwxNyArMjY4LDIyIEBAIHZvaWQgV2ViRGV2VG9vbHNBZ2VudEltcGw6Omluc3BlY3RFbGVt ZW50QXQoY29uc3QgV2ViUG9pbnQmIHBvaW50KQogCiB2b2lkIFdlYkRldlRvb2xzQWdlbnRJbXBs OjpzZXRSdW50aW1lRmVhdHVyZUVuYWJsZWQoY29uc3QgV2ViU3RyaW5nJiBmZWF0dXJlLCBib29s IGVuYWJsZWQpCiB7Ci0gICAgaWYgKGZlYXR1cmUgPT0ga0FwdUFnZW50RmVhdHVyZU5hbWUpCi0g ICAgICAgIHNldEFwdUFnZW50RW5hYmxlZChlbmFibGVkKTsKLSAgICBlbHNlIGlmIChmZWF0dXJl ID09IGtUaW1lbGluZUZlYXR1cmVOYW1lKQotICAgICAgICBzZXRUaW1lbGluZVByb2ZpbGluZ0Vu YWJsZWQoZW5hYmxlZCk7Ci0gICAgZWxzZSBpZiAoZmVhdHVyZSA9PSBrUmVzb3VyY2VUcmFja2lu Z0ZlYXR1cmVOYW1lKSB7CisgICAgc2V0UnVudGltZVByb3BlcnR5KGZlYXR1cmUsIGVuYWJsZWQg PyBTdHJpbmcoInRydWUiKSA6IFN0cmluZygiZmFsc2UiKSk7Cit9CisKK3ZvaWQgV2ViRGV2VG9v bHNBZ2VudEltcGw6OnNldFJ1bnRpbWVQcm9wZXJ0eShjb25zdCBXZWJTdHJpbmcmIG5hbWUsIGNv bnN0IFdlYlN0cmluZyYgdmFsdWUpCit7CisgICAgaWYgKG5hbWUgPT0ga0FwdUFnZW50RmVhdHVy ZU5hbWUpCisgICAgICAgIHNldEFwdUFnZW50RW5hYmxlZCh2YWx1ZSA9PSAidHJ1ZSIpOworICAg IGVsc2UgaWYgKG5hbWUgPT0ga1RpbWVsaW5lRmVhdHVyZU5hbWUpCisgICAgICAgIHNldFRpbWVs aW5lUHJvZmlsaW5nRW5hYmxlZCh2YWx1ZSA9PSAidHJ1ZSIpOworICAgIGVsc2UgaWYgKG5hbWUg PT0ga1Jlc291cmNlVHJhY2tpbmdGZWF0dXJlTmFtZSkgewogICAgICAgICBJbnNwZWN0b3JDb250 cm9sbGVyKiBpYyA9IGluc3BlY3RvckNvbnRyb2xsZXIoKTsKLSAgICAgICAgaWYgKGVuYWJsZWQp CisgICAgICAgIGlmICh2YWx1ZSA9PSAidHJ1ZSIpCiAgICAgICAgICAgaWMtPmVuYWJsZVJlc291 cmNlVHJhY2tpbmcoZmFsc2UgLyogbm90IHN0aWNreSAqLywgZmFsc2UgLyogbm8gcmVsb2FkICov KTsKICAgICAgICAgZWxzZQogICAgICAgICAgIGljLT5kaXNhYmxlUmVzb3VyY2VUcmFja2luZyhm YWxzZSAvKiBub3Qgc3RpY2t5ICovKTsKLSAgICB9IGVsc2UgaWYgKGZlYXR1cmUgPT0ga0Zyb250 ZW5kQ29ubmVjdGVkRmVhdHVyZU5hbWUgJiYgZW5hYmxlZCAmJiAhaW5zcGVjdG9yQ29udHJvbGxl cigpLT5oYXNGcm9udGVuZCgpKQorICAgIH0gZWxzZSBpZiAobmFtZSA9PSBrRnJvbnRlbmRDb25u ZWN0ZWRGZWF0dXJlTmFtZSAmJiB2YWx1ZSA9PSAidHJ1ZSIgJiYgIWluc3BlY3RvckNvbnRyb2xs ZXIoKS0+aGFzRnJvbnRlbmQoKSkKICAgICAgICAgZnJvbnRlbmRMb2FkZWQoKTsKIH0KIApAQCAt MzAxLDkgKzMwNiw5IEBAIHZvaWQgV2ViRGV2VG9vbHNBZ2VudEltcGw6OnNldEFwdUFnZW50RW5h YmxlZChib29sIGVuYWJsZWQpCiAgICAgICAgICAgaWMtPmRpc2FibGVSZXNvdXJjZVRyYWNraW5n KGZhbHNlKTsKICAgICAgIG1fcmVzb3VyY2VUcmFja2luZ1dhc0VuYWJsZWQgPSBmYWxzZTsKICAg ICB9Ci0gICAgbV9jbGllbnQtPnJ1bnRpbWVGZWF0dXJlU3RhdGVDaGFuZ2VkKAorICAgIG1fY2xp ZW50LT5ydW50aW1lUHJvcGVydHlDaGFuZ2VkKAogICAgICAgICBrQXB1QWdlbnRGZWF0dXJlTmFt ZSwKLSAgICAgICAgZW5hYmxlZCk7CisgICAgICAgIGVuYWJsZWQgPyBTdHJpbmcoInRydWUiKSA6 IFN0cmluZygiZmFsc2UiKSk7CiB9CiAKIFdlYkNvcmU6Okluc3BlY3RvckNvbnRyb2xsZXIqIFdl YkRldlRvb2xzQWdlbnRJbXBsOjppbnNwZWN0b3JDb250cm9sbGVyKCkKQEAgLTQxNywyMiArNDIy LDIyIEBAIGJvb2wgV2ViRGV2VG9vbHNBZ2VudEltcGw6OnNlbmRNZXNzYWdlVG9Gcm9udGVuZChj b25zdCBXVEY6OlN0cmluZyYgbWVzc2FnZSkKIAogdm9pZCBXZWJEZXZUb29sc0FnZW50SW1wbDo6 cmVzb3VyY2VUcmFja2luZ1dhc0VuYWJsZWQoKQogewotICAgIG1fY2xpZW50LT5ydW50aW1lRmVh dHVyZVN0YXRlQ2hhbmdlZChrUmVzb3VyY2VUcmFja2luZ0ZlYXR1cmVOYW1lLCB0cnVlKTsKKyAg ICBtX2NsaWVudC0+cnVudGltZVByb3BlcnR5Q2hhbmdlZChrUmVzb3VyY2VUcmFja2luZ0ZlYXR1 cmVOYW1lLCAidHJ1ZSIpOwogfQogCiB2b2lkIFdlYkRldlRvb2xzQWdlbnRJbXBsOjpyZXNvdXJj ZVRyYWNraW5nV2FzRGlzYWJsZWQoKQogewotICAgIG1fY2xpZW50LT5ydW50aW1lRmVhdHVyZVN0 YXRlQ2hhbmdlZChrUmVzb3VyY2VUcmFja2luZ0ZlYXR1cmVOYW1lLCBmYWxzZSk7CisgICAgbV9j bGllbnQtPnJ1bnRpbWVQcm9wZXJ0eUNoYW5nZWQoa1Jlc291cmNlVHJhY2tpbmdGZWF0dXJlTmFt ZSwgImZhbHNlIik7CiB9CiAKIHZvaWQgV2ViRGV2VG9vbHNBZ2VudEltcGw6OnRpbWVsaW5lUHJv ZmlsZXJXYXNTdGFydGVkKCkKIHsKLSAgICBtX2NsaWVudC0+cnVudGltZUZlYXR1cmVTdGF0ZUNo YW5nZWQoa1RpbWVsaW5lRmVhdHVyZU5hbWUsIHRydWUpOworICAgIG1fY2xpZW50LT5ydW50aW1l UHJvcGVydHlDaGFuZ2VkKGtUaW1lbGluZUZlYXR1cmVOYW1lLCAidHJ1ZSIpOwogfQogCiB2b2lk IFdlYkRldlRvb2xzQWdlbnRJbXBsOjp0aW1lbGluZVByb2ZpbGVyV2FzU3RvcHBlZCgpCiB7Ci0g ICAgbV9jbGllbnQtPnJ1bnRpbWVGZWF0dXJlU3RhdGVDaGFuZ2VkKGtUaW1lbGluZUZlYXR1cmVO YW1lLCBmYWxzZSk7CisgICAgbV9jbGllbnQtPnJ1bnRpbWVQcm9wZXJ0eUNoYW5nZWQoa1RpbWVs aW5lRmVhdHVyZU5hbWUsICJmYWxzZSIpOwogfQogCiB2b2lkIFdlYkRldlRvb2xzQWdlbnRJbXBs OjpldmFsdWF0ZUluV2ViSW5zcGVjdG9yKGxvbmcgY2FsbElkLCBjb25zdCBXZWJTdHJpbmcmIHNj cmlwdCkKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRGV2VG9vbHNBZ2VudElt cGwuaCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRGV2VG9vbHNBZ2VudEltcGwuaAppbmRleCBh MGQyNjQ3Li43M2I4YTFlIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkRldlRv b2xzQWdlbnRJbXBsLmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJEZXZUb29sc0FnZW50 SW1wbC5oCkBAIC03Nyw2ICs3Nyw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIHZvaWQgaW5zcGVj dEVsZW1lbnRBdChjb25zdCBXZWJQb2ludCYgcG9pbnQpOwogICAgIHZpcnR1YWwgdm9pZCBldmFs dWF0ZUluV2ViSW5zcGVjdG9yKGxvbmcgY2FsbElkLCBjb25zdCBXZWJTdHJpbmcmIHNjcmlwdCk7 CiAgICAgdmlydHVhbCB2b2lkIHNldFJ1bnRpbWVGZWF0dXJlRW5hYmxlZChjb25zdCBXZWJTdHJp bmcmIGZlYXR1cmUsIGJvb2wgZW5hYmxlZCk7CisgICAgdmlydHVhbCB2b2lkIHNldFJ1bnRpbWVQ cm9wZXJ0eShjb25zdCBXZWJTdHJpbmcmIG5hbWUsIGNvbnN0IFdlYlN0cmluZyYgdmFsdWUpOwog ICAgIHZpcnR1YWwgdm9pZCBzZXRUaW1lbGluZVByb2ZpbGluZ0VuYWJsZWQoYm9vbCBlbmFibGUp OwogCiAgICAgdmlydHVhbCB2b2lkIGlkZW50aWZpZXJGb3JJbml0aWFsUmVxdWVzdCh1bnNpZ25l ZCBsb25nLCBXZWJGcmFtZSosIGNvbnN0IFdlYlVSTFJlcXVlc3QmKTsK