4405 2005-08-12 08:58:36 -0700 <button> not listed in form collections. 2005-12-27 04:02:38 -0800 1 1 1 Unclassified WebKit DOM 420+ Other Linux RESOLVED FIXED P2 Normal --- 1 maksim mjs oldest_to_newest 16487 0 maksim 2005-08-12 08:58:36 -0700 Hi.. Looks like you folks also have the KDE bug #110629, <button> not included in form elements collection. Will attach testcase and the obvious patch (against kde svn, don't have a mac) 16488 1 3353 maksim 2005-08-12 08:59:44 -0700 Created attachment 3353 Testcase Testcase (khtmltests/regression/tests/ecma/form-collect-button-110629.html) FFox, WinIE, and MacIE all find the <button> 16489 2 maksim 2005-08-12 09:00:54 -0700 The following obvious change fixes it: maksim@treetop khtml]$ ~/kde3/kdesdk/scripts/svnlastchange html/html_formimpl.h ------------------------------------------------------------------------ r446120 | orlovich | 2005-08-12 11:31:46 -0400 (Fri, 12 Aug 2005) | 4 lines <button> belongs in form collections, too. Testcase based on the report upcoming. BUG:110629 ------------------------------------------------------------------------ Index: html/html_formimpl.h =================================================================== --- html/html_formimpl.h (revision 446119) +++ html/html_formimpl.h (revision 446120) @@ -196,6 +196,7 @@ public: }; virtual Id id() const; + virtual bool isEnumeratable() const { return true; } DOMString type() const; typeEnum buttonType() const { return m_type; } 26716 3 5298 mjs 2005-12-27 04:01:46 -0800 Created attachment 5298 Maks's fix in patch form, with test case 26717 4 5298 mjs 2005-12-27 04:02:27 -0800 Comment on attachment 5298 Maks's fix in patch form, with test case r=me on Maks's fix. 3353 2005-08-12 08:59:44 -0700 2005-12-27 04:01:46 -0800 Testcase form-collect-button-110629.html text/html 684 maksim PCEtLSBCYXNlZCBvbiB0ZXN0Y2FzZSBmcm9tIEtERSBidWcgIzExMDYyOSwgaGVhdmlseSBtb2Rp ZmllZCAtLT4KPGh0bWw+ICA8aGVhZD4gCiA8ZGl2IGlkPSJsb2ciPgogPC9kaXY+CiA8c2NyaXB0 PiAKZnVuY3Rpb24gZG9Mb2codGV4dCkKewogICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImxv ZyIpLmlubmVySFRNTCArPSB0ZXh0ICsgIjxicj4iOwp9CgpmdW5jdGlvbiBkb0l0KCkgewogICAg ZG9Mb2coZG9jdW1lbnQudGVzdC5lbGVtZW50cy5sZW5ndGgpOwogICAgZG9Mb2coZG9jdW1lbnQu dGVzdC5lbGVtZW50c1swXS5uYW1lKTsKICAgIGRvTG9nKGRvY3VtZW50LnRlc3QuZWxlbWVudHNb MV0ubmFtZSk7CiAgICBkb0xvZyhkb2N1bWVudC50ZXN0LmZvby52YWx1ZSk7CiAgICBkb0xvZyhk b2N1bWVudC50ZXN0LmJsYS52YWx1ZSk7Cn0KIDwvc2NyaXB0PiAKICAgPC9oZWFkPiAKCiAgIDxi b2R5IG9ubG9hZD0iZG9JdCgpIj4gCiAgICAgPGZvcm0gbmFtZT0idGVzdCI+IAogICAgIDxpbnB1 dCB0eXBlPSJidXR0b24iIG5hbWU9ImZvbyIgaWQ9ImZvbyIgdmFsdWU9IkJ1dHRvbjEiPiAKICAg ICA8YnV0dG9uIHR5cGU9ImJ1dHRvbiIgbmFtZT0iYmxhIiBpZD0iYmxhIiB2YWx1ZT0iQnV0dG9u MiI+QnV0dG9uMjwvYnV0dG9uPiAKICAgICA8L2Zvcm0+IAogICA8L2JvZHk+IAogPC9odG1sPiAK 5298 2005-12-27 04:01:46 -0800 2005-12-27 04:02:27 -0800 Maks's fix in patch form, with test case button-in-form-collection.patch.txt text/plain 4935 mjs SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3Jv b3QvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjE4NwpkaWZm IC1wIC11IC1yMS4xODcgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCi0tLSBMYXlvdXRUZXN0cy9DaGFu Z2VMb2cJMjcgRGVjIDIwMDUgMTE6MDc6NDggLTAwMDAJMS4xODcKKysrIExheW91dFRlc3RzL0No YW5nZUxvZwkyNyBEZWMgMjAwNSAxMjowMDoyMSAtMDAwMApAQCAtMiw2ICsyLDE2IEBACiAKICAg ICAgICAgUmV2aWV3ZWQsIHR3ZWFrZWQgYW5kIGxhbmRlZCBieSBNYWNpZWouCiAKKwktIHRlc3Qg Y2FzZSBmb3IgNDQwNTogPGJ1dHRvbj4gbm90IGxpc3RlZCBpbiBmb3JtIGNvbGxlY3Rpb25zLgor CWh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDQwNQorCisg ICAgICAgICogZmFzdC9mb3Jtcy9idXR0b24taW4tZm9ybXMtY29sbGVjdGlvbi1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvYnV0dG9uLWluLWZvcm1zLWNvbGxlY3Rp b24uaHRtbDogQWRkZWQuCisKKzIwMDUtMTItMjcgIE1ha3MgT3Jsb3ZpY2ggPG1ha3NpbUBrZGUu b3JnPgorCisgICAgICAgIFJldmlld2VkLCB0d2Vha2VkIGFuZCBsYW5kZWQgYnkgTWFjaWVqLgor CiAJLSB0ZXN0IGNhc2UgZm9yIDYyMzQ6IENhbiBkZWxldGUgYXJyYXkgaW5kZXggcHJvcGVydHkg aW5jb3JyZWN0bHkuCiAJaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNn aT9pZD02MjM0CiAKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZm9ybXMvYnV0dG9uLWluLWZvcm1z LWNvbGxlY3Rpb24tZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IGJ1dHRvbi1pbi1m b3Jtcy1jb2xsZWN0aW9uLWV4cGVjdGVkLnR4dApkaWZmIC1OIExheW91dFRlc3RzL2Zhc3QvZm9y bXMvYnV0dG9uLWluLWZvcm1zLWNvbGxlY3Rpb24tZXhwZWN0ZWQudHh0Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL2J1dHRvbi1pbi1mb3Jtcy1jb2xsZWN0aW9uLWV4cGVjdGVkLnR4dAkxIEph biAxOTcwIDAwOjAwOjAwIC0wMDAwCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2J1dHRvbi1p bi1mb3Jtcy1jb2xsZWN0aW9uLWV4cGVjdGVkLnR4dAkyNyBEZWMgMjAwNSAxMjowMDo0NSAtMDAw MApAQCAtMCwwICsxLDkgQEAKK1RoZSBmb2xsb3dpbmcgdGVzdHMgZm9yIHJlZ3Jlc3Npb24gYWdh aW5zdCA0NDA1OiA8YnV0dG9uPiBub3QgbGlzdGVkIGluIGZvcm0gY29sbGVjdGlvbnMuIFlvdSBz aG91bGQgc2VlIGEgc2VyaWVzIG9mIGxpbmVzIHN0YXJ0aW5nIHdpdGggUEFTUy4KKworIEJ1dHRv bjIKK1BBU1MgZG9jdW1lbnQudGVzdC5lbGVtZW50cy5sZW5ndGggaXMgMgorUEFTUyBkb2N1bWVu dC50ZXN0LmVsZW1lbnRzWzBdLm5hbWUgaXMgImZvbyIKK1BBU1MgZG9jdW1lbnQudGVzdC5lbGVt ZW50c1sxXS5uYW1lIGlzICJibGEiCitQQVNTIGRvY3VtZW50LnRlc3QuZm9vLnZhbHVlIGlzICJC dXR0b24xIgorUEFTUyBkb2N1bWVudC50ZXN0LmJsYS52YWx1ZSBpcyAiQnV0dG9uMiIKKwpJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9idXR0b24taW4tZm9ybXMtY29sbGVjdGlvbi5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KUkNTIGZpbGU6IGJ1dHRvbi1pbi1mb3Jtcy1jb2xsZWN0aW9uLmh0bWwKZGlm ZiAtTiBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2J1dHRvbi1pbi1mb3Jtcy1jb2xsZWN0aW9uLmh0 bWwKLS0tIExheW91dFRlc3RzL2Zhc3QvZm9ybXMvYnV0dG9uLWluLWZvcm1zLWNvbGxlY3Rpb24u aHRtbAkxIEphbiAxOTcwIDAwOjAwOjAwIC0wMDAwCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Zvcm1z L2J1dHRvbi1pbi1mb3Jtcy1jb2xsZWN0aW9uLmh0bWwJMjcgRGVjIDIwMDUgMTI6MDA6NDYgLTAw MDAKQEAgLTAsMCArMSw0NCBAQAorPCEtLSBCYXNlZCBvbiB0ZXN0Y2FzZSBmcm9tIEtERSBidWcg IzExMDYyOSwgaGVhdmlseSBtb2RpZmllZCAtLT4KKzxodG1sPiAgPGhlYWQ+IAorCis8c2NyaXB0 IHNyYz0iLi4vanMva2RlL3Jlc291cmNlcy9iYXNlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+Citp ZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVy LmR1bXBBc1RleHQoKTsKKworZnVuY3Rpb24gdGVzdFBhc3NlZChtc2cpCit7CisgICAgZG9jdW1l bnQud3JpdGUoIjxiPjxmb250IGNvbG9yPWdyZWVuPlBBU1M8L2ZvbnQ+PC9iPiAiICsgbXNnICsg Ijxicj4iKTsKK30KKworZnVuY3Rpb24gdGVzdEZhaWxlZChtc2cpCit7CisgICAgZG9jdW1lbnQu d3JpdGUoIjxiPjxmb250IGNvbG9yPXJlZD5GQUlMPC9mb250PjwvYj4gIiArIG1zZyArICI8YnI+ Iik7Cit9CisKK2Z1bmN0aW9uIGRlYnVnKGEpIAoreyAKKyAgICBkb2N1bWVudC53cml0ZSgiPHA+ ICIgKyBhICsgIjwvcD4iKTsgCit9Cis8L3NjcmlwdD4KKyAgIDwvaGVhZD4gCisKKyAgIDxib2R5 PiAKKzxwPlRoZSBmb2xsb3dpbmcgdGVzdHMgZm9yIHJlZ3Jlc3Npb24gYWdhaW5zdCA8YSBocmVm PSJodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTQ0MDUiPjQ0 MDU6ICZsdDtidXR0b24mZ3Q7IG5vdCBsaXN0ZWQgaW4gZm9ybSBjb2xsZWN0aW9ucy48L2E+IFlv dSBzaG91bGQgc2VlIGEgc2VyaWVzIG9mIGxpbmVzIHN0YXJ0aW5nIHdpdGggUEFTUy48L3A+Cisg ICAKKyAgICAgPGZvcm0gbmFtZT0idGVzdCI+IAorICAgICA8aW5wdXQgdHlwZT0iYnV0dG9uIiBu YW1lPSJmb28iIGlkPSJmb28iIHZhbHVlPSJCdXR0b24xIj4gCisgICAgIDxidXR0b24gdHlwZT0i YnV0dG9uIiBuYW1lPSJibGEiIGlkPSJibGEiIHZhbHVlPSJCdXR0b24yIj5CdXR0b24yPC9idXR0 b24+IAorICAgICA8L2Zvcm0+IAorCis8YnI+CisgPHNjcmlwdD4gCisgICAgc2hvdWxkQmUoImRv Y3VtZW50LnRlc3QuZWxlbWVudHMubGVuZ3RoIiwgIjIiKTsKKyAgICBzaG91bGRCZSgiZG9jdW1l bnQudGVzdC5lbGVtZW50c1swXS5uYW1lIiwgJyJmb28iJyk7CisgICAgc2hvdWxkQmUoImRvY3Vt ZW50LnRlc3QuZWxlbWVudHNbMV0ubmFtZSIsICciYmxhIicpOworICAgIHNob3VsZEJlKCJkb2N1 bWVudC50ZXN0LmZvby52YWx1ZSIsICciQnV0dG9uMSInKTsKKyAgICBzaG91bGRCZSgiZG9jdW1l bnQudGVzdC5ibGEudmFsdWUiLCAnIkJ1dHRvbjIiJyk7CisgPC9zY3JpcHQ+IAorCisgICA8L2Jv ZHk+IAorIDwvaHRtbD4gCkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBm aWxlOiAvY3ZzL3Jvb3QvV2ViQ29yZS9DaGFuZ2VMb2csdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEu NDIKZGlmZiAtcCAtdSAtcjEuNDIgV2ViQ29yZS9DaGFuZ2VMb2cKLS0tIFdlYkNvcmUvQ2hhbmdl TG9nCTI2IERlYyAyMDA1IDIxOjQ2OjE2IC0wMDAwCTEuNDIKKysrIFdlYkNvcmUvQ2hhbmdlTG9n CTI3IERlYyAyMDA1IDEyOjAxOjM0IC0wMDAwCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDUtMTItMjcg IE1ha3MgT3Jsb3ZpY2ggPG1ha3NpbUBrZGUub3JnPgorCisgICAgICAgIFJldmlld2VkIGFuZCBs YW5kZWQgYnkgTWFjaWVqLgorCisJLSBmaXhlZCA0NDA1OiA8YnV0dG9uPiBub3QgbGlzdGVkIGlu IGZvcm0gY29sbGVjdGlvbnMuCisJaHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3df YnVnLmNnaT9pZD00NDA1CisKKwlUZXN0OiBmYXN0L2Zvcm1zL2J1dHRvbi1pbi1mb3Jtcy1jb2xs ZWN0aW9uLmh0bWwKKwkKKyAgICAgICAgKiBraHRtbC9odG1sL2h0bWxfZm9ybWltcGwuaDoKKyAg ICAgICAgKERPTTo6SFRNTEJ1dHRvbkVsZW1lbnRJbXBsOjppc0VudW1lcmF0YWJsZSk6IG92ZXJy aWRlIHRvIHJldHVybiB0cnVlCisKIDIwMDUtMTItMjUgIE1hY2llaiBTdGFjaG93aWFrICA8bWpz QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHZW9mZi4KSW5kZXg6IFdlYkNvcmUv a2h0bWwvaHRtbC9odG1sX2Zvcm1pbXBsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9yb290 L1dlYkNvcmUva2h0bWwvaHRtbC9odG1sX2Zvcm1pbXBsLmgsdgpyZXRyaWV2aW5nIHJldmlzaW9u IDEuMTAwCmRpZmYgLXAgLXUgLXIxLjEwMCBXZWJDb3JlL2todG1sL2h0bWwvaHRtbF9mb3JtaW1w bC5oCi0tLSBXZWJDb3JlL2todG1sL2h0bWwvaHRtbF9mb3JtaW1wbC5oCTIyIERlYyAyMDA1IDIz OjA2OjIwIC0wMDAwCTEuMTAwCisrKyBXZWJDb3JlL2todG1sL2h0bWwvaHRtbF9mb3JtaW1wbC5o CTI3IERlYyAyMDA1IDEyOjAxOjU2IC0wMDAwCkBAIC0yNDksNiArMjQ5LDggQEAgcHVibGljOgog ICAgIHZpcnR1YWwgdm9pZCBkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50SW1wbCAqZXZ0KTsKICAg ICB2aXJ0dWFsIGJvb2wgYXBwZW5kRm9ybURhdGEoRm9ybURhdGFMaXN0JiwgYm9vbCk7CiAKKyAg ICB2aXJ0dWFsIGJvb2wgaXNFbnVtZXJhdGFibGUoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9IAor CiAgICAgdmlydHVhbCBib29sIGlzU3VjY2Vzc2Z1bFN1Ym1pdEJ1dHRvbigpIGNvbnN0OwogICAg IHZpcnR1YWwgYm9vbCBpc0FjdGl2YXRlZFN1Ym1pdCgpIGNvbnN0OwogICAgIHZpcnR1YWwgdm9p ZCBzZXRBY3RpdmF0ZWRTdWJtaXQoYm9vbCBmbGFnKTsK