44021 2010-08-14 22:52:18 -0700 <style> inside <noscript> is parsed when JavaScript is enabled. 2010-08-19 16:44:58 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED FIXED P2 Normal --- 0 johanneslindenbaum webkit-unassigned abarth ap commit-queue eric hohle webkit.review.bot oldest_to_newest 264788 0 johanneslindenbaum 2010-08-14 22:52:18 -0700 Summary: When adding <style> definitions inside of a <noscript> tag the style declarations are applied even when JavaScript is enabled. Steps to Reproduce: <noscript> <style type="text/css"> #myId { display: none; } </style> </noscript> Expected Results: Style declarations inside of no script, attempting to gracefully degrade a form, should not be parsed. When JavaScript is in enabled #myDiv should remain visible, where during a disabled JavaScript page load the element should not be displayed. Actual Results: Style definitions are applied when JavaScript is enabled. Firefox 3.6.8 correctly ignores <style> in <noscript> IE 8 (Win 7) correctly ignores <style> in <noscript> Chrome 5.0.375.99 parses <style> in <noscript> Safari 5.0.1 (6533.17.8) parses <style> in <noscript> 265931 1 abarth 2010-08-17 21:29:48 -0700 In all likelihood this is fixed on trunk. Testing now. 265935 2 abarth 2010-08-17 21:36:48 -0700 *** Bug 28195 has been marked as a duplicate of this bug. *** 265936 3 64668 abarth 2010-08-17 21:38:18 -0700 Created attachment 64668 Patch 266965 4 64668 ap 2010-08-19 14:30:55 -0700 Comment on attachment 64668 Patch Thanks! It's a little surprising to see noscript without script, and maybe we should be also testing the more common case where they come together, but I don't think there is a strong technical reason to. I'm a little confused by your comment in bug 28195 - is 13522 the same, after all? 266971 5 abarth 2010-08-19 14:36:30 -0700 > Thanks! It's a little surprising to see noscript without script, and maybe we should be also testing the more common case where they come together, but I don't think there is a strong technical reason to. Huh? I don't understand this comment. Why would script and noscript come together? > I'm a little confused by your comment in bug 28195 - is 13522 the same, after all? I haven't looked at Bug 13522 yet. Bug 28195 is the same bug as this one. The old parser didn't understand how to properly lex <noscript>. The new parser lexs it as RAWTEXT and then makes it not display. 266996 6 ap 2010-08-19 15:12:26 -0700 > Huh? I don't understand this comment. Why would script and noscript come together? They usually did on Web pages (and sample code) where I saw <noscript>, with it logically being fallback for scripted behavior. Of course, they are not technically related, which is why I said there was no strong reason to test that case. 267004 7 64668 commit-queue 2010-08-19 15:35:52 -0700 Comment on attachment 64668 Patch Clearing flags on attachment: 64668 Committed r65712: <http://trac.webkit.org/changeset/65712> 267005 8 commit-queue 2010-08-19 15:35:58 -0700 All reviewed patches have been landed. Closing bug. 267053 9 webkit.review.bot 2010-08-19 16:44:58 -0700 http://trac.webkit.org/changeset/65712 might have broken SnowLeopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/65699 http://trac.webkit.org/changeset/65700 http://trac.webkit.org/changeset/65701 http://trac.webkit.org/changeset/65702 http://trac.webkit.org/changeset/65703 http://trac.webkit.org/changeset/65704 http://trac.webkit.org/changeset/65705 http://trac.webkit.org/changeset/65706 http://trac.webkit.org/changeset/65707 http://trac.webkit.org/changeset/65708 http://trac.webkit.org/changeset/65709 http://trac.webkit.org/changeset/65710 http://trac.webkit.org/changeset/65711 http://trac.webkit.org/changeset/65712 http://trac.webkit.org/changeset/65713 64668 2010-08-17 21:38:18 -0700 2010-08-19 15:35:52 -0700 Patch bug-44021-20100817213817.patch text/plain 2815 abarth ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3NzQxYjcyNjcyN2EyODk2MzVmZmEzZDAxYjlmZjAwMDg1NjE0M2U2Li5jZDQ3OWY5 M2MzMGFjMjg2NTdiODkwNmM5NWI5NDc4M2JmYWU0NWFjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAK KzIwMTAtMDgtMTcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICA8c3R5bGU+IGluc2lkZSA8bm9z Y3JpcHQ+IGlzIHBhcnNlZCB3aGVuIEphdmFTY3JpcHQgaXMgZW5hYmxlZC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ0MDIxCisKKyAgICAgICAgTW9y ZSByYW5kb20gYnVncyBmaXhlZCBieSB0aGUgSFRNTDUgcGFyc2VyLiAgVGltZSB0byBkb2N1bWVu dCB3aXRoIGEKKyAgICAgICAgY291cGxlIHRlc3RzLiAgSSBhZGRlZCBib3RoIHRoZXNlIHRlc3Rz IGJlY2F1c2UgPG5vc2NyaXB0PiBpbiA8Ym9keT4gaXMKKyAgICAgICAgc2xpZ2h0bHkgZGlmZmVy ZW50IHRoYW4gPG5vc2NyaXB0PiBiZWZvcmUgPGJvZHk+LgorCisgICAgICAgICogZmFzdC9wYXJz ZXIvbm8tc3R5bGUtaW4tbm9zY3JpcHQtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBm YXN0L3BhcnNlci9uby1zdHlsZS1pbi1ub3NjcmlwdC13aXRoLWJvZHktZXhwZWN0ZWQudHh0OiBB ZGRlZC4KKyAgICAgICAgKiBmYXN0L3BhcnNlci9uby1zdHlsZS1pbi1ub3NjcmlwdC13aXRoLWJv ZHkuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFzdC9wYXJzZXIvbm8tc3R5bGUtaW4tbm9zY3Jp cHQuaHRtbDogQWRkZWQuCisKIDIwMTAtMDgtMTcgIEFkZW1hciBkZSBTb3V6YSBSZWlzIEpyICA8 YWRlbWFyLnJlaXNAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW5pZWwg QmF0ZXMuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9uby1zdHlsZS1pbi1u b3NjcmlwdC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9uby1zdHlsZS1p bi1ub3NjcmlwdC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uN2VmMjJlOWE0MzFhZDAyNzI3MTNi NzFmZGM4Nzk0MDE2YzhlZjEyZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3Qv cGFyc2VyL25vLXN0eWxlLWluLW5vc2NyaXB0LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitQ QVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9uby1zdHlsZS1pbi1ub3Nj cmlwdC13aXRoLWJvZHktZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIvbm8t c3R5bGUtaW4tbm9zY3JpcHQtd2l0aC1ib2R5LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43ZWYy MmU5YTQzMWFkMDI3MjcxM2I3MWZkYzg3OTQwMTZjOGVmMTJmCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIvbm8tc3R5bGUtaW4tbm9zY3JpcHQtd2l0aC1ib2R5LWV4 cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L3BhcnNlci9uby1zdHlsZS1pbi1ub3NjcmlwdC13aXRoLWJvZHkuaHRtbCBiL0xheW91dFRl c3RzL2Zhc3QvcGFyc2VyL25vLXN0eWxlLWluLW5vc2NyaXB0LXdpdGgtYm9keS5odG1sCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLjkwNzUyZmMwN2UyYTg0MTY0Y2FmNzYxNTI1MDQ5OGQzZjQxMzQ3ODUKLS0tIC9kZXYv bnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9uby1zdHlsZS1pbi1ub3NjcmlwdC13 aXRoLWJvZHkuaHRtbApAQCAtMCwwICsxLDExIEBACis8Ym9keT4KKzxub3NjcmlwdD4KKzxzdHls ZSB0eXBlPSJ0ZXh0L2NzcyI+CisjZm9vIHsgZGlzcGxheTogbm9uZTsgfQorPC9zdHlsZT4KKzwv bm9zY3JpcHQ+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAg ICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cis8L3NjcmlwdD4KKzxkaXYgaWQ9 ImZvbyI+UEFTUzwvZGl2PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIvbm8t c3R5bGUtaW4tbm9zY3JpcHQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvcGFyc2VyL25vLXN0eWxl LWluLW5vc2NyaXB0Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYjY4ZTZjZTZlNjU1NDE5MTBhYjdhZjI3YzIw ZDAzMWNlMjc1MjFmZgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvcGFyc2Vy L25vLXN0eWxlLWluLW5vc2NyaXB0Lmh0bWwKQEAgLTAsMCArMSwxMCBAQAorPG5vc2NyaXB0Pgor PHN0eWxlIHR5cGU9InRleHQvY3NzIj4KKyNmb28geyBkaXNwbGF5OiBub25lOyB9Cis8L3N0eWxl PgorPC9ub3NjcmlwdD4KKzxzY3JpcHQ+CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVy KQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKzwvc2NyaXB0PgorPGRp diBpZD0iZm9vIj5QQVNTPC9kaXY+Cg==