44020 2010-08-14 22:11:22 -0700 [EFL] Enable localStorage of HTML5 for WebKit EFL 2010-08-17 03:54:37 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 gyuyoung.kim webkit-unassigned abarth barbieri commit-queue eric leandro lucas.de.marchi tonikitoo webkit.review.bot oldest_to_newest 264785 0 gyuyoung.kim 2010-08-14 22:11:22 -0700 Let's enable localStorage of HTML5. 264786 1 64435 gyuyoung.kim 2010-08-14 22:15:41 -0700 Created attachment 64435 Patch I invoke setLocalStorageEnabled() in _ewk_view_priv_new() as below, 26 priv->page_settings->setPluginsEnabled(true); 27 + priv->page_settings->setLocalStorageEnabled(true); BTW, it seems we need to set the initial settings values dynamically. 264824 2 tonikitoo 2010-08-15 06:55:34 -0700 > BTW, it seems we need to set the initial settings values dynamically. what do you mean? 264825 3 64435 commit-queue 2010-08-15 07:10:24 -0700 Comment on attachment 64435 Patch Clearing flags on attachment: 64435 Committed r65380: <http://trac.webkit.org/changeset/65380> 264826 4 commit-queue 2010-08-15 07:10:29 -0700 All reviewed patches have been landed. Closing bug. 264830 5 webkit.review.bot 2010-08-15 07:55:21 -0700 http://trac.webkit.org/changeset/65380 might have broken SnowLeopard Intel Release (Tests) 264957 6 gyuyoung.kim 2010-08-16 00:11:13 -0700 (In reply to comment #2) > > BTW, it seems we need to set the initial settings values dynamically. > > what do you mean? I mean that default settings below is hardcoded. static Ewk_View_Private_Data* _ewk_view_priv_new(Ewk_View_Smart_Data* sd) { ... priv->page_settings->setLoadsImagesAutomatically(true); priv->page_settings->setDefaultFixedFontSize(12); priv->page_settings->setDefaultFontSize(16); priv->page_settings->setSerifFontFamily("serif"); priv->page_settings->setFixedFontFamily("monotype"); priv->page_settings->setSansSerifFontFamily("sans"); priv->page_settings->setStandardFontFamily("sans"); priv->page_settings->setJavaScriptEnabled(true); priv->page_settings->setPluginsEnabled(true); priv->page_settings->setLocalStorageEnabled(true); ... } It seems to me the default values need to be changed by setting file or user and so on. How do you think about it ? 265018 7 tonikitoo 2010-08-16 04:45:36 -0700 (In reply to comment #6) > (In reply to comment #2) > > > BTW, it seems we need to set the initial settings values dynamically. > > > > what do you mean? > > I mean that default settings below is hardcoded. > > static Ewk_View_Private_Data* _ewk_view_priv_new(Ewk_View_Smart_Data* sd) { > ... > priv->page_settings->setLoadsImagesAutomatically(true); > priv->page_settings->setDefaultFixedFontSize(12); > priv->page_settings->setDefaultFontSize(16); > priv->page_settings->setSerifFontFamily("serif"); > priv->page_settings->setFixedFontFamily("monotype"); > priv->page_settings->setSansSerifFontFamily("sans"); > priv->page_settings->setStandardFontFamily("sans"); > priv->page_settings->setJavaScriptEnabled(true); > priv->page_settings->setPluginsEnabled(true); > priv->page_settings->setLocalStorageEnabled(true); > ... > } > > It seems to me the default values need to be changed by setting file or user and so on. How do you think about it ? I agree. Maybe a EWebSettings public class to your API(?) 265460 8 gyuyoung.kim 2010-08-17 03:54:37 -0700 (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #2) > > > > BTW, it seems we need to set the initial settings values dynamically. > > > > > > what do you mean? > > > > I mean that default settings below is hardcoded. > > > > static Ewk_View_Private_Data* _ewk_view_priv_new(Ewk_View_Smart_Data* sd) { > > ... > > priv->page_settings->setLoadsImagesAutomatically(true); > > priv->page_settings->setDefaultFixedFontSize(12); > > priv->page_settings->setDefaultFontSize(16); > > priv->page_settings->setSerifFontFamily("serif"); > > priv->page_settings->setFixedFontFamily("monotype"); > > priv->page_settings->setSansSerifFontFamily("sans"); > > priv->page_settings->setStandardFontFamily("sans"); > > priv->page_settings->setJavaScriptEnabled(true); > > priv->page_settings->setPluginsEnabled(true); > > priv->page_settings->setLocalStorageEnabled(true); > > ... > > } > > > > It seems to me the default values need to be changed by setting file or user and so on. How do you think about it ? > > I agree. Maybe a EWebSettings public class to your API(?) Ok, I will consider how to modify this issue. 64435 2010-08-14 22:15:41 -0700 2010-08-15 07:10:24 -0700 Patch localstorage-patch.txt text/plain 1175 gyuyoung.kim ZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvQ2hhbmdlTG9nIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK aW5kZXggZjEyZjk0Yy4uODdlNmQ1OCAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wOC0xNCAg R3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIEVuYWJsZSBsb2NhbFN0b3Jh Z2Ugb2YgSFRNTDUgZm9yIFdlYktpdCBFRkwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ0MDIwCisKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOiAK KyAgICAgICAgKF9ld2tfdmlld19wcml2X25ldyk6CisKIDIwMTAtMDgtMTEgIFJhZmFlbCBBbnRv Z25vbGxpICA8YW50b2dub2xsaUBwcm9mdXNpb24ubW9iaT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvZXdr L2V3a192aWV3LmNwcCBiL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCA0NjZmNDI5 Li43YTk4YmFjIDEwMDY0NAotLS0gYS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKKysrIGIv V2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC01NTgsNiArNTU4LDcgQEAgc3RhdGljIEV3 a19WaWV3X1ByaXZhdGVfRGF0YSogX2V3a192aWV3X3ByaXZfbmV3KEV3a19WaWV3X1NtYXJ0X0Rh dGEqIHNkKQogICAgIHByaXYtPnBhZ2Vfc2V0dGluZ3MtPnNldFN0YW5kYXJkRm9udEZhbWlseSgi c2FucyIpOwogICAgIHByaXYtPnBhZ2Vfc2V0dGluZ3MtPnNldEphdmFTY3JpcHRFbmFibGVkKHRy dWUpOwogICAgIHByaXYtPnBhZ2Vfc2V0dGluZ3MtPnNldFBsdWdpbnNFbmFibGVkKHRydWUpOwor ICAgIHByaXYtPnBhZ2Vfc2V0dGluZ3MtPnNldExvY2FsU3RvcmFnZUVuYWJsZWQodHJ1ZSk7CiAK ICAgICB1cmwgPSBwcml2LT5wYWdlX3NldHRpbmdzLT51c2VyU3R5bGVTaGVldExvY2F0aW9uKCk7 CiAgICAgcHJpdi0+c2V0dGluZ3MudXNlcl9zdHlsZXNoZWV0ID0gZWluYV9zdHJpbmdzaGFyZV9h ZGQodXJsLnByZXR0eVVSTCgpLnV0ZjgoKS5kYXRhKCkpOwo=