44017 2010-08-14 16:00:33 -0700 XSLTProcessor.transformToFragment should not pass contextElement to the parser (since there is no context) 2010-08-14 16:30:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric commit-queue oldest_to_newest 264758 0 eric 2010-08-14 16:00:33 -0700 XSLTProcessor.transformToFragment should not pass contextElement 264760 1 64432 eric 2010-08-14 16:02:50 -0700 Created attachment 64432 Patch 264762 2 64432 abarth 2010-08-14 16:08:53 -0700 Comment on attachment 64432 Patch WebCore/xml/XSLTProcessor.cpp:103 + fragment->parseHTML(sourceString, 0); I don't get this part of the change. Who passes a non-zero argument? 264763 3 64432 abarth 2010-08-14 16:11:42 -0700 Comment on attachment 64432 Patch Thanks for explaining on IRC. We should probably have two methods with different names since they're semantically different. 264764 4 eric 2010-08-14 16:13:27 -0700 the contextElement is an optional parameter to the parse (at least in HTML5). The Xml parser should work similarly. 264769 5 64432 commit-queue 2010-08-14 16:30:03 -0700 Comment on attachment 64432 Patch Clearing flags on attachment: 64432 Committed r65375: <http://trac.webkit.org/changeset/65375> 264770 6 commit-queue 2010-08-14 16:30:08 -0700 All reviewed patches have been landed. Closing bug. 64432 2010-08-14 16:02:50 -0700 2010-08-14 16:30:03 -0700 Patch bug-44017-20100814180248.patch text/plain 3249 eric ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzU0YTM4NTFkMTIzOGYwNGNjNDA5YjJmNzIzODdkZmI5OGRhNjAyZS4uMTg0OTZkMTQ0ZDg1NDZm Y2RiMmNhODhkYjYwNWRhMTAzOTkxZjJjZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwyMyBAQAogCiAgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgogCisgICAgICAgIFhTTFRQcm9jZXNzb3IudHJhbnNmb3Jt VG9GcmFnbWVudCBzaG91bGQgbm90IHBhc3MgY29udGV4dEVsZW1lbnQgdG8gaHRtbC94bWwgZG9j dW1lbnQgcGFyc2VycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDQwMTcKKworICAgICAgICBUaGlzIGZpeGVzIHR3byB0ZXN0cyB3aGljaCBvdGhlcndp c2Ugd291bGQgZmFpbCB3aGVuIHRoZQorICAgICAgICBIVE1MNSBUcmVlQnVpbGRlciBpcyBlbmFi bGVkIGZvciBmcmFnbWVudCBwYXJzaW5nLgorCisgICAgICAgIFRoaXMgcmV2ZWFsZWQgYSBidWcg aW4gSFRNTFRyZWVCdWlsZGVyKCkgd2hpY2ggSSBmaXhlZCBhcyB3ZWxsLgorCisgICAgICAgICog aHRtbC9IVE1MVHJlZUJ1aWxkZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTFRyZWVCdWls ZGVyOjpIVE1MVHJlZUJ1aWxkZXIpOgorICAgICAgICAqIHhtbC9YU0xUUHJvY2Vzc29yLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZUZyYWdtZW50RnJvbVNvdXJjZSk6CisKKzIwMTAtMDgt MTQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIE1vdmUgaW5uZXJIVE1MIG9mZiBvZiBSYW5nZTo6 Y3JlYXRlQ29udGV4dHVhbEZyYWdtZW50CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00NDAxMQogCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTFRy ZWVCdWlsZGVyLmNwcCBiL1dlYkNvcmUvaHRtbC9IVE1MVHJlZUJ1aWxkZXIuY3BwCmluZGV4IDFk MjM1MzlkYWQ3YjczMWFjYzE2NmEyNjQ0NjkxYmY4NGFlNTdkNzEuLmZkMGI2MmU4NzQ4M2QxZDAy MjRiNWEzNTZiZDdkYTVjMGI0YjZlN2IgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MVHJl ZUJ1aWxkZXIuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MVHJlZUJ1aWxkZXIuY3BwCkBAIC00 MTIsMTMgKzQxMiwxNCBAQCBIVE1MVHJlZUJ1aWxkZXI6OkhUTUxUcmVlQnVpbGRlcihIVE1MVG9r ZW5pemVyKiB0b2tlbml6ZXIsIERvY3VtZW50RnJhZ21lbnQqIGZyYQogewogICAgIGlmIChzaG91 bGRVc2VMZWdhY3lUcmVlQnVpbGRlcihmcmFnbWVudC0+ZG9jdW1lbnQoKSkpCiAgICAgICAgIHJl dHVybjsKLSAgICAvLyBUaGlzIGlzIHN0ZXBzIDItNiBvZiB0aGUgSFRNTDUgRnJhZ21lbnQgQ2Fz ZSBwYXJzaW5nIGFsZ29yaXRobToKLSAgICAvLyBodHRwOi8vd3d3LndoYXR3Zy5vcmcvc3BlY3Mv d2ViLWFwcHMvY3VycmVudC13b3JrL211bHRpcGFnZS90aGUtZW5kLmh0bWwjZnJhZ21lbnQtY2Fz ZQotICAgIGlmIChjb250ZXh0RWxlbWVudCkKKyAgICBpZiAoY29udGV4dEVsZW1lbnQpIHsKKyAg ICAgICAgLy8gU3RlcHMgNC4yLTQuNiBvZiB0aGUgSFRNTDUgRnJhZ21lbnQgQ2FzZSBwYXJzaW5n IGFsZ29yaXRobToKKyAgICAgICAgLy8gaHR0cDovL3d3dy53aGF0d2cub3JnL3NwZWNzL3dlYi1h cHBzL2N1cnJlbnQtd29yay9tdWx0aXBhZ2UvdGhlLWVuZC5odG1sI2ZyYWdtZW50LWNhc2UKICAg ICAgICAgbV9kb2N1bWVudC0+c2V0UGFyc2VNb2RlKGNvbnRleHRFbGVtZW50LT5kb2N1bWVudCgp LT5wYXJzZU1vZGUoKSk7Ci0gICAgcHJvY2Vzc0Zha2VTdGFydFRhZyhodG1sVGFnKTsKLSAgICBy ZXNldEluc2VydGlvbk1vZGVBcHByb3ByaWF0ZWx5KCk7Ci0gICAgbV90cmVlLnNldEZvcm0oY2xv c2VzdEZvcm1BbmNlc3Rvcihjb250ZXh0RWxlbWVudCkpOworICAgICAgICBwcm9jZXNzRmFrZVN0 YXJ0VGFnKGh0bWxUYWcpOworICAgICAgICByZXNldEluc2VydGlvbk1vZGVBcHByb3ByaWF0ZWx5 KCk7CisgICAgICAgIG1fdHJlZS5zZXRGb3JtKGNsb3Nlc3RGb3JtQW5jZXN0b3IoY29udGV4dEVs ZW1lbnQpKTsKKyAgICB9CiB9CiAKIEhUTUxUcmVlQnVpbGRlcjo6fkhUTUxUcmVlQnVpbGRlcigp CmRpZmYgLS1naXQgYS9XZWJDb3JlL3htbC9YU0xUUHJvY2Vzc29yLmNwcCBiL1dlYkNvcmUveG1s L1hTTFRQcm9jZXNzb3IuY3BwCmluZGV4IDdlMDdlZTNmZGJiMzI0OTIyYzJlYjgxM2IxY2U5M2Zi NmI5OWYyOWEuLjZlMTQ5YTFhNmU3ZDc4ZTRjMTM2ODlmZWI2MDAyYjYxN2YyNjNkZjUgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUveG1sL1hTTFRQcm9jZXNzb3IuY3BwCisrKyBiL1dlYkNvcmUveG1sL1hT TFRQcm9jZXNzb3IuY3BwCkBAIC0xMDAsMTEgKzEwMCwxMSBAQCBzdGF0aWMgaW5saW5lIFJlZlB0 cjxEb2N1bWVudEZyYWdtZW50PiBjcmVhdGVGcmFnbWVudEZyb21Tb3VyY2UoY29uc3QgU3RyaW5n JiBzbwogICAgIFJlZlB0cjxEb2N1bWVudEZyYWdtZW50PiBmcmFnbWVudCA9IG91dHB1dERvYy0+ Y3JlYXRlRG9jdW1lbnRGcmFnbWVudCgpOwogCiAgICAgaWYgKHNvdXJjZU1JTUVUeXBlID09ICJ0 ZXh0L2h0bWwiKQotICAgICAgICBmcmFnbWVudC0+cGFyc2VIVE1MKHNvdXJjZVN0cmluZywgb3V0 cHV0RG9jLT5kb2N1bWVudEVsZW1lbnQoKSk7CisgICAgICAgIGZyYWdtZW50LT5wYXJzZUhUTUwo c291cmNlU3RyaW5nLCAwKTsKICAgICBlbHNlIGlmIChzb3VyY2VNSU1FVHlwZSA9PSAidGV4dC9w bGFpbiIpCi0gICAgICAgIGZyYWdtZW50LT5sZWdhY3lQYXJzZXJBZGRDaGlsZChUZXh0OjpjcmVh dGUob3V0cHV0RG9jLCBzb3VyY2VTdHJpbmcpKTsKKyAgICAgICAgZnJhZ21lbnQtPnBhcnNlckFk ZENoaWxkKFRleHQ6OmNyZWF0ZShvdXRwdXREb2MsIHNvdXJjZVN0cmluZykpOwogICAgIGVsc2Ug ewotICAgICAgICBib29sIHN1Y2Nlc3NmdWxQYXJzZSA9IGZyYWdtZW50LT5wYXJzZVhNTChzb3Vy Y2VTdHJpbmcsIG91dHB1dERvYy0+ZG9jdW1lbnRFbGVtZW50KCkpOworICAgICAgICBib29sIHN1 Y2Nlc3NmdWxQYXJzZSA9IGZyYWdtZW50LT5wYXJzZVhNTChzb3VyY2VTdHJpbmcsIDApOwogICAg ICAgICBpZiAoIXN1Y2Nlc3NmdWxQYXJzZSkKICAgICAgICAgICAgIHJldHVybiAwOwogICAgIH0K